build-unit-test-docker: remove libunifex

Most of the original authors of libunifex have moved in another
direction, so sdbusplus will not be using it anymore.

Signed-off-by: Patrick Williams <patri

build-unit-test-docker: remove libunifex

Most of the original authors of libunifex have moved in another
direction, so sdbusplus will not be using it anymore.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I22df03eb6ced5bfbd481aa2eb1eb76b750a06d9c

show more ...

build-unit-test-docker: remove catch2

Based on searching the org in Github[1], there do not appear to be
anymore usages of Catch2. Remove it from our Docker image.

1. https://github.com/search?q=o

build-unit-test-docker: remove catch2

Based on searching the org in Github[1], there do not appear to be
anymore usages of Catch2. Remove it from our Docker image.

1. https://github.com/search?q=org%3Aopenbmc+catch2&type=code

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2cf89c533149266aa908a15bd825bfdbcd450c55

show more ...

Update meson to 0.63.0

Reason: meson 0.63.0 provides a new feature which allows user to apply
diff file on a subproject. This gives user a flexibility to have code
changes in subprojects while runni

Update meson to 0.63.0

Reason: meson 0.63.0 provides a new feature which allows user to apply
diff file on a subproject. This gives user a flexibility to have code
changes in subprojects while running the unit test.

Reference: https://mesonbuild.com/Wrap-dependency-system-manual.html#diff-files

Tested: Locally ran unit test and confirmed that the subproject applied
the diff files correctly.

Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: Icb1ad03d28496120f5afe8010cfa3a3b855975c8

show more ...

Enforce commit message style

Throughout the project, it is a manual human process to enforce the idea
of commit message formatting, and leads to more conflict than would
ideally be required for some

Enforce commit message style

Throughout the project, it is a manual human process to enforce the idea
of commit message formatting, and leads to more conflict than would
ideally be required for something that's relatively algorithmic, and
able to be enforced by CI. Jenkins is able to give faster response
times to users, thus ensuring that committers are more likely to be able
to resolve their commit message issues in a timely manner.

This commit adds the gitlint[1] application to our builds, and
integrates its checks with CI in the format-code.sh script. Gitlint
appears to be a relatively active project with a number of releases,
relatively up to date commits on its github, and by the documentation as
well as this authors testing, appears to do exactly what the project
needs in terms of checks.

gitlint has a number of configuration options[2], of which the defaults
appear to be ok for OpenBMCs style requirements. This commit checks in a
.gitlint file that was generated via 'gitlint generate-config' to use as
a starting point.

To avoid impacting the entire project at this time, this commit checks
for the existence of a .openbmc-enforce-gitlint file in the root of the
directory, and uses that to gate its scanning. At some point in the
future, once we've determined this meets our needs, this check will be
removed so that we can enforce this project-wide.

This commit makes use of the gitlint plugin system to support one
important feature that OpenBMC requires for block line length. The
custom line length rule allows:
1. Block comments to exceed the line length limit
2. Signed-Off-By sections to exceed the line length limit
3. Tabbed in sections to exceed the line length limit

Presumably this same mechanism could be used to handle openbmc/openbmc
commits, to allow meta-<name> to precede the title and go over the
allowed limit, but for the moment, format-code.sh does not apply to
openbmc/openbmc, so this would be for a future change to repotest

When these fails, it attempts to give the user a message that conveys
these allowals to let them fix their commit message quickly.

Tested:
Created a commit with a title that was too long, as well as added a
.openbmc-enforce-gitlint file in bmcweb. Ran openbmc-build-scripts and observed.

'''
-: UC1 Line exceeds max length (101>72).
It's possible you intended to use one of the following exceptions:
1. Put logs or bash lines in a quoted section with triple quotes (''') before and after the section
2. Put a long link at the bottom in a footnote. example: [1] https://my_long_link.com
Line that was too long:
: "VERY LONG LOG LINE THAT TAKES WAY TOO MUCH SPACE AND GOES OVER 72 CHARACTERS, which is a problem"
'''

[1] https://jorisroovers.com/gitlint/
[2] https://jorisroovers.com/gitlint/configuration/
[3] https://jorisroovers.com/gitlint/user_defined_rules/
[4] https://github.com/jorisroovers/gitlint/issues/255#issuecomment-1063494186

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: If42a22bfeca223fd5bc8f35ed937aa5f60713f2a

show more ...

stdplus: Depend on googletest for support lib

This now provides some additional test case routines that require
googletest to build

Change-Id: I191705fa1b65e731308946c1eb72edc09b189bee
Signed-off-b

stdplus: Depend on googletest for support lib

This now provides some additional test case routines that require
googletest to build

Change-Id: I191705fa1b65e731308946c1eb72edc09b189bee
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Improve cppcheck results and calling code

In the ideal case, cppcheck would have an option where it could be
enforcing in the future. This commit works toward that goal, but
doesn't quite get there

Improve cppcheck results and calling code

In the ideal case, cppcheck would have an option where it could be
enforcing in the future. This commit works toward that goal, but
doesn't quite get there.

First, it updates cppcheck to the latest copy from github, instead of
pulling through apt sources. This is done because the current cppcheck
has an issue with std::string_view, and erroneously believes that it
should be passed by reference. The master branch has a fix for this.

Next, it modifies the call of cppcheck in a couple ways, first, to rely
on compile_commands.json from the build step, rather than attempting to
build a list of files itself. This is less error prone, and allows
"whole binary" scans with cppcheck, which leads to fewer false
positives. On the negative side, this means that non-meson/non-cmake
projects will no longer get scanned, which, considering that meson is
what we're converging on, and for any given project a meson port should
probably take priority over cppcheck improvements, this seems
reasonable.

Because of the previous change, the use of popen and communicate() can
be replaced with our more normal methods for calling commands, which
cleans up the code quite a bit.

Adds a cppcheck-temp folder as recommended by the cppcheck docs for
storing intermediate results. This decreases the amount of time
cppcheck takes to run when scanning the same code multiple times.

After that, some argument changes are done to suppress checks that are
noisy, and the project doesn't currently have a way to make pass.

useStlAlgorithm this is just a suggestion, and not always correct, so
it's difficult to make it enforcing. Also, as a project, we tend to not
optimize for std::algorithms as much as we could. At some point in the
future we could turn this back on and make the project have a stronger
opinion on this style, but for the moment, this seems like something to
tackle later.
unusedStructMember this appears to either have bugs, or not understand
when a public struct member is used outside of the compile unit. It
leads to significant noise for things that are actually used, but get
marked unused because they're not used in every compile unit.
postfixOperator use of prefix increment indead of postfix on iterators
is not generally something we enforce on the project, and doesn't seem
like it improves in either the readability or the code, as well as leads
to a lot of noise. Disable for the moment.
unreadVariable Similar to unusedStructMember, this check seems to not be
able to see all possible ifdefs in a section of code, and leads to many
false positives.
knownConditionTrueFalse is supressed because apparently cppcheck isn't
able to read macros, so this flags significant portions of code behind
ifdefs. More investigation is warranted here, but for the moment,
disabling the check gets us closer to the goal

A patch series getting bmcweb code to the point where it's 100% passing
is here, if you want to see the types of changes that cppcheck proposes.
For all the non-disabled checks, cppcheck seems accurate, with no false
positives that I could find, although some slightly pedantic
suggestions.

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/55001

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I7730cc69ad1817cb7d75c04be3b7d1da6c1030d4

show more ...

Update boost to 1.79

Same as yocto is using.

Tested: Built dbus-sensors uring patches (which require 1.79) and they
built correctly.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ic83a

Update boost to 1.79

Same as yocto is using.

Tested: Built dbus-sensors uring patches (which require 1.79) and they
built correctly.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ic83a5ccb940fbc3bce4f8abedce1087e5cdfc102

show more ...

Upgrade clang-tidy version to 14.0.0

Fix a clang issue appearing in clang-tidy-13.0.1
Details refer to: https://reviews.llvm.org/rG1f2d40c47f5f8fd01d91d73a1f52044fe1c83225
[clang-tidy] fix duplicate

Upgrade clang-tidy version to 14.0.0

Fix a clang issue appearing in clang-tidy-13.0.1
Details refer to: https://reviews.llvm.org/rG1f2d40c47f5f8fd01d91d73a1f52044fe1c83225
[clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

Issue: The overload of the constructor will repeatedly fix the member
variables that need to be initialized, Removed the duplicate '{}'.

In current ubuntu:jammy, clang version 14.0.0 is available, so we can use
clang-tidy 14.0.0 to fix the clang issue.

Change-Id: I312888b13ed0ed39e0edf502eca46b11b9e9a62f
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

build-unit-test-docker: Don't generate markdown for PDI

Not used in the unit test container.

Change-Id: I19c053bf73cd08b19f30c855191f1f087f8bca1c
Signed-off-by: William A. Kennington III <wak@googl

build-unit-test-docker: Don't generate markdown for PDI

Not used in the unit test container.

Change-Id: I19c053bf73cd08b19f30c855191f1f087f8bca1c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build-unit-test-docker: update to ubuntu-jammy

Jammy was released on April 21st, 2022. Major changes
impacting our Docker container were:

- native support of OpenSSL3.
- python3.10
- libu

build-unit-test-docker: update to ubuntu-jammy

Jammy was released on April 21st, 2022. Major changes
impacting our Docker container were:

- native support of OpenSSL3.
- python3.10
- liburing2

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8ae6f1cf85367e3a545973c502bfc47f4b1ba95b

show more ...

build-unit-test-docker: remove span-lite

There are no uses of span-lite within the openbmc org anymore and
everyone should be using `std::span` now. Remove it from the Docker
container.

Signed-off

build-unit-test-docker: remove span-lite

There are no uses of span-lite within the openbmc org anymore and
everyone should be using `std::span` now. Remove it from the Docker
container.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I09ceea13678c364ecd331c243aa4476bd0cf2ee4

show more ...

build-unit-test-docker: remove fifo_map

No code and no recipes currently depend on fifo_map. Remove it from
our Docker unit-test container.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Chan

build-unit-test-docker: remove fifo_map

No code and no recipes currently depend on fifo_map. Remove it from
our Docker unit-test container.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib211629376ed4e108248c57d1bf32c77e21818fc

show more ...

meson: update to 0.61.3

This matches the version used in Yocto now.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3c19e5afd3eb23a04e9175bb233144b2b85d13c0

phosphor-logging: fix yaml option

The meson option in the repository is 'yamldir' and not 'yaml_dir'.
Fix this since later versions of Meson complain about an unknown
option being passed.

Signed-of

phosphor-logging: fix yaml option

The meson option in the repository is 'yamldir' and not 'yaml_dir'.
Fix this since later versions of Meson complain about an unknown
option being passed.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4241745e6cafe310152e8d8235db012af447a167

show more ...

autoconf-archive: manually patch C++20 support

autoconf-archive added support for C++20 finally in v2022.02.11
but none of the Ubuntu distro versions have picked this up
yet (checked impish and jamm

autoconf-archive: manually patch C++20 support

autoconf-archive added support for C++20 finally in v2022.02.11
but none of the Ubuntu distro versions have picked this up
yet (checked impish and jammy). Manually patch the file so that
we can upgrade our autoconf-based C++ repositories to use C++20.

The v2022.02.11 version is already included in Yocto.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ied06de39741379689db153896a9a497cb6df229c

show more ...

unit-test: Update gtest source rev to fix std::span issue

The std::span does not support some gtest MACROS and is fixed in
https://github.com/google/googletest/pull/3195 and
https://github.com/googl

unit-test: Update gtest source rev to fix std::span issue

The std::span does not support some gtest MACROS and is fixed in
https://github.com/google/googletest/pull/3195 and
https://github.com/google/googletest/commit/e4717df71a4f45bf9f0ac88c6cd9846a0bc248dd

Including the fixes to support std::span in gtests.

Match the openembedded gtest version in
https://github.com/openembedded/meta-openembedded/pull/564

Change-Id: Ia0171160ee7a0a36c2fb27eb441e25cdec9ba9f1
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Use well-known passwd constants if user root

If the intended user is root, use well-known constants for UID, GID,
and home directory, to avoid wrongly using those of the normal user
running this scr

Use well-known passwd constants if user root

If the intended user is root, use well-known constants for UID, GID,
and home directory, to avoid wrongly using those of the normal user
running this script.

Using -f flag for groupadd, to avoid erroring out if group name
already exists for this user name.

Tested: No longer fails with weird groupadd errors if
run-unit-test-docker.sh command line contains USER="root" setting.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Idc6158386ce96a6e2fa97dd0eb56b928f18e7a35

show more ...

update python path to 3.9 for site-packages

Been having issues getting this to build on Ubuntu 20 and this change
got it working. I don't remember the details on why we need this but we
are now inst

update python path to 3.9 for site-packages

Been having issues getting this to build on Ubuntu 20 and this change
got it working. I don't remember the details on why we need this but we
are now installing python3.9 in our CI images so make it match.

Change-Id: Ic72d32a612d186359b78d098697477db9132c8ad
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

phosphor-dbus-interfaces: remove unnecessary config flags

With Ibb65eddd6c3a3e32f64f4ddf7ac5da4526cab2b7, the PDI repo
enables all interfaces by default, so explicitly enabling some
of them is not n

phosphor-dbus-interfaces: remove unnecessary config flags

With Ibb65eddd6c3a3e32f64f4ddf7ac5da4526cab2b7, the PDI repo
enables all interfaces by default, so explicitly enabling some
of them is not necessary. Remove the config_flags.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie7954198d9475198cbb0f85dc7f4d0b5dc378480

show more ...

scripts/build-unit-test-docker: Update googletest to match openembedded

Promote `googletest` to v1.11 to match openembedded.
See https://github.com/openembedded/meta-openembedded/blob/master/meta-oe

scripts/build-unit-test-docker: Update googletest to match openembedded

Promote `googletest` to v1.11 to match openembedded.
See https://github.com/openembedded/meta-openembedded/blob/master/meta-oe/recipes-test/googletest/googletest_git.bb#L7

Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: I19d315cffc6b7fffaddba7b07a4bd9c7d7533b8d

show more ...

Add python requests to CI

There are some scripts in bmcweb that we'd like to be able to run during
CI. They rely on requests to compare the standards driven files against
what exists in the codebas

Add python requests to CI

There are some scripts in bmcweb that we'd like to be able to run during
CI. They rely on requests to compare the standards driven files against
what exists in the codebase to make sure that people haven't edited by
hand.

To do this, add the requests dependency.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Idbb06d6ba992244c652094040849787bb1487805

show more ...

obmc-build-script: Update fmt to `8.1.1`

Match the version in
https://github.com/openbmc/openbmc/blob/595f63084d313c9708cb435470e6c6dcbbbbe646/meta-openembedded/meta-oe/recipes-support/fmt/fmt_8.1.1

obmc-build-script: Update fmt to `8.1.1`

Match the version in
https://github.com/openbmc/openbmc/blob/595f63084d313c9708cb435470e6c6dcbbbbe646/meta-openembedded/meta-oe/recipes-support/fmt/fmt_8.1.1.bb

Change-Id: Ib647c4f54dfb1a6e619200247a6c4a9f95037140
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Upgrade boost to 1.78

Latest subtree update pulled this in, and boost-url requires it.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ice62443b588fae07bc7bebb4085c13a8373f9515

Update boost url

The latest subtree update pulled in new boost url, and JOY! is API
incompatible with new boost-url. We need the new boost-url in CI, then
this needs to be syncronized with

https:/

Update boost url

The latest subtree update pulled in new boost url, and JOY! is API
incompatible with new boost-url. We need the new boost-url in CI, then
this needs to be syncronized with

https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/50916

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I8e147370cb787706270d49344e870da26e274aa0

show more ...

Use native docker images for scripts on aarch64 Host OS

Commit 051b05b7 support aach64 Host OS to execute scripts. However, it
does not set DOCKER_BASE parameter which consequently uses x86_64 docke

Use native docker images for scripts on aarch64 Host OS

Commit 051b05b7 support aach64 Host OS to execute scripts. However, it
does not set DOCKER_BASE parameter which consequently uses x86_64 docker
images instead of arm64v8 image.
This commit sets DOCKER_BASE to arm64v8/ to use native docker images.

Tested:
1. Set environment variables appropriately and execute scripts. Ensure
all docker images loaded successfully and scripts can execute without
issue.

Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Change-Id: I3c09d448dae17f290f2c2fd1d8116167510635b6

show more ...