build-unit-test-docker: fix clang version argument

The latest version of bash seems to not pass additional arguments
when called with `-c` unless those arguments are after the `--`.

This caused the

build-unit-test-docker: fix clang version argument

The latest version of bash seems to not pass additional arguments
when called with `-c` unless those arguments are after the `--`.

This caused the build-unit-test-docker to not install the latest
version of clang, but instead the release of clang that was present
in the Ubuntu repository.

Add "19" after `--` so that the latest versions of clang tools are
installed.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I894b77b2a03e9125df50a297c9898b3456846cdc

show more ...

build-unit-test-docker: update to clang-19

Clang-19 was released in September. Update our Docker container
to utilize it.

This will likely require re-running clang-format on most repositories
sinc

build-unit-test-docker: update to clang-19

Clang-19 was released in September. Update our Docker container
to utilize it.

This will likely require re-running clang-format on most repositories
since it does not seem 100% compatible.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I88192b41ab7a95599a90915013579608af7bc56f

show more ...

build-unit-test-docker: support podman

Some of our systems utilize podman so ensure this script works for both
docker and podman based systems.

Tested:
- Confirmed still builds on a docker installe

build-unit-test-docker: support podman

Some of our systems utilize podman so ensure this script works for both
docker and podman based systems.

Tested:
- Confirmed still builds on a docker installed Ubuntu server
- Confirmed it now builds on a podman installed Red Hat server

Change-Id: I6f72cf43b32e7f6b9b600b027189a2dcf985f364
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: switch to ubuntu oracular

Ubuntu Oracular is released; switch to it.

As part of this, add systemd-dev to the dependencies in order to solve
the following build failure:
```

build-unit-test-docker: switch to ubuntu oracular

Ubuntu Oracular is released; switch to it.

As part of this, add systemd-dev to the dependencies in order to solve
the following build failure:
```
openbmc/phosphor-objmgr: Run-time dependency systemd found: NO (tried pkgconfig and cmake)
openbmc/phosphor-objmgr:
openbmc/phosphor-objmgr: meson.build:114:26: ERROR: Dependency "systemd" not found, tried pkgconfig and cmake
```

The systemd.pc file is only available as part of systemd-dev now.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6fc4c67c0d5954f47e3752af9b335742901212ac

show more ...

Boost: Upgrade to Version 1.86.0

- Updated package name to use CMake as the build system
- Updated Boost from version 1.84 to 1.86.
- Included atomic, filesystem, and process packages due to
versi

Boost: Upgrade to Version 1.86.0

- Updated package name to use CMake as the build system
- Updated Boost from version 1.84 to 1.86.
- Included atomic, filesystem, and process packages due to
version 1.86 build dependencies.

Change-Id: I594e94db6b5072b42fbbb85cb96849fb98e81ced
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

build-unit-test-docker: Update to gcc-14

Align with the recent Yocto update in OpenBMC[1], which pulls in gcc-14.

[1]: https://github.com/openbmc/openbmc/commit/edff49234e31f23dc79f823473c9e286a215

build-unit-test-docker: Update to gcc-14

Align with the recent Yocto update in OpenBMC[1], which pulls in gcc-14.

[1]: https://github.com/openbmc/openbmc/commit/edff49234e31f23dc79f823473c9e286a21596c1

Change-Id: If65df474997198d7e3d0aa686838b302a9ce87ef
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

build-unit-test-docker: Disable libpldm's ABI compliance check

We use the docker container to maintain libpldm's ABI dump, which is
difficult to do if the container fails to build due to an ABI comp

build-unit-test-docker: Disable libpldm's ABI compliance check

We use the docker container to maintain libpldm's ABI dump, which is
difficult to do if the container fails to build due to an ABI compliance
failure.

Disable the check for the purpose of building the container dependency.
The check remains enabled for the actual CI runs.

Change-Id: Ib7cf8f4b5bf55e7bc4d9e5cc1ea15dd3fb929f93
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

build-unit-test-docker: Disable libpldm tests again

Now that we've merged the change of the option type from feature to
boolean[1], specify that the tests should not be built.

[1]: https://github.c

build-unit-test-docker: Disable libpldm tests again

Now that we've merged the change of the option type from feature to
boolean[1], specify that the tests should not be built.

[1]: https://github.com/openbmc/libpldm/commit/65c64099e17ad81219726e790598cdc1f6e78f9a

Change-Id: Ife75a3505a6975174ffd8036ac042bdbcba27560
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

build-unit-test-docker: Add 'isoduration' to support ISO 8601 duration

As per the proposed design for syncing data to the redundant BMC, time
intervals need to be specified in seconds, minutes, or h

build-unit-test-docker: Add 'isoduration' to support ISO 8601 duration

As per the proposed design for syncing data to the redundant BMC, time
intervals need to be specified in seconds, minutes, or hours. For more
details, refer to the design document:
https://gerrit.openbmc.org/c/openbmc/docs/+/71039/4/designs/
redundant_bmc_data_synchronization.md#157

The JSON doesn't have a in-built infrastructure to represent time
intervals in seconds,minutes etc. So the schema draft 2019-09 supports
format where time intervals can be represented in ISO 8601 duration
format.

Refer #built-in-formats :
https://json-schema.org/understanding-json-schema/reference/string

But for parsing and validating the same it requires an additional
python package called `isoduration`.

Refer #validating-formats :
https://python-jsonschema.readthedocs.io/en/latest/validate/

The change installs the python package `isoduration` to the docker to
enable the support of ISO 8601 duration formats in JSON and schema
files.

Change-Id: I5489aa21118fa8852ed22f40570c2b77c00951e3
Signed-off-by: Arya K Padman <aryakpadman@gmail.com>

show more ...

build-unit-test-docker: Temporarily drop libpldm test configuration

The series at [1] switches libpldm's 'test' option type from feature to
boolean. Avoid the container build error in the interim by

build-unit-test-docker: Temporarily drop libpldm test configuration

The series at [1] switches libpldm's 'test' option type from feature to
boolean. Avoid the container build error in the interim by not disabling
the build of the tests, however, in doing so, ensure that the test build
dependencies are available to meson. The change implements the latter
by allowing the gtest and gmock wraps to download their sources during
the build.

The holistic approach of this patch is a compromise against the effort
required to allow type detection for meson flags, like we do in scripts/
unit-test.py. That code could be made common, however the work is a
bunch of refactoring that ultimately loses value once the patch to
change the test option type to boolean is merged in libpldm. Once
the patch is merged, we can drop `--wrap-mode=default` and introduce
`-Dtests=false` as the replacement for `-Dtests=disabled`.

[1]: https://gerrit.openbmc.org/q/topic:%22options-rework%22+repo:openbmc/libpldm

Change-Id: I51e51c75603db613aac3bd11c719def4b7e23561
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

build-unit-test-docker: Drop libpldm oem-ibm option

The OEM extensions are built by default, so there's no immediate need to
specify the option. Further, the structure of the libpldm meson options
i

build-unit-test-docker: Drop libpldm oem-ibm option

The OEM extensions are built by default, so there's no immediate need to
specify the option. Further, the structure of the libpldm meson options
is changing with the series at [1], so dodge the associated errors for
now.

[1]: https://gerrit.openbmc.org/q/topic:%22options-rework%22+repo:openbmc/libpldm

Change-Id: Id45be82115f93758e96f5d23ca103ff8915ab061
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

build-unit-test-docker: make aws default docker registry

AWS has much better anonymous pull request limits (1 per second) vs
docker hub which is 100 per 6 hours per IP address. A lot of our CI and
d

build-unit-test-docker: make aws default docker registry

AWS has much better anonymous pull request limits (1 per second) vs
docker hub which is 100 per 6 hours per IP address. A lot of our CI and
development occurs on shared systems so it's easy to exceed this limit
on an IP basis.

Tested:
- Verified no setting for DOCKER_REG and a setting of docker.io work as
expected

Change-Id: I7fb220b2541ccb1b65fa74b8638c0258a84b7421
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: provide docker registry override

docker.io continues to tighten control[1] on access to its registry.
Provide a mechanism within this script to utilize a different registry
f

build-unit-test-docker: provide docker registry override

docker.io continues to tighten control[1] on access to its registry.
Provide a mechanism within this script to utilize a different registry
for the base ubuntu image.

[1]: https://www.docker.com/blog/november-2024-updated-plans-announcement/

Tested:
- Confirmed script default still works as expected
- Confirmed the following also works now:
export DOCKER_REG=public.ecr.aws/ubuntu

Change-Id: I4e8251653003cfac514905f2d2a5e8787b8ec06a
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: remove architecture checks

Docker containers now handle this under the covers when you pull a
container.

Tested:
- Confirmed ubuntu:latest works on ppc64le

Change-Id: Ic757

build-unit-test-docker: remove architecture checks

Docker containers now handle this under the covers when you pull a
container.

Tested:
- Confirmed ubuntu:latest works on ppc64le

Change-Id: Ic757d8317cb541e63fd51b29f5fdf4616d71797b
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: add cjson for skeleton

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id70c0c648e53f3c945b953ca1edb63fff152f559

build-unit-test-docker: add glib-2.0 for skeleton

openbmc/skeleton current needs glib-2.0 to build. Add
it to the docker config.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I63a

build-unit-test-docker: add glib-2.0 for skeleton

openbmc/skeleton current needs glib-2.0 to build. Add
it to the docker config.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I63ab9cdd4c84128fb878c6276213981660cd24bd

show more ...

build-unit-test-docker: enable topic-based testing

There are cases when a phosphor-dbus-interfaces change is necessary
before (or at the same time) as a commit in another repository.
Maintainers wil

build-unit-test-docker: enable topic-based testing

There are cases when a phosphor-dbus-interfaces change is necessary
before (or at the same time) as a commit in another repository.
Maintainers will sometimes ignore review of a commit with failing CI
which prevents getting feedback necessary for the reviewer to move
forward with the entire set of changes. Enable topic-based testing
in CI, which will prime the Docker container dependencies from a topic
on Gerrit.

In order to simplify this implementation and avoid having to figure out
commit application order (potentially across splits in the Git tree),
the topic must only have one commit from each repository.

Tested:

Confirmed both phosphor-dbus-interfaces and phosphor-logging selected
commits from the topic when building the Docker container with:
```
$ GERRIT_TOPIC=logging-create-with-path scripts/build-unit-test-docker
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I71831d992ec79a9d820456bd4a70e02d9000ebc2

show more ...

build-unit-test-docker: add nlohmann-json dep to sdbusplus

Pending commit[1] adds nlohmann-json usage in sdbusplus;
update docker dependencies to reflect that.

[1]: https://gerrit.openbmc.org/c/ope

build-unit-test-docker: add nlohmann-json dep to sdbusplus

Pending commit[1] adds nlohmann-json usage in sdbusplus;
update docker dependencies to reflect that.

[1]: https://gerrit.openbmc.org/c/openbmc/sdbusplus/+/74858

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9027c06877c35ae9c5b130d1ce0bec881060b5d7

show more ...

build-unit-test-docker: update googletest

Googletest 1.14 has issues with clang-18. Update to 1.15.2 which
seems to no longer have the issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
C

build-unit-test-docker: update googletest

Googletest 1.14 has issues with clang-18. Update to 1.15.2 which
seems to no longer have the issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic31cd021ea17ba6d1a9f81399f8deaa86bdb5900

show more ...

build-unit-test-docker: use LLVM APT repos

The latest version of clang-18 from ubuntu's apt is 18.1.3,
but the latest stable release is 18.1.8. These two versions have
different output on some repo

build-unit-test-docker: use LLVM APT repos

The latest version of clang-18 from ubuntu's apt is 18.1.3,
but the latest stable release is 18.1.8. These two versions have
different output on some repositories when using clang-format. Switch
to using the apt.llvm.org packages so we get the latest stable versions.

The LLVM apt install tool needed a few additional packages to be
installed, so add those to the base apt-get.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I139cb040b95793ef8e7034d49296a2a5ea3bbac3

show more ...

build-unit-test-docker: update to clang-18

Update the CI docker container to use clang-18.

Change-Id: Iea0776aaa7edd483fa395e23de25ebf5a6288f71
Signed-off-by: Ed Tanous <ed@tanous.net>
Signed-off-b

build-unit-test-docker: update to clang-18

Update the CI docker container to use clang-18.

Change-Id: Iea0776aaa7edd483fa395e23de25ebf5a6288f71
Signed-off-by: Ed Tanous <ed@tanous.net>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build-unit-test-docker: remove old dependencies

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I433fa21559a54684992eed92fc4ac8b69d66092e

unit-test: Support for valgrind on boost

When UTs, which are run under valgrind, utilize boost coroutines, there
might occur errors during stack switching. Boost has prepared an option
to suppress t

unit-test: Support for valgrind on boost

When UTs, which are run under valgrind, utilize boost coroutines, there
might occur errors during stack switching. Boost has prepared an option
to suppress these errors with build option `valgrind=on`, combined with
compile flag `BOOST_USE_VALGRIND` [1]. This patch implements these
options into boost package and CMake/Meson project configurations.

Tested:
On a change where CI are failing due to valgrind errors [2]. When using
container from this patch, these errors stop appearing and CI ends with
success.

[1] https://www.boost.org/doc/libs/1_82_0/libs/context/doc/html/context/stack/valgrind.html
[2] https://gerrit.openbmc.org/c/openbmc/jsnbd/+/59600/11

Change-Id: I183eaf7c15ac9cc2799f446fe7fb933d957fac21
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

build-unit-test-docker: Replace lcov with gcovr

Resolves openbmc/openbmc-build-scripts#37

Tested: run-unit-test-docker.sh runs correctly and coverage report
generated by gcovr is present

Change-Id

build-unit-test-docker: Replace lcov with gcovr

Resolves openbmc/openbmc-build-scripts#37

Tested: run-unit-test-docker.sh runs correctly and coverage report
generated by gcovr is present

Change-Id: I60134758477cb8f2f5deb94c26eca515d48199f2
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ia6b70713d3e9b77d6fd2d9400489ef7f02360364
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...