build-unit-test-docker: make aws default docker registry

AWS has much better anonymous pull request limits (1 per second) vs
docker hub which is 100 per 6 hours per IP address. A lot of our CI and
d

build-unit-test-docker: make aws default docker registry

AWS has much better anonymous pull request limits (1 per second) vs
docker hub which is 100 per 6 hours per IP address. A lot of our CI and
development occurs on shared systems so it's easy to exceed this limit
on an IP basis.

Tested:
- Verified no setting for DOCKER_REG and a setting of docker.io work as
expected

Change-Id: I7fb220b2541ccb1b65fa74b8638c0258a84b7421
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: provide docker registry override

docker.io continues to tighten control[1] on access to its registry.
Provide a mechanism within this script to utilize a different registry
f

build-unit-test-docker: provide docker registry override

docker.io continues to tighten control[1] on access to its registry.
Provide a mechanism within this script to utilize a different registry
for the base ubuntu image.

[1]: https://www.docker.com/blog/november-2024-updated-plans-announcement/

Tested:
- Confirmed script default still works as expected
- Confirmed the following also works now:
export DOCKER_REG=public.ecr.aws/ubuntu

Change-Id: I4e8251653003cfac514905f2d2a5e8787b8ec06a
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: remove architecture checks

Docker containers now handle this under the covers when you pull a
container.

Tested:
- Confirmed ubuntu:latest works on ppc64le

Change-Id: Ic757

build-unit-test-docker: remove architecture checks

Docker containers now handle this under the covers when you pull a
container.

Tested:
- Confirmed ubuntu:latest works on ppc64le

Change-Id: Ic757d8317cb541e63fd51b29f5fdf4616d71797b
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: add cjson for skeleton

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id70c0c648e53f3c945b953ca1edb63fff152f559

build-unit-test-docker: add glib-2.0 for skeleton

openbmc/skeleton current needs glib-2.0 to build. Add
it to the docker config.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I63a

build-unit-test-docker: add glib-2.0 for skeleton

openbmc/skeleton current needs glib-2.0 to build. Add
it to the docker config.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I63ab9cdd4c84128fb878c6276213981660cd24bd

show more ...

build-unit-test-docker: enable topic-based testing

There are cases when a phosphor-dbus-interfaces change is necessary
before (or at the same time) as a commit in another repository.
Maintainers wil

build-unit-test-docker: enable topic-based testing

There are cases when a phosphor-dbus-interfaces change is necessary
before (or at the same time) as a commit in another repository.
Maintainers will sometimes ignore review of a commit with failing CI
which prevents getting feedback necessary for the reviewer to move
forward with the entire set of changes. Enable topic-based testing
in CI, which will prime the Docker container dependencies from a topic
on Gerrit.

In order to simplify this implementation and avoid having to figure out
commit application order (potentially across splits in the Git tree),
the topic must only have one commit from each repository.

Tested:

Confirmed both phosphor-dbus-interfaces and phosphor-logging selected
commits from the topic when building the Docker container with:
```
$ GERRIT_TOPIC=logging-create-with-path scripts/build-unit-test-docker
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I71831d992ec79a9d820456bd4a70e02d9000ebc2

show more ...

build-unit-test-docker: add nlohmann-json dep to sdbusplus

Pending commit[1] adds nlohmann-json usage in sdbusplus;
update docker dependencies to reflect that.

[1]: https://gerrit.openbmc.org/c/ope

build-unit-test-docker: add nlohmann-json dep to sdbusplus

Pending commit[1] adds nlohmann-json usage in sdbusplus;
update docker dependencies to reflect that.

[1]: https://gerrit.openbmc.org/c/openbmc/sdbusplus/+/74858

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9027c06877c35ae9c5b130d1ce0bec881060b5d7

show more ...

build-unit-test-docker: update googletest

Googletest 1.14 has issues with clang-18. Update to 1.15.2 which
seems to no longer have the issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
C

build-unit-test-docker: update googletest

Googletest 1.14 has issues with clang-18. Update to 1.15.2 which
seems to no longer have the issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic31cd021ea17ba6d1a9f81399f8deaa86bdb5900

show more ...

build-unit-test-docker: use LLVM APT repos

The latest version of clang-18 from ubuntu's apt is 18.1.3,
but the latest stable release is 18.1.8. These two versions have
different output on some repo

build-unit-test-docker: use LLVM APT repos

The latest version of clang-18 from ubuntu's apt is 18.1.3,
but the latest stable release is 18.1.8. These two versions have
different output on some repositories when using clang-format. Switch
to using the apt.llvm.org packages so we get the latest stable versions.

The LLVM apt install tool needed a few additional packages to be
installed, so add those to the base apt-get.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I139cb040b95793ef8e7034d49296a2a5ea3bbac3

show more ...

build-unit-test-docker: update to clang-18

Update the CI docker container to use clang-18.

Change-Id: Iea0776aaa7edd483fa395e23de25ebf5a6288f71
Signed-off-by: Ed Tanous <ed@tanous.net>
Signed-off-b

build-unit-test-docker: update to clang-18

Update the CI docker container to use clang-18.

Change-Id: Iea0776aaa7edd483fa395e23de25ebf5a6288f71
Signed-off-by: Ed Tanous <ed@tanous.net>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build-unit-test-docker: remove old dependencies

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I433fa21559a54684992eed92fc4ac8b69d66092e

unit-test: Support for valgrind on boost

When UTs, which are run under valgrind, utilize boost coroutines, there
might occur errors during stack switching. Boost has prepared an option
to suppress t

unit-test: Support for valgrind on boost

When UTs, which are run under valgrind, utilize boost coroutines, there
might occur errors during stack switching. Boost has prepared an option
to suppress these errors with build option `valgrind=on`, combined with
compile flag `BOOST_USE_VALGRIND` [1]. This patch implements these
options into boost package and CMake/Meson project configurations.

Tested:
On a change where CI are failing due to valgrind errors [2]. When using
container from this patch, these errors stop appearing and CI ends with
success.

[1] https://www.boost.org/doc/libs/1_82_0/libs/context/doc/html/context/stack/valgrind.html
[2] https://gerrit.openbmc.org/c/openbmc/jsnbd/+/59600/11

Change-Id: I183eaf7c15ac9cc2799f446fe7fb933d957fac21
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

build-unit-test-docker: Replace lcov with gcovr

Resolves openbmc/openbmc-build-scripts#37

Tested: run-unit-test-docker.sh runs correctly and coverage report
generated by gcovr is present

Change-Id

build-unit-test-docker: Replace lcov with gcovr

Resolves openbmc/openbmc-build-scripts#37

Tested: run-unit-test-docker.sh runs correctly and coverage report
generated by gcovr is present

Change-Id: I60134758477cb8f2f5deb94c26eca515d48199f2
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ia6b70713d3e9b77d6fd2d9400489ef7f02360364
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

build-unit-test-docker: ensure we stop on first branch

Ran into an issue where we were creating our root branch (i.e. 1110) and
then creating some snapshot branches (i.e. 1110-snapshot-xyz). The
scr

build-unit-test-docker: ensure we stop on first branch

Ran into an issue where we were creating our root branch (i.e. 1110) and
then creating some snapshot branches (i.e. 1110-snapshot-xyz). The
script would end up using that snapshot branch.

Lots of potential discussion to be had on our branch creations decisions
but either way, best to make sure we match with the exact branch
being passed in.

Tested:
- Confirmed over in ibm-openbmc/openbmc that we pick up expected
branches now.

Change-Id: I71099f42ca40bfd9fe719a550349eba82000133d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: Add socat

Adding possibility to use socat in the SSH configuration.

Resolves openbmc/openbmc-build-scripts#36

Tested:
run-unit-test-docker.sh runs with EXTRA_DOCKER_RUN_ARG

build-unit-test-docker: Add socat

Adding possibility to use socat in the SSH configuration.

Resolves openbmc/openbmc-build-scripts#36

Tested:
run-unit-test-docker.sh runs with EXTRA_DOCKER_RUN_ARGS=
"-v /home/user/.gitconfig:/home/user/.gitconfig
-v /home/user/.ssh:/home/user/.ssh"

Change-Id: I45e9279c5e3bd3bfc59113bc41ba2abfd7eb1bfa
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

build-unit-test-docker: eslint-plugin-json: pin to v3.1.0

The new v4.0.0 release does not work with an error like this:
```
Error: ESLint configuration in --config » plugin:json/recommended-with-com

build-unit-test-docker: eslint-plugin-json: pin to v3.1.0

The new v4.0.0 release does not work with an error like this:
```
Error: ESLint configuration in --config » plugin:json/recommended-with-comments is invalid:
- Unexpected top-level property "files".
```
Pin eslint-plugin-json to v3.1.0 to solve this.

Change-Id: I773c9c0bda3b87cca92e69089ea37fb20f563ab9
Signed-off-by: Xinnan Xie <xiexinnan@bytedance.com>

show more ...

Capture stderr from docker build

BuildKit sends build messages to stderr and python `sh` does nothing
with it. Redirect stderr to our custom printer function to put
everything in the same stream.

C

Capture stderr from docker build

BuildKit sends build messages to stderr and python `sh` does nothing
with it. Redirect stderr to our custom printer function to put
everything in the same stream.

Change-Id: Id862154be7ef845a758c5f2248f47a8c6d4de7e2
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

Update nghttp2 1.57->1.61

Change-Id: I8491dd58fb4f197c127624119a67ee0814363935
Signed-off-by: Ed Tanous <ed@tanous.net>

build-unit-test-docker:eslint: pin to v8.56.0

The new v9.0 release change the API and our existing use of it no longer
works with an error like this:

```
Invalid option '--eslintrc' - perhaps you m

build-unit-test-docker:eslint: pin to v8.56.0

The new v9.0 release change the API and our existing use of it no longer
works with an error like this:

```
Invalid option '--eslintrc' - perhaps you meant '--ignore'?
```

Until we have some time to sort this out, move us back to the previous
release.

Change-Id: Ieed62b82bb3870c22bb377f562fb75b148395cee
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: Protobuf versions should match

The python protobuf version should match the compiler and library
version, or else we will run into API issues.

Change-Id: Iba9472123734cb1015

build-unit-test-docker: Protobuf versions should match

The python protobuf version should match the compiler and library
version, or else we will run into API issues.

Change-Id: Iba9472123734cb1015c0d2f0dc72bd18be660355
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Remove valgrind-dbgsym

This package doesn't seem to exist anymore and results in

```base: E: Unable to locate package valgrind-dbgsym```

when trying to build.

From the ubuntu maintainers, this do

Remove valgrind-dbgsym

This package doesn't seem to exist anymore and results in

```base: E: Unable to locate package valgrind-dbgsym```

when trying to build.

From the ubuntu maintainers, this doesn't seem necessary anymore

```
If you are on Ubuntu Jammy (22.04) or later, you do not need to
worry about installing debug symbol packages anymore. The
Ubuntu project maintains a Debuginfod server, and GDB and other
debuginfo-consumer applications support it out of the box. For
more information about it, please refer to this page.

If you are on Ubuntu Noble (24.04) or later, Debuginfod is the
preferred method as the following information is outdated and, due
to a new format for the sources.list entries being moved to the
deb822 format.

https://wiki.ubuntu.com/Debug%20Symbol%20Packages#Debuginfod
```

Change-Id: Ib7d221763b30d433c19cfad7fe3b8462ffcb7383
Signed-off-by: Ed Tanous <ed@tanous.net>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: Run ldconfig

The preinstalled packages are copied to /usr/local but ld is not aware
of these libraries until ldconfig is run. This makes the container more
useful for interac

build-unit-test-docker: Run ldconfig

The preinstalled packages are copied to /usr/local but ld is not aware
of these libraries until ldconfig is run. This makes the container more
useful for interactive use out of the box.

Tested:
== Before ==
docker$ ldd /usr/local/lib/libboost_coroutine.so | grep 'not found'
libboost_context.so.1.84.0 => not found

== After ==
docker$ ldd /usr/local/lib/libboost_coroutine.so | grep 'not found'
docker$

Change-Id: I3f6508ad6068df03206b6c405532c0230dd95d8d
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

build-unit-test-docker: ubuntu: switch to noble numbat

The clang-17 package in manic is pinned back at 17.0.2, while the latest
release is 17.0.6. There are some subtle bug fixes around type parsin

build-unit-test-docker: ubuntu: switch to noble numbat

The clang-17 package in manic is pinned back at 17.0.2, while the latest
release is 17.0.6. There are some subtle bug fixes around type parsing,
which are especially useful for clang-format. Upgrade the distro so we
can get these fixes.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I53dce7c01bc04cbff193fd660984f2eb985be91a

show more ...

boost: move to 1.84.0

Change-Id: I68100ca862c86324297fd46f3254674ec7a4fe41
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>