run-unit-test-docker: support podman

podman requires this env variable be set in order to have the correct
permissions to mount your home filesystem.

Tested:
- Verified after the latest sdbusplus u

run-unit-test-docker: support podman

podman requires this env variable be set in order to have the correct
permissions to mount your home filesystem.

Tested:
- Verified after the latest sdbusplus updates that this script can now
run on a POWER9 based server using RH8 + podman

Change-Id: I32a9e68f8cfc5df1d4489a2e089ab3ba92558cc9
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

run-unit-test-docker.sh: add extra docker run args

It can be useful to provide docker run with additional command line
arguments, such as --volume.

Consider a filesystem with git repositories:
~/gi

run-unit-test-docker.sh: add extra docker run args

It can be useful to provide docker run with additional command line
arguments, such as --volume.

Consider a filesystem with git repositories:
~/git/openbmc/bmcweb

And git worktrees for those repositories outside of the ~/git/openbmc
namespace:

~/worktrees/worktree-a/bmcweb
~/worktrees/worktree-b/bmcweb

and then using EXTRA_DOCKER_RUN_ARGS="--volume $HOME/git:$HOME/git" it
becomes possible to run the unit tests with such a layout.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I5524e4d369f98229180b2e1beaf322381ca814c7

show more ...

run-unit-test-docker: avoid all workspace copying

Finish cleaning up all cases where the run-unit-test-docker script
copies content from this repo into the workspace and instead access
it directly i

run-unit-test-docker: avoid all workspace copying

Finish cleaning up all cases where the run-unit-test-docker script
copies content from this repo into the workspace and instead access
it directly in-place from the workspace.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2be10881aa9e672917522b99feaf228bc227c3b2

show more ...

format-code: improve script ergonomics

- Add getopt and help-text.
- Default to `pwd` for repository.
- Utilize `git rev-parse` to find repo-root if ran from subdir.
- Find default config di

format-code: improve script ergonomics

- Add getopt and help-text.
- Default to `pwd` for repository.
- Utilize `git rev-parse` to find repo-root if ran from subdir.
- Find default config directory using `${BASH_SOURCE[0]}`.
- Improve and colorize logging.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I925b17f65fe817d30a0932954761d3849e27a8ea

show more ...

format-code: simplify codespell

* Avoid copying codespell config files into the workspace.
* Drop 'ignore-words' support.
* Filter out Signed-off-by lines.

The 'openbmc-spelling-ignore.txt' file co

format-code: simplify codespell

* Avoid copying codespell config files into the workspace.
* Drop 'ignore-words' support.
* Filter out Signed-off-by lines.

The 'openbmc-spelling-ignore.txt' file contained someone's last
name, which was being triggered by codespell as being similar enough
to a real word that it was identified as a mispelling. Instead of
keeping their name in an ignore file, filter out the Signed-off-by.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie2c96a000c352dc02a5dee1db3d2d9ea2b629cef

show more ...

format-code: avoid copying eslint config

There isn't a strong reason to copy the eslint config into the
workspace when we can just reference the `openbmc-build-scripts`
repository from within the wo

format-code: avoid copying eslint config

There isn't a strong reason to copy the eslint config into the
workspace when we can just reference the `openbmc-build-scripts`
repository from within the workspace, like we did for gitlint.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iad6c05527fb60d906d7b9536f4e7608885d4c59f

show more ...

spelling: add ignore list

Thu Ba reported that their name is getting rejected as a spelling
mistake in their Signed-off-by. Add capability to ignore words
from the primary dictionaries and add 'ba'

spelling: add ignore list

Thu Ba reported that their name is getting rejected as a spelling
mistake in their Signed-off-by. Add capability to ignore words
from the primary dictionaries and add 'ba' to the ignore list.

Tested:

Before change, manually running codespell results in:
```
./config/openbmc-spelling-ignore.txt:1: Ba ==> By, be
```
Manually running codespell with ignore-list option removes this.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I33134e519e28024926b6da00340d2d52e2e884bd

show more ...

run-unit-test-docker: Support http_proxy env

If http_proxy env is set, add proxy related env into docker container so
that the unit test could be run in a proxy environment.

This could be useful fo

run-unit-test-docker: Support http_proxy env

If http_proxy env is set, add proxy related env into docker container so
that the unit test could be run in a proxy environment.

This could be useful for repo like bmcweb that downloads extra content
during build and test.

Tested: Verify the bmcweb repo CI could use the proxy to download the
DSP8010 schema zip.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I8970c5eec76adaa096af127c93c409de55221181

show more ...

run-unit-test-docker: add comment for TEST_ONLY

The NO_FORMAT_CODE option is in the comment block. It also makes sense
to add the TEST_ONLY option to that comment block.

Tested: tested locally thou

run-unit-test-docker: add comment for TEST_ONLY

The NO_FORMAT_CODE option is in the comment block. It also makes sense
to add the TEST_ONLY option to that comment block.

Tested: tested locally though it only changes a comment.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I49f48e813c633bd89b9c82df128e84e3c59c8993

show more ...

run-unit-test-docker.sh: add INTERACTIVE option

This allows running an interactive bash shell instead of the default
unit testing script.

Tested: Ran with and without "INTERACTIVE=true"

Signed-off

run-unit-test-docker.sh: add INTERACTIVE option

This allows running an interactive bash shell instead of the default
unit testing script.

Tested: Ran with and without "INTERACTIVE=true"

Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Change-Id: Ifaee7d0dd705466ce70ad49aae48ac9a4a7ab522

show more ...

run-ci: remove --network=host

There shouldn't be any reason to expose the Docker container
directly on the host network. The default in Docker is 'bridge'.

This was originally introduced in a comm

run-ci: remove --network=host

There shouldn't be any reason to expose the Docker container
directly on the host network. The default in Docker is 'bridge'.

This was originally introduced in a commit that added CMake support
back in 2017 but with no explanation. Removing it now...

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6f7f218cd23b86d62efdadafa8e75c8a8615b4da

show more ...

spellcheck: move dictionary to config dir

Consolidate all configuration into the 'config' directory rather than
having a 'dictionary' subdirectory with a single file in it.

Signed-off-by: Patrick W

spellcheck: move dictionary to config dir

Consolidate all configuration into the 'config' directory rather than
having a 'dictionary' subdirectory with a single file in it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I45d3508a5875148c3fb90150da98013de6a568e7

show more ...

JSON validation support in CI

Most of the openbmc repositories depend on JSON configuration files,
which are consumed by the respective daemons at runtime.

It's a good value add

JSON validation support in CI

Most of the openbmc repositories depend on JSON configuration files,
which are consumed by the respective daemons at runtime.

It's a good value add to catch the JSON validation errors early in the
repository CI itself.

By default, the CI would be picking config/eslint-global-config as the
default configuration to run the JSON validation. The default configuration
can be overridden by the presence of the .eslintrc.json file from the
repository for which the CI is running against.

Repositories cannot completely opt-out of the JSON validation, but they
choose to skip whatever files/folders they want using the .eslintignore
configuration file or, they can also write the rules in .eslintrc.json
config file to turn errors into warnings.

This commit brings in eslint & eslint-plugin-json which does only the
"json validation".

Visit the below link(s) for more details & various error's/warnings that
this plugin would report:
https://www.npmjs.com/package/eslint-plugin-json
https://github.com/azeemba/eslint-plugin-json

I have tested all the repos under openbmc with the eslint-global-config
and only two repos are breaking due to this change, they are already
fixed(please check the topic: "json-validation" for more details)

Testing Example :
1. Make a json bad by purposefully removing a comma

Running the json validator on the repo using it's config >

/home/manojeda/ci_test_area/pldm/configurations/fru_master.json
19:26 error Expected comma json/*

✖ 1 problem (1 error, 0 warnings)

2. if the json is good, the validation proceeds fruther without
any issues.

Change-Id: I2c2c14b18bb626b1a5ab5d818b92d5ba370e1639
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Spell check on commit message support for CI

- This commit would add the codespell package while
building the base container.

- The intention is that, we maintain two dictiona

Spell check on commit message support for CI

- This commit would add the codespell package while
building the base container.

- The intention is that, we maintain two dictionaries
1. That comes directly with codespell
- We should also download the latest dictionary while
while building the base container.
2. An openbmc spellings dictionary
- We should be able to add words and spellings that are
openbmc related in this dictionary over time.

- When the commit message have words that the dictionary does not have,
the CI proceeds further without any rejection. The CI only scores a -1 if
it sees a word wrongly spelled from it knowledge from the dictionary.

Tested by:

1. when commit message have mistakes: It breaks & scores a -1
It also highlights the spelling mistake and the correct spelling
to be used.

2. when commit message does not have mistakes : it does not break &
proceeds further for compilation.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I87278597876b6e2b0a59e297cde020631491b5fd

show more ...

run-unit-test-docker: minor shellcheck fixes

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I497d15cbdca88b3cac1b05bef3947ec658ef7235

utilize DISTRO default from build-unit-test-docker

Both run-unit-test-docker.sh and build-unit-test-docker have a default
for DISTRO. We don't want users to have to update both when

utilize DISTRO default from build-unit-test-docker

Both run-unit-test-docker.sh and build-unit-test-docker have a default
for DISTRO. We don't want users to have to update both when
changing the default use the common denominator which is
build-unit-test-docker.

Change-Id: Id2813570d1104c97ee6d8737960a103c1e028b52
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: create hashed tags for final image

Create a tag for the final image in the same format as the stage
images. Display this tag to stdout at the end of the docker b

build-unit-test-docker: create hashed tags for final image

Create a tag for the final image in the same format as the stage
images. Display this tag to stdout at the end of the docker build
so that other scripts can consume it via calls like:
$(scripts/build-unit-test-docker)

Modify `run-unit-test-docker.sh` to get the docker image from
`build-unit-test-docker` rather than a static image name. This
ensures that the docker image used in unit testing is the exact
image requested to be built. (Soon this will allow us to incorporate
Gerrit changes into the docker image itself.)

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idd7a9a7b0157f1c520b33b3ec7ac0d5b52018d9e

show more ...

build-unit-test-docker: convert to Python

Do a near identical conversion from bash to Python for the script which
builds the unit-test docker containers. I plan to do additional
enh

build-unit-test-docker: convert to Python

Do a near identical conversion from bash to Python for the script which
builds the unit-test docker containers. I plan to do additional
enhancements to build the sub-containers in parallel, so I needed to
first do this conversion to Python in order to make that implementation
sane.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6df6f294b41f3a01f95fbe23a6dcd1ea21a315a9

show more ...

shellcheck: clean up shellcheck warnings and enable

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibc843b98c0fea97a31d3d15b556a32f091bf8e47

run-docker: add argument passthrough

Add capability to pass arguments through to unit-test.py. For example
to instruct unit-test.py to repeat tests 100 times use:

EXTRA_UNIT_TE

run-docker: add argument passthrough

Add capability to pass arguments through to unit-test.py. For example
to instruct unit-test.py to repeat tests 100 times use:

EXTRA_UNIT_TEST_ARGS="-r 100"

or just:

EXTRA_UNIT_TEST_ARGS=-r100

Change-Id: I0bd665070c69ff4f61b14fcc5a22bb6dd8ee2d30
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

move unit test docker up to gcc10

The project will soon be moving to gcc10 so ensure we're running it in
CI. Getting to gcc10 required an update to the latest Ubuntu LTS
release. The

move unit test docker up to gcc10

The project will soon be moving to gcc10 so ensure we're running it in
CI. Getting to gcc10 required an update to the latest Ubuntu LTS
release. The latest Ubuntu release moved to python 3.8.

Change-Id: I555c446bc9f9ec4b12e6ed270f5689d75586a4e7
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Add --noformat option for unit test

The run-unit-test-docker.sh and unit-test.py will run format-code.sh to
check the code format, and break when the code is not formatted
correctly.

Add --noformat option for unit test

The run-unit-test-docker.sh and unit-test.py will run format-code.sh to
check the code format, and break when the code is not formatted
correctly.

For local-ci, this is unecessary because the code not "git add" or not
committed is treated as not-formatted and will break.

Adding NO_FORMAT_CODE option to make the unit test skip formatting the
code, so that one could write code in local repo, run the local-ci
without having to git add ro commit the changes.

Tested: Run run-unit-test-docker.sh as before, verify the format-code.sh
is invoked;
Run 'NO_FORMAT_CODE=1 run-unit-test-docker.sh', verify the
format-code.sh is not invoked.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: Ib3b6cf34390c91d551bc14613e925b8e51a3065f

show more ...

run-unit-test-docker.sh: clean up copied scripts

The tool copies some scripts to the workspace directory. It appears this
is done so that the permissions can be changed, as opposed to

run-unit-test-docker.sh: clean up copied scripts

The tool copies some scripts to the workspace directory. It appears this
is done so that the permissions can be changed, as opposed to
potentially changing the repo containing the scripts.

Updated the tool to removed this copied scripts after the tool finishes
successfully.

Change-Id: I8b1be3b05d007da7e1f55df776d0dffcbc712d77
Signed-off-by: Zane Shelley <zshelle@us.ibm.com>

show more ...

run-unit-test-docker: Fix out of sync distro

build-unit-test-docker was switched to eoan but this was missed during
that change 0232a25bf96e8017a90d6d86985678d7b5681bf6.

Change-

run-unit-test-docker: Fix out of sync distro

build-unit-test-docker was switched to eoan but this was missed during
that change 0232a25bf96e8017a90d6d86985678d7b5681bf6.

Change-Id: I56fbc973ee9c2c5837bff7593e30c1daa928a4d7
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

unit-test-docker: ubuntu:bionic -> ubuntu:disco

This updates us to the soon to be released version of ubuntu, skipping
cosmic so that we don't have to jump verisons again for a while. Th

unit-test-docker: ubuntu:bionic -> ubuntu:disco

This updates us to the soon to be released version of ubuntu, skipping
cosmic so that we don't have to jump verisons again for a while. The
main draw here is to get a newer version of systemd to match the version
we are using in yocto (237 -> 240). This also gives us the benefit of
being able to clean up the gcc override for gcc-8 since it is the
default in disco.

Change-Id: I2327b481bdbe6b8a1c82d193bdc8d9b5e1a6e452
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...