OWNERS: Remove Zev

I'm changing jobs and am no longer going to be working on OpenBMC.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I930c0c52239f54024df7ece3e4b93ee39ba792dd

systemd: rename service file to align with repo name

Updated systemd service file as following for better readability
start-ipkvm.service -> obmc-ikvm.service

Testing:

Verified systemd service usi

systemd: rename service file to align with repo name

Updated systemd service file as following for better readability
start-ipkvm.service -> obmc-ikvm.service

Testing:

Verified systemd service using QEMU + AST2600EVB firmware.

Before changes:

root@evb-ast2600:~# systemctl status start-ipkvm
* start-ipkvm.service - OpenBMC ipKVM daemon

After changes:

root@evb-ast2600:~# systemctl status obmc-ikvm
* obmc-ikvm.service - OpenBMC ipKVM daemon

Change-Id: I8260a09b074b04c47821758c31ecad5d53eca40c
Signed-off-by: Mohammed Javith Akthar M <mohammedjavitham@ami.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I6e1b877213f3a2921d78ffe2a5fe71d93db65574
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ikvm_manager.cpp: fix a deadlock issue

There is a deadlock in the case that the screen resolution is altered.
The probability of deadlock will increase as the frame rate increases.
The deadlock is l

ikvm_manager.cpp: fix a deadlock issue

There is a deadlock in the case that the screen resolution is altered.
The probability of deadlock will increase as the frame rate increases.
The deadlock is likely to be reproduced when the frame rate is set to
above 30fps. The scenario of deadlock is described as below.

mainThread serverThread
|
setServerDone
|
setVideoDone <----------switch to mainThread <----set serverDone to true
|
waitServer
|
serverDone is set to FALSE
|
screen resolution has been changed
|
videoDone is set to FALSE
|
waitServer(A, wait serverThread to set serverDone to TRUE, \
| block mainthread)
|
----------switch to serverThread-------------------> waitVideo
|
|
(B, wait mainthread to set videoDone to TRUE, block serverThread)

A)The main thread is blocked for waiting serverThread to set serverDone,
at the meantime, B)The serverThread is blocked for waiting main thread
to set videoDone. So a deadlock is generated.

The patch delays to set videoDone to false after the mainThread is
blocked for waiting serverDone, then the value of the videoDone
maintains true. So the serverThread is unblocked as the videoDone is
true. After serverThread finishes executing setServerDone, mainThread
is unblocked and continues executing.

Change-Id: If30d2cd5c493a909397fde43d1cf538cc28f3df2
Signed-off-by: Min Wang <wangmin@phytium.com.cn>

show more ...

meson: Support local build

Add necessary dependencies and subproject files to support local meson
build.

Tested:
"meson setup build && cd build && meson compile" finishes successfully.

Change-Id:

meson: Support local build

Add necessary dependencies and subproject files to support local meson
build.

Tested:
"meson setup build && cd build && meson compile" finishes successfully.

Change-Id: I27a495811e9aa71db5292952ed5bc44a691ec1d6
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I0fa32cad54ece07b45e9abd54754cd262f5dd718
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix some warnings by cppcheck

Warning message:
```
ikvm_manager.hpp:26:5: style: Class 'Manager' has a constructor with
1 argument that is not explicit. [noExplicitConstructor]
Manager(const Arg

Fix some warnings by cppcheck

Warning message:
```
ikvm_manager.hpp:26:5: style: Class 'Manager' has a constructor with
1 argument that is not explicit. [noExplicitConstructor]
Manager(const Args& args);
^
```

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I993565998eebfa7ab7447b05f50ac627c9f41060

show more ...

meson: Replace configure_file with fs.copyfile

configure_file is deprecated since 0.64.0, and replace it with
fs.copyfile.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I152baf9da48e5b

meson: Replace configure_file with fs.copyfile

configure_file is deprecated since 0.64.0, and replace it with
fs.copyfile.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I152baf9da48e5bae8c36710f25b2a932835459ac

show more ...

create_usbhid.sh: update english product string

Current product string value for english locale is configured as
"virtual_input". Updated string value to "Virtual Keyboard and Mouse"
for better read

create_usbhid.sh: update english product string

Current product string value for english locale is configured as
"virtual_input". Updated string value to "Virtual Keyboard and Mouse"
for better readability.

Tested:

1. Verified using AST2600EVB + Ubuntu server 20.04 as BMC host os

2. Launch KVM and execute following command inside host
> sudo evtest /dev/input/event3 | head

3. Observe the "Input device name" field in the command output

Before changes:

Input driver version is 1.0.1
Input device ID: bus 0x3 vendor 0x1d6b product 0x104 version 0x101
Input device name: "OpenBMC virtual_input"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 1 (KEY_ESC)
Event code 2 (KEY_1)
Event code 3 (KEY_2)
Event code 4 (KEY_3)

After changes:

Input driver version is 1.0.1
Input device ID: bus 0x3 vendor 0x1d6b product 0x104 version 0x101
Input device name: "OpenBMC Virtual Keyboard and Mouse"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 1 (KEY_ESC)
Event code 2 (KEY_1)
Event code 3 (KEY_2)
Event code 4 (KEY_3)

Change-Id: If1ea31fb5d7d2d1bac021e05272d7ba2f0f65130
Signed-off-by: Mohammed Javith Akthar M <mohammedjavitham@ami.com>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ia4f5ca309de77d83fdf85

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ia4f5ca309de77d83fdf850cb0682bbdfa75c3590
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I520ea7fb067992065539299a2e5dfa4ff28788ab
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I2c107a339cfda6cc9f1b2fdcd2123f603bce9216
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add V4L2_PIX_FMT_RGB24 pixel format support

This is the format used by the gxp v4l2 driver.

Change-Id: Ia78e39b95f1cdffa2df111d1f1af4cb9c290cc9f
Signed-off-by: charles kearney <charles.kearney@hpe.

Add V4L2_PIX_FMT_RGB24 pixel format support

This is the format used by the gxp v4l2 driver.

Change-Id: Ia78e39b95f1cdffa2df111d1f1af4cb9c290cc9f
Signed-off-by: charles kearney <charles.kearney@hpe.com>

show more ...

Incorrect port id for gadget driver

The portId should be 1e6a0000.usb-vhub.X instead of gadget.Y.

Tested with
1. Connect evb-ast2500 evb to a mother board.
2. Dump the input devices event by evtest

Incorrect port id for gadget driver

The portId should be 1e6a0000.usb-vhub.X instead of gadget.Y.

Tested with
1. Connect evb-ast2500 evb to a mother board.
2. Dump the input devices event by evtest.
3. Establish KVM session on WebUI.
4. Move around the mouse on WebUI.
5. Press keyboard on WebUI.

Mouse:
```
$ sudo evtest /dev/input/event16
Input driver version is 1.0.1
Input device ID: bus 0x3 vendor 0x1d6b product 0x104 version 0x101
Input device name: "OpenBMC virtual_input"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 272 (BTN_LEFT)
Event code 273 (BTN_RIGHT)
Event code 274 (BTN_MIDDLE)
Event type 2 (EV_REL)
Event code 8 (REL_WHEEL)
Event code 11 (REL_WHEEL_HI_RES)
Event type 3 (EV_ABS)
Event code 0 (ABS_X)
Value 16383
Min 0
Max 32767
Event code 1 (ABS_Y)
Value 16383
Min 0
Max 32767
Event type 4 (EV_MSC)
Event code 4 (MSC_SCAN)
Properties:
Testing ... (interrupt to exit)
Event: time 1678869292.665398, type 3 (EV_ABS), code 0 (ABS_X), value
30720
Event: time 1678869292.665398, type 3 (EV_ABS), code 1 (ABS_Y), value 0
Event: time 1678869292.665398, -------------- SYN_REPORT ------------
Event: time 1678869292.683394, type 3 (EV_ABS), code 0 (ABS_X), value
30566
Event: time 1678869292.683394, type 3 (EV_ABS), code 1 (ABS_Y), value
546
Event: time 1678869292.683394, -------------- SYN_REPORT ------------
Event: time 1678869292.699394, type 3 (EV_ABS), code 0 (ABS_X), value
30412
Event: time 1678869292.699394, type 3 (EV_ABS), code 1 (ABS_Y), value
819
Event: time 1678869292.699394, -------------- SYN_REPORT ------------
Event: time 1678869292.716394, type 3 (EV_ABS), code 0 (ABS_X), value
30259
Event: time 1678869292.716394, type 3 (EV_ABS), code 1 (ABS_Y), value
1228
Event: time 1678869292.716394, -------------- SYN_REPORT ------------
Event: time 1678869292.734401, type 3 (EV_ABS), code 0 (ABS_X), value
16383
Event: time 1678869292.734401, type 3 (EV_ABS), code 1 (ABS_Y), value
16383
```

Keyboard:
```
$ sudo evtest /dev/input/event15
Input driver version is 1.0.1
Input device ID: bus 0x3 vendor 0x1d6b product 0x104 version 0x101
Input device name: "OpenBMC virtual_input"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 1 (KEY_ESC)
Event code 2 (KEY_1)
Event code 3 (KEY_2)
Event code 4 (KEY_3)
Event code 5 (KEY_4)
Event code 6 (KEY_5)
Event code 7 (KEY_6)
Event code 8 (KEY_7)
Event code 9 (KEY_8)
Event code 10 (KEY_9)
... skip
Event: time 1678869404.403709, -------------- SYN_REPORT ------------
Event: time 1678869404.566714, type 4 (EV_MSC), code 4 (MSC_SCAN), value
70007
Event: time 1678869404.566714, type 1 (EV_KEY), code 32 (KEY_D), value 1
Event: time 1678869404.566714, -------------- SYN_REPORT ------------
Event: time 1678869404.612705, type 4 (EV_MSC), code 4 (MSC_SCAN), value
70007
Event: time 1678869404.612705, type 1 (EV_KEY), code 32 (KEY_D), value 0
Event: time 1678869404.612705, -------------- SYN_REPORT ------------
Event: time 1678869405.525694, type 4 (EV_MSC), code 4 (MSC_SCAN), value
700e1
Event: time 1678869405.525694, type 1 (EV_KEY), code 42 (KEY_LEFTSHIFT),
value 1
Event: time 1678869405.525694, -------------- SYN_REPORT ------------
Event: time 1678869405.535692, type 4 (EV_MSC), code 4 (MSC_SCAN), value
700e1
Event: time 1678869405.535692, type 1 (EV_KEY), code 42 (KEY_LEFTSHIFT),
value 0
```

Fixes: 20de859 ("Potentially connect udc device incorrectly")
Change-Id: Ia01d767c2f07145ab0abe660ff63f42d5e8974a2
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>

show more ...

whitespace removal suggested by format-code.sh script run on the repository.

Change-Id: Ib54bd222ba3549bcf310a211992c2e35681f8b81
Signed-off-by: charles kearney <charles.kearney@hpe.com>

Potentially connect udc device incorrectly

The fs::directory_iterator doesn't specify the order of enumeration of
folders. The if-condition here doesn't prevent the folder other than
gadget port, e

Potentially connect udc device incorrectly

The fs::directory_iterator doesn't specify the order of enumeration of
folders. The if-condition here doesn't prevent the folder other than
gadget port, e.g. 1e6a0000.usb-vhub:pX, be taken into account, e.g.
power folder. In this case, an exception will be generate internally
in connect(). This patch add another check to make sure the folder is
a gadget port.

Without this patch, occasionally obmc-ikvm shows below message and
failed to enumerate USB-HID gadget devices (mouse and keyboard).
```
[ 101.840770] Error: Driver 'configfs-gadget' is already registered,
aborting...
[ 101.848547] UDC core: obmc_hid: driver registration failed: -16

```

Tested with evb-ast2500 to connect VM, then launch KVM and disconnect
for several times.

Fixes: c11257d864ff ("Connect HID gadget device dynamically")
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
Change-Id: I0cad041d69d580a544e60c79e1c991482ca79819

show more ...

OWNERS: promote Zev to maintainer

Zev is an active reviewer of this repository and seems to have a
good handle on the needs from a user perspective. Suggest promoting
him to maintainer to aid in re

OWNERS: promote Zev to maintainer

Zev is an active reviewer of this repository and seems to have a
good handle on the needs from a user perspective. Suggest promoting
him to maintainer to aid in responsiveness to reviews on this repo.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id00825858f55582d0bb1f72657fe3fcc5b03eed1

show more ...

README: run prettier to reformat

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39dbfbc7fd4b5637c0637a53e4e61ef2840c362d

create_usbhid.sh: fix shellcheck warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I77a763381c9029d13549f0f1f9ea63407158cb76

Fix shellcheck warnings

Fix shellcheck warnings in create_usbhid.sh script.

Tested: HID gadget was connected/disconnected properly even with the
fixed script.

Signed-off-by: Jae Hyun Yoo <quic_jae

Fix shellcheck warnings

Fix shellcheck warnings in create_usbhid.sh script.

Tested: HID gadget was connected/disconnected properly even with the
fixed script.

Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
Change-Id: I78ae45db2f50ef400d72dd92895e67c50d01753e

show more ...

OWNERS: Add myself as a reviewer

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: Ifff6ef1f9214cee727cddae4148513793b920c0b

Add support for specifying UDC that HID gadget will connect to

Currently, HID gadget always connects to the USB virtual hub port
under /sys/bus/platform/devices/1e6a0000.usb-vhub, which only works
o

Add support for specifying UDC that HID gadget will connect to

Currently, HID gadget always connects to the USB virtual hub port
under /sys/bus/platform/devices/1e6a0000.usb-vhub, which only works
on ASPEED platform.

This commit adds support for specifying UDC that HID gadget will
connect to, it could be useful for non-ASPEED platform. Although there
are still some other ASPEED-specific behaviors need to be addressed,
but this commit is the first step for non-ASPEED platform.

Tested:
Specify UDC by '-u' parameter and HID gadget will connect to it. Otherwise,
HID gadget will connect to the USB virtual hub port.

Signed-off-by: Marvin Lin <milkfafa@gmail.com>
Change-Id: Ie24ed9d32cb4f7483e8d4c8b51cc5e1bb5fa94de

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1c8047bbf659e0c49daebccadf23d2a72af7888e

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib651b434bf1b7ace693779f729bbc2dfa7240d0b

build: update to C++20

We are using C++20 in all our repositories now.

Change-Id: I6e9c3a125944033f1be0912ce1885565d716d51c