clang-tidy: Initial commit

Added initial .clang-tidy configuration file with recommended C++ checks
aligned with the OpenBMC-approved checklist. This setup enforces modern
C++ best practices and hel

clang-tidy: Initial commit

Added initial .clang-tidy configuration file with recommended C++ checks
aligned with the OpenBMC-approved checklist. This setup enforces modern
C++ best practices and helps catch common issues early in development.

Change-Id: I49dccc478666f3eb5bc5979bc41985d92b86e66d
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: replace NULL/0 with nullptr

Adopt C++11 nullptr for pointer initialization and null checks,
replacing 0/NULL. Improves readability, avoids implicit integer
conversions, and aligns with c

clang-tidy: replace NULL/0 with nullptr

Adopt C++11 nullptr for pointer initialization and null checks,
replacing 0/NULL. Improves readability, avoids implicit integer
conversions, and aligns with clang-tidy modernize-use-nullptr.
No functional behavior changes.

Change-Id: I83f4434e87f1bf0133057bb3bfeb9a07502d6d32
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: delete default constructor

Default constructor was invalid for class semantics and caused
clang-tidy/Clang diagnostics. Mark the default constructor as
`=delete` to prevent accidental de

clang-tidy: delete default constructor

Default constructor was invalid for class semantics and caused
clang-tidy/Clang diagnostics. Mark the default constructor as
`=delete` to prevent accidental default construction and keep
-Werror builds green. No functional changes.

Fixed below errors (example)
'''
../ikvm_input.hpp:32:12: error: explicitly defaulted copy assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
32 | Input& operator=(const Input&) = default;
| ^
'''

Change-Id: Ic6777c6b3f1820457151a33b176668d7da20ae63
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

ikvm_input.cpp: fix potential segfault issue

Context:
Sometimes we see a segmentation fault (SIGSEGV) inside
std::local_Rb_tree_rotate_left when calling keysDown.insert()
in Input::keyEvent() (ikvm_

ikvm_input.cpp: fix potential segfault issue

Context:
Sometimes we see a segmentation fault (SIGSEGV) inside
std::local_Rb_tree_rotate_left when calling keysDown.insert()
in Input::keyEvent() (ikvm_input.cpp:192). The problem happens
rarely, is hard to reproduce, and occurs when two KVM sessions
send keyboard events at the same time.

Coredump:
Program terminated with signal SIGSEGV, Segmentation fault.
__root=@0x7e9c19b8: 0x75301c08) at /usr/src/debug/gcc-runtime/
13.2.0/libstdc++-v3/src/c++98/tree.cc:138
138 __x->_M_right = __y->_M_left;
[Current thread is 1 (LWP 12227)]
(gdb) bt
__root=@0x7e9c19b8: 0x75301c08) at /usr/src/debug/gcc-runtime/
13.2.0/libstdc++-v3/src/c++98/tree.cc:138
(__insert_left=<optimized out>, __x=__x@entry=0x75100678,
__p=<optimized out>, __header=...)
at /usr/src/debug/gcc-runtime/13.2.0/libstdc++-v3/src/c++98/
tree.cc:278
std::_Select1st<std::pair<int const, int> >, std::less<int>,
std::allocator<std::pair<int const, int> > >::_M_insert_node
(__z=0x75100678, __p=<optimized out>, __x=<optimized out>,
this=0x7e9c19b0) at /usr/include/c++/13.2.0/bits/stl_tree.h:2385
std::_Select1st<std::pair<int const, int> >, std::less<int>,
std::allocator<std::pair<int const, int> > >::_Auto_node::_M_insert (
__p=..., this=<synthetic pointer>) at /usr/include/c++/13.2.0/bits/
stl_tree.h:1657
std::_Select1st<std::pair<int const, int> >, std::less<int>,
std::allocator<std::pair<int const, int> > >::_M_emplace_hint_unique
<std::pair<unsigned int, unsigned int> > (__pos=..., this=0x7e9c19b0)
at /usr/include/c++/13.2.0/bits/stl_tree.h:2465
std::allocator<std::pair<int const, int> > >::emplace_hint
<std::pair<unsigned int, unsigned int> > (__pos=..., this=0x7e9c19b0)
at /usr/include/c++/13.2.0/bits/stl_map.h:640
<int const, int> > >::insert<std::pair<unsigned int, unsigned int> >
(__x=..., this=0x7e9c19b0)
at /usr/include/c++/13.2.0/bits/stl_map.h:860
key=key@entry=65407, cl=cl@entry=0x5ff958) at
/usr/src/debug/obmc-ikvm/1.0+git/ikvm_input.cpp:192
at /usr/src/debug/obmc-ikvm/1.0+git/ikvm_server.cpp:217
at /usr/src/debug/obmc-ikvm/1.0+git/ikvm_manager.cpp:119
(__p=<optimized out>) at /usr/src/debug/gcc-runtime/13.2.0/
libstdc++-v3/src/c++11/thread.cc:104
from debugfs/usr/lib/libc.so.6
Backtrace stopped: previous frame identical to this frame
(corrupt stack?)

Root cause:
Both keysDown (a std::map) and keyboardReport were changed at
the same time by multiple threads from different client sessions,
without any locking. Since std::map isn’t thread-safe, concurrent
insert or erase operations can corrupt its internal RB-tree.

Fix:
Add mutex (keyEventMutex / keyState mutex) guarding all access to
keysDown and keyboardReport inside keyEvent().

Testing:
Tested simultaneous keyboard input from two KVM sessions; no crashes
occurred. Used this fix in normal operation for a long time without
the issue coming back

Change-Id: I1f197e3259299585e7747314e791c5a01c42863c
Signed-off-by: Hariharan Rangasamy <hariharanr@ami.com>

show more ...

Fix KVM support for AST2500 platform

Since commit ad830bb, KVM has stopped working on the AST2500
platform. The issue occurs because the AST2500 is not handled
by the `create_usbhid.sh` script.

Thi

Fix KVM support for AST2500 platform

Since commit ad830bb, KVM has stopped working on the AST2500
platform. The issue occurs because the AST2500 is not handled
by the `create_usbhid.sh` script.

This change adds proper handling for AST2500 in the script.
Added fallback to default devname in case of unsupported SOC.

Fixes: https://github.com/openbmc/obmc-ikvm/issues/14
Introduced-by: https://gerrit.openbmc.org/c/openbmc/obmc-ikvm/+/79771

Change-Id: If79fefa2ad193a848ff1c0a66dff6c97aac9fc0d
Signed-off-by: Hariharan Rangasamy <hariharanr@ami.com>

show more ...

Config vhub dev name by soc family

Configure the vhub dev name according to the soc family
Ast26xx use 1e6a0000.usb-vhub
Ast27xx use 12060000.usb-vhub

Tested:
In ast2700 soc:
```
admin:~# ls -l /de

Config vhub dev name by soc family

Configure the vhub dev name according to the soc family
Ast26xx use 1e6a0000.usb-vhub
Ast27xx use 12060000.usb-vhub

Tested:
In ast2700 soc:
```
admin:~# ls -l /dev | grep hidg
crw------- 1 admin root 236, 0 Jan 1 00:03 hidg0
crw------- 1 admin root 236, 1 Jan 1 00:03 hidg1
```

Change-Id: I4599bce278612a8c286f24cca43686a9de1f3016
Signed-off-by: Xinnan Xie <xiexinnan@bytedance.com>

show more ...

README.md : Update information about using KVM

Updated instructions for using both the BMC web interface and a VNC
client to establish a remote KVM session.

Change-Id: Ia7b551129a42d550215a902f1f63

README.md : Update information about using KVM

Updated instructions for using both the BMC web interface and a VNC
client to establish a remote KVM session.

Change-Id: Ia7b551129a42d550215a902f1f6324775d413327
Signed-off-by: Hariharan Rangasamy <hariharanr@ami.com>

show more ...

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated alias[1]. Move to the non-deprecated /
underscore-separated variant.

[1]: https://github.com/systemd/systemd/commit/4908de44b0a0409f84a7cdc5641b114d6ce8ba03

Change-Id: Ifc86bc78a0bdf2e23734b04d3bf83603729c4cc7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: Iaa079d6913693179299873030b6fc54d9a9c1341
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ib1952502b325c66fe62930554bee4cf9d1550eba
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ib1952502b325c66fe62930554bee4cf9d1550eba
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

OWNERS: Remove Zev

I'm changing jobs and am no longer going to be working on OpenBMC.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I930c0c52239f54024df7ece3e4b93ee39ba792dd

systemd: rename service file to align with repo name

Updated systemd service file as following for better readability
start-ipkvm.service -> obmc-ikvm.service

Testing:

Verified systemd service usi

systemd: rename service file to align with repo name

Updated systemd service file as following for better readability
start-ipkvm.service -> obmc-ikvm.service

Testing:

Verified systemd service using QEMU + AST2600EVB firmware.

Before changes:

root@evb-ast2600:~# systemctl status start-ipkvm
* start-ipkvm.service - OpenBMC ipKVM daemon

After changes:

root@evb-ast2600:~# systemctl status obmc-ikvm
* obmc-ikvm.service - OpenBMC ipKVM daemon

Change-Id: I8260a09b074b04c47821758c31ecad5d53eca40c
Signed-off-by: Mohammed Javith Akthar M <mohammedjavitham@ami.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I6e1b877213f3a2921d78ffe2a5fe71d93db65574
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ikvm_manager.cpp: fix a deadlock issue

There is a deadlock in the case that the screen resolution is altered.
The probability of deadlock will increase as the frame rate increases.
The deadlock is l

ikvm_manager.cpp: fix a deadlock issue

There is a deadlock in the case that the screen resolution is altered.
The probability of deadlock will increase as the frame rate increases.
The deadlock is likely to be reproduced when the frame rate is set to
above 30fps. The scenario of deadlock is described as below.

mainThread serverThread
|
setServerDone
|
setVideoDone <----------switch to mainThread <----set serverDone to true
|
waitServer
|
serverDone is set to FALSE
|
screen resolution has been changed
|
videoDone is set to FALSE
|
waitServer(A, wait serverThread to set serverDone to TRUE, \
| block mainthread)
|
----------switch to serverThread-------------------> waitVideo
|
|
(B, wait mainthread to set videoDone to TRUE, block serverThread)

A)The main thread is blocked for waiting serverThread to set serverDone,
at the meantime, B)The serverThread is blocked for waiting main thread
to set videoDone. So a deadlock is generated.

The patch delays to set videoDone to false after the mainThread is
blocked for waiting serverDone, then the value of the videoDone
maintains true. So the serverThread is unblocked as the videoDone is
true. After serverThread finishes executing setServerDone, mainThread
is unblocked and continues executing.

Change-Id: If30d2cd5c493a909397fde43d1cf538cc28f3df2
Signed-off-by: Min Wang <wangmin@phytium.com.cn>

show more ...

meson: Support local build

Add necessary dependencies and subproject files to support local meson
build.

Tested:
"meson setup build && cd build && meson compile" finishes successfully.

Change-Id:

meson: Support local build

Add necessary dependencies and subproject files to support local meson
build.

Tested:
"meson setup build && cd build && meson compile" finishes successfully.

Change-Id: I27a495811e9aa71db5292952ed5bc44a691ec1d6
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I0fa32cad54ece07b45e9abd54754cd262f5dd718
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix some warnings by cppcheck

Warning message:
```
ikvm_manager.hpp:26:5: style: Class 'Manager' has a constructor with
1 argument that is not explicit. [noExplicitConstructor]
Manager(const Arg

Fix some warnings by cppcheck

Warning message:
```
ikvm_manager.hpp:26:5: style: Class 'Manager' has a constructor with
1 argument that is not explicit. [noExplicitConstructor]
Manager(const Args& args);
^
```

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I993565998eebfa7ab7447b05f50ac627c9f41060

show more ...

meson: Replace configure_file with fs.copyfile

configure_file is deprecated since 0.64.0, and replace it with
fs.copyfile.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I152baf9da48e5b

meson: Replace configure_file with fs.copyfile

configure_file is deprecated since 0.64.0, and replace it with
fs.copyfile.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I152baf9da48e5bae8c36710f25b2a932835459ac

show more ...

create_usbhid.sh: update english product string

Current product string value for english locale is configured as
"virtual_input". Updated string value to "Virtual Keyboard and Mouse"
for better read

create_usbhid.sh: update english product string

Current product string value for english locale is configured as
"virtual_input". Updated string value to "Virtual Keyboard and Mouse"
for better readability.

Tested:

1. Verified using AST2600EVB + Ubuntu server 20.04 as BMC host os

2. Launch KVM and execute following command inside host
> sudo evtest /dev/input/event3 | head

3. Observe the "Input device name" field in the command output

Before changes:

Input driver version is 1.0.1
Input device ID: bus 0x3 vendor 0x1d6b product 0x104 version 0x101
Input device name: "OpenBMC virtual_input"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 1 (KEY_ESC)
Event code 2 (KEY_1)
Event code 3 (KEY_2)
Event code 4 (KEY_3)

After changes:

Input driver version is 1.0.1
Input device ID: bus 0x3 vendor 0x1d6b product 0x104 version 0x101
Input device name: "OpenBMC Virtual Keyboard and Mouse"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 1 (KEY_ESC)
Event code 2 (KEY_1)
Event code 3 (KEY_2)
Event code 4 (KEY_3)

Change-Id: If1ea31fb5d7d2d1bac021e05272d7ba2f0f65130
Signed-off-by: Mohammed Javith Akthar M <mohammedjavitham@ami.com>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ia4f5ca309de77d83fdf85

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ia4f5ca309de77d83fdf850cb0682bbdfa75c3590
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I520ea7fb067992065539299a2e5dfa4ff28788ab
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I2c107a339cfda6cc9f1b2fdcd2123f603bce9216
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add V4L2_PIX_FMT_RGB24 pixel format support

This is the format used by the gxp v4l2 driver.

Change-Id: Ia78e39b95f1cdffa2df111d1f1af4cb9c290cc9f
Signed-off-by: charles kearney <charles.kearney@hpe.

Add V4L2_PIX_FMT_RGB24 pixel format support

This is the format used by the gxp v4l2 driver.

Change-Id: Ia78e39b95f1cdffa2df111d1f1af4cb9c290cc9f
Signed-off-by: charles kearney <charles.kearney@hpe.com>

show more ...

Incorrect port id for gadget driver

The portId should be 1e6a0000.usb-vhub.X instead of gadget.Y.

Tested with
1. Connect evb-ast2500 evb to a mother board.
2. Dump the input devices event by evtest

Incorrect port id for gadget driver

The portId should be 1e6a0000.usb-vhub.X instead of gadget.Y.

Tested with
1. Connect evb-ast2500 evb to a mother board.
2. Dump the input devices event by evtest.
3. Establish KVM session on WebUI.
4. Move around the mouse on WebUI.
5. Press keyboard on WebUI.

Mouse:
```
$ sudo evtest /dev/input/event16
Input driver version is 1.0.1
Input device ID: bus 0x3 vendor 0x1d6b product 0x104 version 0x101
Input device name: "OpenBMC virtual_input"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 272 (BTN_LEFT)
Event code 273 (BTN_RIGHT)
Event code 274 (BTN_MIDDLE)
Event type 2 (EV_REL)
Event code 8 (REL_WHEEL)
Event code 11 (REL_WHEEL_HI_RES)
Event type 3 (EV_ABS)
Event code 0 (ABS_X)
Value 16383
Min 0
Max 32767
Event code 1 (ABS_Y)
Value 16383
Min 0
Max 32767
Event type 4 (EV_MSC)
Event code 4 (MSC_SCAN)
Properties:
Testing ... (interrupt to exit)
Event: time 1678869292.665398, type 3 (EV_ABS), code 0 (ABS_X), value
30720
Event: time 1678869292.665398, type 3 (EV_ABS), code 1 (ABS_Y), value 0
Event: time 1678869292.665398, -------------- SYN_REPORT ------------
Event: time 1678869292.683394, type 3 (EV_ABS), code 0 (ABS_X), value
30566
Event: time 1678869292.683394, type 3 (EV_ABS), code 1 (ABS_Y), value
546
Event: time 1678869292.683394, -------------- SYN_REPORT ------------
Event: time 1678869292.699394, type 3 (EV_ABS), code 0 (ABS_X), value
30412
Event: time 1678869292.699394, type 3 (EV_ABS), code 1 (ABS_Y), value
819
Event: time 1678869292.699394, -------------- SYN_REPORT ------------
Event: time 1678869292.716394, type 3 (EV_ABS), code 0 (ABS_X), value
30259
Event: time 1678869292.716394, type 3 (EV_ABS), code 1 (ABS_Y), value
1228
Event: time 1678869292.716394, -------------- SYN_REPORT ------------
Event: time 1678869292.734401, type 3 (EV_ABS), code 0 (ABS_X), value
16383
Event: time 1678869292.734401, type 3 (EV_ABS), code 1 (ABS_Y), value
16383
```

Keyboard:
```
$ sudo evtest /dev/input/event15
Input driver version is 1.0.1
Input device ID: bus 0x3 vendor 0x1d6b product 0x104 version 0x101
Input device name: "OpenBMC virtual_input"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 1 (KEY_ESC)
Event code 2 (KEY_1)
Event code 3 (KEY_2)
Event code 4 (KEY_3)
Event code 5 (KEY_4)
Event code 6 (KEY_5)
Event code 7 (KEY_6)
Event code 8 (KEY_7)
Event code 9 (KEY_8)
Event code 10 (KEY_9)
... skip
Event: time 1678869404.403709, -------------- SYN_REPORT ------------
Event: time 1678869404.566714, type 4 (EV_MSC), code 4 (MSC_SCAN), value
70007
Event: time 1678869404.566714, type 1 (EV_KEY), code 32 (KEY_D), value 1
Event: time 1678869404.566714, -------------- SYN_REPORT ------------
Event: time 1678869404.612705, type 4 (EV_MSC), code 4 (MSC_SCAN), value
70007
Event: time 1678869404.612705, type 1 (EV_KEY), code 32 (KEY_D), value 0
Event: time 1678869404.612705, -------------- SYN_REPORT ------------
Event: time 1678869405.525694, type 4 (EV_MSC), code 4 (MSC_SCAN), value
700e1
Event: time 1678869405.525694, type 1 (EV_KEY), code 42 (KEY_LEFTSHIFT),
value 1
Event: time 1678869405.525694, -------------- SYN_REPORT ------------
Event: time 1678869405.535692, type 4 (EV_MSC), code 4 (MSC_SCAN), value
700e1
Event: time 1678869405.535692, type 1 (EV_KEY), code 42 (KEY_LEFTSHIFT),
value 0
```

Fixes: 20de859 ("Potentially connect udc device incorrectly")
Change-Id: Ia01d767c2f07145ab0abe660ff63f42d5e8974a2
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>

show more ...

whitespace removal suggested by format-code.sh script run on the repository.

Change-Id: Ib54bd222ba3549bcf310a211992c2e35681f8b81
Signed-off-by: charles kearney <charles.kearney@hpe.com>