service files: Disable tcp and unix forwarding

TCP and unix stream SSH forwarding are not used for obmc-console, so
disable it in dropbear arguments.

Signed-off-by: Matt Johnston <matt@codeconstruc

service files: Disable tcp and unix forwarding

TCP and unix stream SSH forwarding are not used for obmc-console, so
disable it in dropbear arguments.

Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Change-Id: I498f7ee8ee7f91474e02c077f2df1871dcee39ba

show more ...

console-server: Fix tty paths with Linux 6.8+

The sysfs files are found in a different path with newer Linux
versions, so update the vuart config search code.

The relevant linux change is [1].

[1]

console-server: Fix tty paths with Linux 6.8+

The sysfs files are found in a different path with newer Linux
versions, so update the vuart config search code.

The relevant linux change is [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b286f4e87e325b76789f30337c98ba72e00532e2
Change-Id: Iab686d384b20d8e2495ebbc04a1632be85919cb9
Co-authored-by: Jeremy Kerr <jk@codeconstruct.com.au>
Signed-off-by: Eddie James <eajames@linux.ibm.com>

show more ...

console-server: rework error path for realpath(../..) failure

We shouldn't hit this, as no tty paths will be directly under /sys. All
following code will require tty_device_tty_dir to be set, so use

console-server: rework error path for realpath(../..) failure

We shouldn't hit this, as no tty paths will be directly under /sys. All
following code will require tty_device_tty_dir to be set, so use the
exit path without indicating an error.

Change-Id: I3a447d0fed6dda6372fed7a6c7879fad7f04f077
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>

show more ...

console-server: separate search for vuart node from tty setup

Move the code that sets up the tty to before the search for uart type.

Change-Id: Id08bfddd4e7710ba32f41aa10f4ce684b516a232
Signed-off-

console-server: separate search for vuart node from tty setup

Move the code that sets up the tty to before the search for uart type.

Change-Id: Id08bfddd4e7710ba32f41aa10f4ce684b516a232
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>

show more ...

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated alias[1]. Move to the non-deprecated /
underscore-separated variant.

[1]: https://github.com/systemd/systemd/commit/4908de44b0a0409f84a7cdc5641b114d6ce8ba03

Change-Id: I913d49c33da18f146b3b5d2ac47136d173e35b88
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

markdownlint: minor fixes

Change-Id: Id2086624c8727066aeea020c427f535f91fd31ce
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-tidy: format with config-clang-tidy

Reformat the .clang-tidy file for consistency using the
config-clang-tidy tool from openbmc-build-scripts.

Change-Id: I13360da960b37755974de2b7b53b31a646f5

clang-tidy: format with config-clang-tidy

Reformat the .clang-tidy file for consistency using the
config-clang-tidy tool from openbmc-build-scripts.

Change-Id: I13360da960b37755974de2b7b53b31a646f56be2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

console-server: Fix pointer arithmetic in container_of() implementation

Pointer arithmetic is performed in units of the size of the pointed-to
object. Cast to char to ensure that both the pointer ar

console-server: Fix pointer arithmetic in container_of() implementation

Pointer arithmetic is performed in units of the size of the pointed-to
object. Cast to char to ensure that both the pointer arithmetic is
defined, and that subtracting the result of the offsetof() stays
in-bounds.

The issue was detected by clang-tidy:

```
>>> /usr/bin/clang-tidy --use-color -export-fixes .../obmc-console/buildc92dibdo/meson-private/clang-tidy-fix/log-handler.c.m2f5figo.yaml -quiet -p .../obmc-console/buildc92dibdo .../obmc-console/log-handler.c
9557 warnings generated.
../log-handler.c:50:9: error: suspicious usage of 'offsetof(...)' in pointer arithmetic; this scaled value will be scaled again by the '-' operator [bugprone-sizeof-expression,-warnings-as-errors]
50 | return container_of(handler, struct log_handler, handler);
| ^
../console-server.h:272:27: note: expanded from macro 'container_of'
272 | ((type *)((void *)((ptr) - offsetof(type, member))))
| ^ ~~~~~~~~~~~~~~~~~~~~~~
../log-handler.c:50:9: note: '-' in pointer arithmetic internally scales with 'sizeof(struct handler)' == 8
50 | return container_of(handler, struct log_handler, handler);
| ^
../console-server.h:272:27: note: expanded from macro 'container_of'
272 | ((type *)((void *)((ptr) - offsetof(type, member))))
| ^
```

Change-Id: I808428c0a751abeb4409cf28dd5e95588ae5c0e2
Fixes: 1a0e03b4385e ("Split IO handling code into separate handler modules")
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Fix unexpected behavior in client_timeout() error handling

There are 4 places that call client_close(), 3 are in poller callback
function before return _REMOVE. The client_ringbuffer_poll() and
clie

Fix unexpected behavior in client_timeout() error handling

There are 4 places that call client_close(), 3 are in poller callback
function before return _REMOVE. The client_ringbuffer_poll() and
client_poll() both set the client->rbc = NULL or client->poller = NULL
correspondingly to avoid client_close() unregistering the poller within
poller callback. Because calling console_poller_unregister() within the
loop of console-sever.c:call_pollers() will make the loop writing into
freed poller, corrupting the memory and cause unexpected hehavior.

This fix is let the timeout callback follow the same pattern and avoid
calling console_poller_unregister() within call_pollers() loop.

Change-Id: If723a476d4142a42aa62e97ed0d2e2abca5e00c6
Signed-off-by: Dan Zhang <zhdaniel@google.com>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: Ife939931ed265bc3f7eceda84a0e3db3bd1012de
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

config.h: Include stddef.h for size_t

Address the following clang-tidy issue:

```
Error while processing .../obmc-console/config.h.
.../obmc-console/config.h:36:49: error: unknown type name 'size_t

config.h: Include stddef.h for size_t

Address the following clang-tidy issue:

```
Error while processing .../obmc-console/config.h.
.../obmc-console/config.h:36:49: error: unknown type name 'size_t' [clang-diagnostic-error]
36 | int config_parse_bytesize(const char *size_str, size_t *size);
| ^
```

Fixes: 1e04f449b7f0 ("use iniparser dependency for config file parsing")
Change-Id: I22adfc548d1f8837fda8920267a16e93c17c8475
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

obmc-console: fix segfault on missing config

The `obmc-console-client` allow to not specify configuration file for
active session. But at the same time it does not tolerate null pointer
passed as co

obmc-console: fix segfault on missing config

The `obmc-console-client` allow to not specify configuration file for
active session. But at the same time it does not tolerate null pointer
passed as config. This leads to a segmentation fault due to a missing
configuration file.

Fix this small inconvenience.

Added testcase to make sure that obmc-console-client doesn't segfault
when invoked without any arguments.

Output without the fix:
'''
+ /home/dev/obmc-console/build/obmc-console-client
+ grep Connection refused
Segmentation fault (core dumped)
'''

Output with the fix:
'''
+ /home/ninad/dev/1110_ghe/obmc-console/build/obmc-console-client
+ grep Connection refused
+ cleanup
+ cd -
+ rm -rf /tmp/test_console_client_no_args_3245394.DZqk0S
'''

Change-Id: Ia83da8bca30e2be94e00066f20f2cbe2ccba23b6
Tested-by: Ninad Palsule <ninad@linux.ibm.com>
Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
Signed-off-by: Igor Kononenko <i.kononenko.e@gmail.com>

show more ...

log-handler: Set the end of the file as the file size

The file descriptor is lost after system AC cycle.
The log file will grow indefinitely if the log recorded does not exceed
the maximum log size

log-handler: Set the end of the file as the file size

The file descriptor is lost after system AC cycle.
The log file will grow indefinitely if the log recorded does not exceed
the maximum log size after each AC cycle.

Change-Id: If23d68b08817d54731dd6eff8a42e9eb476b6437
Fixes: 46d9ef298f2e ("Do not truncate log files after reboot")
Signed-off-by: Marshall Zhan <marshall.zhan.wiwynn@gmail.com>

show more ...

log-handler: fix console logs

server->n_consoles was not incremented until after console_init.

But the log handler already made use of that value to decide which
filename to use for logging, in the

log-handler: fix console logs

server->n_consoles was not incremented until after console_init.

But the log handler already made use of that value to decide which
filename to use for logging, in the case of config with no sections.

This fix avoids use of server->n_consoles in favor of looking at the
number of sections in the config.

Change-Id: Ic19802808197557cd1f632c63a0123604a619039
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I2f8eeee40b0b2583092d351979dd77fd277a97ba
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

docs/mux-support.md: Fix MD014 warnings

The following warnings are generated by using markdownlint analysis:
```
MD014/commands-show-output Dollar signs used before commands without showing output [

docs/mux-support.md: Fix MD014 warnings

The following warnings are generated by using markdownlint analysis:
```
MD014/commands-show-output Dollar signs used before commands without showing output [Context: "$ obmc-console-server --config..."]
```
Refer to markdown-lint [1] to fix MD014
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/014-commands-show-output.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9daa0403355e45bf39410ccf92693bdccf1830c4

show more ...

docs/mux-support.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Conte

docs/mux-support.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I67875268370268715241c0ddb2c58da4a9a3f54f

show more ...

test: multiple consoles

Change-Id: Ib7e63eb9b5a9c000ad7548115e46517b8b0bfc92
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.

test: multiple consoles

Change-Id: Ib7e63eb9b5a9c000ad7548115e46517b8b0bfc92
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

test: console socket write

Change-Id: I77ba9168f5b363f7e776d54eb143a716544b5bb5
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.c

test: console socket write

Change-Id: I77ba9168f5b363f7e776d54eb143a716544b5bb5
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

test: console socket read

Change-Id: Ic7c2035640db4e403afe9db01a33ccb532d195d6
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.co

test: console socket read

Change-Id: Ic7c2035640db4e403afe9db01a33ccb532d195d6
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

test: console-client can write

Change-Id: Iffc38fb78ebbf79f8a0bdd7cd0b8cbc5916768cc
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstru

test: console-client can write

Change-Id: Iffc38fb78ebbf79f8a0bdd7cd0b8cbc5916768cc
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

test: console-client can read

Change-Id: I08c7523af548968c1545189c0007f44144589aec
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruc

test: console-client can read

Change-Id: I08c7523af548968c1545189c0007f44144589aec
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

test: console logs to file

Test for the logging feature of obmc-console-server.

Change-Id: I9836727a944a0351962133baa2fd2ff5eb60e67f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Sign

test: console logs to file

Test for the logging feature of obmc-console-server.

Change-Id: I9836727a944a0351962133baa2fd2ff5eb60e67f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

changelog: List UART mux support and iniparser dependency

UART mux support is a notable feature. Make sure users can be aware
of it.

Change-Id: I26ae052f5b64d4eaaea1f814bfddf9632739f2c7
Signed-off-

changelog: List UART mux support and iniparser dependency

UART mux support is a notable feature. Make sure users can be aware
of it.

Change-Id: I26ae052f5b64d4eaaea1f814bfddf9632739f2c7
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

docs/mux-support.md: README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/mux-support.md:1 MD041/first-line-heading/first-line-h1 First line in

docs/mux-support.md: README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/mux-support.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Mux Support"]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Id2dc44fd63b40492a67965c4a51aceeb67b9307d

show more ...