Revision tags: v5.15.10, v5.15.9, v5.15.8, v5.15.7, v5.15.6, v5.15.5, v5.15.4, v5.15.3, v5.15.2, v5.15.1, v5.15, v5.14.14, v5.14.13, v5.14.12, v5.14.11, v5.14.10, v5.14.9, v5.14.8, v5.14.7, v5.14.6, v5.10.67, v5.10.66, v5.14.5, v5.14.4, v5.10.65, v5.14.3, v5.10.64, v5.14.2, v5.10.63, v5.14.1, v5.10.62, v5.14, v5.10.61, v5.10.60, v5.10.53, v5.10.52, v5.10.51, v5.10.50, v5.10.49, v5.13, v5.10.46, v5.10.43, v5.10.42, v5.10.41, v5.10.40, v5.10.39, v5.4.119, v5.10.36, v5.10.35, v5.10.34, v5.4.116, v5.10.33, v5.12, v5.10.32, v5.10.31, v5.10.30, v5.10.27, v5.10.26, v5.10.25, v5.10.24, v5.10.23, v5.10.22, v5.10.21, v5.10.20, v5.10.19, v5.4.101, v5.10.18, v5.10.17, v5.11, v5.10.16, v5.10.15, v5.10.14, v5.10, v5.8.17, v5.8.16, v5.8.15, v5.9, v5.8.14, v5.8.13, v5.8.12, v5.8.11, v5.8.10, v5.8.9, v5.8.8, v5.8.7, v5.8.6, v5.4.62 |
|
#
a0fce283 |
| 29-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove Y, M, N columns
There are so many ways to toggle bool / tristate options.
I do not know how useful these columns are.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
|
#
62ed1656 |
| 29-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove ConfigView class
Now that ConfigView only contains ConfigList, we can remove ConfigView and just use ConfigList.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
|
#
7930dd91 |
| 29-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: move setShowName/Range() to ConfigList from ConfigView
ConfigView::setShowName/Range() only get access to the 'list' member.
Move them to the more relevant ConfigList class.
Signed
kconfig: qconf: move setShowName/Range() to ConfigList from ConfigView
ConfigView::setShowName/Range() only get access to the 'list' member.
Move them to the more relevant ConfigList class.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
f3eea294 |
| 29-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove ConfigLineEdit class
Now that "int", "hex", "string" menus are edited in-place, this class is no longer needed.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
|
#
37162a68 |
| 29-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: allow to edit "int", "hex", "string" menus in-place
Previously, when you double-clicked the "int", "hex", or "string" menus, a line-edit gadget showed up to allow you to input the va
kconfig: qconf: allow to edit "int", "hex", "string" menus in-place
Previously, when you double-clicked the "int", "hex", or "string" menus, a line-edit gadget showed up to allow you to input the value, which looked clumsy.
Also, it was buggy; the editor opened even if the config option was not editable. For example, just try to double-click CC_VERSION_TEXT, which has no prompt.
This commit sub-classes QStyleItemDelegate to allow users to edit "int", "hex", "string" menus in-place. Just double-click (or press the F2 key) in the data column. Then, an editor widget is placed on top of the item view.
The two methods are overridden:
createEditor - process only when the data column is being accessed and the menu is visible. Otherwise, return nullptr to disallow editing.
setModelData - take the new data from the editor, and set it to the addressed symbol. If it was successful, update all the list windows. Otherwise, (the reason for the failure is possibly the input data was out of range), set the old value back to the editor.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
669a1ee4 |
| 29-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: show data column all the time
The next commit will allow users to edit "int", "hex", "string" menus in-place from the data column.
The data column should be always displayed.
Signe
kconfig: qconf: show data column all the time
The next commit will allow users to edit "int", "hex", "string" menus in-place from the data column.
The data column should be always displayed.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
f9b918fa |
| 29-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: move ConfigView::updateList(All) to ConfigList class
ConfigView::updateList() iterates over all views, and then calls updateList() against for its ConfigList instance.
This means th
kconfig: qconf: move ConfigView::updateList(All) to ConfigList class
ConfigView::updateList() iterates over all views, and then calls updateList() against for its ConfigList instance.
This means there is no point to implement it in the ConfigView class.
Move and rename as follows:
ConfigView::updateList() -> ConfigList::updateListForAll() ConfigView::updateListAll() -> ConfigList::updateListAllForAll()
I used QList to contain all ConfigList instances.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
6a143041 |
| 29-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove unused ConfigItem::okRename()
Commit 76538660fb08 ("Port xconfig to Qt5 - Remove custom ListView classes.") removed the original implementation, where ConfigItem::okRename() o
kconfig: qconf: remove unused ConfigItem::okRename()
Commit 76538660fb08 ("Port xconfig to Qt5 - Remove custom ListView classes.") removed the original implementation, where ConfigItem::okRename() overrode Q3ListViewItem::okRename().
Commit 59e564408f88 ("Port xconfig to Qt5 - Put back some of the old implementation.") restored the empty stub, but it seems useless.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
Revision tags: v5.8.5, v5.8.4, v5.4.61, v5.8.3, v5.4.60, v5.8.2, v5.4.59 |
|
#
66c262be |
| 17-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove unused colNr
This is not used at all.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
|
#
7d1300e6 |
| 17-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: fix the popup menu in the ConfigInfoView window
I do not know when ConfigInfoView::createStandardContextMenu() is called.
Because QTextEdit::createStandardContextMenu() is not virtu
kconfig: qconf: fix the popup menu in the ConfigInfoView window
I do not know when ConfigInfoView::createStandardContextMenu() is called.
Because QTextEdit::createStandardContextMenu() is not virtual, ConfigInfoView::createStandardContextMenu() cannot override it. Even if right-click the ConfigInfoView window, the "Show Debug Info" menu does not show up.
Build up the menu in the constructor, and invoke it from the contextMenuEvent().
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
Revision tags: v5.8.1, v5.4.58 |
|
#
d4bbe8a1 |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: move setOptionMode() to ConfigList from ConfigView
ConfigView::setOptionMode() only gets access to the 'list' member.
Move it to the more relevant ConfigList class.
Signed-off-by:
kconfig: qconf: move setOptionMode() to ConfigList from ConfigView
ConfigView::setOptionMode() only gets access to the 'list' member.
Move it to the more relevant ConfigList class.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
5cb255ff |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: refactor icon setups
These icon data are used by ConfigItem, but stored in each instance of ConfigView. There is no point to keep the same data in each of 3 instances, "menu", "confi
kconfig: qconf: refactor icon setups
These icon data are used by ConfigItem, but stored in each instance of ConfigView. There is no point to keep the same data in each of 3 instances, "menu", "config", and "search".
Move the icon data to the more relevant ConfigItem class, and make them static members.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
4fa91f52 |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove unused voidPix, menuInvPix
These are initialized, but not used by anyone.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
|
#
5ca534cd |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove ConfigItem::text/setText
Use QTreeWidgetItem::text/setText directly
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
|
#
abf741a9 |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove ConfigList::addColumn/removeColumn
Use QTreeView::showColumn/hideColumn directly.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
|
#
711b875b |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove ConfigItem::pixmap/setPixmap
Use QTreeWidgetItem::icon/setIcon directly.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
|
#
5b75a6c8 |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove 'parent' from ConfigList::updateMenuList()
All the call-sites of this function pass 'this' to the first argument.
So, 'parent' is always the 'this' pointer.
Signed-off-by: M
kconfig: qconf: remove 'parent' from ConfigList::updateMenuList()
All the call-sites of this function pass 'this' to the first argument.
So, 'parent' is always the 'this' pointer.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
1031685c |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove unused argument from ConfigView::updateList()
Now that ConfigList::updateList() takes no argument, the 'item' argument ConfigView::updateList() is no longer used.
Signed-off-
kconfig: qconf: remove unused argument from ConfigView::updateList()
Now that ConfigList::updateList() takes no argument, the 'item' argument ConfigView::updateList() is no longer used.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
cb77043f |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove unused argument from ConfigList::updateList()
This function allocates 'item' before using it, so the argument 'item' is always shadowed.
Remove the meaningless argument.
Sig
kconfig: qconf: remove unused argument from ConfigList::updateList()
This function allocates 'item' before using it, so the argument 'item' is always shadowed.
Remove the meaningless argument.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
740fdef8 |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove name from ConfigSearchWindow constructor
This constructor is only called with "search" as the second argument.
Hard-code the name in the constructor, and drop it from the fun
kconfig: qconf: remove name from ConfigSearchWindow constructor
This constructor is only called with "search" as the second argument.
Hard-code the name in the constructor, and drop it from the function argument.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
1b4263e7 |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove unused ConfigList::listView()
I do not know how this function can be useful. In fact, it is unsed.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
|
#
2afb3e26 |
| 07-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove toolBar from ConfigMainWindow members
This pointer is only used in the ConfigMainWindow constructor.
Drop it from the private members.
Signed-off-by: Masahiro Yamada <masahi
kconfig: qconf: remove toolBar from ConfigMainWindow members
This pointer is only used in the ConfigMainWindow constructor.
Drop it from the private members.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
Revision tags: v5.4.57, v5.4.56, v5.8 |
|
#
ccf56e5f |
| 01-Aug-2020 |
Masahiro Yamada <masahiroy@kernel.org> |
kconfig: qconf: remove wrong ConfigList::firstChild()
This function returns the first child object, but the returned pointer is not compatible with (ConfigItem *).
Commit cc1c08edccaf ("kconfig: qc
kconfig: qconf: remove wrong ConfigList::firstChild()
This function returns the first child object, but the returned pointer is not compatible with (ConfigItem *).
Commit cc1c08edccaf ("kconfig: qconf: don't show goback button on splitMode") uncovered this issue because using the pointer from this function would make qconf crash. (https://lkml.org/lkml/2020/7/18/411)
This function does not work. Remove.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
Revision tags: v5.7.12, v5.4.55, v5.7.11, v5.4.54, v5.7.10, v5.4.53, v5.4.52, v5.7.9, v5.7.8, v5.4.51, v5.4.50, v5.7.7 |
|
#
b06c3ec3 |
| 30-Jun-2020 |
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
kconfig: qconf: re-implement setSelected()
The default implementation for setSelected() at QTreeWidgetItem allows multiple items to be selected.
Well, this should never be possible for the configIt
kconfig: qconf: re-implement setSelected()
The default implementation for setSelected() at QTreeWidgetItem allows multiple items to be selected.
Well, this should never be possible for the configItem lists.
So, implement a function that will automatically clean any previous selection. This simplifies the logic somewhat, while making the selection logic to be applied atomically, avoiding future issues on that.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|
#
c4f7398b |
| 30-Jun-2020 |
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
kconfig: qconf: make debug links work again
The Qt5 conversion broke support for debug info links.
Restore the behaviour added by changeset ab45d190fd4a ("kconfig: create links in info window").
T
kconfig: qconf: make debug links work again
The Qt5 conversion broke support for debug info links.
Restore the behaviour added by changeset ab45d190fd4a ("kconfig: create links in info window").
The original approach was to pass a pointer for a data struct via an <a href>. That doesn't sound a good idea, as, if something gets wrong, the app could crash. So, instead, pass the name of the symbol, and validate such symbol at the hyperlink handling logic.
Link: https://lore.kernel.org/lkml/20200628125421.12458086@coco.lan/ Reported-by: Maxim Levitsky <mlevitsk@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
show more ...
|