staging: rtl8723bs: Use helpers to check broadcast and multicast Ether addresses

Use is_multicast_ether_addr() and is_broadcast_ether_addr()
instead of custom macro IS_MCAST() and MacAddr_isBcst(),

staging: rtl8723bs: Use helpers to check broadcast and multicast Ether addresses

Use is_multicast_ether_addr() and is_broadcast_ether_addr()
instead of custom macro IS_MCAST() and MacAddr_isBcst(), the buffer
is properly aligned.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230814105623.292541-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove rf type branching (second patch)

remove RFType field in dm_odm_t struct, keep unconditioned
all code branches related to 1T1R path, delete the others.

Remove unused varia

staging: rtl8723bs: remove rf type branching (second patch)

remove RFType field in dm_odm_t struct, keep unconditioned
all code branches related to 1T1R path, delete the others.

Remove unused variable to silence gcc warning.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/fd41fbfba16df2b93a7593c1f853a874255e945c.1628329348.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove unused struct member

remove unused bIsMPChip struct member and all code
storing it.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/ad

staging: rtl8723bs: remove unused struct member

remove unused bIsMPChip struct member and all code
storing it.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/ad7831868683a99598cd00a3aacc45f76ba234e8.1628329348.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: clean driver from unused RF paths

rtl8723bs support only two rf paths (A and B), remove all
the others (C, D, BC, ...) as they are unused. Keep
just one enum selecting rf path, r

staging: rtl8723bs: clean driver from unused RF paths

rtl8723bs support only two rf paths (A and B), remove all
the others (C, D, BC, ...) as they are unused. Keep
just one enum selecting rf path, remove unused macro
indicating max rf path number, add an item in rf_path
enum for this pourpose.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/23060c85ab9aa468c9c021378f0dc8a8f887a578.1628329348.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove unused macros

remove unused macros detected by -Wunused-macros
gcc option.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/20210801134

staging: rtl8723bs: remove unused macros

remove unused macros detected by -Wunused-macros
gcc option.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/20210801134629.23433-1-fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove unused ODM_CMNINFO_BOARD_TYPE enum item

remove ODM_CMNINFO_BOARD_TYPE enum item, fix comments
accordingly (given that 5GHz code isn't supported).

Acked-by: Hans de Goede

staging: rtl8723bs: remove unused ODM_CMNINFO_BOARD_TYPE enum item

remove ODM_CMNINFO_BOARD_TYPE enum item, fix comments
accordingly (given that 5GHz code isn't supported).

Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/e3adfc218779c9c1ea904e806f77fc5007be180f.1624367072.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove 5Ghz code related to RF power calibration

remove 5Ghz code related to RF calibration. Remove
table arrays, variables and macros related to RF power
tracking.

Acked-by: Ha

staging: rtl8723bs: remove 5Ghz code related to RF power calibration

remove 5Ghz code related to RF calibration. Remove
table arrays, variables and macros related to RF power
tracking.

Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/f2096f71ae80f0cb7805a0e48536babc9809a3de.1624367072.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove all branchings between 2.4Ghz and 5Ghz band types

remove all code branchings tied to dual band support. The device
works only on 2.4Ghz band so there's no need to check wh

staging: rtl8723bs: remove all branchings between 2.4Ghz and 5Ghz band types

remove all code branchings tied to dual band support. The device
works only on 2.4Ghz band so there's no need to check which
band we are on. Removed all code branches that would be valid
only for 5Ghz for it's dead code. Removed enums, table fields
indexing by band type, function arguments passing current
band type and all other thing related to telling us
which band we are on.

Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/72bb27f6a7b3be607f93f5b406d863dd08376986.1624367071.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove all 5Ghz network types

remove all 5Ghz network types. rtl8723bs works on
802.11bgn standards and on 2.4Ghz band.

So remove all code related to 802.11a and 802.11ac
standa

staging: rtl8723bs: remove all 5Ghz network types

remove all 5Ghz network types. rtl8723bs works on
802.11bgn standards and on 2.4Ghz band.

So remove all code related to 802.11a and 802.11ac
standards, which the device doesn't support.

Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/7e4644a71d0ba2819370171b3dc78bfc755f6313.1624367071.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove DebugLevel member in dm_odm_t struct

remove DebugLevel in dm_odm_t struct,
remove private debug level tracing.

remove unused variable as well to suppress compiler warning

staging: rtl8723bs: remove DebugLevel member in dm_odm_t struct

remove DebugLevel in dm_odm_t struct,
remove private debug level tracing.

remove unused variable as well to suppress compiler warning.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/ac4afb00f904511e0cbb23136f8e7a3e204ad7ed.1619794331.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove member in dm_odm_t struct

remove DebugComponent in dm_odm_t struct,
remove private debug component tracing.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-o

staging: rtl8723bs: remove member in dm_odm_t struct

remove DebugComponent in dm_odm_t struct,
remove private debug component tracing.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/313d08514d2105c826ef3c92555fa557def2b9c2.1619794331.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove ODM_InitDebugSetting() function

remove ODM_InitDebugSetting() function. It was
intended to initialize removed private debug
system. So remove it.

Reviewed-by: Dan Carpent

staging: rtl8723bs: remove ODM_InitDebugSetting() function

remove ODM_InitDebugSetting() function. It was
intended to initialize removed private debug
system. So remove it.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/6a8524b780674d05f33977eb86878d95c7338a1a.1619794331.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: replace ODM_RT_ASSERT with netdev_dbg()

replace ODM_RT_ASSERT with netdev dbg.

Marco ODM_RT_ASSERT wraps a raw prink and prints a message
everytime second argument is false. Thi

staging: rtl8723bs: replace ODM_RT_ASSERT with netdev_dbg()

replace ODM_RT_ASSERT with netdev dbg.

Marco ODM_RT_ASSERT wraps a raw prink and prints a message
everytime second argument is false. This occurrence prints
always, so replace it with netdev_dbg()

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/3f172aaefb84aaac639f1850c5eb45678578e393.1619794331.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove all commented out ODM_RT_TRACE logs

remove all commented out ODM_RT_TRACE logs.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiu

staging: rtl8723bs: remove all commented out ODM_RT_TRACE logs

remove all commented out ODM_RT_TRACE logs.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/a98ce6637bb15de79997325a78672fc81c48cd6a.1619794331.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove empty functions

remove functions left empty after ODM_RT_TRACE deletion.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gm

staging: rtl8723bs: remove empty functions

remove functions left empty after ODM_RT_TRACE deletion.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/2a0606394fec2cbb32df6ec0bf4b5974416195f6.1619794331.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove ODM_RT_TRACE logs

remove all ODM_RT_TRACE logs.

ODM_RT_TRACE macro default behaviour
is _trace nothing_. To enable it a hand code
edit is needed in hal/odm_debug.c.
So ju

staging: rtl8723bs: remove ODM_RT_TRACE logs

remove all ODM_RT_TRACE logs.

ODM_RT_TRACE macro default behaviour
is _trace nothing_. To enable it a hand code
edit is needed in hal/odm_debug.c.
So just remove it.

Applied the semantic patch:

@@
@@

- ODM_RT_TRACE(...);

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/23e21c100ba4f0753c6f03a1bb28d9bd7729b64b.1619794331.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove all commented out DBG_8192C logs

remove all commented out DBG_8192C logs.

Macro DBG_8192C belongs to a family of verbose
private tracing macros.

The default behaviour is

staging: rtl8723bs: remove all commented out DBG_8192C logs

remove all commented out DBG_8192C logs.

Macro DBG_8192C belongs to a family of verbose
private tracing macros.

The default behaviour is _do nothing_, to activate
it one should define DEBUG symbol by hand.

So just remove it

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/d954fbde0ae689cd053a57f57f954f14b5d013cb.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove commented out MSG_8192C log

remove commented out MSG_8192C log.

MSG_8192C is a private trace mechanism macro and is deactivated.
(i.e. the default behaviour is _do nothin

staging: rtl8723bs: remove commented out MSG_8192C log

remove commented out MSG_8192C log.

MSG_8192C is a private trace mechanism macro and is deactivated.
(i.e. the default behaviour is _do nothing_)
The only way to activate it is to manually define a debug
symbol.

So just remove it.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/845969563d7c90d1b7aa3215ae29dd91afc5100c.1617971592.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove commented out DBG_871X logs

remove all commented out DBG_871X logs unmatched by
semantic patch.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.ker

staging: rtl8723bs: remove commented out DBG_871X logs

remove all commented out DBG_871X logs unmatched by
semantic patch.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/125e216e3bb5bc938e06b15dadfbbf51d9517dde.1617802415.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove function prototypes in hal/odm.c

fix the following checkpatch issues:

WARNING: externs should be avoided in .c files
285: FILE: drivers/staging/rtl8723bs/hal/odm.c:285:
+

staging: rtl8723bs: remove function prototypes in hal/odm.c

fix the following checkpatch issues:

WARNING: externs should be avoided in .c files
285: FILE: drivers/staging/rtl8723bs/hal/odm.c:285:
+void odm_CommonInfoSelfInit(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
287: FILE: drivers/staging/rtl8723bs/hal/odm.c:287:
+void odm_CommonInfoSelfUpdate(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
289: FILE: drivers/staging/rtl8723bs/hal/odm.c:289:
+void odm_CmnInfoInit_Debug(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
291: FILE: drivers/staging/rtl8723bs/hal/odm.c:291:
+void odm_BasicDbgMessage(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
305: FILE: drivers/staging/rtl8723bs/hal/odm.c:305:
+void odm_RefreshRateAdaptiveMaskCE(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
309: FILE: drivers/staging/rtl8723bs/hal/odm.c:309:
+void odm_RSSIMonitorInit(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
311: FILE: drivers/staging/rtl8723bs/hal/odm.c:311:
+void odm_RSSIMonitorCheckCE(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
313: FILE: drivers/staging/rtl8723bs/hal/odm.c:313:
+void odm_RSSIMonitorCheck(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
315: FILE: drivers/staging/rtl8723bs/hal/odm.c:315:
+void odm_SwAntDetectInit(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
317: FILE: drivers/staging/rtl8723bs/hal/odm.c:317:
+void odm_SwAntDivChkAntSwitchCallback(void *FunctionContext);
--
WARNING: externs should be avoided in .c files
321: FILE: drivers/staging/rtl8723bs/hal/odm.c:321:
+void odm_GlobalAdapterCheck(void);
--
WARNING: externs should be avoided in .c files
323: FILE: drivers/staging/rtl8723bs/hal/odm.c:323:
+void odm_RefreshRateAdaptiveMask(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
325: FILE: drivers/staging/rtl8723bs/hal/odm.c:325:
+void ODM_TXPowerTrackingCheck(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
327: FILE: drivers/staging/rtl8723bs/hal/odm.c:327:
+void odm_RateAdaptiveMaskInit(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
330: FILE: drivers/staging/rtl8723bs/hal/odm.c:330:
+void odm_TXPowerTrackingInit(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
338: FILE: drivers/staging/rtl8723bs/hal/odm.c:338:
+void odm_InitHybridAntDiv(struct dm_odm_t *pDM_Odm);
--
WARNING: externs should be avoided in .c files
340: FILE: drivers/staging/rtl8723bs/hal/odm.c:340:
+bool odm_StaDefAntSel(
--
WARNING: externs should be avoided in .c files
349: FILE: drivers/staging/rtl8723bs/hal/odm.c:349:
+void odm_SetRxIdleAnt(struct dm_odm_t *pDM_Odm, u8 Ant, bool bDualPath);
--
WARNING: externs should be avoided in .c files
353: FILE: drivers/staging/rtl8723bs/hal/odm.c:353:
+void odm_HwAntDiv(struct dm_odm_t *pDM_Odm);

removed function prototypes and made staics where needed
in hal/odm.c

moved function definition in file to let the compiler work

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/9a92a2f29c2c9fb3c386a3c1d0d25f628845c563.1616503354.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove unnecessary logging in hal/odm.c

fix the following checkpatch.pl issues:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
1109: FILE: drivers/staging/rtl872

staging: rtl8723bs: remove unnecessary logging in hal/odm.c

fix the following checkpatch.pl issues:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
1109: FILE: drivers/staging/rtl8723bs/hal/odm.c:1109:
+ /* printk("==> %s\n", __func__); */

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/20210318152610.16758-9-fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

Staging: rtl8723bs: fix names in odm.h

This commit converts names of structs / enums
in hal/odm.h from ALL_CAPS format to lowercase

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https:/

Staging: rtl8723bs: fix names in odm.h

This commit converts names of structs / enums
in hal/odm.h from ALL_CAPS format to lowercase

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210317222130.29528-41-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

Staging: rtl8723bs: fix names in odm_DIG.h

This commit converts names of structs / enums
in hal/odm_DIG.h from ALL_CAPS format to lowercase

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link:

Staging: rtl8723bs: fix names in odm_DIG.h

This commit converts names of structs / enums
in hal/odm_DIG.h from ALL_CAPS format to lowercase

Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210317222130.29528-37-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

Staging: rtl8723bs: fix spaces in odm.c

This commit fixes the following checkpatch.pl errors:

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#285: FILE: ./hal/odm.c:285:
+void

Staging: rtl8723bs: fix spaces in odm.c

This commit fixes the following checkpatch.pl errors:

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#285: FILE: ./hal/odm.c:285:
+void odm_CommonInfoSelfInit(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#287: FILE: ./hal/odm.c:287:
+void odm_CommonInfoSelfUpdate(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#289: FILE: ./hal/odm.c:289:
+void odm_CmnInfoInit_Debug(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#291: FILE: ./hal/odm.c:291:
+void odm_BasicDbgMessage(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#305: FILE: ./hal/odm.c:305:
+void odm_RefreshRateAdaptiveMaskCE(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#309: FILE: ./hal/odm.c:309:
+void odm_RSSIMonitorInit(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#311: FILE: ./hal/odm.c:311:
+void odm_RSSIMonitorCheckCE(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#313: FILE: ./hal/odm.c:313:
+void odm_RSSIMonitorCheck(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#315: FILE: ./hal/odm.c:315:
+void odm_SwAntDetectInit(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#323: FILE: ./hal/odm.c:323:
+void odm_RefreshRateAdaptiveMask(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#325: FILE: ./hal/odm.c:325:
+void ODM_TXPowerTrackingCheck(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#327: FILE: ./hal/odm.c:327:
+void odm_RateAdaptiveMaskInit(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#330: FILE: ./hal/odm.c:330:
+void odm_TXPowerTrackingInit(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#338: FILE: ./hal/odm.c:338:
+void odm_InitHybridAntDiv(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#341: FILE: ./hal/odm.c:341:
+ struct DM_ODM_T * pDM_Odm,

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#349: FILE: ./hal/odm.c:349:
+void odm_SetRxIdleAnt(struct DM_ODM_T * pDM_Odm, u8 Ant, bool bDualPath);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#353: FILE: ./hal/odm.c:353:
+void odm_HwAntDiv(struct DM_ODM_T * pDM_Odm);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#363: FILE: ./hal/odm.c:363:
+void ODM_DMInit(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#393: FILE: ./hal/odm.c:393:
+void ODM_DMWatchdog(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#420: FILE: ./hal/odm.c:420:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#448: FILE: ./hal/odm.c:448:
+void ODM_CmnInfoInit(struct DM_ODM_T * pDM_Odm, enum ODM_CMNINFO_E CmnInfo, u32 Value)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#560: FILE: ./hal/odm.c:560:
+void ODM_CmnInfoHook(struct DM_ODM_T * pDM_Odm, enum ODM_CMNINFO_E CmnInfo, void *pValue)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#689: FILE: ./hal/odm.c:689:
+ struct DM_ODM_T * pDM_Odm,

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#717: FILE: ./hal/odm.c:717:
+void ODM_CmnInfoUpdate(struct DM_ODM_T * pDM_Odm, u32 CmnInfo, u64 Value)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#831: FILE: ./hal/odm.c:831:
+void odm_CommonInfoSelfInit(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#841: FILE: ./hal/odm.c:841:
+void odm_CommonInfoSelfUpdate(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#867: FILE: ./hal/odm.c:867:
+void odm_CmnInfoInit_Debug(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#888: FILE: ./hal/odm.c:888:
+void odm_BasicDbgMessage(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#935: FILE: ./hal/odm.c:935:
+void odm_RateAdaptiveMaskInit(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#937: FILE: ./hal/odm.c:937:
+ struct ODM_RATE_ADAPTIVE * pOdmRA = &pDM_Odm->RateAdaptive;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#953: FILE: ./hal/odm.c:953:
+ struct DM_ODM_T * pDM_Odm,

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1083: FILE: ./hal/odm.c:1083:
+void odm_RefreshRateAdaptiveMask(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1094: FILE: ./hal/odm.c:1094:
+void odm_RefreshRateAdaptiveMaskCE(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1131: FILE: ./hal/odm.c:1131:
+ struct DM_ODM_T * pDM_Odm,

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1137: FILE: ./hal/odm.c:1137:
+ struct ODM_RATE_ADAPTIVE * pRA = &pDM_Odm->RateAdaptive;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1196: FILE: ./hal/odm.c:1196:
+void odm_RSSIMonitorInit(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1198: FILE: ./hal/odm.c:1198:
+ struct RA_T * pRA_Table = &pDM_Odm->DM_RA_Table;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1204: FILE: ./hal/odm.c:1204:
+void odm_RSSIMonitorCheck(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1217: FILE: ./hal/odm.c:1217:
+ struct DM_ODM_T * pDM_Odm = &(pHalData->odmpriv);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1234: FILE: ./hal/odm.c:1234:
+void odm_RSSIMonitorCheckCE(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1243: FILE: ./hal/odm.c:1243:
+ struct RA_T * pRA_Table = &pDM_Odm->DM_RA_Table;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1306: FILE: ./hal/odm.c:1306:
+static u8 getSwingIndex(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1330: FILE: ./hal/odm.c:1330:
+void odm_TXPowerTrackingInit(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1374: FILE: ./hal/odm.c:1374:
+void ODM_TXPowerTrackingCheck(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1398: FILE: ./hal/odm.c:1398:
+void odm_SwAntDetectInit(struct DM_ODM_T * pDM_Odm)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1400: FILE: ./hal/odm.c:1400:
+ struct SWAT_T * pDM_SWAT_Table = &pDM_Odm->DM_SWAT_Table;

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210315170618.2566-21-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...

staging: rtl8723bs: remove typedefs in odm_DIG.h

This commit fixes the following checkpatch.pl warnings:

WARNING: do not add new typedefs
#11: FILE: hal/odm_DIG.h:11:
+typedef struct _D

staging: rtl8723bs: remove typedefs in odm_DIG.h

This commit fixes the following checkpatch.pl warnings:

WARNING: do not add new typedefs
#11: FILE: hal/odm_DIG.h:11:
+typedef struct _Dynamic_Initial_Gain_Threshold_ {

WARNING: do not add new typedefs
#62: FILE: hal/odm_DIG.h:62:
+typedef struct false_ALARM_STATISTICS {

WARNING: do not add new typedefs
#80: FILE: hal/odm_DIG.h:80:
+typedef enum tag_Dynamic_Init_Gain_Operation_Type_Definition {

WARNING: do not add new typedefs
#91: FILE: hal/odm_DIG.h:91:
+typedef enum tag_ODM_PauseDIG_Type {

WARNING: do not add new typedefs
#96: FILE: hal/odm_DIG.h:96:
+typedef enum tag_ODM_PauseCCKPD_Type {

Signed-off-by: Marco Cesati <marco.cesati@gmail.com>
Link: https://lore.kernel.org/r/20210312082638.25512-32-marco.cesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

show more ...