Revision tags: v4.1-rc5, v4.1-rc4, v4.1-rc3, v4.1-rc2, v4.1-rc1, v4.0, v4.0-rc7, v4.0-rc6, v4.0-rc5 |
|
#
4c42d979 |
| 16-Mar-2015 |
Somya Anand <somyaanand214@gmail.com> |
Staging: nvec: use !x instead of x == NULL
Functions like devm_kzalloc, kmalloc_array, devm_ioremap, usb_alloc_urb, alloc_netdev return NULL as a return value on failure. Generally, When NULL repres
Staging: nvec: use !x instead of x == NULL
Functions like devm_kzalloc, kmalloc_array, devm_ioremap, usb_alloc_urb, alloc_netdev return NULL as a return value on failure. Generally, When NULL represents failure, !x is commonly used.
This patch cleans up the tests on the results of these functions, thereby using !x instead of x == NULL or NULL == x. This is done via following coccinelle script: @prob_7@ identifier x; statement S; @@
( x = devm_kzalloc(...); | x = usb_alloc_urb(...); | x = kmalloc_array(...); | x = devm_ioremap(...); | x = alloc_netdev(...); ) ... - if(NULL == x) + if(!x) S Further we have used isomorphism characteristics of coccinelle to indicate x == NULL and NULL == x are equivalent. This is done via following iso script.
Expression @ is_null @ expression X; @@ X == NULL <=> NULL == X
Signed-off-by: Somya Anand <somyaanand214@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v4.0-rc4, v4.0-rc3, v4.0-rc2, v4.0-rc1, v3.19, v3.19-rc7, v3.19-rc6 |
|
#
2b7ded0f |
| 20-Jan-2015 |
Marc Dietrich <marvin24@gmx.de> |
staging: nvec: specify a platform-device base id
commit 6e3f62f079 (mfd: core: Fix platform-device id generation) modified the computation of the mfd cell id. Negative numbers forbit the specificati
staging: nvec: specify a platform-device base id
commit 6e3f62f079 (mfd: core: Fix platform-device id generation) modified the computation of the mfd cell id. Negative numbers forbit the specification of cell ids as we do. Fix this for now by specifying a base of 0 instead. In the long run, this may be changed to automatic cell ids (base -2).
Fixes: 6e3f62f079 Reported-by: Misha Komarovskiy <zombah@gmail.com> Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
#
3ec69881 |
| 20-Jan-2015 |
Marc Dietrich <marvin24@gmx.de> |
staging: nvec: specify a platform-device base id
commit 6e3f62f079 (mfd: core: Fix platform-device id generation) modified the computation of the mfd cell id. Negative numbers forbit the specificati
staging: nvec: specify a platform-device base id
commit 6e3f62f079 (mfd: core: Fix platform-device id generation) modified the computation of the mfd cell id. Negative numbers forbit the specification of cell ids as we do. Fix this for now by specifying a base of 0 instead. In the long run, this may be changed to automatic cell ids (base -2).
Reported-by: Misha Komarovskiy <zombah@gmail.com> Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
show more ...
|
Revision tags: v3.19-rc5 |
|
#
9b872a74 |
| 11-Jan-2015 |
Gustavo A. R. Silva <silvagustavosilva@gmail.com> |
Staging: nvec: Fixed a typo
Fixed a typo in nvec.c file
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
Revision tags: v3.19-rc4, v3.19-rc3, v3.19-rc2, v3.19-rc1, v3.18, v3.18-rc7, v3.18-rc6, v3.18-rc5, v3.18-rc4, v3.18-rc3, v3.18-rc2 |
|
#
d5dbc024 |
| 20-Oct-2014 |
Wolfram Sang <wsa@the-dreams.de> |
staging: nvec: drop owner assignment from platform_drivers
A platform_driver does not need to set an owner, it will be populated by the driver core.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
|
Revision tags: v3.18-rc1, v3.17, v3.17-rc7, v3.17-rc6, v3.17-rc5, v3.17-rc4, v3.17-rc3, v3.17-rc2, v3.17-rc1, v3.16 |
|
#
b5b628ba |
| 29-Jul-2014 |
Thierry Reding <treding@nvidia.com> |
staging/nvec: Use platform_get_irq()
As opposed to platform_get_resource(), the platform_get_irq() function has special code to handle driver probe deferral when booting using DT and where an interr
staging/nvec: Use platform_get_irq()
As opposed to platform_get_resource(), the platform_get_irq() function has special code to handle driver probe deferral when booting using DT and where an interrupt provider hasn't been registered yet. While this is unlikely to become an issue for nvec, platform_get_irq() is the recommended way to get at interrupts.
Signed-off-by: Thierry Reding <treding@nvidia.com> Acked-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
#
47e7b050 |
| 29-Jul-2014 |
Thierry Reding <treding@nvidia.com> |
staging/nvec: Do not pass resource to mfd_add_devices()
The mfd_add_devices() function takes a struct resource * as fifth argument, but the nvec driver passes in a void __iomem *. The driver gets aw
staging/nvec: Do not pass resource to mfd_add_devices()
The mfd_add_devices() function takes a struct resource * as fifth argument, but the nvec driver passes in a void __iomem *. The driver gets away with it because none of the subdevices ever directly access the registers.
Since subdevices never need to access the registers we can simply pass NULL instead.
Signed-off-by: Thierry Reding <treding@nvidia.com> Acked-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v3.16-rc7 |
|
#
5d30566f |
| 21-Jul-2014 |
Thierry Reding <treding@nvidia.com> |
staging/nvec: Remove double const qualifier
The SIMPLE_DEV_PM_OPS macro already uses the const qualifier, so there's no need to repeat it.
Signed-off-by: Thierry Reding <treding@nvidia.com> Acked-b
staging/nvec: Remove double const qualifier
The SIMPLE_DEV_PM_OPS macro already uses the const qualifier, so there's no need to repeat it.
Signed-off-by: Thierry Reding <treding@nvidia.com> Acked-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v3.16-rc6, v3.16-rc5, v3.16-rc4 |
|
#
5a9077a8 |
| 05-Jul-2014 |
Pawel Lebioda <pawel.lebioda89@gmail.com> |
staging: nvec: remove unneccessary 'out of memory' message
Fix the following warning reported by checkpatch.pl:
WARNING: Possible unnecessary 'out of memory' message 811: FILE: drivers/staging/nvec
staging: nvec: remove unneccessary 'out of memory' message
Fix the following warning reported by checkpatch.pl:
WARNING: Possible unnecessary 'out of memory' message 811: FILE: drivers/staging/nvec/nvec.c:811
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com> Acked-by: Marc Dietrich <marvin24@gmx.de> Reviewed-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
#
aea2cda3 |
| 05-Jul-2014 |
Pawel Lebioda <pawel.lebioda89@gmail.com> |
staging: nvec: remove unnecessary 'else' after 'return' statement
Fix the following warning reported by checkpatch.pl:
WARNING: else is not generally useful after a break or return 235: FILE: drive
staging: nvec: remove unnecessary 'else' after 'return' statement
Fix the following warning reported by checkpatch.pl:
WARNING: else is not generally useful after a break or return 235: FILE: drivers/staging/nvec/nvec.c:235
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com> Acked-by: Marc Dietrich <marvin24@gmx.de> Reviewed-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v3.16-rc3, v3.16-rc2, v3.16-rc1, v3.15, v3.15-rc8, v3.15-rc7, v3.15-rc6, v3.15-rc5, v3.15-rc4, v3.15-rc3, v3.15-rc2, v3.15-rc1, v3.14, v3.14-rc8, v3.14-rc7, v3.14-rc6 |
|
#
b77f2767 |
| 05-Mar-2014 |
Ebru Akagunduz <ebru.akagunduz@gmail.com> |
Staging:nvec: fix quoted string split across lines
Fix checkpatch.pl issues with quoted string split across lines in nvec.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by: Paul E
Staging:nvec: fix quoted string split across lines
Fix checkpatch.pl issues with quoted string split across lines in nvec.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v3.14-rc5, v3.14-rc4, v3.14-rc3, v3.14-rc2, v3.14-rc1, v3.13, v3.13-rc8, v3.13-rc7, v3.13-rc6, v3.13-rc5, v3.13-rc4, v3.13-rc3, v3.13-rc2, v3.13-rc1 |
|
#
2977dc92 |
| 18-Nov-2013 |
Geert Uytterhoeven <geert@linux-m68k.org> |
mfd: staging: Constify struct mfd_cell where possible
As of commit 03e361b25ee8dfb1fd9b890072c23c4aae01c6c7 ("mfd: Stop setting refcounting pointers in original mfd_cell arrays"), the "cell" paramet
mfd: staging: Constify struct mfd_cell where possible
As of commit 03e361b25ee8dfb1fd9b890072c23c4aae01c6c7 ("mfd: Stop setting refcounting pointers in original mfd_cell arrays"), the "cell" parameter of mfd_add_devices() is "const" again. Hence make all cell data passed to mfd_add_devices() const where possible.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: devel@driverdev.osuosl.org Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Lee Jones <lee.jones@linaro.org>
show more ...
|
#
c0df5bf5 |
| 06-Nov-2013 |
Stephen Warren <swarren@nvidia.com> |
staging: nvec: use reset framework
Tegra's clock driver now provides an implementation of the common reset API (include/linux/reset.h). Use this instead of the old Tegra- specific API; that will soo
staging: nvec: use reset framework
Tegra's clock driver now provides an implementation of the common reset API (include/linux/reset.h). Use this instead of the old Tegra- specific API; that will soon be removed.
Signed-off-by: Stephen Warren <swarren@nvidia.com> Acked-by: Marc Dietrich <marvin24@gmx.de> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Thierry Reding <treding@nvidia.com>
show more ...
|
#
6330f9cf |
| 07-Nov-2013 |
Dan Carpenter <dan.carpenter@oracle.com> |
staging: nvec: potential NULL dereference on error path
We assume nvec->rx can be NULL earlier so I have added a check here as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-o
staging: nvec: potential NULL dereference on error path
We assume nvec->rx can be NULL earlier so I have added a check here as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
#
28397dc9 |
| 18-Nov-2013 |
Geert Uytterhoeven <geert@linux-m68k.org> |
mfd: staging: Constify struct mfd_cell where possible
As of commit 03e361b25ee8dfb1fd9b890072c23c4aae01c6c7 ("mfd: Stop setting refcounting pointers in original mfd_cell arrays"), the "cell" paramet
mfd: staging: Constify struct mfd_cell where possible
As of commit 03e361b25ee8dfb1fd9b890072c23c4aae01c6c7 ("mfd: Stop setting refcounting pointers in original mfd_cell arrays"), the "cell" parameter of mfd_add_devices() is "const" again. Hence make all cell data passed to mfd_add_devices() const where possible.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: devel@driverdev.osuosl.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v3.12, v3.12-rc7, v3.12-rc6, v3.12-rc5, v3.12-rc4 |
|
#
15f1df57 |
| 02-Oct-2013 |
Tugce Sirin <ztugcesirin@gmail.com> |
staging: nvec: fix space after if statement in nvec.c
This patch fixes space after if statement in nvec/nvec.c
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com> Signed-off-by: Greg Kroah-Hartman <
staging: nvec: fix space after if statement in nvec.c
This patch fixes space after if statement in nvec/nvec.c
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v3.12-rc3, v3.12-rc2, v3.12-rc1, v3.11, v3.11-rc7, v3.11-rc6, v3.11-rc5, v3.11-rc4, v3.11-rc3 |
|
#
ca250b60 |
| 27-Jul-2013 |
Marc Dietrich <marvin24@gmx.de> |
staging: nvec: re-enable the clock on resume
On resume the slave controller is reinitialized. The tegra i2c master controller disables the clock at the end of the initialiation, propably to save som
staging: nvec: re-enable the clock on resume
On resume the slave controller is reinitialized. The tegra i2c master controller disables the clock at the end of the initialiation, propably to save some power, and enables it again on each transfer. We don't do this yet and also forgot to enable the clock on resume. Fix this copy-paste error by not disabling the clock after initialization.
This didn't striked us yet because suspend/resume hasn't landed in mainline yet, but will soon.
Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v3.11-rc2, v3.11-rc1, v3.10, v3.10-rc7 |
|
#
95cd1860 |
| 21-Jun-2013 |
Marc Dietrich <marvin24@gmx.de> |
staging: nvec: move device tree parsing to its own function
This moves device tree parsing to its own function so more stuff can be cleanly added in the future.
Signed-off-by: Leon Romanovsky <leon
staging: nvec: move device tree parsing to its own function
This moves device tree parsing to its own function so more stuff can be cleanly added in the future.
Signed-off-by: Leon Romanovsky <leon@leon.nu> Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
#
2c6cbdd0 |
| 21-Jun-2013 |
Marc Dietrich <marvin24@gmx.de> |
staging: nvec: remove instantiating via platform device
Tegra has been converted to support device tree only. Remove support for instantiating via platform device.
Signed-off-by: Leon Romanovsky <l
staging: nvec: remove instantiating via platform device
Tegra has been converted to support device tree only. Remove support for instantiating via platform device.
Signed-off-by: Leon Romanovsky <leon@leon.nu> Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v3.10-rc6, v3.10-rc5, v3.10-rc4, v3.10-rc3, v3.10-rc2 |
|
#
4f39b5b5 |
| 12-May-2013 |
Wolfram Sang <wsa@the-dreams.de> |
drivers/staging/nvec: don't check resource with devm_ioremap_resource
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver.
Signed-off-by: Wolfram
drivers/staging/nvec: don't check resource with devm_ioremap_resource
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
show more ...
|
#
79719e64 |
| 16-May-2013 |
Wolfram Sang <wsa@the-dreams.de> |
drivers/staging/nvec: don't check resource with devm_ioremap_resource
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver.
Signed-off-by: Wolfram
drivers/staging/nvec: don't check resource with devm_ioremap_resource
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v3.10-rc1 |
|
#
c2b62f60 |
| 29-Apr-2013 |
Marc Dietrich <marvin24@gmx.de> |
staging: nvec: cleanup childs on remove
Disable device functions and unregister notifier if available. The serio device must not be "kzallocated". Otherwise serio_unregister_port will fail because t
staging: nvec: cleanup childs on remove
Disable device functions and unregister notifier if available. The serio device must not be "kzallocated". Otherwise serio_unregister_port will fail because the device is already freed.
Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
#
111c1587 |
| 29-Apr-2013 |
Marc Dietrich <marvin24@gmx.de> |
staging: nvec: implement unregistering of notifiers
This implements the unregistering of notifiers so kernel modules can be unloaded.
Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: G
staging: nvec: implement unregistering of notifiers
This implements the unregistering of notifiers so kernel modules can be unloaded.
Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
#
d398f56e |
| 29-Apr-2013 |
Marc Dietrich <marvin24@gmx.de> |
staging: nvec: cleanup childs on remove
Disable device functions and unregister notifier if available. The serio device must not be "kzallocated". Otherwise serio_unregister_port will fail because t
staging: nvec: cleanup childs on remove
Disable device functions and unregister notifier if available. The serio device must not be "kzallocated". Otherwise serio_unregister_port will fail because the device is already freed.
Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
#
218468f4 |
| 29-Apr-2013 |
Marc Dietrich <marvin24@gmx.de> |
staging: nvec: implement unregistering of notifiers
This implements the unregistering of notifiers so kernel modules can be unloaded.
Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: G
staging: nvec: implement unregistering of notifiers
This implements the unregistering of notifiers so kernel modules can be unloaded.
Signed-off-by: Marc Dietrich <marvin24@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|