7e6e2288 | 08-May-2018 |
Christian Gromm <christian.gromm@microchip.com> |
staging: most: i2c: reduce parameters inconsistency
Currently, there are two module parameters for the i2c driver: - polling_req: boolean irq/polling mode; - scan_rate: polling rate, that is use
staging: most: i2c: reduce parameters inconsistency
Currently, there are two module parameters for the i2c driver: - polling_req: boolean irq/polling mode; - scan_rate: polling rate, that is used in the case where the polling mode is active
This model is misconfiguration-prone. For example, it is possible to select polling mode with the zero polling rate or configure non-zero polling rate in a combination with the IRQ mode.
This patch replaces the 'polling_req' and 'scan_rate' by the 'polling_rate', where the value zero means the interrupt driven mode and other values are used as the polling rate in the polling mode.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
eb50842c | 08-May-2018 |
Christian Gromm <christian.gromm@microchip.com> |
staging: most: i2c: remove redundant list_mutex
The elements of the dev->rx.list are consumed in the pending_rx_work and populated in the function enqueue() that cancels the pending_rx_work.
The fu
staging: most: i2c: remove redundant list_mutex
The elements of the dev->rx.list are consumed in the pending_rx_work and populated in the function enqueue() that cancels the pending_rx_work.
The function enqueue() and poison_channel() do not race anyway.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
6471c269 | 08-May-2018 |
Christian Gromm <christian.gromm@microchip.com> |
staging: most: i2c: remove redundant is_open
The variable is_open is checked only in the work function pending_rx_work() that is only active between the calls configure_channel() and poison_channel(
staging: most: i2c: remove redundant is_open
The variable is_open is checked only in the work function pending_rx_work() that is only active between the calls configure_channel() and poison_channel().
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
0003718c | 08-May-2018 |
Christian Gromm <christian.gromm@microchip.com> |
staging: most: i2c: trace real polling rate
The real polling rate depends on the CONFIG_HZ and may differ from the required polling rate.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de> Sig
staging: most: i2c: trace real polling rate
The real polling rate depends on the CONFIG_HZ and may differ from the required polling rate.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
ea8bcd52 | 08-May-2018 |
Christian Gromm <christian.gromm@microchip.com> |
staging: most: i2c: prevent zero delay polling
This patch avoids that a configured scan_rate of more than MSEC_PER_SEC might result in a polling delay of zero.
Signed-off-by: Christian Gromm <chris
staging: most: i2c: prevent zero delay polling
This patch avoids that a configured scan_rate of more than MSEC_PER_SEC might result in a polling delay of zero.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
cd2e7148 | 08-May-2018 |
Christian Gromm <christian.gromm@microchip.com> |
staging: most: i2c: avoid polling in case of misconfig
This patch prevents the driver from falling back to polling mode in case of IRQ misconfiguration.
Signed-off-by: Christian Gromm <christian.gr
staging: most: i2c: avoid polling in case of misconfig
This patch prevents the driver from falling back to polling mode in case of IRQ misconfiguration.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
795ce218 | 08-May-2018 |
Christian Gromm <christian.gromm@microchip.com> |
staging: most: i2c: do not wait in work function
This patch removes the function wait_event_interruptible from the work function to avoid waiting.
Signed-off-by: Christian Gromm <christian.gromm@mi
staging: most: i2c: do not wait in work function
This patch removes the function wait_event_interruptible from the work function to avoid waiting.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
95b2f82d | 08-May-2018 |
Christian Gromm <christian.gromm@microchip.com> |
staging: most: i2c: remove unnecessary poison_channel call
This removes call of the poison_channel that is: - not allowed after most_deregister_interface; - is made during the most_deregister_in
staging: most: i2c: remove unnecessary poison_channel call
This removes call of the poison_channel that is: - not allowed after most_deregister_interface; - is made during the most_deregister_interface call.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|