42877c38 | 25-May-2023 |
Osama Muhammad <osmtendev@gmail.com> |
HSI: omap_ssi_port: Drop error checking for debugfs_create_dir
This patch fixes the error checking in omap_ssi_port.c. The DebugFS kernel API is developed in a way that the caller can safely ignore
HSI: omap_ssi_port: Drop error checking for debugfs_create_dir
This patch fixes the error checking in omap_ssi_port.c. The DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes.
Signed-off-by: Osama Muhammad <osmtendev@gmail.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
show more ...
|
3ffa9f71 | 24-Nov-2022 |
Yuan Can <yuancan@huawei.com> |
HSI: omap_ssi_core: Fix error handling in ssi_init()
The ssi_init() returns the platform_driver_register() directly without checking its return value, if platform_driver_register() failed, the ssi_p
HSI: omap_ssi_core: Fix error handling in ssi_init()
The ssi_init() returns the platform_driver_register() directly without checking its return value, if platform_driver_register() failed, the ssi_pdriver is not unregistered. Fix by unregister ssi_pdriver when the last platform_driver_register() failed.
Fixes: 0fae198988b8 ("HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module") Signed-off-by: Yuan Can <yuancan@huawei.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
show more ...
|
1aff514e | 31-Oct-2022 |
Yang Yingliang <yangyingliang@huawei.com> |
HSI: omap_ssi_core: fix possible memory leak in ssi_probe()
If ssi_add_controller() returns error, it should call hsi_put_controller() to give up the reference that was set in hsi_alloc_controller()
HSI: omap_ssi_core: fix possible memory leak in ssi_probe()
If ssi_add_controller() returns error, it should call hsi_put_controller() to give up the reference that was set in hsi_alloc_controller(), so that it can call hsi_controller_release() to free controller and ports that allocated in hsi_alloc_controller().
Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
show more ...
|
f5181c35 | 31-Oct-2022 |
Yang Yingliang <yangyingliang@huawei.com> |
HSI: omap_ssi_core: fix unbalanced pm_runtime_disable()
In error label 'out1' path in ssi_probe(), the pm_runtime_enable() has not been called yet, so pm_runtime_disable() is not needed.
Fixes: b20
HSI: omap_ssi_core: fix unbalanced pm_runtime_disable()
In error label 'out1' path in ssi_probe(), the pm_runtime_enable() has not been called yet, so pm_runtime_disable() is not needed.
Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
show more ...
|
81190815 | 14-Sep-2022 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
HSI: nokia-modem: Replace of_gpio_count() by gpiod_count()
As a preparation to unexport of_gpio_named_count(), convert the driver to use gpiod_count() instead.
Signed-off-by: Andy Shevchenko <andri
HSI: nokia-modem: Replace of_gpio_count() by gpiod_count()
As a preparation to unexport of_gpio_named_count(), convert the driver to use gpiod_count() instead.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
show more ...
|
b28dbcb3 | 05-Sep-2022 |
Jianglei Nie <niejianglei2021@163.com> |
HSI: ssi_protocol: fix potential resource leak in ssip_pn_open()
ssip_pn_open() claims the HSI client's port with hsi_claim_port(). When hsi_register_port_event() gets some error and returns a neget
HSI: ssi_protocol: fix potential resource leak in ssip_pn_open()
ssip_pn_open() claims the HSI client's port with hsi_claim_port(). When hsi_register_port_event() gets some error and returns a negetive value, the HSI client's port should be released with hsi_release_port().
Fix it by calling hsi_release_port() when hsi_register_port_event() fails.
Signed-off-by: Jianglei Nie <niejianglei2021@163.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
show more ...
|
551e325b | 26-Aug-2022 |
Jack Wang <jinpu.wang@ionos.com> |
HSI: omap_ssi_port: Fix dma_map_sg error check
dma_map_sg return 0 on error, in case of error return -EIO to caller.
Cc: Sebastian Reichel <sre@kernel.org> Cc: linux-kernel@vger.kernel.org (open li
HSI: omap_ssi_port: Fix dma_map_sg error check
dma_map_sg return 0 on error, in case of error return -EIO to caller.
Cc: Sebastian Reichel <sre@kernel.org> Cc: linux-kernel@vger.kernel.org (open list) Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver") Signed-off-by: Jack Wang <jinpu.wang@ionos.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
show more ...
|
0f1a3e5f | 19-May-2022 |
Linus Walleij <linus.walleij@linaro.org> |
HSI: cmt_speech: Pass a pointer to virt_to_page()
A pointer into virtual memory is represented by a (void *) not an u32, so the compiler warns:
drivers/hsi/clients/cmt_speech.c:1092:35: warning: pa
HSI: cmt_speech: Pass a pointer to virt_to_page()
A pointer into virtual memory is represented by a (void *) not an u32, so the compiler warns:
drivers/hsi/clients/cmt_speech.c:1092:35: warning: passing argument 1 of 'virt_to_pfn' makes pointer from integer without a cast [-Wint-conversion]
Fix this with an explicit cast.
Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com> Cc: Aaro Koskinen <aaro.koskinen@iki.fi> Cc: Pavel Machek <pavel@ucw.cz> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
show more ...
|
9a2ea132 | 04-Apr-2022 |
Miaoqian Lin <linmq006@gmail.com> |
HSI: omap_ssi: Fix refcount leak in ssi_probe
When returning or breaking early from a for_each_available_child_of_node() loop, we need to explicitly call of_node_put() on the child node to possibly
HSI: omap_ssi: Fix refcount leak in ssi_probe
When returning or breaking early from a for_each_available_child_of_node() loop, we need to explicitly call of_node_put() on the child node to possibly release the node.
Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
show more ...
|
8a77ed6d | 01-Dec-2020 |
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
HSI: core: fix a kernel-doc markup
A function has a different name between their prototype and its kernel-doc markup.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by:
HSI: core: fix a kernel-doc markup
A function has a different name between their prototype and its kernel-doc markup.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
show more ...
|