| 0c1e81d0 | 05-Oct-2023 |
Ondrej Zary <linux@zary.sk> |
ata: pata_parport: fit3: implement IDE command set registers
fit3 protocol driver does not support accessing IDE control registers
(device control/altstatus). The DOS driver does not use these regis
ata: pata_parport: fit3: implement IDE command set registers
fit3 protocol driver does not support accessing IDE control registers
(device control/altstatus). The DOS driver does not use these registers
either (as observed from DOSEMU trace). But the HW seems to be capable
of accessing these registers - I simply tried bit 3 and it works!
The control register is required to properly reset ATAPI devices or
they will be detected only once (after a power cycle).
Tested with EXP Computer CD-865 with MC-1285B EPP cable and
TransDisk 3000.
Signed-off-by: Ondrej Zary <linux@zary.sk>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| f343e578 | 05-Oct-2023 |
Ondrej Zary <linux@zary.sk> |
ata: pata_parport: add custom version of wait_after_reset
Some parallel adapters (e.g. EXP Computer MC-1285B EPP Cable) return
bogus values when there's no master device present. This can cause
rese
ata: pata_parport: add custom version of wait_after_reset
Some parallel adapters (e.g. EXP Computer MC-1285B EPP Cable) return
bogus values when there's no master device present. This can cause
reset to fail, preventing the lone slave device (such as EXP Computer
CD-865) from working.
Add custom version of wait_after_reset that ignores master failure when
a slave device is present. The custom version is also needed because
the generic ata_sff_wait_after_reset uses direct port I/O for slave
device detection.
Signed-off-by: Ondrej Zary <linux@zary.sk>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| d2302427 | 05-Oct-2023 |
Ondrej Zary <linux@zary.sk> |
ata: pata_parport: implement set_devctl
Add missing ops->sff_set_devctl implementation.
Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)")
Cc: stable@vger.kernel.org
Signed-
ata: pata_parport: implement set_devctl
Add missing ops->sff_set_devctl implementation.
Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)")
Cc: stable@vger.kernel.org
Signed-off-by: Ondrej Zary <linux@zary.sk>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| a5ae12c8 | 16-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix on26 module code indentation and style
Fix the header, indentation and coding style in the on26 pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix on26 module code indentation and style
Fix the header, indentation and coding style in the on26 pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| 012f2059 | 16-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix on20 module code indentation and style
Fix the header, indentation and coding style in the on20 pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix on20 module code indentation and style
Fix the header, indentation and coding style in the on20 pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| ece68db9 | 16-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix ktti module code indentation and style
Fix the header, indentation and coding style in the ktti pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix ktti module code indentation and style
Fix the header, indentation and coding style in the ktti pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| 65db10ca | 16-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix kbic module code indentation and style
Fix the header, indentation and coding style in the kbic pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix kbic module code indentation and style
Fix the header, indentation and coding style in the kbic pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| bd91cbfa | 16-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix friq module code indentation and style
Fix the header, indentation and coding style in the friq pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix friq module code indentation and style
Fix the header, indentation and coding style in the friq pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| 6b427116 | 16-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix fit3 module code indentation and style
Fix the header, indentation and coding style in the fit3 pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix fit3 module code indentation and style
Fix the header, indentation and coding style in the fit3 pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| 0d5e8172 | 16-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix fit2 module code indentation and style
Fix the header, indentation and coding style in the fit2 pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix fit2 module code indentation and style
Fix the header, indentation and coding style in the fit2 pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| 8be31971 | 15-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix epia module code indentation and style
Fix the header, indentation and coding style in the epia pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix epia module code indentation and style
Fix the header, indentation and coding style in the epia pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| 3cb41685 | 15-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix epat module code indentation and style
Fix the header, indentation and coding style in the epat pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix epat module code indentation and style
Fix the header, indentation and coding style in the epat pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| d6332c12 | 15-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix dstr module code indentation and style
Fix the header, indentation and coding style in the dstr pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix dstr module code indentation and style
Fix the header, indentation and coding style in the dstr pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| 630b64bc | 15-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix comm module code indentation and style
Fix the header, indentation and coding style in the comm pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix comm module code indentation and style
Fix the header, indentation and coding style in the comm pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| ec52d524 | 15-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix bpck6 module code indentation and style
Fix the header, indentation and coding style in the bpck6 pata parport
protocol module to suppress warnings from smatch and other stati
ata: pata_parport: Fix bpck6 module code indentation and style
Fix the header, indentation and coding style in the bpck6 pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| ab0695ee | 15-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix aten module code indentation and style
Fix the header, indentation and coding style in the aten pata parport
protocol module to suppress warnings from smatch and other static
ata: pata_parport: Fix aten module code indentation and style
Fix the header, indentation and coding style in the aten pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
show more ...
|
| f19c694f | 08-May-2023 |
Damien Le Moal <dlemoal@kernel.org> |
ata: pata_parport: Fix frpw module code indentation and style
Fix the header, indentation and coding style in the frpw pata parport
protocol module to suppress smatch warnings such as:
drivers/ata/
ata: pata_parport: Fix frpw module code indentation and style
Fix the header, indentation and coding style in the frpw pata parport
protocol module to suppress smatch warnings such as:
drivers/ata/pata_parport/frpw.c:234 frpw_test_proto() warn: inconsistent indenting
No functional changes.
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202305061212.EPgEMLXl-lkp@intel.com/
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
show more ...
|
| 140b2603 | 22-Mar-2023 |
Damien Le Moal <damien.lemoal@opensource.wdc.com> |
ata: pata_parport-bpck6: Declare mode_map as static
Compilation C=1 of the bpck6 protocol module generates the following
message:
drivers/ata/pata_parport/bpck6.c:62:5: warning: symbol 'mode_map' w
ata: pata_parport-bpck6: Declare mode_map as static
Compilation C=1 of the bpck6 protocol module generates the following
message:
drivers/ata/pata_parport/bpck6.c:62:5: warning: symbol 'mode_map' was
not declared. Should it be static?
Fix this by declaring mode_map as static.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Ondrej Zary <linux@zary.sk>
show more ...
|
| 919c1194 | 22-Mar-2023 |
Damien Le Moal <damien.lemoal@opensource.wdc.com> |
ata: pata_parport-bpck6: Remove dependency on 64BIT
There is no reason to have compilation of the bpck6 protocol module
being dependent on 64BIT. Remove this dependency.
Signed-off-by: Damien Le Mo
ata: pata_parport-bpck6: Remove dependency on 64BIT
There is no reason to have compilation of the bpck6 protocol module
being dependent on 64BIT. Remove this dependency.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Ondrej Zary <linux@zary.sk>
show more ...
|