pdr: Assign record_handle in entity_association_pdr_add_children()

The entity_association_pdr_add_children() static API was hard coding
the record handle value to 0 rather than assigning the record_

pdr: Assign record_handle in entity_association_pdr_add_children()

The entity_association_pdr_add_children() static API was hard coding
the record handle value to 0 rather than assigning the record_handle
value provided as a input parameter.

Tested: Unit tested

Fixes: 25ddbccfae0e ("pdr: Add pldm_entity_association_pdr_add_from_node_with_record_handle()")
Change-Id: I96b6a340f027abd2ef4009380a2fcf27742531bd
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

oem: meta: Add decode_oem_meta_file_io_req()

Support decode_oem_meta_file_io_req() cmd to decode the incoming post
code.

PLDM OEM Meta Write File IO cmd:
Example:
Request:
Byte 0: 0x3F (OEM c

oem: meta: Add decode_oem_meta_file_io_req()

Support decode_oem_meta_file_io_req() cmd to decode the incoming post
code.

PLDM OEM Meta Write File IO cmd:
Example:
Request:
Byte 0: 0x3F (OEM cmd)
Byte 1: 0x02 (FILE IO)
Byte 2: 0x00 (File io type : POST CODE)
Byte 3-6: 0x04 (Data length)
Byte 7-10: 0x93 0xE0 0x00 0xEA (post code)

Response:
Byte 0: 0x00 (success)

Tested:
- Unit Tests passed.

Change-Id: I85437698642dd3cbe6084acf1feada842d206eac
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

pdr: Stabilise pldm_entity_association_pdr_add_from_node_with_record_handle()

The usage of
pldm_entity_association_pdr_add_from_node_with_record_handle() is
demonstrated here:

https://gerrit.openbm

pdr: Stabilise pldm_entity_association_pdr_add_from_node_with_record_handle()

The usage of
pldm_entity_association_pdr_add_from_node_with_record_handle() is
demonstrated here:

https://gerrit.openbmc.org/c/openbmc/pldm/+/63125

Change-Id: I564d2253402b22af561ebf710f33c142b70b2e16
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pdr: Stabilise pldm_pdr_find_last_in_range() API

Use of pldm_pdr_find_last_in_range() API is demonstarted here:
https://gerrit.openbmc.org/c/openbmc/pldm/+/63125

Change-Id: Idf51abc591fd2e2ab31f3b7

pdr: Stabilise pldm_pdr_find_last_in_range() API

Use of pldm_pdr_find_last_in_range() API is demonstarted here:
https://gerrit.openbmc.org/c/openbmc/pldm/+/63125

Change-Id: Idf51abc591fd2e2ab31f3b7e1d2957d1345702e7
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

meson: Configure abi-dumper for mixed headers

We split the headers between include/ and src/ dependening on their
purpose and use different include strategies to differentiate. There's
no restrictio

meson: Configure abi-dumper for mixed headers

We split the headers between include/ and src/ dependening on their
purpose and use different include strategies to differentiate. There's
no restriction on the header names, so make sure abi-dumper is aware.

Change-Id: I21a6da776ce8bbf5d5d1e328f44e9cd650406dea
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Sort abi-dumper output

It turns out that it helps to read the man-page! Hopefully this makes
the show a whole lot more manageable.

Change-Id: I2b44a457702f1792617c0d76a443bd27b85c1515
Signed

meson: Sort abi-dumper output

It turns out that it helps to read the man-page! Hopefully this makes
the show a whole lot more manageable.

Change-Id: I2b44a457702f1792617c0d76a443bd27b85c1515
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

libpldm: More fixes for header use

b0c1d20a5bde ("libpldm: Fix header use") only did half the job,
addressing compilation concerns for the library itself. As it turns out
there were still plenty of

libpldm: More fixes for header use

b0c1d20a5bde ("libpldm: Fix header use") only did half the job,
addressing compilation concerns for the library itself. As it turns out
there were still plenty of places that used local includes for paths to
the public headers.

Apply the rest of the header cleanups to hopefully get us into a
consistent state.

Fixes: b0c1d20a5bde ("libpldm: Fix header use")
Change-Id: I8d4b59c9241770583abb30389452af0a32b18b99
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

libpldm: Rationalise the local and installed path of pldm.h

Since chopping libpldm out of openbmc/pldm.git there's been a symlink
from `include/libpldm/pldm.h` pointing to
`include/libpldm/requester

libpldm: Rationalise the local and installed path of pldm.h

Since chopping libpldm out of openbmc/pldm.git there's been a symlink
from `include/libpldm/pldm.h` pointing to
`include/libpldm/requester/pldm.h`. The file list contained in the
`libpldm_headers` variable defined by `include/libpldm/meson.build`
contained an entry for `requester/pldm.h`, though not the symlink found
at `include/libpldm/pldm.h`.

Prior to a7989cd65d51 ("meson: Fix for OEM header collision issue")
`install_headers(libpldm_headers, ...)` directive didn't specify
`preserve_path: true`, therefore the `requester/pldm.h` header file was
installed directly under `${INCLUDEDIR}/libpldm` as
`${INCLUDEDIR}/libpldm/pldm.h`, and no file was installed to
`${INCLUDEDIR}/libpldm/requester/pldm.h`.

All dependent applications using the declarations in `pldm.h` therefore
included the header using the directive `#include <libpldm/pldm.h>`.
However, internal to the libpldm implementation we were using the
non-symlinked path in the local tree:
`#include "libpldm/requester/pldm.h"`

With a7989cd65d51 ("meson: Fix for OEM header collision issue") we
rationalised the meson variables used to install the headers as part of
properly separating OEM headers from one-another. This lead to
specifying `preserve_path: true` for the
`install_headers(libpldm_headers, ...)` meson directive, which further
lead to the installed location of `pldm.h` changing to
`${INCLUDEDIR}/libpldm/requester/pldm.h`. This broke all consuming
applications which were necessarily using `#include <libpldm/pldm.h>` as
outlined above.

Get rid of the symlink at `include/libpldm/pldm.h`, move
`include/libpldm/requester/pldm.h` there instead, and fix up all
internal references to the header. This unbreaks applications consuming
libpldm, and prevents internal inconsistencies going forward.

Fixes: a7989cd65d51 ("meson: Fix for OEM header collision issue")
Change-Id: I24f1e25303890c41fd3da6323c67d838022cc55d
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Add supported PLDM message types to the enum

Added PLDM_SMBIOS & PLDM_RDE messages types to the enum based
on DSP0245 specification.

Change-Id: I936ee7fcd0937c1f8026a6e01ef6513d6a489450
Signed-off-

Add supported PLDM message types to the enum

Added PLDM_SMBIOS & PLDM_RDE messages types to the enum based
on DSP0245 specification.

Change-Id: I936ee7fcd0937c1f8026a6e01ef6513d6a489450
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

meson: Move ABI compliance check alongside library target

In the spirit of keeping-things-that-are-together-together.

Change-Id: I8e75beae84da06fe1f9a32de569a1816ae093be9
Signed-off-by: Andrew Jeff

meson: Move ABI compliance check alongside library target

In the spirit of keeping-things-that-are-together-together.

Change-Id: I8e75beae84da06fe1f9a32de569a1816ae093be9
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Decouple 'oem-ibm' feature from parent projects

This was an artefact of libpldm's previous life where it was integrated
into OpenBMC's pldm.git.

Change-Id: I90f0004542a35d87b6653f49941ec5e27

meson: Decouple 'oem-ibm' feature from parent projects

This was an artefact of libpldm's previous life where it was integrated
into OpenBMC's pldm.git.

Change-Id: I90f0004542a35d87b6653f49941ec5e2768d1da7
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Default tests feature to 'auto'

With that, reduce the strength of the get_option('tests') conditions to
allowed().

Change-Id: I2ae42606a64d39c2bc5667bf009c95558c0bc4d6
Signed-off-by: Andrew

meson: Default tests feature to 'auto'

With that, reduce the strength of the get_option('tests') conditions to
allowed().

Change-Id: I2ae42606a64d39c2bc5667bf009c95558c0bc4d6
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Fix for OEM header collision issue

It needs to be possible to build libpldm with any number of oem features
enabled simultaneously. If the header files are same then the earlier
implementatio

meson: Fix for OEM header collision issue

It needs to be possible to build libpldm with any number of oem features
enabled simultaneously. If the header files are same then the earlier
implementation will not work.

Install the header file in a way that doesn't break any oem portions.
Also the symlinks are generated to the older location until we migrate
the applications using the files to new location.

Tested: The headers are installed in the new location
and symlinks are generated.

Change-Id: I1455d52ff4b0c7f74b49d136bf582182537592d1
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

libpldm: Fix header use

The headers need to work whether we're building libpldm in the repo or
we're building another project depending on the headers in the system
include directory.

Tidy up the p

libpldm: Fix header use

The headers need to work whether we're building libpldm in the repo or
we're building another project depending on the headers in the system
include directory.

Tidy up the paths involved and switch to defining the public headers as
system headers for the purpose of the build.

Change-Id: I49413988c94d393ea5761bc4684edcd2c2482a98
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

license: add spdx identifier to all files

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ifddd07cc0eb5edeb2dcb410747073d68c6631cb1

oem: ibm: Add chapdata file type support

- When remote user configure the network parameter information for
partition firmware to boot different server on the network then
remote user has to aut

oem: ibm: Add chapdata file type support

- When remote user configure the network parameter information for
partition firmware to boot different server on the network then
remote user has to authenticate themselves to the server.

- Remote user will pass encrypted key(chapsecret) and it's keyname
(chapname) to remote host via file io operation which would be
done via PLDM.

- Adding new chapdata file type support which contain chapname and
chapsecret information which would be communicate to remote
terminus via PLDM.

Change-Id: I48710a7ce80e08a27c0b0e960378b2f56c69b4ef
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Id7eff2a106b4da7af550c473ec391fa00db5e95b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Improving the clarity of the code

Callers of the function
pldm_bios_table_attr_value_entry_enum_decode_handles() provide the
pointer to the buffer and its size. Modifying the buffer size and using

Improving the clarity of the code

Callers of the function
pldm_bios_table_attr_value_entry_enum_decode_handles() provide the
pointer to the buffer and its size. Modifying the buffer size and using
it in the library can be error-prone. Adjust the code to only read the
buffer size and not to modify it.

Tested:
Unit Tests passed.

Change-Id: I26e843fa817e969719aa19f1922b4ea8622078f2
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

OWNERS: remove TOF members

When the libpldm repository was created, we added some TOF members as
maintainers to ensure there was adequate coverage. Andrew has really
done all of the work here and i

OWNERS: remove TOF members

When the libpldm repository was created, we added some TOF members as
maintainers to ensure there was adequate coverage. Andrew has really
done all of the work here and is the primary maintainer of libpldm. He
has also brought on some other reviewers.

With this in mind, it seems unnecessary for the TOF members to be left
in place as maintainers / reviewers.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If86140e1634cdd9c048d2dbb8295aae871343db0

show more ...

changlog: Move new entries out of v0.7.0 release section

Changes post-v0.7.0 were mistakenly added into the v0.7.0 section. Move
them out into the Unreleased section.

Fixes: 91c06e9a535b ("base: Pr

changlog: Move new entries out of v0.7.0 release section

Changes post-v0.7.0 were mistakenly added into the v0.7.0 section. Move
them out into the Unreleased section.

Fixes: 91c06e9a535b ("base: Provide pldm_msg_hdr_correlate_response()")
Fixes: cc45aed7808d ("transport: af-mctp: Add pldm_transport_af_mctp_bind()")
Fixes: 5239d9a69cc2 ("base: Stabilise pldm_msg_hdr_correlate_response()")
Fixes: 7dc429da1b29 ("transport: af-mctp: Stabilise pldm_transport_af_mctp_bind()")
Change-Id: I534628c36f9db8d67f66b5acf96f0d71d64c58bb
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

README: Add a note explaining ABI stability

Change-Id: I32b0d7a28cea819ff8df4505762e007e39a186c1
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

transport: af-mctp: Stabilise pldm_transport_af_mctp_bind()

Use of pldm_transport_af_mctp_bind() is demonstrated in the following
patch to pldmd:

https://gerrit.openbmc.org/c/openbmc/pldm/+/63652

transport: af-mctp: Stabilise pldm_transport_af_mctp_bind()

Use of pldm_transport_af_mctp_bind() is demonstrated in the following
patch to pldmd:

https://gerrit.openbmc.org/c/openbmc/pldm/+/63652

Change-Id: I9c902d94c13bceb611606e7439964d9485ebec07
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

base: Stabilise pldm_msg_hdr_correlate_response()

Use of pldm_msg_hdr_correlate_response() is demonstrated in the
following patch to pldmd:

https://gerrit.openbmc.org/c/openbmc/pldm/+/66819

Change

base: Stabilise pldm_msg_hdr_correlate_response()

Use of pldm_msg_hdr_correlate_response() is demonstrated in the
following patch to pldmd:

https://gerrit.openbmc.org/c/openbmc/pldm/+/66819

Change-Id: I875b2dee5247c986a36ccd456956fb7e2a18d11a
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

abi: Update x86_64 dump in accordance with the CI output

Maintain the x86_64 ABI dump as generated by the OpenBMC CI container.
This is a sensible reference point that should give us consistent dump

abi: Update x86_64 dump in accordance with the CI output

Maintain the x86_64 ABI dump as generated by the OpenBMC CI container.
This is a sensible reference point that should give us consistent dump
output.

Change-Id: I2f573a159cfa5564d952d62a882ef06a27041e91
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

abi: Drop aarch64 ABI reference

Maintaining the ABI dump across multiple distros let alone across
multiple architectures is too much of a headache. Let's maintain one
dump for the architecture that'

abi: Drop aarch64 ABI reference

Maintaining the ABI dump across multiple distros let alone across
multiple architectures is too much of a headache. Let's maintain one
dump for the architecture that's used by CI (x86_64).

Change-Id: I648ad930c55d1c3929a377932dd6c4f29e0df0c6
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...