checklists: changes: Add The Byte Order Fallacy to influences

See also [1].

[1]: https://amboar.github.io/notes/2023/06/19/representations-and-design-boundaries-with-endianness.html

Change-Id: I1c

checklists: changes: Add The Byte Order Fallacy to influences

See also [1].

[1]: https://amboar.github.io/notes/2023/06/19/representations-and-design-boundaries-with-endianness.html

Change-Id: I1ca3accfd8a4940ff753f70a104b0615e49ec605
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: firmware_update: Avoid integer overflow

A large fw_device_pkg_data_length could cause uint16_t
calc_min_record_length to wrap around. Instead use a size_t.

Change-Id: I1e0ee5a350d82cb477fd0955

dsp: firmware_update: Avoid integer overflow

A large fw_device_pkg_data_length could cause uint16_t
calc_min_record_length to wrap around. Instead use a size_t.

Change-Id: I1e0ee5a350d82cb477fd0955a11ded659a5c5933
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>

show more ...

dsp: Add FD side firmware_update encode/decode

This implements FD counterparts for firmware update (type 5)
encoding/decoding.

In tests after encoding a message, a subsequent decode is performed an

dsp: Add FD side firmware_update encode/decode

This implements FD counterparts for firmware update (type 5)
encoding/decoding.

In tests after encoding a message, a subsequent decode is performed and
the outputs are compared. This tests the FD portion of the message
decoding.

Change-Id: I5454acee19588b0679a9b0218588fc4c0a66b01d
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>

show more ...

msgbuf: Add pldm_msgbuf_destroy_used()

Used when inserting int a msgbuf, returns the total length that has been
used.

Change-Id: I981c6b8a1fd194387fdf8a6a3299c3811d33c622
Signed-off-by: Matt Johnst

msgbuf: Add pldm_msgbuf_destroy_used()

Used when inserting int a msgbuf, returns the total length that has been
used.

Change-Id: I981c6b8a1fd194387fdf8a6a3299c3811d33c622
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>

show more ...

msgbuf: Add pldm_msgbuf_insert_uint64

Required for encoding firmware update non_functioning_component_bitmap

Change-Id: I3360b09150021bc30423bdc8de4936b6fa31092d
Signed-off-by: Matt Johnston <matt@

msgbuf: Add pldm_msgbuf_insert_uint64

Required for encoding firmware update non_functioning_component_bitmap

Change-Id: I3360b09150021bc30423bdc8de4936b6fa31092d
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>

show more ...

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: Ie38f1c94398df0d663d0e27d2e2e1d0d77a47fae
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

dsp: firmware_update: Add iterator for downstream device parameters

The previous attempt where we invented a struct that made it possible to
hold full-sized version strings was awkward on several fr

dsp: firmware_update: Add iterator for downstream device parameters

The previous attempt where we invented a struct that made it possible to
hold full-sized version strings was awkward on several fronts. Replace
it with an iterator in the style of the downstream device descriptors.

Change-Id: If9b83f4704b3068de9113af7451051c086f39969
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: firmware_update: Expand "params" in symbol names

Try to keep the names aligned with the spec so that they're more easily
searched for. We can abbreviate other words such as request, response,
l

dsp: firmware_update: Expand "params" in symbol names

Try to keep the names aligned with the spec so that they're more easily
searched for. We can abbreviate other words such as request, response,
length etc as necessary.

Change-Id: Ia5a2c93c153c70107be0fcddb1043b2e08cdd026
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

libpldm: Release v0.11.0

The tag updates the ABI dump to be generated with gcc-14.

Change-Id: Ia546199b003b338a6291a8778a233209115864ae
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

dsp: firmware_update: pack decomposed parameters to struct

There're two APIs that have decomposed parameters:
`encode_query_downstream_identifiers_req()` and
`encode_get_downstream_firmware_params_r

dsp: firmware_update: pack decomposed parameters to struct

There're two APIs that have decomposed parameters:
`encode_query_downstream_identifiers_req()` and
`encode_get_downstream_firmware_params_req(),
which against the checklist of API/ABI stabilization,
squashed those parameters to a struct to meet the request.

Change-Id: Ia952251cf8dcaeba060985e759e1d7aadf7b5b4d
Signed-off-by: Unive Tien <unive.tien.wiwynn@gmail.com>

show more ...

dsp: firmware_update: Change return type of downstream device ABI/APIs

So far all of the downstream device related ABI/APIs were marked as
`TESTING`, before stabilize them, any deprecated code shoul

dsp: firmware_update: Change return type of downstream device ABI/APIs

So far all of the downstream device related ABI/APIs were marked as
`TESTING`, before stabilize them, any deprecated code should be
removed, including PLDM Completion Code, therefore, change all of the
return type of these to `ERRNO`.

Change-Id: Ie6b390fcc1c91a425f9181ec4ce4495729baab51
Signed-off-by: Unive Tien <unive.tien.wiwynn@gmail.com>

show more ...

dsp: base: add encode_pldm_header_only_errno()

Currently, `encode_pldm_header_only()` returns PLDM Completion Code,
which is deprecated, but most of this API's use case were internally
inside libpld

dsp: base: add encode_pldm_header_only_errno()

Currently, `encode_pldm_header_only()` returns PLDM Completion Code,
which is deprecated, but most of this API's use case were internally
inside libpldm itself, therefore, add `encode_pldm_header_only_errno()`
as an internal API.

Change-Id: I87822a4f6afe8aa8eb87034179c37341d7ca4190
Signed-off-by: Unive Tien <unive.tien.wiwynn@gmail.com>

show more ...

meson: Make transport optional

transport and requester code has Linux-specific dependencies. Make
building those parts optional (enabled by default).

Change-Id: I1fff0e3cc0a1edb302eee664d5bccb03254

meson: Make transport optional

transport and requester code has Linux-specific dependencies. Make
building those parts optional (enabled by default).

Change-Id: I1fff0e3cc0a1edb302eee664d5bccb0325429609
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>

show more ...

dsp: pdr: Replace ENOKEY with ENOENT

Make pldm_pdr_find_child_container_id_index_range_exclude() return
ENOENT, since that is a standard errno. ENOKEY is Linux specific.

pldm_pdr_find_child_contain

dsp: pdr: Replace ENOKEY with ENOENT

Make pldm_pdr_find_child_container_id_index_range_exclude() return
ENOENT, since that is a standard errno. ENOKEY is Linux specific.

pldm_pdr_find_child_container_id_index_range_exclude() is marked as
TESTING ABI, so the change in error code should be OK.

Change-Id: I3fb3076b236e4e3b1c31f13d819dcaca38076a5d
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>

show more ...

README: Rework OEM notes

I feel the expectations are more easily expressed as a list, in which
case we don't require the diagram any longer. The diagram hadn't been
updated since we chopped libpldm

README: Rework OEM notes

I feel the expectations are more easily expressed as a list, in which
case we don't require the diagram any longer. The diagram hadn't been
updated since we chopped libpldm out of openbmc/pldm.git, and had
some minor oddities. It's not necessary to rework it if we just drop
it entirely.

Change-Id: Iea329604fee9438c1f35a8873e0b2923edb1abda
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Convert options from feature to boolean

Features are things we can automatically enable or disable based on the
presence or absence of supporting dependencies. Neither ABI compliance
testing

meson: Convert options from feature to boolean

Features are things we can automatically enable or disable based on the
presence or absence of supporting dependencies. Neither ABI compliance
testing (despite the fact that we can detect the tool) nor tests fit
this category: They are developer tools and their use should be judged
ahead of the invocation of meson.

Change-Id: I9725cc0444d92c8443cfb28ecd878f77792f38ce
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Specify OEM extensions in an array

Prevent a proliferation of options by exploiting choice-constrained
arrays.

Change-Id: I5bb5c9bfd41d2854fafee189734abcf58b058d82
Signed-off-by: Andrew Jeff

meson: Specify OEM extensions in an array

Prevent a proliferation of options by exploiting choice-constrained
arrays.

Change-Id: I5bb5c9bfd41d2854fafee189734abcf58b058d82
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Sort options file

Let's try to keep everything tidy.

Change-Id: I5e33613ceaa77ded41fc2076ba527242a40015dd
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

meson: Switch default_options to dict

As of meson 1.2.0 we can pass a dict rather than encoding settings in
a string. We already require meson 1.3.0, so take the opportunity to
improve the ergonomic

meson: Switch default_options to dict

As of meson 1.2.0 we can pass a dict rather than encoding settings in
a string. We already require meson 1.3.0, so take the opportunity to
improve the ergonomics.

Change-Id: I8ce7b5b02ddcb3150c6ff25c0ff99e8d594f3a74
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: firmware_update: Fix missing #include <span>

std::span started being used in
dec237bcdafe ("tests: firmware_update: Clean up some use of
reinterpret_cast<>()").

It is unclear why CI was OK, a

dsp: firmware_update: Fix missing #include <span>

std::span started being used in
dec237bcdafe ("tests: firmware_update: Clean up some use of
reinterpret_cast<>()").

It is unclear why CI was OK, a failure is reported with gcc
13.2.0-23ubuntu4 (building externally, not OpenBMC tools).

gitlint-ignore: UC1, B1
Fixes: dec237bcdafe ("tests: firmware_update: Clean up some use of reinterpret_cast<>()")
Change-Id: If5bfbcc72ddcbd31764d84338cf9f915c9d467a0
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>

show more ...

base: add PLDM Command numbers

Add more PLDM command numbers as table "Table 7 - PLDM Messaging
Control and Discovery Command Codes" in DSP0240 V1.2.0. These commands
will be used in pldm code as [1

base: add PLDM Command numbers

Add more PLDM command numbers as table "Table 7 - PLDM Messaging
Control and Discovery Command Codes" in DSP0240 V1.2.0. These commands
will be used in pldm code as [1].

[1] https://gerrit.openbmc.org/c/openbmc/pldm/+/75970

Change-Id: Ie265a53c7e851945a6c196528c0aa9cb34c7a146
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

platform: add PLDM Command numbers

Add more PLDM command numbers as table "Table 110 - Command numbers" in
DSP0248 V1.3.0. These commands will be used in pldm code as [1].

[1] https://gerrit.openbm

platform: add PLDM Command numbers

Add more PLDM command numbers as table "Table 110 - Command numbers" in
DSP0248 V1.3.0. These commands will be used in pldm code as [1].

[1] https://gerrit.openbmc.org/c/openbmc/pldm/+/75949

Change-Id: I07a2762c20794e227ba479710296b77cfd7a518f
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

scripts: pre-submit: Print meson format diff on failure

Like in the case of clang-format failures in OpenBMC CI, show what was
changed.

Change-Id: I5180ba948f7c9feffd6c89e8420af90dc269fcad
Signed-o

scripts: pre-submit: Print meson format diff on failure

Like in the case of clang-format failures in OpenBMC CI, show what was
changed.

Change-Id: I5180ba948f7c9feffd6c89e8420af90dc269fcad
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: pre-submit: Be informative on meson formatting failures

Previously the script just silently exited with a failure status.
That's unhelpful to people reading the CI output, so write somethin

scripts: pre-submit: Be informative on meson formatting failures

Previously the script just silently exited with a failure status.
That's unhelpful to people reading the CI output, so write something
informative.

Change-Id: Ia1b618e004c457d97d1c0f690f74567991cac830
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: pre-submit: Ensure changelog captures API updates

I think most people have fallen short of this ideal at some point, so
add an automated check.

Change-Id: Ic7d2da4d97d49d7e5f43bc341b7e1338

scripts: pre-submit: Ensure changelog captures API updates

I think most people have fallen short of this ideal at some point, so
add an automated check.

Change-Id: Ic7d2da4d97d49d7e5f43bc341b7e13381b8176e5
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...