scripts: Add abi-dump-formatter

abi-dumper uses perl's Data::Dumper without configuring the formatter,
which defaults to key-aligned indentation. That causes massive diff
churn, so provide a wrapper

scripts: Add abi-dump-formatter

abi-dumper uses perl's Data::Dumper without configuring the formatter,
which defaults to key-aligned indentation. That causes massive diff
churn, so provide a wrapper script to fix the dump formatting.

Change-Id: Id6834d9f2a8be7222036579c86448930633a796c
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

tests: Guard test functions exercising testing APIs

Otherwise when the build is configured with `-Dabi=deprecated,stable`
the test binaries will fail to link.

Change-Id: I0f7937a01f38ca12ef6a7c47d7

tests: Guard test functions exercising testing APIs

Otherwise when the build is configured with `-Dabi=deprecated,stable`
the test binaries will fail to link.

Change-Id: I0f7937a01f38ca12ef6a7c47d72e7c393a03d8f4
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

tests: Adjust expectations in accordance with -DNDEBUG

If assertions are disabled then `EXPECT_DEATH()` will fail. Guard
`EXPECT_DEATH()` calls with an NDEBUG test, and substitute an
appropriate tes

tests: Adjust expectations in accordance with -DNDEBUG

If assertions are disabled then `EXPECT_DEATH()` will fail. Guard
`EXPECT_DEATH()` calls with an NDEBUG test, and substitute an
appropriate test when it's defined.

Change-Id: I60541762aceb656c2eff03a438f314197b281f77
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

docs: Add checklists for changes and releases

This is useful for me to remember what it is that I should be doing when
making a release, but also to set expectations for contributions.

Change-Id: I

docs: Add checklists for changes and releases

This is useful for me to remember what it is that I should be doing when
making a release, but also to set expectations for contributions.

Change-Id: I06c20f2238ee47e12bc40e327264cf78ac563378
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

msgbuf: Add copy API

pldm_msgbuf_copy API allows copy of data from one msg buffer
to another. This was done earlier with a pldm_msgbuf_extract()
followed by pldm_msgbuf_insert().

Change-Id: I159792

msgbuf: Add copy API

pldm_msgbuf_copy API allows copy of data from one msg buffer
to another. This was done earlier with a pldm_msgbuf_extract()
followed by pldm_msgbuf_insert().

Change-Id: I159792f726916761894aefb0a8795f1f0dc84114
Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>

show more ...

msgbuf: Remove use of ssize_t for overflow tracking

There are a few concerns with the use of ssize_t in this context:

1. It's defined by POSIX and not C, and I'd prefer we not require POSIX
conc

msgbuf: Remove use of ssize_t for overflow tracking

There are a few concerns with the use of ssize_t in this context:

1. It's defined by POSIX and not C, and I'd prefer we not require POSIX
concepts where we can avoid it
2. ssize_t is defined over [-1, SSIZE_MAX] - it is not defined to have
the range of a regular signed type.

The source of both these statements is The Open Group Base
Specifications Issue 7, 2018 edition. IEEE Std 1003.1-2017 (Revision of
IEEE Std 1003.1-2008)

The second point directly contradicts how I was trying to use ssize_t in
the msgbuf implementation. As a result, switch the type of `remaining`
to intmax_t. Usually intmax_t is a problem child, but it's not used in
any public API, and it has the semantics I wanted by contrast to the
definition of ssize_t.

Note that we add assert() calls where we know the value of remaining
must be negative. Without the addition of the `assert()` calls in the
underflow checks, clang-analyzer gets tripped up by not being able to
prove `INTMAX_MIN + (intmax_t)sizeof(uint16_t) < 0`:

```
../src/platform.c:17:18: error: The left operand of '+' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult,-warnings-as-errors]
17 | if (ctx->length + sizeof(*ctx) < lower) {
| ^
../src/platform.c:2445:6: note: 'rc' is 0
2445 | if (rc) {
| ^~
../src/platform.c:2445:2: note: Taking false branch
2445 | if (rc) {
| ^
../src/platform.c:2449:7: note: Calling 'pldm_msgbuf_extract_value_pdr_hdr'
2449 | rc = pldm_msgbuf_extract_value_pdr_hdr(buf, &hdr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/msgbuf/platform.h:17:2: note: Calling 'pldm__msgbuf_extract_uint16'
17 | pldm_msgbuf_extract(ctx, hdr->length);
| ^
../src/msgbuf/../msgbuf.h:517:2: note: expanded from macro 'pldm_msgbuf_extract'
517 | _Generic((dst), \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
518 | uint8_t: pldm__msgbuf_extract_uint8, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
519 | int8_t: pldm__msgbuf_extract_int8, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
520 | uint16_t: pldm__msgbuf_extract_uint16, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
521 | int16_t: pldm__msgbuf_extract_int16, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
522 | uint32_t: pldm__msgbuf_extract_uint32, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
523 | int32_t: pldm__msgbuf_extract_int32, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
524 | real32_t: pldm__msgbuf_extract_real32)(ctx, (void *)&(dst))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/msgbuf/../msgbuf.h:341:7: note: 'ctx' is non-null
341 | if (!ctx || !ctx->cursor || !dst) {
| ^~~
../src/msgbuf/../msgbuf.h:341:6: note: Left side of '||' is false
341 | if (!ctx || !ctx->cursor || !dst) {
| ^
../src/msgbuf/../msgbuf.h:341:20: note: Field 'cursor' is non-null
341 | if (!ctx || !ctx->cursor || !dst) {
| ^
../src/msgbuf/../msgbuf.h:341:6: note: Left side of '||' is false
341 | if (!ctx || !ctx->cursor || !dst) {
| ^
../src/msgbuf/../msgbuf.h:341:31: note: 'dst' is non-null
341 | if (!ctx || !ctx->cursor || !dst) {
| ^~~
../src/msgbuf/../msgbuf.h:341:2: note: Taking false branch
341 | if (!ctx || !ctx->cursor || !dst) {
| ^
../src/msgbuf/../msgbuf.h:347:2: note: Taking true branch
347 | if (ctx->remaining < INTMAX_MIN + (intmax_t)sizeof(ldst)) {
| ^
../src/msgbuf/../msgbuf.h:348:3: note: Returning without writing to '*dst'
348 | return PLDM_ERROR_INVALID_LENGTH;
| ^
../src/msgbuf/platform.h:17:2: note: Returning from 'pldm__msgbuf_extract_uint16'
17 | pldm_msgbuf_extract(ctx, hdr->length);
| ^
../src/msgbuf/../msgbuf.h:517:2: note: expanded from macro 'pldm_msgbuf_extract'
517 | _Generic((dst), \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
518 | uint8_t: pldm__msgbuf_extract_uint8, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
519 | int8_t: pldm__msgbuf_extract_int8, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
520 | uint16_t: pldm__msgbuf_extract_uint16, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
521 | int16_t: pldm__msgbuf_extract_int16, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
522 | uint32_t: pldm__msgbuf_extract_uint32, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
523 | int32_t: pldm__msgbuf_extract_int32, \
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
524 | real32_t: pldm__msgbuf_extract_real32)(ctx, (void *)&(dst))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/msgbuf/platform.h:19:2: note: Returning without writing to 'hdr->length'
19 | return pldm_msgbuf_validate(ctx);
| ^
../src/platform.c:2449:7: note: Returning from 'pldm_msgbuf_extract_value_pdr_hdr'
2449 | rc = pldm_msgbuf_extract_value_pdr_hdr(buf, &hdr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/platform.c:2450:6: note: 'rc' is 0
2450 | if (rc) {
| ^~
../src/platform.c:2450:2: note: Taking false branch
2450 | if (rc) {
| ^
../src/platform.c:2454:7: note: Calling 'pldm_platform_pdr_hdr_validate'
2454 | rc = pldm_platform_pdr_hdr_validate(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2455 | &hdr, PLDM_PDR_NUMERIC_EFFECTER_PDR_MIN_LENGTH,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2456 | pdr_data_length);
| ~~~~~~~~~~~~~~~~
../src/platform.c:17:18: note: The left operand of '+' is a garbage value
17 | if (ctx->length + sizeof(*ctx) < lower) {
| ~~~~~~~~~~~ ^
```

Change-Id: Idbe5a14455ad677a39c8f535eddd9c2ce471c783
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

msgbuf: Rework detection of invalid memory regions

From Annex J.2 of N2176 (C17 draft specification):

> Addition or subtraction of a pointer into, or just beyond, an array
> object and an integer t

msgbuf: Rework detection of invalid memory regions

From Annex J.2 of N2176 (C17 draft specification):

> Addition or subtraction of a pointer into, or just beyond, an array
> object and an integer type produces a result that does not point into,
> or just beyond, the same array object (6.5.6).

Instead we can lean on uintptr_t from 7.20.1.4, and from there the
defined behavior of unsigned overflow.

Change-Id: Ia1b47b87efeb9c96057d294a3e38e90bfdba5386
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

tests: oem: meta: Fix fileio use of msgbuf

After resolving some undefined behavior regarding pointer arithmetic in
pldm_msgbuf_init(), clang-tidy detected the following:

```
clang-tidy-17 -export-f

tests: oem: meta: Fix fileio use of msgbuf

After resolving some undefined behavior regarding pointer arithmetic in
pldm_msgbuf_init(), clang-tidy detected the following:

```
clang-tidy-17 -export-fixes /tmp/tmpmu0oifam/tmpwpj83pgb.yaml -p=/home/andrew/src/openbmc.org/openbmc/libpldm/origin/buildkcgocca3 -quiet /home/andrew/src/openbmc.org/openbmc/libpldm/origin/tests/oem/meta/libpldm_fileio_test.cpp
../src/msgbuf.h:593:14: error: Branch condition evaluates to a garbage value [clang-analyzer-core.uninitialized.Branch,-warnings-as-errors]
593 | if (!ctx || !ctx->cursor) {
| ^
../tests/oem/meta/libpldm_fileio_test.cpp:26:5: note: Calling 'pldm_msgbuf_init'
26 | pldm_msgbuf_init(ctx, 0, &buf[hdrSize], sizeof(buf) - hdrSize);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/msgbuf.h:75:7: note: 'ctx' is non-null
75 | if (!ctx || !buf) {
| ^~~
../src/msgbuf.h:75:6: note: Left side of '||' is false
75 | if (!ctx || !buf) {
| ^
../src/msgbuf.h:75:15: note: 'buf' is non-null
75 | if (!ctx || !buf) {
| ^~~
../src/msgbuf.h:75:2: note: Taking false branch
75 | if (!ctx || !buf) {
| ^
../src/msgbuf.h:79:7: note: 'minsize' is <= 'len'
79 | if ((minsize > len) || (len > SSIZE_MAX)) {
| ^~~~~~~
../src/msgbuf.h:79:6: note: Left side of '||' is false
79 | if ((minsize > len) || (len > SSIZE_MAX)) {
| ^
../src/msgbuf.h:79:26: note: 'len' is <= SSIZE_MAX
79 | if ((minsize > len) || (len > SSIZE_MAX)) {
| ^~~
../src/msgbuf.h:79:2: note: Taking false branch
79 | if ((minsize > len) || (len > SSIZE_MAX)) {
| ^
../src/msgbuf.h:83:6: note: Assuming the condition is true
83 | if ((uintptr_t)buf + len < len) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
../src/msgbuf.h:83:2: note: Taking true branch
83 | if ((uintptr_t)buf + len < len) {
| ^
../src/msgbuf.h:84:3: note: Returning without writing to 'ctx->cursor'
84 | return PLDM_ERROR_INVALID_LENGTH;
| ^
../tests/oem/meta/libpldm_fileio_test.cpp:26:5: note: Returning from 'pldm_msgbuf_init'
26 | pldm_msgbuf_init(ctx, 0, &buf[hdrSize], sizeof(buf) - hdrSize);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../tests/oem/meta/libpldm_fileio_test.cpp:28:5: note: Calling 'pldm_msgbuf_insert_uint8'
28 | pldm_msgbuf_insert_uint8(ctx, fileHandle);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/msgbuf.h:593:7: note: 'ctx' is non-null
593 | if (!ctx || !ctx->cursor) {
| ^~~
../src/msgbuf.h:593:6: note: Left side of '||' is false
593 | if (!ctx || !ctx->cursor) {
| ^
../src/msgbuf.h:593:14: note: Branch condition evaluates to a garbage value
593 | if (!ctx || !ctx->cursor) {
| ^~~~~~~~~~~~
```

Fixes: 22fad3957d36 ("oem: meta: Add decode_oem_meta_file_io_req()")
Change-Id: I99f1d6f8c28a7e812b12f5ef60af5d0f0b0d1866
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

fw_update: Add encode req & decode resp for query_downtream_identifiers

Add support for Query Downstream Identifiers to ask all downstream
devices' Descriptors managed by a endpoint.

The code is de

fw_update: Add encode req & decode resp for query_downtream_identifiers

Add support for Query Downstream Identifiers to ask all downstream
devices' Descriptors managed by a endpoint.

The code is developed based on the definition of
'QueryDownstreamIdentifiers' in DSP0267_1.1.0 Section 10.4

Change-Id: I6282a894c73b78470c147e77d81e5a4ddd6a39a8
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

fw_update: Add encode req & decode resp for query_downstream_devices

Add support for Query Downstream Devices to ask if a endpoint supports
downstream devices.

The code is developed based on the de

fw_update: Add encode req & decode resp for query_downstream_devices

Add support for Query Downstream Devices to ask if a endpoint supports
downstream devices.

The code is developed based on the definition of
'QueryDownstreamDevices' in DSP0267_1.1.0. Section 10.3

Change-Id: I5925290de5023eb48f675e736429fe9f257170c8
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

oem: ibm: Support for the Real SAI entity id

This commit adds the Real SAI (System Attention Indicator) oem
entity id.

Real SAI is a physical led indicator which lights up whenever
there is a platf

oem: ibm: Support for the Real SAI entity id

This commit adds the Real SAI (System Attention Indicator) oem
entity id.

Real SAI is a physical led indicator which lights up whenever
there is a platform error (originated from BMC) or a partition
error that is not mapped to any physical FRU (Field Replaceable Unit).

The pldm commit that uses this value is
https://gerrit.openbmc.org/c/openbmc/pldm/+/48906

Change-Id: I3e070303c1a8aed236be05fbf79a402f6b1322f8
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>

show more ...

pdr: Add decode_numeric_effecter_pdr_data()

Add `decode_numeric_effecter_pdr_data` API to decode the numeric
effecter PDR data in DSP0248_1.2.2 table 87. The API will be used to
retrieve the data fi

pdr: Add decode_numeric_effecter_pdr_data()

Add `decode_numeric_effecter_pdr_data` API to decode the numeric
effecter PDR data in DSP0248_1.2.2 table 87. The API will be used to
retrieve the data fields of numeric effecter from the PDRs in `pldmd`.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I323a1288cb0262bd39f4f28701ddc7dbb70c33c8

show more ...

msgbuf: Enable pldm_msgbuf_extract() into packed members

`pldm_msgbuf_extract()` should work correctly regardless of whether the
`dst` argument is a member of a packed or padded struct.

To get ther

msgbuf: Enable pldm_msgbuf_extract() into packed members

`pldm_msgbuf_extract()` should work correctly regardless of whether the
`dst` argument is a member of a packed or padded struct.

To get there while still achieving type safety we have to jump through
some hoops. Commentary in the patch hopefully captures many of them, but
a side-effect of the hoop-jumping is a couple of changes to ergonomics
of the msgbuf API:

1. `pldm_msgbuf_extract()` no-longer requires that the `dst`
argument be a pointer. Instead, it must be an lvalue, removing all
the `&<lvalue>` noise from the call-sites.

2. However, unfortunately the generic extraction macro has been split in
two. We now have:

2.1 `pldm_msgbuf_extract()`, and
2.2 `pldm_msgbuf_extract_p()`, for when the reference we already have
for the `dst` object is a pointer and not an lvalue.

The split was necessary because I couldn't get GCC and Clang to play
nice with differences required in the assignment expression for lvalue
and pointer type-names in the one macro. Whilst it causes a bunch of
churn it isn't a great concern as the APIs are purely internal to the
library implementation.

Change-Id: Ifc5440a5b838a48bb84c881ec334d9e145365edb
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

libpldm: add enum used by some Network Controller

The network interface connectors and ports connection entity types
(along with Link State set and Redfish Device Resource PDR) are useful
for some N

libpldm: add enum used by some Network Controller

The network interface connectors and ports connection entity types
(along with Link State set and Redfish Device Resource PDR) are useful
for some NIC devices.

Change-Id: I28cd2c9db4ef3bfc9885892b41312d31a709ebbf
Signed-off-by: Jinliang Wang <jinliangw@google.com>

show more ...

changelog: Fix whitespace in `Changelog` header

0ee776642275 ("platform: Add alias members to PDRRepoChgEvent") added
some entries to the changelog, but managed to ding the top level header
whitespa

changelog: Fix whitespace in `Changelog` header

0ee776642275 ("platform: Add alias members to PDRRepoChgEvent") added
some entries to the changelog, but managed to ding the top level header
whitespace in the process. Undo that.

Fixes: 0ee776642275 ("platform: Add alias members to PDRRepoChgEvent")
Change-Id: Ie2e769e0d97d0ed2601933740ded5f145cf40542
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

OWNERS: Add Pavithra as a reviewer

I have been actively contributing to openbmc/libpldm for quite
some time now. Attached is a summary of my contributions to the
repository [1].

I would like to lea

OWNERS: Add Pavithra as a reviewer

I have been actively contributing to openbmc/libpldm for quite
some time now. Attached is a summary of my contributions to the
repository [1].

I would like to learn & help out on the reviews.

[1]: https://github.com/openbmc/libpldm/commits?author=Pavithrab7

Change-Id: I97758048c4d2aee683503bbb46d94b38b95bae29
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

oem: ibm: Add Firmware UAK as a FRU field type

The oem-ibm FRU field type enumeration is added with a new enum value
for Firmware Update Access Key (UAK) value. The PLDM commit that uses
this enum v

oem: ibm: Add Firmware UAK as a FRU field type

The oem-ibm FRU field type enumeration is added with a new enum value
for Firmware Update Access Key (UAK) value. The PLDM commit that uses
this enum value is [oem-ibm: Access key update support][1]

[1]: https://gerrit.openbmc.org/c/openbmc/pldm/+/49054

Change-Id: I50f12be1dd1a92ad11431e5b2b9573e54b50d1e1
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

oem-ibm: Alias pldm_oem_ibm_fru_field_type members as PLDM_OEM_IBM_*

The oem-ibm FRU field type enumeration did not have a IBM prefix in
their enum values. This change is done to give more consisten

oem-ibm: Alias pldm_oem_ibm_fru_field_type members as PLDM_OEM_IBM_*

The oem-ibm FRU field type enumeration did not have a IBM prefix in
their enum values. This change is done to give more consistent names to
the enum constants.

The older version of these duplicate constants will be removed once a
tag containing the new members has been created.

Change-Id: Ibba743c24dc6f41b767e88e27b843a49f8731f5d
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

platform: Add alias members to PDRRepoChgEvent

Alias constants are added in pldmPDRRepositoryChgEvent
changeRecord event data operation enum. This is done
to give more consistent names to the enum c

platform: Add alias members to PDRRepoChgEvent

Alias constants are added in pldmPDRRepositoryChgEvent
changeRecord event data operation enum. This is done
to give more consistent names to the enum constants.
The older version of these duplicate constants will be
removed after backward compatibility is taken care.

See CHANGELOG.md for more information on this enum.

Change-Id: Ie30f9034d4ca12abd5d2a4b3e584e0f63f55e56b
Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>

show more ...

state-set: Add all system power states (set ID 260)

System power state defines power states of a system
or an entity in the system.

Change-Id: If9b08b6e954fc3d73e98df7307aa7b397f04707c
Signed-off-b

state-set: Add all system power states (set ID 260)

System power state defines power states of a system
or an entity in the system.

Change-Id: If9b08b6e954fc3d73e98df7307aa7b397f04707c
Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>

show more ...

oem: ibm: Add PCIe slot sensor/effector StateSetId

Adds sensor and effecter state set IDs for all the
PCIe Slots & adapters present on BMC. Possible
conditions of the PLDM_ENTITY_SLOT type of entity

oem: ibm: Add PCIe slot sensor/effector StateSetId

Adds sensor and effecter state set IDs for all the
PCIe Slots & adapters present on BMC. Possible
conditions of the PLDM_ENTITY_SLOT type of entity
are defined by PLDM_OEM_IBM_SLOT_ENABLE_SENSOR_STATE.

Slot sensor state set ID is required to find the sensor
state of the PCIE slot. Sensor state value of a PCIE
slot can be enabled, disabled or unknown.

PCIE slot is enabled with the effector state set ID
defined with this commit.

Tested By: Using pldmtool set effecter state and read
sensor state for PCIE slot was verified for this change

1.pldmtool platform SetStateEffecterStates -i 124 -c 1 -d 01 02 -v
2.pldmtool platform GetStateSensorReadings -i 208 -r 01

Change-Id: I87f4f76ff6f3dc6e15b4677ad42e7b28e1c40aa2
Signed-off-by: Varsha Kaverappa <vkaverap@in.ibm.com>

show more ...

libpldm: Change hexadecimal literals to lowercase

As per a comment at [1].

The change was generated with the following:

```
sed -Ei 's/0[xX]([0-9]*[A-F][0-9]*)+/\L\0/g' $(git ls-files)
```

[1]: h

libpldm: Change hexadecimal literals to lowercase

As per a comment at [1].

The change was generated with the following:

```
sed -Ei 's/0[xX]([0-9]*[A-F][0-9]*)+/\L\0/g' $(git ls-files)
```

[1]: https://gerrit.openbmc.org/c/openbmc/libpldm/+/69192

Change-Id: Ib0a41dfaf626aec3167e773262883f9c1de797b2
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

oem-ibm : Add an enum for oem-ibm FRU type

The oem-ibm FRU field type enumeration is added with a
new enum value for PCIE Config Space Data. The PLDM commit
that uses this enum value is
https://gerr

oem-ibm : Add an enum for oem-ibm FRU type

The oem-ibm FRU field type enumeration is added with a
new enum value for PCIE Config Space Data. The PLDM commit
that uses this enum value is
https://gerrit.openbmc.org/c/openbmc/pldm/+/45144.

Change-Id: Ifbac52020677f1361c9a79c0008c2d0d7e75e5dc
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

state-set: Add the enum for Device Power State

As per the spec DSP0249 the PLDM state set Device
Power State [Set ID: 257] can have four enumeration
values defined. This commit adds the unknown, on

state-set: Add the enum for Device Power State

As per the spec DSP0249 the PLDM state set Device
Power State [Set ID: 257] can have four enumeration
values defined. This commit adds the unknown, on
and off state in enum for the same.

Change-Id: I8565df98006c183df50d8220db02fdb61a3eae04
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

oem-ibm: User password file types support

This commit adds the new file types for user password authentication
and user password change.

If host passes the username and password credentials to the

oem-ibm: User password file types support

This commit adds the new file types for user password authentication
and user password change.

If host passes the username and password credentials to the BMC, it
should support below requirements through any password validation
mechanism (Ex: PAM module)
1. Password authentication
2. Password change if the password has been expired

Change-Id: I2daa1e6388d1a2abf8193453728ef8a80b3b24b7
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>

show more ...