dsp: bios_table: Rename pldm_bios_table_attr_value_entry_encode_enum_check()

Introduce pldm_bios_table_attr_value_entry_encode_enum(), deprecate
pldm_bios_table_attr_value_entry_encode_enum_check(),

dsp: bios_table: Rename pldm_bios_table_attr_value_entry_encode_enum_check()

Introduce pldm_bios_table_attr_value_entry_encode_enum(), deprecate
pldm_bios_table_attr_value_entry_encode_enum_check(), add rename
configuration and apply it.

gitlint-ignore: T1
Change-Id: I8fe0da169b9acc919d01ba024503e72fd2792d4e
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_attr_entry_integer_encode_check()

Introduce pldm_bios_table_attr_entry_integer_encode(), deprecate
pldm_bios_table_attr_entry_integer_encode_check(), add rena

dsp: bios_table: Rename pldm_bios_table_attr_entry_integer_encode_check()

Introduce pldm_bios_table_attr_entry_integer_encode(), deprecate
pldm_bios_table_attr_entry_integer_encode_check(), add rename
configuration and apply it.

gitlint-ignore: T1
Change-Id: I4ad074babfa33e661cb5b0791cc539453dbd27c7
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_attr_entry_string_decode_def_string_length_check()

Introduce
pldm_bios_table_attr_entry_string_decode_def_string_length(), deprecate
pldm_bios_table_attr_entr

dsp: bios_table: Rename pldm_bios_table_attr_entry_string_decode_def_string_length_check()

Introduce
pldm_bios_table_attr_entry_string_decode_def_string_length(), deprecate
pldm_bios_table_attr_entry_string_decode_def_string_length_check(), add
the rename configuration and apply it.

As a consequence clang-tidy detected the following, though it's unclear
why it was not detected previously:

```
clang-tidy-17 -export-fixes /tmp/tmpf4lalo2j/tmpkiyu1sgy.yaml -p=/home/andrew/src/openbmc.org/openbmc/libpldm/origin/build1qcxy8ww -quiet /home/andrew/src/openbmc.org/openbmc/libpldm/origin/src/dsp/bios_table.c
../src/dsp/bios_table.c:460:2: error: Null pointer passed to 2nd parameter expecting 'nonnull' [clang-analyzer-core.NonNullParamChecker,-warnings-as-errors]
460 | memcpy(buffer, fields->def_string, length);
| ^ ~~~~~~~~~~~~~~~~~~
../src/dsp/bios_table.c:457:11: note: Assuming the condition is true
457 | length = length < (size - 1) ? length : (size - 1);
| ^~~~~~~~~~~~~~~~~~~
../src/dsp/bios_table.c:457:11: note: '?' condition is true
../src/dsp/bios_table.c:460:2: note: Null pointer passed to 2nd parameter expecting 'nonnull'
460 | memcpy(buffer, fields->def_string, length);
| ^ ~~~~~~~~~~~~~~~~~~
```

gitlint-ignore: T1, B1
Change-Id: Ic390e00f520cb3d5e479604b34939cefd09e9448
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_attr_entry_string_encode_check()

Introduce pldm_bios_table_attr_entry_string_encode(), deprecate
pldm_bios_table_attr_entry_string_encode_check(), add the ren

dsp: bios_table: Rename pldm_bios_table_attr_entry_string_encode_check()

Introduce pldm_bios_table_attr_entry_string_encode(), deprecate
pldm_bios_table_attr_entry_string_encode_check(), add the rename
configuration and apply it.

Change-Id: I7c2b70784dd91757723857ca9544d9462937a8a7
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()

Introduce pldm_bios_table_attr_entry_enum_decode_pv_hdls(), deprecate
pldm_bios_table_attr_entry_enum_decode_pv_hdls_ch

dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()

Introduce pldm_bios_table_attr_entry_enum_decode_pv_hdls(), deprecate
pldm_bios_table_attr_entry_enum_decode_pv_hdls_check(), add the rename
configuration and apply it.

gitlint-ignore: T1
Change-Id: I29b4d24ce0bbb92ff0491c2abae4b512d4374e74
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_def_num_check()

Introduce pldm_bios_table_attr_entry_enum_decode_def_num(), deprecate
pldm_bios_table_attr_entry_enum_decode_def_num_ch

dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_def_num_check()

Introduce pldm_bios_table_attr_entry_enum_decode_def_num(), deprecate
pldm_bios_table_attr_entry_enum_decode_def_num_check(), add the rename
configuration and apply it.

gitlint-ignore: T1
Change-Id: Ia0eec8050e39f2ee45c350386af32bd5c37135c5
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_pv_num_check()

Introduce `pldm_bios_table_attr_entry_enum_decode_pv_num()`, deprecate
`pldm_bios_table_attr_entry_enum_decode_pv_num_ch

dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_pv_num_check()

Introduce `pldm_bios_table_attr_entry_enum_decode_pv_num()`, deprecate
`pldm_bios_table_attr_entry_enum_decode_pv_num_check()`, add the rename
configuration and apply it.

gitlint-ignore: T1
Change-Id: Ifb34736e9c1a31ad15649e556dcb6e3c98890f07
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_encode_check()

Introduce pldm_bios_table_attr_entry_enum_encode(), deprecate
pldm_bios_table_attr_entry_enum_encode_check(), add the rename
co

dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_encode_check()

Introduce pldm_bios_table_attr_entry_enum_encode(), deprecate
pldm_bios_table_attr_entry_enum_encode_check(), add the rename
configuration and apply it.

Change-Id: I52586f960c5bda2a8c839d27c95bd65ca90c831f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_string_entry_decode_string_check()

Introduce pldm_bios_table_string_entry_decode_string(), deprecate
pldm_bios_table_string_entry_decode_string_check(), add t

dsp: bios_table: Rename pldm_bios_table_string_entry_decode_string_check()

Introduce pldm_bios_table_string_entry_decode_string(), deprecate
pldm_bios_table_string_entry_decode_string_check(), add the rename
configuration and apply it.

gitlint-ignore: T1
Change-Id: Ia204acd95d9e1d9bc80d91dd0ff6ffea3a1fe243
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_string_entry_encode_check()

Introduce pldm_bios_table_string_entry_encode(), deprecate
pldm_bios_table_string_entry_encode_check(), add the rename
configurati

dsp: bios_table: Rename pldm_bios_table_string_entry_encode_check()

Introduce pldm_bios_table_string_entry_encode(), deprecate
pldm_bios_table_string_entry_encode_check(), add the rename
configuration and apply it.

Change-Id: I3a75320fde4be6bf913b3eb9b56ccacc11abf511
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: pdr: Rename pldm_entity_association_pdr_add_from_node_check()

Introduce pldm_entity_association_pdr_add_from_node(), deprecate
pldm_entity_association_pdr_add_from_node_check(), add the rename

dsp: pdr: Rename pldm_entity_association_pdr_add_from_node_check()

Introduce pldm_entity_association_pdr_add_from_node(), deprecate
pldm_entity_association_pdr_add_from_node_check(), add the rename
configuration and apply it.

Change-Id: Id4f20365115977810491e8feb465042e51e3a267
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: pdr: Rename pldm_entity_association_pdr_add_check()

Introduce pldm_entity_association_pdr_add(), deprecate
pldm_entity_association_pdr_add_check(), add the rename configuration
and then apply i

dsp: pdr: Rename pldm_entity_association_pdr_add_check()

Introduce pldm_entity_association_pdr_add(), deprecate
pldm_entity_association_pdr_add_check(), add the rename configuration
and then apply it.

One quirk this time around is that we had forgotten to remove the
declaration of pldm_entity_association_pdr_add() from the header when we
removed its implementation. Clean this issue up as well, as it's
necessary to avoid the type conflict.

Change-Id: Id8e61c817017dd7caefa9fd7b2bc59ee0f1f6721
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: pdr: Rename pldm_pdr_add_fru_record_set_check()

Drop the `_check` suffix so it is now `pldm_pdr_add_fru_record_set()`,
and run `apply-renames` to update any internal references.

Change-Id: Iaa

dsp: pdr: Rename pldm_pdr_add_fru_record_set_check()

Drop the `_check` suffix so it is now `pldm_pdr_add_fru_record_set()`,
and run `apply-renames` to update any internal references.

Change-Id: Iaaa452269caa47369c80b43bf65f30d2a004ec66
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: pdr: Rename pldm_pdr_add_check()

Drop the `_check` suffix so it is now `pldm_pdr_add()`.

Change-Id: I9b32317f99a89acbe1cc0510380cd26badd145d6
Signed-off-by: Andrew Jeffery <andrew@codeconstruc

dsp: pdr: Rename pldm_pdr_add_check()

Drop the `_check` suffix so it is now `pldm_pdr_add()`.

Change-Id: I9b32317f99a89acbe1cc0510380cd26badd145d6
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: Add abi-dump-updater

The intent is to run this from inside an instance of the OpenBMC CI
docker container.

Change-Id: I02dd4e8b100d02f44ce540137decfb66f5481488
Signed-off-by: Andrew Jeffer

scripts: Add abi-dump-updater

The intent is to run this from inside an instance of the OpenBMC CI
docker container.

Change-Id: I02dd4e8b100d02f44ce540137decfb66f5481488
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

evolutions: Replace coccinelle script with clang-rename config

As mentioned previously, coccinelle struggles to parse C++. As
such, replace the one coccinelle script so far with the clang-rename
equ

evolutions: Replace coccinelle script with clang-rename config

As mentioned previously, coccinelle struggles to parse C++. As
such, replace the one coccinelle script so far with the clang-rename
equivalent.

Change-Id: Ic2d971d3aeaf223345add01e1d26c23491015c05
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: Add apply-renames based on clang-rename

It turns out coccinelle is not so great at parsing C++. At the moment
the transformations we're interested in are renames, so let's at least
leverage

scripts: Add apply-renames based on clang-rename

It turns out coccinelle is not so great at parsing C++. At the moment
the transformations we're interested in are renames, so let's at least
leverage something that can parse C++ for them.

scripts/apply-renames tries to automate the invocation of clang-rename
in a way that avoids most of the foot-guns.

Change-Id: I2f69a8301010f0f00f5fa0337b7921498ae125f9
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

README.md: Fix MD014 warnings

The following warnings are generated by using markdownlint analysis:
```
MD014/commands-show-output Dollar signs used before commands without showing output [Context: "

README.md: Fix MD014 warnings

The following warnings are generated by using markdownlint analysis:
```
MD014/commands-show-output Dollar signs used before commands without showing output [Context: "$ meson setup ... -Dlibpldm:ab..."]
```
Refer to markdown-lint [1] to fix MD014
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/014-commands-show-output.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ib65ad072e91e49f7b04efcabe129c83b2c0b0edb

show more ...

README.md: Fix MD010 warnings

The following warnings are generated by using markdownlint analysis:
```
README.md:150:1 MD010/no-hard-tabs Hard tabs [Column: 1]
README.md:151:1 MD010/no-hard-tabs Har

README.md: Fix MD010 warnings

The following warnings are generated by using markdownlint analysis:
```
README.md:150:1 MD010/no-hard-tabs Hard tabs [Column: 1]
README.md:151:1 MD010/no-hard-tabs Hard tabs [Column: 1]
README.md:152:1 MD010/no-hard-tabs Hard tabs [Column: 1]
```
Refer to markdown-lint [1] to fix MD010
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/010-no-hard-tabs.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7066e286d1b8849f311fef0472f8766ada0dd05e

show more ...

CHANGELOG.md: Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
MD034/no-bare-urls Bare URL used [Context: "https://github.com/openbmc/ope..."]
```
Refer to

CHANGELOG.md: Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
MD034/no-bare-urls Bare URL used [Context: "https://github.com/openbmc/ope..."]
```
Refer to markdown-lint [1] to fix MD034
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/034-no-bare-urls.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7e73269fd0eed59d2c3e79a7977853ffb6a5ac8f

show more ...

CHANGELOG.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "``

CHANGELOG.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia2464d3309541710d44ce3004e642a714362a36d

show more ...

docs: checklists: Add Alexis King's name to Parse, don't validate

The other entries list the author, let's keep that going.

Change-Id: Id2f9c9f3b24d81537e0cf52f00547f1eba112d9e
Signed-off-by: Andre

docs: checklists: Add Alexis King's name to Parse, don't validate

The other entries list the author, let's keep that going.

Change-Id: Id2f9c9f3b24d81537e0cf52f00547f1eba112d9e
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

docs: checklists: Add CWE as a reference

Common Weakness Enumeration is a collection of error categories that can
occur at various points in the software lifecycle.

Change-Id: I0da19a96505536780d13

docs: checklists: Add CWE as a reference

Common Weakness Enumeration is a collection of error categories that can
occur at various points in the software lifecycle.

Change-Id: I0da19a96505536780d131be5659566713f7237fe
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

platform: Stabilise decode_pldm_message_poll_event_data() APIs

See usage example at:
[1] https://gerrit.openbmc.org/c/openbmc/pldm/+/73033/1/platform-mc/event_manager.cpp#126

Change-Id: Ic680a514b2

platform: Stabilise decode_pldm_message_poll_event_data() APIs

See usage example at:
[1] https://gerrit.openbmc.org/c/openbmc/pldm/+/73033/1/platform-mc/event_manager.cpp#126

Change-Id: Ic680a514b224d366cc00fa291f2da45dde77950a
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

platform: Rework decode/encode_pldm_message_poll_event_data() APIs

Adds `struct pldm_message_poll_event` which includes `format_version`,
`event_id` and `data_transfer_handle` in `pldmMessagePollEve

platform: Rework decode/encode_pldm_message_poll_event_data() APIs

Adds `struct pldm_message_poll_event` which includes `format_version`,
`event_id` and `data_transfer_handle` in `pldmMessagePollEvent` data.
Rework decode/encode_pldm_message_poll_event_data() APIs to use `struct
pldm_message_poll_event poll_event` as parameter.

Change-Id: I01c643ed320b17141d89068cb3e00b1a99162d77
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...