bios_table: Remove pldm_bios_table_attr_entry_enum_decode_pv_num_check()

Deprecated prior to v0.9.0.

Change-Id: I03c297167ec79cb5cf77423d473c2bc944ff7e30
Signed-off-by: Andrew Jeffery <andrew@codec

bios_table: Remove pldm_bios_table_attr_entry_enum_decode_pv_num_check()

Deprecated prior to v0.9.0.

Change-Id: I03c297167ec79cb5cf77423d473c2bc944ff7e30
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

bios_table: Remove pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()

Deprecated prior to v0.9.0.

gitlint-ignore: T1
Change-Id: I56f2c06b511ec02642b9d4fc80be49b990665dd2
Signed-off-by: Andrew J

bios_table: Remove pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()

Deprecated prior to v0.9.0.

gitlint-ignore: T1
Change-Id: I56f2c06b511ec02642b9d4fc80be49b990665dd2
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

bios_table: Remove pldm_bios_table_attr_entry_enum_decode_def_num_check()

Deprecated prior to v0.9.0.

gitlint-ignore: T1
Change-Id: Ie282b6265393b835640cc7831851b30c09183f49
Signed-off-by: Andrew J

bios_table: Remove pldm_bios_table_attr_entry_enum_decode_def_num_check()

Deprecated prior to v0.9.0.

gitlint-ignore: T1
Change-Id: Ie282b6265393b835640cc7831851b30c09183f49
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

bios_table: Remove pldm_bios_table_append_pad_checksum_check()

Deprecated prior to v0.9.0.

Change-Id: I8aac1c7d4cfeab795a05d0d3aa5acccd0bd7d905
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.c

bios_table: Remove pldm_bios_table_append_pad_checksum_check()

Deprecated prior to v0.9.0.

Change-Id: I8aac1c7d4cfeab795a05d0d3aa5acccd0bd7d905
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

libpldm: Release v0.9.1

Change-Id: I5f7349b9661f42b317413ea083bca6f8ac77beaf
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

checklists: releases: Add note about moving evolutions

Evolutions for the current release need to be moved into the directory
named after the release.

Change-Id: Id6afc46e7042d88b627dd110b119defd00

checklists: releases: Add note about moving evolutions

Evolutions for the current release need to be moved into the directory
named after the release.

Change-Id: Id6afc46e7042d88b627dd110b119defd00d9571b
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: apply-renames: Update default clang version to 18

clang 18.1.8 is currently installed in the OpenBMC CI container.
Changing the default saves having to explicitly invoke `scripts/
apply-ren

scripts: apply-renames: Update default clang version to 18

clang 18.1.8 is currently installed in the OpenBMC CI container.
Changing the default saves having to explicitly invoke `scripts/
apply-renames` with `CLANG_VERSION=18`.

Change-Id: I2f0ff5baf485a34089dc663cb5870efa36f3c3c6
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: pre-submit: Run release buildtype tests under valgrind

This is the most important case due to release builds disabling
assertions and potentially changing optimization levels and so-forth,

scripts: pre-submit: Run release buildtype tests under valgrind

This is the most important case due to release builds disabling
assertions and potentially changing optimization levels and so-forth,
where undefined behavior gets its opportunity to shine.

Change-Id: If195a50c7156fcda164fee14ed6071ecd79c019f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Format build files with `meson format`

Additionally, add the formatting command to `scripts/pre-submit` so it's
run by OpenBMC's CI (via `scripts/run-ci`).

Change-Id: Ifb8fc06106b8cfa9155e98

meson: Format build files with `meson format`

Additionally, add the formatting command to `scripts/pre-submit` so it's
run by OpenBMC's CI (via `scripts/run-ci`).

Change-Id: Ifb8fc06106b8cfa9155e986528b769a5ca450b4c
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

libpldm: Release v0.9.0

Change-Id: Ie5aec47dafb5e103d29b96fc6712d3ac75d5c987
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

platform: Stabilise decode_pldm_platform_cper_event API

See usage example at:
[1] https://gerrit.openbmc.org/c/openbmc/pldm/+/63028/86/platform-mc/event_manager.cpp#77

Change-Id: I43c5c807f10ac38ee

platform: Stabilise decode_pldm_platform_cper_event API

See usage example at:
[1] https://gerrit.openbmc.org/c/openbmc/pldm/+/63028/86/platform-mc/event_manager.cpp#77

Change-Id: I43c5c807f10ac38ee893e65a9d75fca76312d188
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

compiler: Provide LIBPLDM_CC_NONNULL{,_ARGS()}

This allows us to elide checks where they're not necessary, and warn
people at compile-time when they're doing things they shouldn't.

Note that this c

compiler: Provide LIBPLDM_CC_NONNULL{,_ARGS()}

This allows us to elide checks where they're not necessary, and warn
people at compile-time when they're doing things they shouldn't.

Note that this comes with an apparent ABI break. abi-compliance-checker
reports:

```
platform.h, libpldm.so.0.8.0
[−] decode_sensor_op_data ( uint8_t const* sensor_data, size_t sensor_data_length, uint8_t* present_op_state, uint8_t* previous_op_state )
Change: The parameter previous_op_state became passed in r8 register instead of rcx.
Effect Applications will read the wrong memory block instead of the parameter value.
```

It's unclear to me why. The signature hasn't changed, but how the
implementation tests the parameter values has.

Change-Id: Ie8d8bc1641280522532d9b4764bf07c64b1921c8
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

msgbuf: Harden pldm_msgbuf_{insert,extract}_array()

Review of some proposed APIs suggested that correct use of the
pldm_msgbuf_{insert,extract}_array() helpers was more difficult that it
should be.

msgbuf: Harden pldm_msgbuf_{insert,extract}_array()

Review of some proposed APIs suggested that correct use of the
pldm_msgbuf_{insert,extract}_array() helpers was more difficult that it
should be. In the three-parameter form, it was too tempting to provide
the length to extract as parsed out of a PLDM message. The intended
use was that the length parameter represented the length of the
user-provided data buffer.

Instead, move to a four-parameter form, provide reasonable documentation
for how these APIs should be used, fix all the call-sites, and deprecate
some existing unsafe APIs.

Change-Id: If58e5574600e80b354f383554283c4eda5d7234c
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

compiler: Provide LIBPLDM_CC_ALWAYS_INLINE

Using it through the code-base reduces some of the source noise, and
gives us a way to control the definition going forward.

Change-Id: I27e76cbae5c45f0ef

compiler: Provide LIBPLDM_CC_ALWAYS_INLINE

Using it through the code-base reduces some of the source noise, and
gives us a way to control the definition going forward.

Change-Id: I27e76cbae5c45f0efd64b01fb9a8b243a6c8e65d
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

docs: checklists: Capture no-unused-structs in changes checklist

Unused structs become an API headache - dependent applications can come
to rely on them despite them having no use by the library.

P

docs: checklists: Capture no-unused-structs in changes checklist

Unused structs become an API headache - dependent applications can come
to rely on them despite them having no use by the library.

Provide advice to avoid them altogether.

Change-Id: Ic68d725e5f7b569e77f429e858a69085cde1fb2e
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

platform: Remove `_data` suffix from `cper_event` decode API

Rename `decode_pldm_platform_cper_event_data` to
`decode_pldm_platform_cper_event` as the API does not decode the CPER
data, it decodes t

platform: Remove `_data` suffix from `cper_event` decode API

Rename `decode_pldm_platform_cper_event_data` to
`decode_pldm_platform_cper_event` as the API does not decode the CPER
data, it decodes the event message.

Change-Id: I0937f043e4d3836f20733f78ea3f5970da6585d5
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ifa6971bf40e5bfddc7693

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ifa6971bf40e5bfddc76935308027472806c48c4b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

compiler: Provide LIBPLDM_CC_UNUSED

Ensure that we have __has_attribute available, and then further
ensure that the unused attribute is provided. Once satisfied, define
LIBPDLM_CC_UNUSED and replace

compiler: Provide LIBPLDM_CC_UNUSED

Ensure that we have __has_attribute available, and then further
ensure that the unused attribute is provided. Once satisfied, define
LIBPDLM_CC_UNUSED and replace raw use of __attribute__((unused)).

Change-Id: I2433039297d5fdedb8b8d99b30e73e4542d9069f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I0af2024502c08b1060bb6beb0895108459f00d48
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

docs: checklists: Codec functions must take a message struct

Some reasoning is provided as well.

Change-Id: Ic0fc7ff16b58ceff3a1ab8c08923b16de4353e33
Signed-off-by: Andrew Jeffery <andrew@codeconst

docs: checklists: Codec functions must take a message struct

Some reasoning is provided as well.

Change-Id: Ic0fc7ff16b58ceff3a1ab8c08923b16de4353e33
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

platform: Add decode_pldm_cper_event_data() API

Support decoder for `cperEvent` event class as table `Table 27 -
CPEREvent class eventData format` in DSP0248 V1.3.0.

Change-Id: I6165980e0570bbb2115

platform: Add decode_pldm_cper_event_data() API

Support decoder for `cperEvent` event class as table `Table 27 -
CPEREvent class eventData format` in DSP0248 V1.3.0.

Change-Id: I6165980e0570bbb21158af9e6adee15894b3bf3a
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

libpldm: Introduce LIBPLDM_CC_COUNTED_BY()

The macro wraps __attribute__((counted_by(x))) if compiler support
is available. The `counted_by(...)` attribute gives the compiler the
necessary informati

libpldm: Introduce LIBPLDM_CC_COUNTED_BY()

The macro wraps __attribute__((counted_by(x))) if compiler support
is available. The `counted_by(...)` attribute gives the compiler the
necessary information to track invalid accesses for flexible array
members.

See the related GCC documentation at [1].

[1]: https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html#index-counted_005fby-variable-attribute

Change-Id: If87e022d27df03b7e882df95f8c2452a4d4b828f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_append_pad_checksum_check()

Introduce pldm_bios_table_append_pad_checksum(), deprecate
pldm_bios_table_append_pad_checksum_check(), add rename configuration
a

dsp: bios_table: Rename pldm_bios_table_append_pad_checksum_check()

Introduce pldm_bios_table_append_pad_checksum(), deprecate
pldm_bios_table_append_pad_checksum_check(), add rename configuration
and apply it.

Change-Id: I77e79f4be6cecbac87b47d2140e1714b519c4e8d
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_attr_value_entry_encode_integer_check()

Introduce pldm_bios_table_attr_value_entry_encode_integer(), deprecate
pldm_bios_table_attr_value_entry_encode_integer

dsp: bios_table: Rename pldm_bios_table_attr_value_entry_encode_integer_check()

Introduce pldm_bios_table_attr_value_entry_encode_integer(), deprecate
pldm_bios_table_attr_value_entry_encode_integer_check(), add rename
configuration and apply it.

gitlint-ignore: T1
Change-Id: I7832752518592e69f8d64ac57d2724345b096729
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: bios_table: Rename pldm_bios_table_attr_value_entry_encode_string_check()

Introduce pldm_bios_table_attr_value_entry_encode_string(), deprecate
pldm_bios_table_attr_value_entry_encode_string_ch

dsp: bios_table: Rename pldm_bios_table_attr_value_entry_encode_string_check()

Introduce pldm_bios_table_attr_value_entry_encode_string(), deprecate
pldm_bios_table_attr_value_entry_encode_string_check, add rename
configuration and apply it.

gitlint-ignore: T1
Change-Id: I7f785aca80a8115bc5e6c60be40ac23ac3e322f1
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...