1a3983ce | 29-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_attr_value_entry_encode_string_check()
Introduce pldm_bios_table_attr_value_entry_encode_string(), deprecate pldm_bios_table_attr_value_entry_encode_string_ch
dsp: bios_table: Rename pldm_bios_table_attr_value_entry_encode_string_check()
Introduce pldm_bios_table_attr_value_entry_encode_string(), deprecate pldm_bios_table_attr_value_entry_encode_string_check, add rename configuration and apply it.
gitlint-ignore: T1 Change-Id: I7f785aca80a8115bc5e6c60be40ac23ac3e322f1 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
09004d6a | 29-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_attr_value_entry_encode_enum_check()
Introduce pldm_bios_table_attr_value_entry_encode_enum(), deprecate pldm_bios_table_attr_value_entry_encode_enum_check(),
dsp: bios_table: Rename pldm_bios_table_attr_value_entry_encode_enum_check()
Introduce pldm_bios_table_attr_value_entry_encode_enum(), deprecate pldm_bios_table_attr_value_entry_encode_enum_check(), add rename configuration and apply it.
gitlint-ignore: T1 Change-Id: I8fe0da169b9acc919d01ba024503e72fd2792d4e Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
5347e279 | 29-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_attr_entry_integer_encode_check()
Introduce pldm_bios_table_attr_entry_integer_encode(), deprecate pldm_bios_table_attr_entry_integer_encode_check(), add rena
dsp: bios_table: Rename pldm_bios_table_attr_entry_integer_encode_check()
Introduce pldm_bios_table_attr_entry_integer_encode(), deprecate pldm_bios_table_attr_entry_integer_encode_check(), add rename configuration and apply it.
gitlint-ignore: T1 Change-Id: I4ad074babfa33e661cb5b0791cc539453dbd27c7 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
c668ffce | 25-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_attr_entry_string_decode_def_string_length_check()
Introduce pldm_bios_table_attr_entry_string_decode_def_string_length(), deprecate pldm_bios_table_attr_entr
dsp: bios_table: Rename pldm_bios_table_attr_entry_string_decode_def_string_length_check()
Introduce pldm_bios_table_attr_entry_string_decode_def_string_length(), deprecate pldm_bios_table_attr_entry_string_decode_def_string_length_check(), add the rename configuration and apply it.
As a consequence clang-tidy detected the following, though it's unclear why it was not detected previously:
``` clang-tidy-17 -export-fixes /tmp/tmpf4lalo2j/tmpkiyu1sgy.yaml -p=/home/andrew/src/openbmc.org/openbmc/libpldm/origin/build1qcxy8ww -quiet /home/andrew/src/openbmc.org/openbmc/libpldm/origin/src/dsp/bios_table.c ../src/dsp/bios_table.c:460:2: error: Null pointer passed to 2nd parameter expecting 'nonnull' [clang-analyzer-core.NonNullParamChecker,-warnings-as-errors] 460 | memcpy(buffer, fields->def_string, length); | ^ ~~~~~~~~~~~~~~~~~~ ../src/dsp/bios_table.c:457:11: note: Assuming the condition is true 457 | length = length < (size - 1) ? length : (size - 1); | ^~~~~~~~~~~~~~~~~~~ ../src/dsp/bios_table.c:457:11: note: '?' condition is true ../src/dsp/bios_table.c:460:2: note: Null pointer passed to 2nd parameter expecting 'nonnull' 460 | memcpy(buffer, fields->def_string, length); | ^ ~~~~~~~~~~~~~~~~~~ ```
gitlint-ignore: T1, B1 Change-Id: Ic390e00f520cb3d5e479604b34939cefd09e9448 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
f6be4933 | 25-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_attr_entry_string_encode_check()
Introduce pldm_bios_table_attr_entry_string_encode(), deprecate pldm_bios_table_attr_entry_string_encode_check(), add the ren
dsp: bios_table: Rename pldm_bios_table_attr_entry_string_encode_check()
Introduce pldm_bios_table_attr_entry_string_encode(), deprecate pldm_bios_table_attr_entry_string_encode_check(), add the rename configuration and apply it.
Change-Id: I7c2b70784dd91757723857ca9544d9462937a8a7 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
82b4d3b4 | 25-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()
Introduce pldm_bios_table_attr_entry_enum_decode_pv_hdls(), deprecate pldm_bios_table_attr_entry_enum_decode_pv_hdls_ch
dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()
Introduce pldm_bios_table_attr_entry_enum_decode_pv_hdls(), deprecate pldm_bios_table_attr_entry_enum_decode_pv_hdls_check(), add the rename configuration and apply it.
gitlint-ignore: T1 Change-Id: I29b4d24ce0bbb92ff0491c2abae4b512d4374e74 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
46673f4a | 25-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_def_num_check()
Introduce pldm_bios_table_attr_entry_enum_decode_def_num(), deprecate pldm_bios_table_attr_entry_enum_decode_def_num_ch
dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_def_num_check()
Introduce pldm_bios_table_attr_entry_enum_decode_def_num(), deprecate pldm_bios_table_attr_entry_enum_decode_def_num_check(), add the rename configuration and apply it.
gitlint-ignore: T1 Change-Id: Ia0eec8050e39f2ee45c350386af32bd5c37135c5 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
b06882f1 | 25-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_pv_num_check()
Introduce `pldm_bios_table_attr_entry_enum_decode_pv_num()`, deprecate `pldm_bios_table_attr_entry_enum_decode_pv_num_ch
dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_decode_pv_num_check()
Introduce `pldm_bios_table_attr_entry_enum_decode_pv_num()`, deprecate `pldm_bios_table_attr_entry_enum_decode_pv_num_check()`, add the rename configuration and apply it.
gitlint-ignore: T1 Change-Id: Ifb34736e9c1a31ad15649e556dcb6e3c98890f07 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
7126b1d2 | 25-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_encode_check()
Introduce pldm_bios_table_attr_entry_enum_encode(), deprecate pldm_bios_table_attr_entry_enum_encode_check(), add the rename co
dsp: bios_table: Rename pldm_bios_table_attr_entry_enum_encode_check()
Introduce pldm_bios_table_attr_entry_enum_encode(), deprecate pldm_bios_table_attr_entry_enum_encode_check(), add the rename configuration and apply it.
Change-Id: I52586f960c5bda2a8c839d27c95bd65ca90c831f Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
8c37ab36 | 25-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_string_entry_decode_string_check()
Introduce pldm_bios_table_string_entry_decode_string(), deprecate pldm_bios_table_string_entry_decode_string_check(), add t
dsp: bios_table: Rename pldm_bios_table_string_entry_decode_string_check()
Introduce pldm_bios_table_string_entry_decode_string(), deprecate pldm_bios_table_string_entry_decode_string_check(), add the rename configuration and apply it.
gitlint-ignore: T1 Change-Id: Ia204acd95d9e1d9bc80d91dd0ff6ffea3a1fe243 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
e48fdd6e | 24-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: bios_table: Rename pldm_bios_table_string_entry_encode_check()
Introduce pldm_bios_table_string_entry_encode(), deprecate pldm_bios_table_string_entry_encode_check(), add the rename configurati
dsp: bios_table: Rename pldm_bios_table_string_entry_encode_check()
Introduce pldm_bios_table_string_entry_encode(), deprecate pldm_bios_table_string_entry_encode_check(), add the rename configuration and apply it.
Change-Id: I3a75320fde4be6bf913b3eb9b56ccacc11abf511 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
d72ea4b8 | 24-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: pdr: Rename pldm_entity_association_pdr_add_check()
Introduce pldm_entity_association_pdr_add(), deprecate pldm_entity_association_pdr_add_check(), add the rename configuration and then apply i
dsp: pdr: Rename pldm_entity_association_pdr_add_check()
Introduce pldm_entity_association_pdr_add(), deprecate pldm_entity_association_pdr_add_check(), add the rename configuration and then apply it.
One quirk this time around is that we had forgotten to remove the declaration of pldm_entity_association_pdr_add() from the header when we removed its implementation. Clean this issue up as well, as it's necessary to avoid the type conflict.
Change-Id: Id8e61c817017dd7caefa9fd7b2bc59ee0f1f6721 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
e7f55113 | 20-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: pdr: Rename pldm_pdr_add_fru_record_set_check()
Drop the `_check` suffix so it is now `pldm_pdr_add_fru_record_set()`, and run `apply-renames` to update any internal references.
Change-Id: Iaa
dsp: pdr: Rename pldm_pdr_add_fru_record_set_check()
Drop the `_check` suffix so it is now `pldm_pdr_add_fru_record_set()`, and run `apply-renames` to update any internal references.
Change-Id: Iaaa452269caa47369c80b43bf65f30d2a004ec66 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
fae3641d | 20-Jun-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
dsp: pdr: Rename pldm_pdr_add_check()
Drop the `_check` suffix so it is now `pldm_pdr_add()`.
Change-Id: I9b32317f99a89acbe1cc0510380cd26badd145d6 Signed-off-by: Andrew Jeffery <andrew@codeconstruc
dsp: pdr: Rename pldm_pdr_add_check()
Drop the `_check` suffix so it is now `pldm_pdr_add()`.
Change-Id: I9b32317f99a89acbe1cc0510380cd26badd145d6 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
f874b383 | 24-Jul-2024 |
Thu Nguyen <thu@os.amperecomputing.com> |
platform: Stabilise decode_pldm_message_poll_event_data() APIs
See usage example at: [1] https://gerrit.openbmc.org/c/openbmc/pldm/+/73033/1/platform-mc/event_manager.cpp#126
Change-Id: Ic680a514b2
platform: Stabilise decode_pldm_message_poll_event_data() APIs
See usage example at: [1] https://gerrit.openbmc.org/c/openbmc/pldm/+/73033/1/platform-mc/event_manager.cpp#126
Change-Id: Ic680a514b224d366cc00fa291f2da45dde77950a Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
show more ...
|
7739d123 | 26-Jul-2024 |
Thu Nguyen <thu@os.amperecomputing.com> |
platform: Rework decode/encode_pldm_message_poll_event_data() APIs
Adds `struct pldm_message_poll_event` which includes `format_version`, `event_id` and `data_transfer_handle` in `pldmMessagePollEve
platform: Rework decode/encode_pldm_message_poll_event_data() APIs
Adds `struct pldm_message_poll_event` which includes `format_version`, `event_id` and `data_transfer_handle` in `pldmMessagePollEvent` data. Rework decode/encode_pldm_message_poll_event_data() APIs to use `struct pldm_message_poll_event poll_event` as parameter.
Change-Id: I01c643ed320b17141d89068cb3e00b1a99162d77 Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
show more ...
|
43cb4b5f | 16-Jul-2024 |
Thu Nguyen <thu@os.amperecomputing.com> |
platform: Stabilise related decode_entity_auxiliary_names_pdr*() APIs
See usage example at: https://gerrit.openbmc.org/c/openbmc/pldm/+/72610
Change-Id: I16c6d42ad11afa59b04676fa187f5ea0764d1880 Si
platform: Stabilise related decode_entity_auxiliary_names_pdr*() APIs
See usage example at: https://gerrit.openbmc.org/c/openbmc/pldm/+/72610
Change-Id: I16c6d42ad11afa59b04676fa187f5ea0764d1880 Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
show more ...
|
b6ef35b4 | 02-Jul-2024 |
Chris Wang <chris.wang.wiwynn@gmail.com> |
fw_update: Add encode req & decode resp for get_downstream_fw_params
Add support for Get Downstream Firmware Parameters to ask all downstream devices' Firmware Parameters.
The code is developed bas
fw_update: Add encode req & decode resp for get_downstream_fw_params
Add support for Get Downstream Firmware Parameters to ask all downstream devices' Firmware Parameters.
The code is developed based on the definition of 'GetDownstreamFirmwareParameters' in DSP0267_1.1.0. Section 10.5
Change-Id: I291ca3b623be6119434b70494bb9a12b22f600b9 Signed-off-by: Chris Wang <chris.wang.wiwynn@gmail.com> Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
dacfa354 | 22-Jun-2024 |
Thu Nguyen <thu@os.amperecomputing.com> |
pdr: Add related decode_entity_auxiliary_names_pdr*() APIs
Add `decode_entity_auxiliary_names_pdr()` to decode the entity auxiliary names PDR raw data to the data fields as table 95 in DSP0248_1.2.2
pdr: Add related decode_entity_auxiliary_names_pdr*() APIs
Add `decode_entity_auxiliary_names_pdr()` to decode the entity auxiliary names PDR raw data to the data fields as table 95 in DSP0248_1.2.2. The API will not decode the entity auxiliary names directly - to expose the language tags and names fields the caller has to subsequently call `decode_pldm_entity_auxiliary_names_pdr_index()`. Between the API calls the caller must allocate memory for the `names` field as an array of `struct pldm_entity_auxiliary_name` with `name_string_count` elements.
Change-Id: I5fc3989c4c4595546a70c01eb2b6dadcf8c14303 Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com> Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
56f73f95 | 07-Jul-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
msgbuf: Add pldm_msgbuf_copy_string_utf16()
Safely copy a NUL-terminated UTF16-{BE,LE} string between msgbuf instances.
Change-Id: If96df9598f17ac771d75f0831be270c5e0139578 Signed-off-by: Andrew Je
msgbuf: Add pldm_msgbuf_copy_string_utf16()
Safely copy a NUL-terminated UTF16-{BE,LE} string between msgbuf instances.
Change-Id: If96df9598f17ac771d75f0831be270c5e0139578 Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
1523778d | 02-Jul-2024 |
Thu Nguyen <thu@os.amperecomputing.com> |
msgbuf: Add pldm_msgbuf_span_string_utf16()
Add pldm_msgbuf_span_string_utf16 API to return the start pointer of the utf16 string in message buffer. The API also returns the UTF16 string length in t
msgbuf: Add pldm_msgbuf_span_string_utf16()
Add pldm_msgbuf_span_string_utf16 API to return the start pointer of the utf16 string in message buffer. The API also returns the UTF16 string length in terms of bytes, including the NUL terminator.
``` __attribute__((always_inline)) static inline int pldm_msgbuf_span_string_utf16(struct pldm_msgbuf *ctx, void **cursor, size_t *length) ```
The `cursor` and `length` are optional. Input NULL to `cursor` and `length` will cause the message buffer cursor points to remaining data. The caller can ignore `length` option by input NULL if they don't care about the size of utf16 string.
Change-Id: I1fc2865a21d9925e49416531b85212b3b07dc37a Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com> Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
8b879600 | 07-Jul-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
msgbuf: Add pldm_msgbuf_copy_string_ascii()
Safely copy a NUL-terminated string between msgbuf instances.
Change-Id: I224dc3f5bbd55fd9d4727ab0de065d5253ee0bea Signed-off-by: Andrew Jeffery <andrew@
msgbuf: Add pldm_msgbuf_copy_string_ascii()
Safely copy a NUL-terminated string between msgbuf instances.
Change-Id: I224dc3f5bbd55fd9d4727ab0de065d5253ee0bea Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
9c83d681 | 02-Jul-2024 |
Thu Nguyen <thu@os.amperecomputing.com> |
msgbuf: Add pldm_msgbuf_span_string_ascii()
Add pldm_msgbuf_span_string_ascii() API to find the start of the ascii string in the message buffer.
``` pldm_msgbuf_span_string_ascii(struct pldm_msgbuf
msgbuf: Add pldm_msgbuf_span_string_ascii()
Add pldm_msgbuf_span_string_ascii() API to find the start of the ascii string in the message buffer.
``` pldm_msgbuf_span_string_ascii(struct pldm_msgbuf *ctx, void **cursor, size_t *length) ```
The API returns the start pointer of ascii string in the message buffer and length of that ascii string includes Terminator. The `cursor` and `length` are optional. Input NULL to `cursor` and `length` will cause the message buffer cursor points to remaining data. The caller can ignore `length` option by input NULL if they don't care about the size of ascii string.
Change-Id: I4a73b7425ee1e4e5621eb16de6e16189efdf202b Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com> Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
1c57144d | 07-Jul-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
msgbuf: Generalize array extraction and insertion
Build the type-safe and generic behavior on top of memcpy() via a "private" helper that takes a void pointer.
Change-Id: Iedb8e9237c780735d4cac41fe
msgbuf: Generalize array extraction and insertion
Build the type-safe and generic behavior on top of memcpy() via a "private" helper that takes a void pointer.
Change-Id: Iedb8e9237c780735d4cac41fe0a723c3751c64ce Signed-off-by: Chris Wang <chris.wang.wiwynn@gmail.com> Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
274732fc | 05-Jul-2024 |
Pavithra Barithaya <pavithrabarithaya07@gmail.com> |
pdr: Add pldm_pdr_get_terminus_handle() API
Adds a new libpldm API to get the terminus handle of the particular record given as input from the PDR repo.
Change-Id: I3694cc3974a564296f4584b70de7d6d1
pdr: Add pldm_pdr_get_terminus_handle() API
Adds a new libpldm API to get the terminus handle of the particular record given as input from the PDR repo.
Change-Id: I3694cc3974a564296f4584b70de7d6d1dad2a866 Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>
show more ...
|