utils: Remove is_transfer_flag_valid() from the public API

It has been deprecated since prior to v0.13.0. Remove the
LIBPLDM_ABI_DEPRECATED annotation, hiding the symbol externally. It's
now only av

utils: Remove is_transfer_flag_valid() from the public API

It has been deprecated since prior to v0.13.0. Remove the
LIBPLDM_ABI_DEPRECATED annotation, hiding the symbol externally. It's
now only available internal to the library.

Change-Id: Ie0b63454db3fd11ca87874e2eb5c27171c06d6f1
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

utils: Remove is_time_legal() from the public API

It has been deprecated since prior to v0.13.0. Remove the
LIBPLDM_ABI_DEPRECATED annotation, hiding the symbol externally. It's
now only available i

utils: Remove is_time_legal() from the public API

It has been deprecated since prior to v0.13.0. Remove the
LIBPLDM_ABI_DEPRECATED annotation, hiding the symbol externally. It's
now only available internal to the library.

Change-Id: I81567279d13b6781aae856e2604451e65bfda6fd
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

utils: Migrate pldm_base_ver2str() to base

The ver32 type is defined in the base specification (DSP0240).
Associated functions should also be defined in the base module.

Change-Id: I71e06b3b1be83fe

utils: Migrate pldm_base_ver2str() to base

The ver32 type is defined in the base specification (DSP0240).
Associated functions should also be defined in the base module.

Change-Id: I71e06b3b1be83fe512f573b9f2227e2a17a93c63
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

utils: Rename ver2str() to pldm_base_ver2str()

Tidy-up the un-prefixed namespace.

Change-Id: Iaf51d3ef0f38fda26a7a27bdd3871547f8f425c6
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Split out BCD translation unit

Chip away at removing "utils".

Change-Id: I5f31cb13e9325cffe47bc85ea55eac0cf9289ec8
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename dec2bcd32() to pldm_bcd_dec2bcd32()

Tidy-up the un-prefixed namespace.

Change-Id: I05355c56cf10e965b01431aa569d14cb5827438a
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename bcd2dec32() to pldm_bcd_bcd2dec32()

Tidy-up the un-prefixed namespace.

Change-Id: I95998b308b829edb783e7437517ba1984b87709e
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename dec2bcd16() to pldm_bcd_dec2bcd16()

Tidy-up the un-prefixed namespace.

Change-Id: I1a8887a2fd6c11b84f457afc7cf4194a920691cd
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename bcd2dec16() to pldm_bcd_bcd2dec16()

Tidy-up the un-prefixed namespace.

Change-Id: Idaf648c681288f73b9898d845f7a146a460d4f4d
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename dec2bcd8() to pldm_bcd_dec2bcd8()

Tidy-up the un-prefixed namespace.

Change-Id: I74db956b9dbb48d86c3560d0b5379c5cb09ef240
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename bcd2dec8() to pldm_bcd_bcd2dec8()

Tidy-up the un-prefixed namespace.

Change-Id: I6dea486e3ee08cd9a9c4df675e6ebe5974ccc062
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Split out EDAC translation unit

Chip away at removing "utils".

Change-Id: I361d7f779e1077b16e83c75d6b4d86814bb4dcad
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

msgbuf: Add pldm_msgbuf_insert_real32

Support from extracting real32_t data is already present, but the insert
functionality is missing.

This change is required for encoding platform sensor data in

msgbuf: Add pldm_msgbuf_insert_real32

Support from extracting real32_t data is already present, but the insert
functionality is missing.

This change is required for encoding platform sensor data in the msgbuf.

Change-Id: Iff397116d15f23e51c472b8e478b4a2511ce0692
Signed-off-by: Roger G. Coscojuela <roger.gili-coscojuela@sipearl.com>

show more ...

pdr: Stabilize APIs for removing records

- pldm_entity_association_pdr_remove_contained_entity()
- pldm_entity_association_tree_delete_node()
- pldm_pdr_delete_by_effecter_id()
- pldm_pdr_delete_by_

pdr: Stabilize APIs for removing records

- pldm_entity_association_pdr_remove_contained_entity()
- pldm_entity_association_tree_delete_node()
- pldm_pdr_delete_by_effecter_id()
- pldm_pdr_delete_by_sensor_id()
- pldm_pdr_remove_fru_record_set_by_rsi()

Use of all these APIs is demonstrated in [1].

[1]: https://gerrit.openbmc.org/c/openbmc/pldm/+/79879

Change-Id: I4dc97c4f5b60621b281d97feab79b3349432b598
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

transport: Improve time validation in pldm_transport_send_recv_msg()

There is at least one system where the current value returned by
CLOCK_MONOTONIC is 2589793 which fails the overflow test in
`tim

transport: Improve time validation in pldm_transport_send_recv_msg()

There is at least one system where the current value returned by
CLOCK_MONOTONIC is 2589793 which fails the overflow test in
`timeval_is_valid`. Upon close inspecting we dont really want to test
the actual end time but rather the difference (remaining) since the
real risk we are trying to avoid is overflowing when the call to
`timeval_to_msec()` is made.

So, move the check to test `remaining` instead of `end`.

Change-Id: If6533855025ff3ba0be19bad791f58ca812b80a7
Fixes: abaf61f45e2a ("transport: Prevent sticking in waiting for response")
Signed-off-by: Amithash Prasad <amithash@meta.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

tests: transport: send_recv_one: Prevent invalid accesses

EXPECT_*() doesn't exit on failure which leads to the following
undefined behavior:

```
Running main() from /usr/src/googletest/googletest/

tests: transport: send_recv_one: Prevent invalid accesses

EXPECT_*() doesn't exit on failure which leads to the following
undefined behavior:

```
Running main() from /usr/src/googletest/googletest/src/gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Transport
[ RUN ] Transport.send_recv_one
../tests/transport/send_recv_one.cpp:88: Failure
Expected equality of these values:
rc
Which is: -12
PLDM_REQUESTER_SUCCESS
Which is: 0

../tests/transport/send_recv_one.cpp:89: Failure
Expected equality of these values:
len
Which is: 94647119099472
sizeof(resp)
Which is: 4

../tests/transport/send_recv_one.cpp:90: Failure
Expected equality of these values:
memcmp(msg, resp, len)
Which is: -1
0

free(): invalid pointer
fish: Job 1, 'ASAN_OPTIONS=halt_on_error=1:ab…' terminated by signal SIGABRT (Abort)
```

Switch to ASSERT_EQ() to exit failure when the error is detected and
avoid UB.

Change-Id: I696c85e25ca8220db7b0790aad4d743cc724938c
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

tests: meson: Use system include type for googletest dependencies

Squash warnings that are generated by project-specific CXXFLAGS.

Change-Id: I36bf08a13e7bac1bd276c36d98de2efdf892e9ed
Signed-off-by

tests: meson: Use system include type for googletest dependencies

Squash warnings that are generated by project-specific CXXFLAGS.

Change-Id: I36bf08a13e7bac1bd276c36d98de2efdf892e9ed
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: base: Omit checksum for Multipart receive ACKNOWLEDGE_COMPLETION

This fix is based on DSP0240 v1.2.0 section 9.6.6, Table 17
DataIntegrityChecksum property description.

DataIntegrityChecksum p

dsp: base: Omit checksum for Multipart receive ACKNOWLEDGE_COMPLETION

This fix is based on DSP0240 v1.2.0 section 9.6.6, Table 17
DataIntegrityChecksum property description.

DataIntegrityChecksum property should be there unless the
response TransferFlag property is ACKNOWLEDGE_COMPLETION

This patch fixes the issue where DataIntegrityChecksum is only
included if the TransferFlag is PLDM_END or PLDM_START_AND_END

Change-Id: I6d715d21d9d9d55bbda6139108be9cfb288ad209
Fixes: 21a639d6e67d ("dsp: base: Add encode resp for MultipartReceive command")
Signed-off-by: Kasun Athukorala <kasunath@google.com>

show more ...

dsp: base: Fix MultipartReceive Request decoding

This fix is based on DSP0240 v1.2.0 section 9.6.6 - Flag usage for
MultipartReceive (paragraph 351) and Table 17 MultipartReceive request
format.

-

dsp: base: Fix MultipartReceive Request decoding

This fix is based on DSP0240 v1.2.0 section 9.6.6 - Flag usage for
MultipartReceive (paragraph 351) and Table 17 MultipartReceive request
format.

- Removed RequestedSectionOffset check.

The Property can be 0 for any TransferOperation flag.

- Changed DataTransferHandle check.

The property can be 0 except with PLDM_XFER_NEXT_PART. Eg. In DSP0242
v1.0.0 section 9.8.2, Table 19, and DSP0240 v1.2.0 section 9.6.5, Table
17, when using MultipartReceive to read a file, the client has to send
transfer handle 0 with XFER_FIRST_PART.

Change-Id: I06428556f9dee341de97f72b015ed0347adc9454
Fixes: 9c76679224cf ("libpldm: Migrate to subproject")
Signed-off-by: Kasun Athukorala <kasunath@google.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

clang-tidy-21: uninitialized-const-pointer warnings

Fix a few clang warnings raised with clang-tidy-21:

```
../tests/dsp/platform.cpp:917:46: error: variable 'effecter_value' is uninitialized when

clang-tidy-21: uninitialized-const-pointer warnings

Fix a few clang warnings raised with clang-tidy-21:

```
../tests/dsp/platform.cpp:917:46: error: variable 'effecter_value' is uninitialized when passed as a const pointer argument here [-Werror,-Wuninitialized-const-pointer]
917 | 0, 0, 6, reinterpret_cast<uint8_t*>(&effecter_value), request,
../tests/dsp/firmware_update.cpp:4837:47: error: variable 'data' is uninitialized when passed as a const pointer argument here [-Werror,-Wuninitialized-const-pointer]
4837 | rc = decode_pldm_firmware_update_package(&data, sizeof(data), nullptr, &hdr,
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I468d2a1db894cf8ea0e72cd44b6fdc6c9130607d

show more ...

clang-format: update latest spec and reformat with clang-21

Copy the latest format file from the docs repository and apply using
clang-format-21.

See I795e88ada8e676c242b5a18888ce9c08afdedc93 for c

clang-format: update latest spec and reformat with clang-21

Copy the latest format file from the docs repository and apply using
clang-format-21.

See I795e88ada8e676c242b5a18888ce9c08afdedc93 for clang-21 enablement.

Change-Id: Ie541f039aa995c7cd7654ae28ece19884595eb32
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: base: Added encode_pldm_base_negotiate_transfer_params_resp()

This command is based on DSP0240 v1.2.0 section 9.6.2
NegotiateTransferParameters (0x07).

gitlint-ignore: T1
Signed-off-by: Kasun

dsp: base: Added encode_pldm_base_negotiate_transfer_params_resp()

This command is based on DSP0240 v1.2.0 section 9.6.2
NegotiateTransferParameters (0x07).

gitlint-ignore: T1
Signed-off-by: Kasun Athukorala <kasunath@google.com>
Change-Id: I619ca0b356df065b662b16d4a469730fd145f9de

show more ...

dsp: base: Added decode_pldm_base_negotiate_transfer_params_req()

This command is based on DSP0240 v1.2.0 section 9.6.2
NegotiateTransferParameters (0x07).

gitlint-ignore: T1
Change-Id: I4fa193444d

dsp: base: Added decode_pldm_base_negotiate_transfer_params_req()

This command is based on DSP0240 v1.2.0 section 9.6.2
NegotiateTransferParameters (0x07).

gitlint-ignore: T1
Change-Id: I4fa193444df9ba5b109ca063163d7f7d109fcbda
Signed-off-by: Kasun Athukorala <kasunath@google.com>

show more ...

utils: Add an API to calculate cumulative crc32

Change-Id: I6c6fce214b98bc8f7284bc3e58319a9ef659e1b0
Signed-off-by: Kasun Athukorala <kasunath@google.com>

tests: dsp: firmware_update: Drop guards for package parsing tests

These are now marked stable and shouldn't be conditionally compiled.

Fixes:

```
../tests/dsp/firmware_update.cpp:53:5: error: unu

tests: dsp: firmware_update: Drop guards for package parsing tests

These are now marked stable and shouldn't be conditionally compiled.

Fixes:

```
../tests/dsp/firmware_update.cpp:53:5: error: unused variable 'PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_1' [-Werror,-Wunused-const-variable]
53 | PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_1{
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../tests/dsp/firmware_update.cpp:59:5: error: unused variable 'PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_2' [-Werror,-Wunused-const-variable]
59 | PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_2{0x31, 0x19, 0xce, 0x2f, 0xe8, 0x0a,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../tests/dsp/firmware_update.cpp:64:5: error: unused variable 'PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_3' [-Werror,-Wunused-const-variable]
64 | PLDM_FWUP_PACKAGE_HEADER_IDENTIFIER_V1_3{0x7b, 0x29, 0x1c, 0x99, 0x6d, 0xb6,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Fixes: f6ef78f676a9 ("dsp: firmware_update: Stabilized new firmware package parsing ABI")
Change-Id: I3386d3827b80d31cb702cb9f3f67d616b09be478
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...