#
e984a461 |
| 07-Sep-2024 |
Andrew Jeffery <andrew@codeconstruct.com.au> |
meson: Format build files with `meson format`
Additionally, add the formatting command to `scripts/pre-submit` so it's run by OpenBMC's CI (via `scripts/run-ci`).
Change-Id: Ifb8fc06106b8cfa9155e98
meson: Format build files with `meson format`
Additionally, add the formatting command to `scripts/pre-submit` so it's run by OpenBMC's CI (via `scripts/run-ci`).
Change-Id: Ifb8fc06106b8cfa9155e986528b769a5ca450b4c Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
show more ...
|
#
9a6ba89c |
| 18-Jul-2023 |
Andrew Jeffery <andrew@aj.id.au> |
transport: Introduce a transport for testing purposes
I've put the test transport header along side the source file as its presence and implementation is an internal detail to support the test suite
transport: Introduce a transport for testing purposes
I've put the test transport header along side the source file as its presence and implementation is an internal detail to support the test suite. No consumers of libpldm outside its test suite should have any need for the test transport. We can always choose to make the header public if for some reason someone does eventually want to use it.
In addition, add a new test suite exercising the transport interfaces.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ie9906bdc6a397436b91198196de04ffd6c93fc46
show more ...
|
#
04273e9f |
| 16-Jun-2023 |
Rashmica Gupta <rashmica@linux.ibm.com> |
transports: Resize socket send buffer if needed
This was originally added in openbmc/pldm to make the socket send buffer big enough to send a message if the message is longer than the current send b
transports: Resize socket send buffer if needed
This was originally added in openbmc/pldm to make the socket send buffer big enough to send a message if the message is longer than the current send buffer size.
When you call set_sock_opt with buffer size X, given that X is within a certain range, the send buffer is actually set to 2*X. get_sock_opt returns the 2*X value, not X. So add in some helper functions.
Change-Id: I8ded9357db4268cd264cf0ecfb80479223106c09 Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>
show more ...
|
#
c1b66f42 |
| 08-Dec-2022 |
Rashmica Gupta <rashmica@linux.ibm.com> |
requester: Add new APIs to support multiple transports
This patch has two goals: (1) enable consumers to send PLDM messages over different transports and (2) do this in a way that allows us to move
requester: Add new APIs to support multiple transports
This patch has two goals: (1) enable consumers to send PLDM messages over different transports and (2) do this in a way that allows us to move towards a cleaner and more complete set of requester APIs.
The sole transport option of MCTP via the userspace mctp-demux-daemon is being deprecated. New transports are being added: MCTP via the kernel (AF_MCTP) and eventually NC-SI. As such, the requester APIs need updating to support multiple transports, as well as not having MCTP specific details in the APIs. To avoid a flag day, the current APIs (pldm_send, etc) have been rewritten terms of the new APIs.
The current APIs operate at the transport level - they don't implement all of the behaviour necessary for a requester. As such, the new APIs to send/recv a message have the prefix `pldm_transport`, rather than `pldm_requester`. Given the level that these APIs are operating at, these only send and receive a PLDM message. Any additional logic, such as looking for a response with a particular instance ID, belongs at the requester abstraction level.
Some of the missing behaviours to fully be a PLDM requester are: assigning instance IDs, request retransmission, implementing timeouts, and enforcing only one PLDM request to a specific TID at a time. These things are currently implemented in pldmd, meaning any consumer other than pldmd using the libpldm "requester" APIs doesn't get the full functionality of a requester and has to implement these things themselves.
We would like to eventually move these behaviours into libpldm so the libpldm requester APIs actually implement what is required to be a PLDM requester.
The next steps to add in a full set of requester APIs, while enabling the use of multiple transports looks something like this:
1) add instance id APIs into libpldm. 2) convert pldmd to use libpldm instance id APIs - so all users of PLDM are still using the same instance id allocation method. 3) convert all consumers of libpldm over to using the new libpldm APIs, including the instance id functions. 4) add in the AF_MCTP transport and move consumers over to it. 5) refactor the encode/decode functions to only encode/decode and not frame the message (ie, remove the instance id from these functions) 6) add additional requester functionality into libpldm, and have these use the `pldm_transport` APIs directly. 7) move consumers over to the new `pldm_requester` APIs. 8) remove unused code from pldmd.
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com> Change-Id: I06e602831f360bbd0efda53d410bfb5080b3100d
show more ...
|