include: Remove libpldm/utils.h

At this point it only existed to include other headers. Users should
rather include the necessary headers directly.

Change-Id: Ie0fbf9caccea0dfe75be0127e675e3949dc52

include: Remove libpldm/utils.h

At this point it only existed to include other headers. Users should
rather include the necessary headers directly.

Change-Id: Ie0fbf9caccea0dfe75be0127e675e3949dc52d61
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I27a1db143cecac594b9e6f173c80f87bc0d39786
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

utils: Remove is_transfer_flag_valid() from the public API

It has been deprecated since prior to v0.13.0. Remove the
LIBPLDM_ABI_DEPRECATED annotation, hiding the symbol externally. It's
now only av

utils: Remove is_transfer_flag_valid() from the public API

It has been deprecated since prior to v0.13.0. Remove the
LIBPLDM_ABI_DEPRECATED annotation, hiding the symbol externally. It's
now only available internal to the library.

Change-Id: Ie0b63454db3fd11ca87874e2eb5c27171c06d6f1
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

utils: Remove is_time_legal() from the public API

It has been deprecated since prior to v0.13.0. Remove the
LIBPLDM_ABI_DEPRECATED annotation, hiding the symbol externally. It's
now only available i

utils: Remove is_time_legal() from the public API

It has been deprecated since prior to v0.13.0. Remove the
LIBPLDM_ABI_DEPRECATED annotation, hiding the symbol externally. It's
now only available internal to the library.

Change-Id: I81567279d13b6781aae856e2604451e65bfda6fd
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

utils: Migrate pldm_base_ver2str() to base

The ver32 type is defined in the base specification (DSP0240).
Associated functions should also be defined in the base module.

Change-Id: I71e06b3b1be83fe

utils: Migrate pldm_base_ver2str() to base

The ver32 type is defined in the base specification (DSP0240).
Associated functions should also be defined in the base module.

Change-Id: I71e06b3b1be83fe512f573b9f2227e2a17a93c63
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

utils: Rename ver2str() to pldm_base_ver2str()

Tidy-up the un-prefixed namespace.

Change-Id: Iaf51d3ef0f38fda26a7a27bdd3871547f8f425c6
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Split out BCD translation unit

Chip away at removing "utils".

Change-Id: I5f31cb13e9325cffe47bc85ea55eac0cf9289ec8
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename dec2bcd32() to pldm_bcd_dec2bcd32()

Tidy-up the un-prefixed namespace.

Change-Id: I05355c56cf10e965b01431aa569d14cb5827438a
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename bcd2dec32() to pldm_bcd_bcd2dec32()

Tidy-up the un-prefixed namespace.

Change-Id: I95998b308b829edb783e7437517ba1984b87709e
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename dec2bcd16() to pldm_bcd_dec2bcd16()

Tidy-up the un-prefixed namespace.

Change-Id: I1a8887a2fd6c11b84f457afc7cf4194a920691cd
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename bcd2dec16() to pldm_bcd_bcd2dec16()

Tidy-up the un-prefixed namespace.

Change-Id: Idaf648c681288f73b9898d845f7a146a460d4f4d
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename dec2bcd8() to pldm_bcd_dec2bcd8()

Tidy-up the un-prefixed namespace.

Change-Id: I74db956b9dbb48d86c3560d0b5379c5cb09ef240
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Rename bcd2dec8() to pldm_bcd_bcd2dec8()

Tidy-up the un-prefixed namespace.

Change-Id: I6dea486e3ee08cd9a9c4df675e6ebe5974ccc062
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

utils: Split out EDAC translation unit

Chip away at removing "utils".

Change-Id: I361d7f779e1077b16e83c75d6b4d86814bb4dcad
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

msgbuf: Add pldm_msgbuf_insert_real32

Support from extracting real32_t data is already present, but the insert
functionality is missing.

This change is required for encoding platform sensor data in

msgbuf: Add pldm_msgbuf_insert_real32

Support from extracting real32_t data is already present, but the insert
functionality is missing.

This change is required for encoding platform sensor data in the msgbuf.

Change-Id: Iff397116d15f23e51c472b8e478b4a2511ce0692
Signed-off-by: Roger G. Coscojuela <roger.gili-coscojuela@sipearl.com>

show more ...

pdr: Stabilize APIs for removing records

- pldm_entity_association_pdr_remove_contained_entity()
- pldm_entity_association_tree_delete_node()
- pldm_pdr_delete_by_effecter_id()
- pldm_pdr_delete_by_

pdr: Stabilize APIs for removing records

- pldm_entity_association_pdr_remove_contained_entity()
- pldm_entity_association_tree_delete_node()
- pldm_pdr_delete_by_effecter_id()
- pldm_pdr_delete_by_sensor_id()
- pldm_pdr_remove_fru_record_set_by_rsi()

Use of all these APIs is demonstrated in [1].

[1]: https://gerrit.openbmc.org/c/openbmc/pldm/+/79879

Change-Id: I4dc97c4f5b60621b281d97feab79b3349432b598
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

msgbuf: platform: Correct pldm_msgbuf_extract_effecter_data

`pldm_msgbuf_extract_effecter_data` should call to
`pldm__msgbuf_extract_effecter_data` instead of
`pldm__msgbuf_extract_range_field_forma

msgbuf: platform: Correct pldm_msgbuf_extract_effecter_data

`pldm_msgbuf_extract_effecter_data` should call to
`pldm__msgbuf_extract_effecter_data` instead of
`pldm__msgbuf_extract_range_field_format`. This commit corrects the
function to call to the designated one.

Fixes: d4878cd ("pdr: Add decode_numeric_effecter_pdr_data()")
Change-Id: I1bc9ed88eb291368c4fd96560bf089e597d75b55
Signed-off-by: Chau Ly <chaul@amperecomputing.com>

show more ...

transport: Fix msec overflow test

The value 1000 was left in the wrong spot, leading to an incorrect
inversion of the msec calculation when testing for overflow. An
alternative is to reduce it to 1,

transport: Fix msec overflow test

The value 1000 was left in the wrong spot, leading to an incorrect
inversion of the msec calculation when testing for overflow. An
alternative is to reduce it to 1, but that correlates poorly with the
expression used by timeval_to_msec().

Reported-by: Milton Miller <mdmii@outlook.com>
Fixes: 69b5a9cde88b ("transport: Improve time validation in pldm_transport_send_recv_msg()")
Change-Id: I59816c6f2b773dfd076e393455394f08cfe67198
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

transport: Improve time validation in pldm_transport_send_recv_msg()

There is at least one system where the current value returned by
CLOCK_MONOTONIC is 2589793 which fails the overflow test in
`tim

transport: Improve time validation in pldm_transport_send_recv_msg()

There is at least one system where the current value returned by
CLOCK_MONOTONIC is 2589793 which fails the overflow test in
`timeval_is_valid`. Upon close inspecting we dont really want to test
the actual end time but rather the difference (remaining) since the
real risk we are trying to avoid is overflowing when the call to
`timeval_to_msec()` is made.

So, move the check to test `remaining` instead of `end`.

Change-Id: If6533855025ff3ba0be19bad791f58ca812b80a7
Fixes: abaf61f45e2a ("transport: Prevent sticking in waiting for response")
Signed-off-by: Amithash Prasad <amithash@meta.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Add environ as a link seam for platform APIs

Allow precise redirection of platform-related APIs (such as those
provided by libc) for the purpose of unit tests.

Change-Id: I615b25805fc7a24eb5d67e872

Add environ as a link seam for platform APIs

Allow precise redirection of platform-related APIs (such as those
provided by libc) for the purpose of unit tests.

Change-Id: I615b25805fc7a24eb5d67e87237bf35c8e262b93
Signed-off-by: Amithash Prasad <amithash@meta.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

compiler: Sort static_assert()s

Keep them in a sensible order for the purpose of adding new entries.

Change-Id: I58df3603863ef28a31b1be1158ddde40f47975eb
Signed-off-by: Andrew Jeffery <andrew@codec

compiler: Sort static_assert()s

Keep them in a sensible order for the purpose of adding new entries.

Change-Id: I58df3603863ef28a31b1be1158ddde40f47975eb
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: base: Omit checksum for Multipart receive ACKNOWLEDGE_COMPLETION

This fix is based on DSP0240 v1.2.0 section 9.6.6, Table 17
DataIntegrityChecksum property description.

DataIntegrityChecksum p

dsp: base: Omit checksum for Multipart receive ACKNOWLEDGE_COMPLETION

This fix is based on DSP0240 v1.2.0 section 9.6.6, Table 17
DataIntegrityChecksum property description.

DataIntegrityChecksum property should be there unless the
response TransferFlag property is ACKNOWLEDGE_COMPLETION

This patch fixes the issue where DataIntegrityChecksum is only
included if the TransferFlag is PLDM_END or PLDM_START_AND_END

Change-Id: I6d715d21d9d9d55bbda6139108be9cfb288ad209
Fixes: 21a639d6e67d ("dsp: base: Add encode resp for MultipartReceive command")
Signed-off-by: Kasun Athukorala <kasunath@google.com>

show more ...

dsp: base: Fix MultipartReceive Request decoding

This fix is based on DSP0240 v1.2.0 section 9.6.6 - Flag usage for
MultipartReceive (paragraph 351) and Table 17 MultipartReceive request
format.

-

dsp: base: Fix MultipartReceive Request decoding

This fix is based on DSP0240 v1.2.0 section 9.6.6 - Flag usage for
MultipartReceive (paragraph 351) and Table 17 MultipartReceive request
format.

- Removed RequestedSectionOffset check.

The Property can be 0 for any TransferOperation flag.

- Changed DataTransferHandle check.

The property can be 0 except with PLDM_XFER_NEXT_PART. Eg. In DSP0242
v1.0.0 section 9.8.2, Table 19, and DSP0240 v1.2.0 section 9.6.5, Table
17, when using MultipartReceive to read a file, the client has to send
transfer handle 0 with XFER_FIRST_PART.

Change-Id: I06428556f9dee341de97f72b015ed0347adc9454
Fixes: 9c76679224cf ("libpldm: Migrate to subproject")
Signed-off-by: Kasun Athukorala <kasunath@google.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: base: decode_pldm_base_negotiate_transfer_params_resp() is stable

cb987c5c8863 ("dsp: base: Added
decode_pldm_base_negotiate_transfer_params_req()") accidentally
set `decode_pldm_base_negotiate

dsp: base: decode_pldm_base_negotiate_transfer_params_resp() is stable

cb987c5c8863 ("dsp: base: Added
decode_pldm_base_negotiate_transfer_params_req()") accidentally
set `decode_pldm_base_negotiate_transfer_params_resp()` back to
`LIBPLDM_ABI_TESTING` when it was stabilized by 26c8eb2a2f22 ("Stabilize
PLDM File Transfer related APIs").

Further, the existing integration of abi-compliance-checker was unable
to find the fault as the generated dump contained testing symbols, and
so decode_pldm_base_negotiate_transfer_params_resp() wasn't found to
be absent. We rework scripts/pre-submit such that this kind of problem
results in a CI failure.

Change-Id: I27d48e275646bbd75f19a3e1fe309a584d893cf2
Fixes: cb987c5c8863 ("dsp: base: Added decode_pldm_base_negotiate_transfer_params_req()")
Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

dsp: base: Added encode_pldm_base_negotiate_transfer_params_resp()

This command is based on DSP0240 v1.2.0 section 9.6.2
NegotiateTransferParameters (0x07).

gitlint-ignore: T1
Signed-off-by: Kasun

dsp: base: Added encode_pldm_base_negotiate_transfer_params_resp()

This command is based on DSP0240 v1.2.0 section 9.6.2
NegotiateTransferParameters (0x07).

gitlint-ignore: T1
Signed-off-by: Kasun Athukorala <kasunath@google.com>
Change-Id: I619ca0b356df065b662b16d4a469730fd145f9de

show more ...