meson: Convert options from feature to boolean

Features are things we can automatically enable or disable based on the
presence or absence of supporting dependencies. Neither ABI compliance
testing

meson: Convert options from feature to boolean

Features are things we can automatically enable or disable based on the
presence or absence of supporting dependencies. Neither ABI compliance
testing (despite the fact that we can detect the tool) nor tests fit
this category: They are developer tools and their use should be judged
ahead of the invocation of meson.

Change-Id: I9725cc0444d92c8443cfb28ecd878f77792f38ce
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: pre-submit: Print meson format diff on failure

Like in the case of clang-format failures in OpenBMC CI, show what was
changed.

Change-Id: I5180ba948f7c9feffd6c89e8420af90dc269fcad
Signed-o

scripts: pre-submit: Print meson format diff on failure

Like in the case of clang-format failures in OpenBMC CI, show what was
changed.

Change-Id: I5180ba948f7c9feffd6c89e8420af90dc269fcad
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: pre-submit: Be informative on meson formatting failures

Previously the script just silently exited with a failure status.
That's unhelpful to people reading the CI output, so write somethin

scripts: pre-submit: Be informative on meson formatting failures

Previously the script just silently exited with a failure status.
That's unhelpful to people reading the CI output, so write something
informative.

Change-Id: Ia1b618e004c457d97d1c0f690f74567991cac830
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: pre-submit: Ensure changelog captures API updates

I think most people have fallen short of this ideal at some point, so
add an automated check.

Change-Id: Ic7d2da4d97d49d7e5f43bc341b7e1338

scripts: pre-submit: Ensure changelog captures API updates

I think most people have fallen short of this ideal at some point, so
add an automated check.

Change-Id: Ic7d2da4d97d49d7e5f43bc341b7e13381b8176e5
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: pre-submit: Run GCC's static analyzer

More information can be found in the gcc manual[1] or via the Red Hat
blog posts[2][3][4].

[1]: https://gcc.gnu.org/onlinedocs/gcc/Static-Analyzer-Opt

scripts: pre-submit: Run GCC's static analyzer

More information can be found in the gcc manual[1] or via the Red Hat
blog posts[2][3][4].

[1]: https://gcc.gnu.org/onlinedocs/gcc/Static-Analyzer-Options.html
[2]: https://developers.redhat.com/articles/2022/04/12/state-static-analysis-gcc-12-compiler
[3]: https://developers.redhat.com/articles/2023/05/31/improvements-static-analysis-gcc-13-compiler
[4]: https://developers.redhat.com/articles/2024/04/03/improvements-static-analysis-gcc-14-compiler

Change-Id: Iab174b209dd12a6b27ba43d4097850d0ad87b29a
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: pre-submit: Run release buildtype tests under valgrind

This is the most important case due to release builds disabling
assertions and potentially changing optimization levels and so-forth,

scripts: pre-submit: Run release buildtype tests under valgrind

This is the most important case due to release builds disabling
assertions and potentially changing optimization levels and so-forth,
where undefined behavior gets its opportunity to shine.

Change-Id: If195a50c7156fcda164fee14ed6071ecd79c019f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Format build files with `meson format`

Additionally, add the formatting command to `scripts/pre-submit` so it's
run by OpenBMC's CI (via `scripts/run-ci`).

Change-Id: Ifb8fc06106b8cfa9155e98

meson: Format build files with `meson format`

Additionally, add the formatting command to `scripts/pre-submit` so it's
run by OpenBMC's CI (via `scripts/run-ci`).

Change-Id: Ifb8fc06106b8cfa9155e986528b769a5ca450b4c
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: Add pre-submit

pre-submit runs through the pre-submission commands outlined in docs/
checklists/changes.md. This allows easy checking via:

```
$ git rebase -x ./scripts/pre-submit origin/m

scripts: Add pre-submit

pre-submit runs through the pre-submission commands outlined in docs/
checklists/changes.md. This allows easy checking via:

```
$ git rebase -x ./scripts/pre-submit origin/main
```

Change-Id: Ib8b0f7725a31081cd70253032e107ed83aa22626
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...