clang-tidy: Enable cppcoreguidelines-pro-type-reinterpret-cast

There are ways to avoid reinterpret_cast<>() in many circumstances.
For libpldm, often its use can be replaced with placement-new.
Enab

clang-tidy: Enable cppcoreguidelines-pro-type-reinterpret-cast

There are ways to avoid reinterpret_cast<>() in many circumstances.
For libpldm, often its use can be replaced with placement-new.
Enable the lint for reinterpret_cast<>() to prevent its use in future
changes. This way we can stay inside the language rather than rely on
implementation-defined behavior.

Existing uses of reinterpret_cast<>() are marked NOLINT for now, with
the intent that we clean them up over time. The insertion of the NOLINTs
was automated with sed.

Change-Id: If6654f774e438de9262fe9f9012c6b574764c326
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

clang-tidy: Restrict analysis to libpldm headers

Meson doesn't regard subproject headers as system headers by default,
which means they trigger analysis by clang-tidy. That's not something we
care a

clang-tidy: Restrict analysis to libpldm headers

Meson doesn't regard subproject headers as system headers by default,
which means they trigger analysis by clang-tidy. That's not something we
care about and clang-tidy seems to dislike things that gtest and gmock
are doing, so ignore them.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Iaa904f0517f7102b88ce7ee230b8360e2cc1dfd4

show more ...

Add clang-tidy file

I've customised this from the usual C++-oriented .clang-tidy file to
work with the C codebase of libpldm. I've had to drop some desirable
checks (such as `readability-identifier-

Add clang-tidy file

I've customised this from the usual C++-oriented .clang-tidy file to
work with the C codebase of libpldm. I've had to drop some desirable
checks (such as `readability-identifier-naming`) as we have C++ for the
tests and it would be nice to remain idiomatic there. It turns out
clang-tidy has configuration to control what file extensions get
analysed, however it's difficult to justify enabling it when e.g. Fedora
37 only ships clang-15 which does not contain support for this option.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I0bb01c82b27265873b9049402633672a4ad94e8a

show more ...