3600922 sizeof of incorrect value, bzero deprecated

3600931 leaks

3600942 check return code

3600946 check for failed bind on send, leaks

3600960 check the copy of password exists

3600963 leak and failed random future note

3600964 leak

3600965 move the initialization past the null intf check

ID: 3595188 - minor leaks via options. revert prev, this cleaner naming, changes by Zdenek Styblik

fixes minor leaks on command line argument parsing

ID: 3598203 - 'mc getsysinfo|setsysinfo' needs a bit of re-work
ID: 3597782 - 'lib/ipmi_mc' - sysinfo_param() has two consecutive returns
ID: 3597781 - 'mc getsysinfo|setsysinfo' help has typos

Comm

ID: 3598203 - 'mc getsysinfo|setsysinfo' needs a bit of re-work
ID: 3597782 - 'lib/ipmi_mc' - sysinfo_param() has two consecutive returns
ID: 3597781 - 'mc getsysinfo|setsysinfo' help has typos

Commit changes/fixes issues described in tickets #3598203, #3597782 and
#3597781.
Typos in help text of 'getsysinfo'/'setsysinfo' got fixed and function
printf_sysinfo_usage() has been created.
Consecutive return in function sysinfo_param() has been removed.
Some code has been re-worked:
* ipmi_getsysinfo() -> ipmi_mc_getsysinfo(),
* ipmi_setsysinfo() -> ipmi_mc_setsysinfo();
* ipmi_sysinfo_main() extended for 'is_set' parameter to signal whether it's
a get/set operation
* return codes changed
* code styling clean-up
* a bit of code clean-up in ipmi_sysinfo_main(), ipmi_mc_getsysinfo(),
ipmi_mc_setsysinfo()

show more ...

ID: 3597471 - 'lib/ipmi_mc.c' - needs a bit of re-work - rc, inv. options

Commit fixes 'help' and return codes(help =~ 0, invalid > 1). Indentation of
file as well as some formatting changes were ma

ID: 3597471 - 'lib/ipmi_mc.c' - needs a bit of re-work - rc, inv. options

Commit fixes 'help' and return codes(help =~ 0, invalid > 1). Indentation of
file as well as some formatting changes were made as well.

show more ...

ID: 3577154 - 'lib/ipmi_mc.c' - return value of 'mc reset'

Commit adds response handling for 'mc reset' commands according to IPMI
specification.

Reported by: Duncan Idaho

ID: 3597468 - 'lib/ipmi_mc.c' - print_mc_usage() prints to STDOUT

Commit replaces printf() with lprintf(LOG_NOTICE,...) to print help text on
STDERR as other ipmitool's sub-commands do.

ID: 3597469 - 'mc watchdog off' prints on STDERR, should be STDOUT

Commit fixes/replaces lprintf(LOG_ERR,...) with printf() to print info message
on STDOUT instead of STDERR in 'mc watchdog off'.

ID: 3597470 - 'mc watchdog reset' prints on STDERR, should be STDOUT

Commit fixes/replaces lprintf(LOG_ERR,...) with printf() to print info message
on STDOUT instead of STDERR in 'mc watchdog reset'.

ID: 3595199 - Add support for # ipmitool sdr <list|elist> help;

Commit adds suppor for # ipmitool sdr <list|elist> help; command.

'lib/helper.c', 'include/ipmitool/helper.h' - add str2double()

Commit adds function to handle conversion from string to double. Function has
the same concept as other str2*() functions.

ID: 3594835 - NULL reference possible in str2*() functions

Commit fixes possible NULL reference in str2*() functions in 'lib/helper.c'.
Although it's less likely to happen in ipmitool's daily life,

ID: 3594835 - NULL reference possible in str2*() functions

Commit fixes possible NULL reference in str2*() functions in 'lib/helper.c'.
Although it's less likely to happen in ipmitool's daily life, it's still
possible.
Let's make sure it doesn't happen.

show more ...

ID: 3592773 - # ipmitool sdr info; prints incorrect info

Commit fixes output printed by # ipmitool sdr info; about 'SDR Repository Alloc
info supported' due to incorrect member name; probably becaus

ID: 3592773 - # ipmitool sdr info; prints incorrect info

Commit fixes output printed by # ipmitool sdr info; about 'SDR Repository Alloc
info supported' due to incorrect member name; probably because of copy-paste
error.

show more ...

ID: 3592770 - # ipmitool sdr list|elist INV_INPUT; return code

Commit fixes return code of # ipmitool sdr list|elist; when invalid
input/unknown command is given.
Return code is > 0 now and error me

ID: 3592770 - # ipmitool sdr list|elist INV_INPUT; return code

Commit fixes return code of # ipmitool sdr list|elist; when invalid
input/unknown command is given.
Return code is > 0 now and error message is printed.

show more ...

ID: 3592732 - 'lib/ipmi_picmg.c' - printf() misuse

Commit replaces printf() with appropriate lprintf() calls. Some error messages
got changed as well.

ID: 3528310 - 'lib/ipmi_picmg.c' - NULL reference

Commit fixes reference to rsp which can be NULL if there is no response from
BMC, eg. KCS driver is not loaded.

'lib/helper.c' - clean-up - remove standalone tabs('\t')

Commit removes standalone tabs - code clean-up.

ID: 3528347 - 'lib/ipmi_raw.c' - possible int *flow

Commit fixes missing return in function is_valid_param() which slipped in code
review.