if no interface is specified, use the dbus interface by default

This is a patch that should only be on openbmc, not sent upstream
because the dbus interface is really only an openbmc thing.

Signed-

if no interface is specified, use the dbus interface by default

This is a patch that should only be on openbmc, not sent upstream
because the dbus interface is really only an openbmc thing.

Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

plugins/dbus: Use default dbus connection

... so we'll use the system bus if run as UID 0.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

plugins/dbus: Fix ccode response

We need to copy it in from the dbus reply.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

plugins/dbus: fix missing semicolon

Reported-by: Chris Austen <austenc@us.ibm.com>

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

plugins/dbus: Split netfn from lun, and ccode from data

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

plugins: Add a backend for the OpenBMC dbus interface

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

ID:388 - Turn all messages into LOG_INFO in VITA discovery

... because people without VITA support don't care about errors related to VITA
discovery. This has been suggested as a part of the ticket

ID:388 - Turn all messages into LOG_INFO in VITA discovery

... because people without VITA support don't care about errors related to VITA
discovery. This has been suggested as a part of the ticket and "copied" after
PICMG discovery.

show more ...

ID:388 - Handle ccode 0xCC as well in VITA discovery

ID:390 - Support for new Communication Interface (USB Medium)

This feature request is for adding support for USB Medium as an interface in
IPMITool. AMI BMC (OEM feature) provides Virtual USB device

ID:390 - Support for new Communication Interface (USB Medium)

This feature request is for adding support for USB Medium as an interface in
IPMITool. AMI BMC (OEM feature) provides Virtual USB devices in the host as
part of its feature list. IPMITool can use this 'Virtual USB device' as a
medium for Inband communication with BMC.

Just like any other interface, use can just give 'ipmitool -I usb xxxx' to
communicate with the BMC via USB Interface.

show more ...

Remove trailing white-spaces in src/plugins/dummy/dummy.c

ID:391 - changing data_len from 17 to 16 according to ipmi spec 22.29, first byte is completion code

Remove trailing white-spaces in ipmi_user.c

ID:388 - Fix Error message always printed if BMC does not support VITA

Print error message for 0xC1 to LOG_DEBUG instead of LOG_ERR, because it isn't
an error if VITA isn't supported.

ID:389 - Add on of Advantech IANA number

Cleanup trailing white-spaces in ipmi_vita.c

ID:355 - Fix couple compiler warnings in ipmi_lanp.h

Commit fixes couple compiler warnings which come from ipmi_lanp.h by setting
values of struct attrs.

ID:376 - Add means to configure "Bad Password Threshold"

Add support for setting and printing of the "Bad Password Threshold"
LAN configuration parameter.

ID:384 - Fix compilation under cygwin64

Patch fixes several compile-time errors which appear during IPMITOOL
compilation in Cygwin64 environment.

Commit for: Dmitry Bazhenov

ID:383 - Fix compile-time error in src/plugins/lan/lan.c

Patch fixes an error of incompatible pointer type which appears during LAN
plugin compilation.

Commit for: Dmitry Bazhenov

ID:382 - Fix memcpy() params in HpmFwupgActionUploadFirmware()

The 'bufLength' variable holds a constant chunk size. If the actual
data length is less than the 'bufLength', then it crashes IPMITool.

ID:382 - Fix memcpy() params in HpmFwupgActionUploadFirmware()

The 'bufLength' variable holds a constant chunk size. If the actual
data length is less than the 'bufLength', then it crashes IPMITool. The
code was already there to calculate the remaining data length, but was
not used in memcpy(). We changed it to use the 'count' variable which
holds the proper available data length.

Commit for: Viswanathan Swaminathan

show more ...

ID:369 - Fix lanplus interface bridging and response matching

Request/response matching for bridged and double-bridged requests is broken.
This patch reworks the sending and command construction cod

ID:369 - Fix lanplus interface bridging and response matching

Request/response matching for bridged and double-bridged requests is broken.
This patch reworks the sending and command construction code, and fixes the
response matching problems.
Since the polling code is retried several times, it was moved into a separate
function in order to make the code more readable.

Commit for: Dmitry Bazhenov

show more ...

ID:368 - Fix handling of bridging-related parameters

1. my_addr is not set if an interface does not expose set_my_addr.
Currently, the only interface which requires some special handling to set

ID:368 - Fix handling of bridging-related parameters

1. my_addr is not set if an interface does not expose set_my_addr.
Currently, the only interface which requires some special handling to set
my_addr is OpenIPMI. But changing of my_addr still needed for other interfaces.
So, we must set it regardless of presence of set_my_addr().
2. Since set_my_addr() for serial interfaces only sets my_addr, we remove them
as redundand.
3. Bridging is enabled when either trasit_addr or target_addr is not 0.
Currentle transit_addr is not regarded.
4. target_lun does not relate to briging. It is needed for "raw" command. We
set it regardles of bridging.

Commit for: Dmitry Bazhenov

show more ...

ID:367 - Fix building of non-bridged LAN interface commands

When bridging is used (-t specifies an address which is different from 20h),
presession command must go to BMC_SLAVE_ADDR, not to target_a

ID:367 - Fix building of non-bridged LAN interface commands

When bridging is used (-t specifies an address which is different from 20h),
presession command must go to BMC_SLAVE_ADDR, not to target_addr.
BMC_SLAVE_ADDR is always used as the responder address in outer Send Message
request, when message is forwarded. Use the same approach for non-bridged
commands.

Commit for: Dmitry Bazhenov

show more ...

ID:366 - Properly clean LAN and LAN+ interfaces on close

When closing, LAN and LAN+ interfaces do not do proper cleaning of request
entries. Some pointers remain non NULL. This may cause bad memory

ID:366 - Properly clean LAN and LAN+ interfaces on close

When closing, LAN and LAN+ interfaces do not do proper cleaning of request
entries. Some pointers remain non NULL. This may cause bad memory references.

Commit for: Dmitry Bazhenov

show more ...

ID:365 - Fix for ipmitool crash when using serial-terminal interface

Negative value returned by serial_read_line() function was not properly
recognized, since the storage type was unsigned. This cau

ID:365 - Fix for ipmitool crash when using serial-terminal interface

Negative value returned by serial_read_line() function was not properly
recognized, since the storage type was unsigned. This caused ipmitool crash in
some sutuations. This patch fixes the problem.

Commit for: Dmitry Bazhenov

show more ...