ID: 3603419 - 'lib/ipmi_dcmi.c' - waste of resources

Commit moves one #ifdef upwards in the code, so resources are not wasted
pointlessly. There is no need to allocate memory for variables/structs a

ID: 3603419 - 'lib/ipmi_dcmi.c' - waste of resources

Commit moves one #ifdef upwards in the code, so resources are not wasted
pointlessly. There is no need to allocate memory for variables/structs and open
interface, if we're about to quit immediately because LAN+ support is not
enabled.
Error message got changed as well and it gets printed on STDERR where it
belongs!

show more ...

Do not bridge in-band ipmi requests when -m <local_addr> is specified without -t <target_address> on the command line. Prior to this change -m <local_addr> would always attempt to bride the request

Do not bridge in-band ipmi requests when -m <local_addr> is specified without -t <target_address> on the command line. Prior to this change -m <local_addr> would always attempt to bride the request becaues the default target_address was being set to 0x20 instead of zero. ID: 3605313

show more ...

ID: 3600911 - 'lib/ipmi_fru.c' - retval ipmi_fru_get_adjust_size_from_buffer()

Commit changes return value of ipmi_fru_get_adjust_size_from_buffer() from void
to int in order to determine whether c

ID: 3600911 - 'lib/ipmi_fru.c' - retval ipmi_fru_get_adjust_size_from_buffer()

Commit changes return value of ipmi_fru_get_adjust_size_from_buffer() from void
to int in order to determine whether call was successful or wasn't.
ipmi_fru_upg_ekeying() got re-work as well.

Changes to ipmi_fru_get_adjust_size_from_buffer():
* CHUNK_SIZE removed
* code formatting
* return value void -> int

Changes to ipmi_fru_upg_ekeying():
* check whether pFilename is NULL
* check return values of called functions
* re-work code - return early on error instead of nested if()
* added (error) messages

show more ...

compile fix. see previous revision diff and comment for code change reason

ID: 3600911 - 'lib/ipmi_fru.c' memory leaks

Commit fixes memory leanks in functions ipmi_fru_set_field_string() and
ipmi_fru_set_field_string_rebuild() in 'lib/ipmi_fru.c'.

Note: it seems to me lik

ID: 3600911 - 'lib/ipmi_fru.c' memory leaks

Commit fixes memory leanks in functions ipmi_fru_set_field_string() and
ipmi_fru_set_field_string_rebuild() in 'lib/ipmi_fru.c'.

Note: it seems to me like these for() cycles do nothing.

Reported-by: Ales Ledvinka

show more ...

ID: 3600910 - make ipmi_lcd_get_platform_model_name() to return int

Commit changes function ipmi_lcd_get_platform_model_name() to return integer
instead of void to signal potentional problems/issues

ID: 3600910 - make ipmi_lcd_get_platform_model_name() to return int

Commit changes function ipmi_lcd_get_platform_model_name() to return integer
instead of void to signal potentional problems/issues.

Reported-by: Ales Ledvinka

show more ...

ID: 3600928 - 'lib/ipmi_pef.c' handle unrecognized event trigger

Commit adds code to handle unrecognized event trigger in
ipmi_pef_print_event_info().

Reported-by: Ales Ledvinka

ID: 3600928 - 'lib/ipmi_pef.c' use 'else if ()' instead of 'if ()'

Commit trades 'if ()' for 'else if ()' and removes one pointless 'if ()' since
rsp isn't NULL at this point.

ID: 3600928 - 'lib/ipmi_pef.c' memory leaks

Commit fixes memory leaks in 'lib/ipmi_pef.c'.

Reported-by: Ales Ledvinka

ID: 3600910 - 'lib/ipmi_delloem.c' use 'else if' instead of 'if', use 'rc'

Commit changes are related to ipmi_ldc_set_lock() in 'lib/ipmi_delloem.c':
* use 'else if' instead of 'if' since it's the s

ID: 3600910 - 'lib/ipmi_delloem.c' use 'else if' instead of 'if', use 'rc'

Commit changes are related to ipmi_ldc_set_lock() in 'lib/ipmi_delloem.c':
* use 'else if' instead of 'if' since it's the same given the context and
probably better
* use 'rc' variable, since it's there, rather than 'return'

Note: ipmi_lcd_set_lock() would use some re-write.

Reported-by: Ales Ledvinka

show more ...

ID: 3600910 - 'lib/ipmi_delloem.c' remove unused variable

Commit removes unused variable 'dte' in ipmi_powermgmt() in
'lib/ipmi_delloem.c'.

ID: 3600927 - change eval order of input param in ipmi_oem_setup()

Commit changes evaluation order of 'oemtype' which is an input parameter to
ipmi_oem_setup() in 'lib/ipmi_oem.c'. Make the check wh

ID: 3600927 - change eval order of input param in ipmi_oem_setup()

Commit changes evaluation order of 'oemtype' which is an input parameter to
ipmi_oem_setup() in 'lib/ipmi_oem.c'. Make the check whether 'oemtype' is NULL
or not one of the first things we do rather than blindly use 'oemtype' in
strncmp() and then check if it isn't NULL. Yes, this is a potential crash
waiting to happen.

Reported-by: Ales Ledvinka

show more ...

ID: 3600930 - dead code in 'lib/ipmi_sdr.c'

Commit adds comment for dead code in 'lib/ipmi_sdr.c'. This part of code has
been purposefully turned off.

ID: 3600930 - 'lib/ipmi_sdr.c' - NULL dereference

Commit fixes NULL dereference in 'lib/ipmi_sdr.c' by checking whether Sensor is
type of 'full' or 'compact'.

Fix by: Jim Mank
Reported by: Ales Led

ID: 3600930 - 'lib/ipmi_sdr.c' - NULL dereference

Commit fixes NULL dereference in 'lib/ipmi_sdr.c' by checking whether Sensor is
type of 'full' or 'compact'.

Fix by: Jim Mank
Reported by: Ales Ledvinka

show more ...

ID: 3602439 - 'lib/ipmi_sdr.c' - memory leaks

Commit fixes memory leaks in 'lib/ipmi_sdr.c'. This is based on ticket #3600930.

Reported by: Ales Ledvinka

ID: 3601265 - # ipmitool sensor get; leaks memory
ID: 3601106 - # ipmitool sensor get NACname; output incorrect/inconsistent

After a lengthy discussion with Jim, I'm removing free() of sdr_record_li

ID: 3601265 - # ipmitool sensor get; leaks memory
ID: 3601106 - # ipmitool sensor get NACname; output incorrect/inconsistent

After a lengthy discussion with Jim, I'm removing free() of sdr_record_list in
ipmi_sensor_get() as this is freed in 'lib/ipmi_main.c' on/prior to ipmitool's
exit.

show more ...

3600962 descriptor leaks

3600914 no more crash on no response. allow more send/recv loops of waiting.

3600929 additional ticket request.

ID: 3601265 - # ipmitool sensor get; leaks memory

Commit fixes memory leak in ipmi_sensor_get() caused by not free()-ing
sdr_record_list.

ID: 3601106 - # ipmitool sensor get NACname; output incorrect/inconsistent

Commit re-works output of # ipmitool sensor get; command. It removes calls to
sensor specific functions with call to ipmi_s

ID: 3601106 - # ipmitool sensor get NACname; output incorrect/inconsistent

Commit re-works output of # ipmitool sensor get; command. It removes calls to
sensor specific functions with call to ipmi_sdr_print_listentry(). This way,
output is unified with the output of '-v sdr list' and actually has corrent
information. Well, at least errors are gone and no information seems to be
missing.
Commit fixes help and return codes as well.

show more ...

ID: 3600908 - 'lib/ipmi_dcmi.c' - crash in ipmi_print_sensor_info(), NULL ref

Commit fixes crash in ipmi_print_sensor_info() in 'lib/ipmi_dcmi.c' due to NULL
reference. 'rec' is correctly checked wh

ID: 3600908 - 'lib/ipmi_dcmi.c' - crash in ipmi_print_sensor_info(), NULL ref

Commit fixes crash in ipmi_print_sensor_info() in 'lib/ipmi_dcmi.c' due to NULL
reference. 'rec' is correctly checked whether NULL or not, but it's used
immediately despite of the outcome of the NULL test.
Also, ipmi_sdr_print_rawentry() is used instead of specific print function.

show more ...

3600907 defined value for "Chassis may not support Force Identify"

3600929 error keyword

3600921 similar code as hpmfwupg reading negative length from failed ftell