ID: 3608759 - Fix bug in configure.in when cross compiling

The previous test to see if we need pragma pack(1) was failing if we
cross compile because there was no way to run the test.

We now use AC

ID: 3608759 - Fix bug in configure.in when cross compiling

The previous test to see if we need pragma pack(1) was failing if we
cross compile because there was no way to run the test.

We now use AC_TRY_COMPILE and add the pragma pack(1) to the test code.
If it compiles, it must be good, so add the define.

Commit for Dan Gora

show more ...

ID: 2871903 - ipmitool user priv incorrectly sets Link Auth

Commit fixes issue in 'user priv' sub-command which turns off LinkAuth whenever
user's privilege is changed. This was caused by not settin

ID: 2871903 - ipmitool user priv incorrectly sets Link Auth

Commit fixes issue in 'user priv' sub-command which turns off LinkAuth whenever
user's privilege is changed. This was caused by not setting apropriate bits.
However, fix leverages Set User Access Command(IPMI spec. v2 PDF, p.320) and
sets 7th bit of 1st byte to 0. This tells BMC not to change IPMI messaging,
LinkAuth and Callback for given user.

As a consequence, ipmitool no longer turns 'IPMI messaging' on by default when
user's privilege is being set. IPMI messaging can be turned on/off via 'channel
setaccess' sub-command.

Reported-by: Kipp Glover

show more ...

ID: 3610286 - 'lib/ipmi_sdr.c' - ipmi_sdr_print_type - incorrect eval

Commit fixes incorrect evaluation of str2uchar() return value in
ipmi_sdr_print_type(). Prior to this fix, practically no user i

ID: 3610286 - 'lib/ipmi_sdr.c' - ipmi_sdr_print_type - incorrect eval

Commit fixes incorrect evaluation of str2uchar() return value in
ipmi_sdr_print_type(). Prior to this fix, practically no user input was accepted
as a valid one in # ipmitool sdr type HEX_SENSOR_TYPE ;

This bug was introduced by ID#3528368 - 'lib/ipmi_sdr.c' - possible int *flow

show more ...

Fix "help" command line processing in fru command defect (ID: 3610117)
introduced by the following changes:

ID: 3582307 - 'lib/ipmi_fru.c' - ipmi_fru_main() return codes
ID: 3582310 - 'lib/ipmi_fru.

Fix "help" command line processing in fru command defect (ID: 3610117)
introduced by the following changes:

ID: 3582307 - 'lib/ipmi_fru.c' - ipmi_fru_main() return codes
ID: 3582310 - 'lib/ipmi_fru.c' - ipmi_fru_main() - misuse of printf()

show more ...

ID: 3608758 - 'include/ipmitool/ipmi.h' - add IPMI_NETFN_OEM

Commit adds IPMI_NETFN_OEM code 0x2E for completeness.

Commit for Dan Gora

ID: 3609985 - delloem : Wrong MAC returned when flex addressing is enabled

Commit fixes problem in 'lib/ipmi_delloem.c'. Command % ipmitool delloem mac;
returns wrong MAC when flex addressing is ena

ID: 3609985 - delloem : Wrong MAC returned when flex addressing is enabled

Commit fixes problem in 'lib/ipmi_delloem.c'. Command % ipmitool delloem mac;
returns wrong MAC when flex addressing is enabled on the blade chassis.

Commit for Krishnaprasad K

show more ...

ID: 3016359 - Get SEL Alloc Information is incorrect

The Information given by the command SEL was incorrect in "Get SEL Allocation"
command. According to the specification "byte 10" in response deno

ID: 3016359 - Get SEL Alloc Information is incorrect

The Information given by the command SEL was incorrect in "Get SEL Allocation"
command. According to the specification "byte 10" in response denotes the
"Maximum record size in allocation units". This information is given as "Max
Record Size : " in sel command. However, ipmitool was getting "byte 9" instead
of "byte 10".

Commit for Gokulakannan

show more ...

ID: 3600933 - 'lib/ipmi_sol.c' - use of deprecated bzero()

Commit replaces deprecated bzero() call with memset().

Commit for Ales Ledvinka

ID: 3609472 - Add the instance to the SOL commands

The SOL protocol supports multiple serial ports using the "instance",
allow this to be passed in to ipmitool.

Commit for Corey Minyard

ID: 3609473 - Add assertion/deassertion to threshold events

The event data and SDRs support assertions and deassertions for threshold events
as well as discrete events. So print out assertion and de

ID: 3609473 - Add assertion/deassertion to threshold events

The event data and SDRs support assertions and deassertions for threshold events
as well as discrete events. So print out assertion and deassertion on all
events.

Commit for Corey Minyard

show more ...

ID: 3600911 - 'lib/ipmi_fru.c' - fix multiple increments in args to printf

Commit fixes multiple increments in arguments of printf() which leads to
undefined/inconsistent behaviour and results.

Rep

ID: 3600911 - 'lib/ipmi_fru.c' - fix multiple increments in args to printf

Commit fixes multiple increments in arguments of printf() which leads to
undefined/inconsistent behaviour and results.

Reported-by: Ales Ledvinka

show more ...

ID: 3608149 - ipmitool - set pointer to NULL after free()

Commit is a response(and fix) to double-free bug in 'lib/ipmi_main.c' via
username. Now, pointers should be set to NULL after calling free()

ID: 3608149 - ipmitool - set pointer to NULL after free()

Commit is a response(and fix) to double-free bug in 'lib/ipmi_main.c' via
username. Now, pointers should be set to NULL after calling free().

Reported-by: Ales Ledvinka

show more ...

ID: 3608261 - 'lib/ipmi_delloem.c' - code formatting

Commit changes code formatting in 'lib/ipmi_delloem.c' to be more consistent
with the rest of ipmitool's code. No functional changes are intended

ID: 3608261 - 'lib/ipmi_delloem.c' - code formatting

Commit changes code formatting in 'lib/ipmi_delloem.c' to be more consistent
with the rest of ipmitool's code. No functional changes are intended.
Clean up isn't perfect, but it's one of steps in long term effort.

show more ...

ID: 3608022 - 'lib/ipmi_fru.c' - unsigned errors

Commit removes 'size' check from ipmi_fru_get_multirec_from_file() as
an unsigned value can't be less than zero(0).
This error has been introduced by

ID: 3608022 - 'lib/ipmi_fru.c' - unsigned errors

Commit removes 'size' check from ipmi_fru_get_multirec_from_file() as
an unsigned value can't be less than zero(0).
This error has been introduced by ID#3600911.

Reported-by: Ales Ledvinka

show more ...

ID: 3607981 - 'lib/ipmi_lanp.c' - replace atoi() calls

Commit replaces atoi() calls with str2uchar() ones to eliminate possible int
*flow via user input.

ID: 3607320 - 'lib/ipmi_lanp.c' - possible NULL reference

Commit fixes possible NULL reference in 'lib/ipmi_lanp.c' which is caused by not
checking return value of get_lan_param(), resp. get_lan_par

ID: 3607320 - 'lib/ipmi_lanp.c' - possible NULL reference

Commit fixes possible NULL reference in 'lib/ipmi_lanp.c' which is caused by not
checking return value of get_lan_param(), resp. get_lan_param_select(). This
function can return NULL in certain situations.

show more ...

REVERT - ID: 3608261 - FReq - 'lib/ipmi_delloem.c' - clean up the code

I'm reverting previous commit. I'm not sure what happened, but there is a huge
difference between what got committed, what came

REVERT - ID: 3608261 - FReq - 'lib/ipmi_delloem.c' - clean up the code

I'm reverting previous commit. I'm not sure what happened, but there is a huge
difference between what got committed, what came as a diff in e-mail and what
should have been committed in the first place.

show more ...

ID: 3608261 - FReq - 'lib/ipmi_delloem.c' - clean up the code

Commit removes trailing white spaces and tabs in 'lib/ipmi_delloem.c'.

ID: 3608007 - 'lib/ipmi_session.c' - typo in error message

Commit fixes typo in error mesage in ipmi_session_main().

ID: 3600926 - 'lib/ipmi_lanp.c'

Commit replaces condition ``if (p == NULL)'' in get_lan_param_select(). This
condition is never met, because structure is on heap.
Condition is replaced by for() cont

ID: 3600926 - 'lib/ipmi_lanp.c'

Commit replaces condition ``if (p == NULL)'' in get_lan_param_select(). This
condition is never met, because structure is on heap.
Condition is replaced by for() control structure which goes through structure
ipmi_lan_params and checks whether requested LAN parameter is defined in
structure or not.

Reported-by: Ales Ledvinka

show more ...

ID: 3528247 - 'lib/ipmi_delloem.c' - fix possible *int flows

Commit fixes possible integer *flows in 'lib/ipmi_delloem.c'. Function
make_int() is removed and replaced with calls to appropriate str2*

ID: 3528247 - 'lib/ipmi_delloem.c' - fix possible *int flows

Commit fixes possible integer *flows in 'lib/ipmi_delloem.c'. Function
make_int() is removed and replaced with calls to appropriate str2*() function
calls from 'lib/helper.c'.

Reported-by: Duncan Idaho

show more ...

ID: 3576212 - 'lib/ipmi_event.c' - better rsp handling

Commit changes handling of response in ipmi_event_fromsensor(). If ccode doesn't
equal to 0, then error message is printed and function returns

ID: 3576212 - 'lib/ipmi_event.c' - better rsp handling

Commit changes handling of response in ipmi_event_fromsensor(). If ccode doesn't
equal to 0, then error message is printed and function returns.

Reported-by: Duncan Idaho

show more ...

ID: 3607393 - 'lib/ipmi_event.c' - redundant '\n' in error message

Commit removes redundant '\n' in error message.

revert back to the 1.8.11 default cipher suite of 3, ID: #3571371, #3576112

ID: 3600911 - 'lib/ipmi_fru.c' - rewrite of ipmi_fru_get_multirec_from_file()

Commit is a rewrite of function ipmi_fru_get_multirec_from_file() in
'lib/ipmi_fru.c'.
Changes:
* argument size is check

ID: 3600911 - 'lib/ipmi_fru.c' - rewrite of ipmi_fru_get_multirec_from_file()

Commit is a rewrite of function ipmi_fru_get_multirec_from_file() in
'lib/ipmi_fru.c'.
Changes:
* argument size is checked; size must be greater than 0
* argument pFileName is checked
* return value of seek() is checked
* error messages are printed on STDERR
* code flow got a re-work

show more ...