ID: 3611306 - 'lib/ipmi_tsol.c' - fix always fail in case of error

Commit fixes bug introduced by fix for ID#3600946 where
an error case was missing braces, so it would always fail.

Commit for Dan

ID: 3611306 - 'lib/ipmi_tsol.c' - fix always fail in case of error

Commit fixes bug introduced by fix for ID#3600946 where
an error case was missing braces, so it would always fail.

Commit for Dan Gora

show more ...

ID: 3608760 - Add bswap.h to ipmi_chassis.c and ipmi_pef.c
ID: 3564701 - ipmitool 1.8.12 doesn't build on big endian architectures

Compilation would fail on big endian architecture because BSWAP_32

ID: 3608760 - Add bswap.h to ipmi_chassis.c and ipmi_pef.c
ID: 3564701 - ipmitool 1.8.12 doesn't build on big endian architectures

Compilation would fail on big endian architecture because BSWAP_32 was not
defined in 'ipmi_chassis.c' and 'ipmi_pef.c'.

The problem was '#include <ipmitool/bswap.h>' depended on WORDS_BIGENDIAN which
comes from '<config.h>'. However, none of the previous header files
would include '<config.h>', so it remained undefined.

'bswap.h' gets included unconditionally now.

Commit for Dan Gora

show more ...

ID: 3608765 - improve debug output in ipmi_ekanalyzer_fru_file2structure()

Format the records a little more clearly by adding offsets.

Commit for Dan Gora

ID: 3608765 - Fix indentation of ipmi_ek_create_amc_p2p_record()

Commit changes indentation and formatting in ipmi_ek_create_amc_p2p_record().

Commit for Dan Gora

ID: 3608765 - Fix signed offset in ipmi_ekanalyzer_fru_file2structure

If the offset was greater than 127, then the multi_offset would end
up being a negative value, which is not what we want.

Commi

ID: 3608765 - Fix signed offset in ipmi_ekanalyzer_fru_file2structure

If the offset was greater than 127, then the multi_offset would end
up being a negative value, which is not what we want.

Commit for Dan Gora

show more ...

ID: 3608765 - ipmi_ekanalyzer_fru_file2structure would return error

ipmi_ekanalyzer_fru_file2structure would return ERROR_STATUS even if
it finished sucessfully.

Commit for Dan Gora

ID: 3608765 - Fix printing in ipmi_ek_display_amc_p2p_record()

Change the amc channel descriptor ports to be displayed in decimal
instead of hex. This matches the 'fru -v' output in ipmitool.

Add d

ID: 3608765 - Fix printing in ipmi_ek_display_amc_p2p_record()

Change the amc channel descriptor ports to be displayed in decimal
instead of hex. This matches the 'fru -v' output in ipmitool.

Add decimal value of Link Asymetric Match values. So people don't have to
look up the value in the source or in the PIGMG spec.

Commit for Dan Gora

show more ...

ID: 3608765 - ipmi_ekanalyzer.c - fix reading amc channel and link descriptors

Due to a bug in gcc where unaligned bit fields were not packed correctly
before gcc 4.4, we changed the fru_picmgext_am

ID: 3608765 - ipmi_ekanalyzer.c - fix reading amc channel and link descriptors

Due to a bug in gcc where unaligned bit fields were not packed correctly
before gcc 4.4, we changed the fru_picmgext_amc_channel_desc_record
and fru_picmgext_amc_link_desc_record structures to use
larger types to be packed correctly. This then requires
us to use the FRU_PICMGEXT_AMC_CHANNEL_DESC_RECORD_SIZE and
FRU_PICMGEXT_AMC_LINK_DESC_RECORD_SIZE defines instead of sizeof for
these structures.

Updated ipmi_ek_create_amc_p2p_record() and
ipmi_ek_display_amc_p2p_record() to read data in the correct byte order
on both big and little endian machines.

Commit for Dan Gora

show more ...

ID: 3608757 - ipmi_fru.h/ipmi_fru.c - various fixes

Fixed several bugs with printing out the Carrier and AMC connectivity
information with 'ipmitool -v fru'

There were several bugs that were caused

ID: 3608757 - ipmi_fru.h/ipmi_fru.c - various fixes

Fixed several bugs with printing out the Carrier and AMC connectivity
information with 'ipmitool -v fru'

There were several bugs that were caused due to using bitfields with
char types in ipmi_fru.h. GCC versions before v4.4 had a bug where
they did not pack the bitfields correctly if the bitfields were not
cleanly aligned with the underlying char type.

Fixed and cleaned up all other PICMG FRU records.

Commit for Dan Gora

show more ...

ID: 3608765 - Fixed big endian bug in ipmi_ek_display_carrier_connectivity.

Fixed a bug where the carrier connectivity point to point descriptor
was not being displayed properly when compiled on big

ID: 3608765 - Fixed big endian bug in ipmi_ek_display_carrier_connectivity.

Fixed a bug where the carrier connectivity point to point descriptor
was not being displayed properly when compiled on big endian machines.

Commit for Dan Gora

show more ...

ID: 3608765 - Fixed bug reading length in fru info on big endian machines

Fixed bugs in ipmi_ek_display_chassis_info_area(),
ipmi_ek_display_product_info_area(), and
ipmi_ekanalyzer_fru_file2structu

ID: 3608765 - Fixed bug reading length in fru info on big endian machines

Fixed bugs in ipmi_ek_display_chassis_info_area(),
ipmi_ek_display_product_info_area(), and
ipmi_ekanalyzer_fru_file2structure() where fread was being called to
read one byte of data into a int or long data type. This would result
in the value being byte swapped since the byte was read into the most
significant byte of the int (ie byte 0) on big endian machines.

Commit for Dan Gora

show more ...

ID: 3608765 - Fixed bug in ipmi_ek_display_board_info_area()

Previous versions were not setting the file_offset properly if a Custom
board type was found, which would prevent subsequent dissectors f

ID: 3608765 - Fixed bug in ipmi_ek_display_board_info_area()

Previous versions were not setting the file_offset properly if a Custom
board type was found, which would prevent subsequent dissectors from
operating properly and terminating the output of 'ipmitool ekanalyze
frushow oc=<atca carrier fruinfo>' early.

Rewrote ipmi_ek_display_board_info_area() to fix indentation and
to properly set the file_offset and end the while loop if a Custom
board_type was found.

Previous versions were also abusing the board_length variable,
treating it as an int and using it to break out of the loop.

Commit for Dan Gora

show more ...

ID: 3608765 - 'lib/ipmi_ekanalyzer.c' - reverse checks to reduce indentation

Rewrote ipmi_ek_display_chassis_info_area,
ipmi_ek_display_product_info_area, and
ipmi_ekanalyzer_fru_file2structure to r

ID: 3608765 - 'lib/ipmi_ekanalyzer.c' - reverse checks to reduce indentation

Rewrote ipmi_ek_display_chassis_info_area,
ipmi_ek_display_product_info_area, and
ipmi_ekanalyzer_fru_file2structure to reverse the checks of error
conditions to reduce the amount of indentation required.

Commit for Dan Gora

show more ...

ID: 3608763 - 'lib/ipmi_sdr.c' - update main help

Commit updates main help of 'lib/ipmi_sdr.c'. Changes:
* LOG_ERR -> LOG_NOTICE
* add error messages, eg. Invalid command, Not enough parameters etc.

ID: 3608763 - 'lib/ipmi_sdr.c' - update main help

Commit updates main help of 'lib/ipmi_sdr.c'. Changes:
* LOG_ERR -> LOG_NOTICE
* add error messages, eg. Invalid command, Not enough parameters etc.
* handle 'sdr fill INV_PARAM'
* return codes on error
* general fixes and changes of SDR help output

Reported-by: Dan Gora

show more ...

ID: 3608763 - 'lib/ipmi_sdr.c' - fix 'nosats' -> 'nosat'

I forgot to modify size of compared string passed to strncmp() while changing
'nosats' to 'nosat'.

ID: 3608763 - ipmi_sdr_print_type() print error if sensor not found

'sdr type <TYPE_OF_SENSOR>' - print error message if sensor of given type
was not found.

Commit for Dan Gora

ID: 3608763 - 'lib/ipmi_sdr.c' - fix 'nosats' -> 'nosat'

Commit fixes typo in strncmp() comparison of argv and changes 'nosats'
to 'nosat'.

Commit for Dan Gora

ID: 3608765 - 'lib/ipmi_ekanalyzer.c' - multiple increments in args to printf()

Performing prefix or postfix increments, eg. ++var or var++, in the
arguments to printf is inherently non-portable and

ID: 3608765 - 'lib/ipmi_ekanalyzer.c' - multiple increments in args to printf()

Performing prefix or postfix increments, eg. ++var or var++, in the
arguments to printf is inherently non-portable and may give different
results on different platforms.
Commit mends this issue.

Commit for Dan Gora

show more ...

ID: 3608765 - Remove unused variables from ipmi_ekanalyzer_ekeying_match().

Commit removes unused local variables from ipmi_ekanalyzer_ekeying_match().

Commit for Dan Gora

ID: 3608765 - Fix spelling of ipmi_ek_diplay_carrier_connectivity()

Commit corrects spelling of function ipmi_ek_display_carrier_connectivity().

Commit for Dan Gora

ID: 3608763 - 'lib/ipmi_sdr.c' - display hex values of Sensors

Commit adds the hex value for the sensor type to displays so that the user
can correlate sensor type values with their hex values witho

ID: 3608763 - 'lib/ipmi_sdr.c' - display hex values of Sensors

Commit adds the hex value for the sensor type to displays so that the user
can correlate sensor type values with their hex values without having to
look them up in the IPMI spec.

Commit for Dan Gora

show more ...

ID: 3608763 - Update sensor_type_desc values to differentiate watchdogs

Previous versions had two values for "Watchdog" in the list which
means that users could not perform # ipmitool sdr type "Watc

ID: 3608763 - Update sensor_type_desc values to differentiate watchdogs

Previous versions had two values for "Watchdog" in the list which
means that users could not perform # ipmitool sdr type "Watchdog";
and get the IPMI v1.0 and later version of the watchdog sensor,
eg. 0x23 instead of 0x11.

Commit for Dan Gora

show more ...

ID: 3608759 - Remove '-Wno-packed-bitfield-compat' from CFLAGS

Commit removes -Wno-packed-bitfield-compat from 'configure.in'. This was hiding
an important bug in ipmi_fru.h and is not a valid flag

ID: 3608759 - Remove '-Wno-packed-bitfield-compat' from CFLAGS

Commit removes -Wno-packed-bitfield-compat from 'configure.in'. This was hiding
an important bug in ipmi_fru.h and is not a valid flag for older versions of
gcc.

Commit for Dan Gora

show more ...

ID: 3608761 - 'lib/ipmi_main.c' - PICMG Get Device Locator was never run

This code was moved to ipmi_main.c from open.c and in the change a bug
was introduced where the PICMG Get Device Locator comm

ID: 3608761 - 'lib/ipmi_main.c' - PICMG Get Device Locator was never run

This code was moved to ipmi_main.c from open.c and in the change a bug
was introduced where the PICMG Get Device Locator command would not
be run unless the user explicitly set my_addr to 0 with the -m command.

The more sensible thing to do is to run this unless the user explictly
overrides it with the -m option.

Commit for Dan Gora

show more ...

ID: 3608762 - 'lib/ipm_hpmfwup.c' - Fixed help messages for hpm command

Commit cleans up the formatting of help output a bit to fit on an 80 column
screen.

Commit for Dan Gora