ID: 255 Fix some typos in ipmitool.1 (Debian Bug #554348)

Commit fixes couple typos in ipmitool's man page.

Commit for Stéphane Aulery

ID: 161 - documentation

Commit contains following documentation changes and related code usage changes:
* sorted arguments
* sorted command line commands
* adds missing arguments
* adds hidden alias

ID: 161 - documentation

Commit contains following documentation changes and related code usage changes:
* sorted arguments
* sorted command line commands
* adds missing arguments
* adds hidden aliases arguments with note of deprecation (feel free to remove if
not deprecated)
* fixes incomplete synopsis
* restructures synopsis to logical blocks
* conditional argument and command combination overrides to fixed defaults

Commit for Ales Ledvinka

show more ...

ID: 253 - Fix lanplus retransmission

Retransmission of lanplus request is broken. ipmi_lanplus_send_payload() keeps
current timeout in local variable 'timeout' and increases it by one with each
retr

ID: 253 - Fix lanplus retransmission

Retransmission of lanplus request is broken. ipmi_lanplus_send_payload() keeps
current timeout in local variable 'timeout' and increases it by one with each
retransmission. But ipmi_lan_poll_recv() waits for response for session->timeout
seconds, which is not incremented -> the request is retransmitted only once,
when timeout and session->timeout equals. No other retransmissions are ever
sent.

In addition, the time is measured in seconds, therefore 'time(NULL) - ltime'
often equals 'timeout' and retransmission should be sent in this case (i.e.
'xmit' should be set).

Commit for Jan Safranek

show more ...

ID: 254 - Fix retry of authentication capabilities retrieval

When lan or lanplus session is being opened, ipmi_get_auth_capabilities_cmd() is
called twice. Now that we have -R and -N options it's no

ID: 254 - Fix retry of authentication capabilities retrieval

When lan or lanplus session is being opened, ipmi_get_auth_capabilities_cmd() is
called twice. Now that we have -R and -N options it's not necessary to have such
weird code, especially with comment ``I'm not sure why we accept a failure for
the first call''.

Commit for Jan Safranek

show more ...

ID: 244 - "0.0" displayed for unspecified threshold values

Not all SEL entries have a "threshold value" specified, yet ipmitool sel elist
always displays a threshold value (as "0.0"), even when one

ID: 244 - "0.0" displayed for unspecified threshold values

Not all SEL entries have a "threshold value" specified, yet ipmitool sel elist
always displays a threshold value (as "0.0"), even when one is not specified.

Commit for Rob Swindell

show more ...

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

ipmi_macinfo() - return (-1) on error

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

ipmi_delloem_lan_main() - return (-1) on error.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

ipmi_powermgmt_clear - remove pointless if-else
Set clearType to 1 by default, so there is no need for if-else anymore.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

Remove `` )'' - white space.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

Don't ``function ()'' - remove white space.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

ipmi_lcd_set_single_line_text - invalid retval - Return (-1) on error as
specified instead of 1.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

pmi_macinfo_drac_idrac_mac - simplify - Return immediately if NicNum doesn't
meet expectations or UseVirtualMacAddress isn't 0.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

ipmi_macinfo_drac_virtual_mac - simplify - Return immediately if NicNum doesn't
meet expectations.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

ipmi_lcd_get_info - simplify - Remove pointless ``if () { } else { }'' and
return immediately on error.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

ipmi_lcd_get_info_wh - simplify - Remove pointless ``if () { } else { }'' and
return immediately on error.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

ipmi_get_power_consumption_data - simplify - If rsp is NULL or ccode is not 0,
then return immediately.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

Remove unnecessary if() from ipmi_print_power_cnsmpt_history().

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

ipmi_get_sd_card_info - return (-1) if no SD card is present.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

Don't prefix error message with extra white space(s).

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

lprintf() doesn't need '\n', so don't give it one.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

ipmi_delloem_vFlash_process() - use two lprintf() calls instead of one combined.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

Re-format all usage functions.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

Don't ``printf (...)'' -> ``printf(...)''.

ID: 28 - 'lib/ipmi_delloem.c' - clean up the code

Use lprintf() instead of printf() for error messages.

ID: 239 - typo in 'mc selftest', add details

Commit fixes a typo and adds details to 'mc selftest' command.

Commit for Rob Swindell