ID: 70 - Fixes and updates for ipmitool hpm

We now will print the decoded strings as well as the error value for
error response codes from the target.

Commit for Dan Gora

ID: 70 - Fixes and updates for ipmitool hpm

Update the help menu for the ipmitool hpm command. Fix the formatting
and explain better the options.

Changed the option 'upgrade <file> all' to 'upgrad

ID: 70 - Fixes and updates for ipmitool hpm

Update the help menu for the ipmitool hpm command. Fix the formatting
and explain better the options.

Changed the option 'upgrade <file> all' to 'upgrade <file> force'.
This makes it clearer that the user is overriding the version check
that 'upgrade <file>' performs.

Commit for Dan Gora

show more ...

ID: 70 - Fixes and updates for ipmitool hpm

Added a new field to show the Deferred firmware version value as part
of the 'hpm check' subcommand.

The deferred firmware version is the version of the

ID: 70 - Fixes and updates for ipmitool hpm

Added a new field to show the Deferred firmware version value as part
of the 'hpm check' subcommand.

The deferred firmware version is the version of the firmware which has
been loaded with the 'hpm upgrade' command, but not yet activated.

Commit for Dan Gora

show more ...

ID: 70 - Fixes and updates for ipmitool hpm

There is no point in putting the size of things in hex.

Commit for Dan Gora

ID: 70 - Fixes and updates for ipmitool hpm

Fixed a bug where the rolling percentage display could corrupt the
version line if the first call to HpmDisplayUpgrade resulted in a
non-zero percentage.

ID: 70 - Fixes and updates for ipmitool hpm

Fixed a bug where the rolling percentage display could corrupt the
version line if the first call to HpmDisplayUpgrade resulted in a
non-zero percentage.

This was produced by performing:

ipmitool hpm upgrade hpm1fru.img

where hpm1fru.img is a small (820 byte) file.

We now call HpmDisplayUpgrade before we transfer any data to ensure
that we get 0% printed before the transfer starts.

Commit for Dan Gora

show more ...

ID: 70 - Fixes and updates for ipmitool hpm

Add two additional chars to the component name string. For the
default Pigeon Point firmware names we need a couple of extra chars
to actually be able to

ID: 70 - Fixes and updates for ipmitool hpm

Add two additional chars to the component name string. For the
default Pigeon Point firmware names we need a couple of extra chars
to actually be able to tell what component is which.

Before:
-----------------------------------------------------
|ID | Name | Versions |
| | | Active | Backup |
-----------------------------------------------------
|*0 |H8S-AMCc F/| 2.00 10000000 | 2.00 0F000000 |
| 1 |H8S-AMCc B/| 2.00 00000000 | ---.-- -------- |
| 2 |H8S-AMCc F/| 2.00 10000000 | ---.-- -------- |
-----------------------------------------------------

After:
--------------------------------------------------------
|ID | Name | Versions |
| | | Active | Backup |
--------------------------------------------------------
|* 0|H8S-AMCc F/W | 2.00 10000000 | 2.00 0F000000 |
| 1|H8S-AMCc B/L | 2.00 00000000 | ---.-- -------- |
| 2|H8S-AMCc F/I | 2.00 10000000 | ---.-- -------- |
--------------------------------------------------------

Commit for Dan Gora

show more ...

ID: 70 - Fixes and updates for ipmitool hpm

Added a '^' character to the ID field which will be set if the
component can be upgraded with the specified file with the 'hpm check
<file>' subcommand.

ID: 70 - Fixes and updates for ipmitool hpm

Added a '^' character to the ID field which will be set if the
component can be upgraded with the specified file with the 'hpm check
<file>' subcommand.

Commit for Dan Gora

show more ...

ID: 70 - Fixes and updates for ipmitool hpm

Update HpmfwupgPreUpgradeCheck to check if the Aux version is also
different when it compares the Image version to the active and
rollback versions.

Fixe

ID: 70 - Fixes and updates for ipmitool hpm

Update HpmfwupgPreUpgradeCheck to check if the Aux version is also
different when it compares the Image version to the active and
rollback versions.

Fixed the indenting and style of HpmfwupgPreUpgradeCheck to make it
more readable.

Commit for Dan Gora

show more ...

ID: 259 - small memory leak in ipmi_user.c

Commit fixes a small memory leak in 'lib/ipmi_user.c' via strdup().
One typo got fixed in the process.

Squash white spaces in 'lib/ipmi_dcmi.c'

Commit squashes white spaces in 'lib/ipmi_dcmi.c'. Tabulators are used for
indentation now. I've tried to clean up comments, long lines, trailing white
space

Squash white spaces in 'lib/ipmi_dcmi.c'

Commit squashes white spaces in 'lib/ipmi_dcmi.c'. Tabulators are used for
indentation now. I've tried to clean up comments, long lines, trailing white
spaces and tabs, code formatting. However, more work is needed especially in
ipmi_dcmi_main() where indentation level is reaching one too many.

No functional changes.

show more ...

ID: 256 - ipmitool could crash when IPv6 address is returned

gethostbyname() can't handle IPv6. Despite this fact it seems worth of
nothing to check whether gethostbyname() really returned AF_INET o

ID: 256 - ipmitool could crash when IPv6 address is returned

gethostbyname() can't handle IPv6. Despite this fact it seems worth of
nothing to check whether gethostbyname() really returned AF_INET or
not. And that's what attached patch does, resp. in case IPv6 is
returned then ipmitool shoud/will terminate.

show more ...

ID: 257 ipmitool exec segfaults if invalid input given

Commit mitigates segfault in 'exec'/ipmishell when
invalid input is given. Code expects another _'_ or _"_ to come, but
if it doesn't, it ends

ID: 257 ipmitool exec segfaults if invalid input given

Commit mitigates segfault in 'exec'/ipmishell when
invalid input is given. Code expects another _'_ or _"_ to come, but
if it doesn't, it ends up r/w unallocated memory.

show more ...

ID: 101 - 'lib/ipmi_sol.c' - possible int *flow

Don't make ref out of ref -> segfault.

ID: 260 - ipmi_user.c - replace atoi() call

Commit replaces deprecated atoi() call.

ID: 101 - 'lib/ipmi_sol.c' - possible int *flow

Commit replaces unhandled strtol() calls with appropriate str2*() functions and
wrappers.

Reported-by: Duncan Idaho

Use tabs instead of white spaces for indentation in 'lib/ipmi_chassis.c'.

Added code to support sensors on other luns (On behalf of Kontron Germany)

ID: 113 - delloem exec file won't handle more than one command

Commit fixes issue with 'delloem' subcommands being executed via 'exec'. State
of variable 'current_arg' is kept between calls which le

ID: 113 - delloem exec file won't handle more than one command

Commit fixes issue with 'delloem' subcommands being executed via 'exec'. State
of variable 'current_arg' is kept between calls which leads to incorrect argv
parsing.
Set variable 'current_arg' every time ipmi_delloem_main() is called.

show more ...

ID: 211 - 'lib/ipmi_dcmi.c' - typo & error printed on STDOUT

Commit fixes couple typos and replaces incorrect printf() calls with appropriate
lprintf() ones.

ID: 153 - 'lib/ipmi_firewall.c' - printf() used instead of lprintf()

Commit adds printf_firewall_info_usage().

ID: 153 - 'lib/ipmi_firewall.c' - printf() used instead of lprintf()

Use lprintf() for error/help messages.

ID: 93 - 'lib/ipmi_firewall.c' - str-to-int conversion is weak

Commit does:
* adds is_ipmi_channel_num() in 'lib/helper.c' for IPMI Channel validation
* replaces unhandled strtol() calls in 'lib/ipm

ID: 93 - 'lib/ipmi_firewall.c' - str-to-int conversion is weak

Commit does:
* adds is_ipmi_channel_num() in 'lib/helper.c' for IPMI Channel validation
* replaces unhandled strtol() calls in 'lib/ipmi_firewall.c'

show more ...

ID: 226 - 'lib/ipmi_sdradd.c' - typo

Fix I2c -> I2C.

ID: 258 - ipmi_sdradd.c - error printed on STDOUT

Commit changes printf("...") -> lprintf(LOG_ERR, "...");

ID: 226 - 'lib/ipmi_sdradd.c' - redundant newline

Commit removes redundant new-lines from error messages in 'lib/ipmi_sdradd.c'.