ID:354 - struct member h_addr has been replaced

Struct member h_addr has been replaced some time ago and kept for backward
compatibility. Let's reflect on this and replace it with h_addr_list[0].

ID:354 - uint8_t >= 0 is always true, don't test it

Commit removes test whether value is greater or equal to 0 in
is_ipmi_channel_num(), because it's always true(and it makes compiler mad).

ID:354 - replace/drop caddr_t in IMB

Commit replaces caddr_t in IMB driver with char *. This is a wild guess
replacement, because caddr_t doesn't have to be char *. However, it shouldn't be
used and

ID:354 - replace/drop caddr_t in IMB

Commit replaces caddr_t in IMB driver with char *. This is a wild guess
replacement, because caddr_t doesn't have to be char *. However, it shouldn't be
used and so shouldn't mmap(). So we'll have to see how things work out.

http://computer-programming-forum.com/47-c-language/556a90938d01f023.htm

show more ...

ID:354 - Replace obsolete u_int[0-9]+_t with standardized types in Free iface

ID:354 - Replace obsolete u_int with uint32_t in dimm_spd.c

Fix of previous commit - memset() expects pointer

Commit fixes replacement of bzero() with memset(). memset() expects pointer and
pointer should be given to it.

Replace deprecated bzero() with memset()

Commit replaces deprecated bzero() with memset().

Fix user input validation in Channel and User sub-commands

Commit fixes validation of user input in Channel and User sub-commands.

Cleanup if/else in ipmi_channel_main()

Cleanup of code formatting in ipmi_channel.c

At least a bit.

ID:349 - user set password - add option to choose 16/20 byte password

Commit adds option to 'user set password' to choose whether password should be
stored as 16 byte or 20 byte. From now on, it's p

ID:349 - user set password - add option to choose 16/20 byte password

Commit adds option to 'user set password' to choose whether password should be
stored as 16 byte or 20 byte. From now on, it's possible to store even 5 bytes
long password as 20 byte password which should make it useless for IPMI v1.5
auth/sessions.

show more ...

Make user User Privilege Limit is within range

Despite the fact we could leave this up to IPMI stack, we won't do that.
Therefore, is_ipmi_user_priv_limit() is added and user provided value checked.

Create ask_password() and re-use code

Commit add function ask_password() which leads to code re-usability and shedding
couple lines of otherwise redundant code.

Fix 'user help' output

Commit fixes padding of 'user help' output. Also, list of expected values of
privilege leves have been added.

Don't use tmp variable since it's not necessary in ipmi_user_test()

Split ipmi_user_main() into smaller functions

Commit splits ipmi_user_main() into smaller functions. Hopefully, this will be
better than giant main() function.

Clenaup formatting in ipmi_user_main()

Code cleanup in ipmi_user_main()

This is just a tip of an iceberg, really.

Cleanup formatting in ipmi_user_main()

Remove trailing white-spaces in ipmi_user.c

ID:348 Add support for the "System Firmware Version"

Add support for the "System Firmware Version" parameter selector (1) to the "Get
System Info Parameters" command ("mc getsysinfo system_fw_versio

ID:348 Add support for the "System Firmware Version"

Add support for the "System Firmware Version" parameter selector (1) to the "Get
System Info Parameters" command ("mc getsysinfo system_fw_version"). The "mc
getsysinfo" command was already implemented and supported, but strangely, only
standard parameter selecter values 2, 3, 4 and Dell-defined parameters were
supported; the standard parameter value 1 (system firmare version) was not
supported.

show more ...

ID:347 - Incorrect reserved channel number

Fix validation of IPMI channel numbers according to IPMIv2.0 rev1.1 and update
documentation as well.

ID:343 - Remove AC_FUNC_MALLOC

Fix cross-compile build error regarding to 'rpl_malloc'.
ipmitool actually does not need the GNU's malloc(0) behavior.
So, remove AC_FUNC_MALLOC from AC-script in orde

ID:343 - Remove AC_FUNC_MALLOC

Fix cross-compile build error regarding to 'rpl_malloc'.
ipmitool actually does not need the GNU's malloc(0) behavior.
So, remove AC_FUNC_MALLOC from AC-script in order to help
cross-compiling ipmitool without need to directly specify
ac_cv_func_malloc_0_nonnull environment variable.

show more ...

ID:345 - Do not do several close session retries when catching SIGINT

Reduce number of retries to 1 when closing interface on SIGINT.
This reduces time needed to terminate the LAN connection.

ID:346 - lib/ipmi_sdradd.c ipmi_sdr_read_record has a file descriptor leak

'lib/ipmi_sdradd.c' ipmi_sdr_read_records() opens a file descriptor and never
closes it. Here is a patch in use by SGI for

ID:346 - lib/ipmi_sdradd.c ipmi_sdr_read_record has a file descriptor leak

'lib/ipmi_sdradd.c' ipmi_sdr_read_records() opens a file descriptor and never
closes it. Here is a patch in use by SGI for quite some time now. Suggested
patch attached.

show more ...