ID:391 - changing data_len from 17 to 16 according to ipmi spec 22.29, first byte is completion code

Remove trailing white-spaces in ipmi_user.c

Merge commit '2f5789750183d4ef8be125b8cb32019441dd0530'

Return codes of functions should be either used or evaluated - always. This
merge is necessary for shell scripting to, eg. signal

Merge commit '2f5789750183d4ef8be125b8cb32019441dd0530'

Return codes of functions should be either used or evaluated - always. This
merge is necessary for shell scripting to, eg. signal there was an error during
execution.

show more ...

_ipmi_set_user_password() - fix missing intf parameter in documentation

Remove ipmi_user_set_password()

Commit removes ipmi_user_set_password() as it's not being used anywhere.

Hook functions in ipmi_user to _ipmi_set_user_password()

Commit hooks functions in ipmi_user to _ipmi_set_user_password() instead of
ipmi_user_set_password().

Add _ipmi_set_user_password() function

Commit adds _ipmi_set_user_password() which is implementation of (22.30) Set
User Command. Function doesn't print anything on stdout/stderr.

Move #define from ipmi_user.c to ipmi_user.h

Commit moves defines of Set User Password operations to header file.

Init user_access_t struct in ipmi_user_priv()

Hook ipmi_user_priv() to _ipmi_set_user_access()

Commit hooks ipmi_user_priv() to _ipmi_set_user_access(). Later got extended for
'change_priv_limit_only', because of the former.
Com

Hook ipmi_user_priv() to _ipmi_set_user_access()

Commit hooks ipmi_user_priv() to _ipmi_set_user_access(). Later got extended for
'change_priv_limit_only', because of the former.
Commit removes ipmi_user_set_userpriv(), because it's not used anywhere.

show more ...

Hook ipmi_print_user_list() and friends to _ipmi_* functions

Commit hooks ipmi_print_user_list() and related functions to new _ipmi_*
functions. It also removes old/unused functions and

Hook ipmi_print_user_list() and friends to _ipmi_* functions

Commit hooks ipmi_print_user_list() and related functions to new _ipmi_*
functions. It also removes old/unused functions and user_access_rsp struct.

show more ...

ipmi_print_user_summary() to utilize _ipmi_get_user_access()

Commit changes ipmi_print_user_summary() to utilize _ipmi_get_user_access() and
user_access_t instead of user_access_rsp.

Fix/remove pointer cast in _ipmi_set_user_access()

Commit removes invalid pointer in _ipmi_set_user_access().

Add _ipmi_get_user_access() and _ipmi_set_user_access()

Commit adds reusable functions _ipmi_get_user_access() and
_ipmi_set_user_access().

Add _ipmi_get_user_name()

Commit adds function _ipmi_get_user_name() which does nothing but fetches User
Name as per 22.29. There are no print-outs when the called.

Fix eval logic in ipmi_user_priv()

Commit fixes bug in eval logic of user input sanitization, resp. && -> ||. Also,
priv_level and user_id variables are initialized to 0 now(CID#1261318).

Fix user input validation in Channel and User sub-commands

Commit fixes validation of user input in Channel and User sub-commands.

ID:349 - user set password - add option to choose 16/20 byte password

Commit adds option to 'user set password' to choose whether password should be
stored as 16 byte or 20 byte. From no

ID:349 - user set password - add option to choose 16/20 byte password

Commit adds option to 'user set password' to choose whether password should be
stored as 16 byte or 20 byte. From now on, it's possible to store even 5 bytes
long password as 20 byte password which should make it useless for IPMI v1.5
auth/sessions.

show more ...

Make user User Privilege Limit is within range

Despite the fact we could leave this up to IPMI stack, we won't do that.
Therefore, is_ipmi_user_priv_limit() is added and user provided va

Make user User Privilege Limit is within range

Despite the fact we could leave this up to IPMI stack, we won't do that.
Therefore, is_ipmi_user_priv_limit() is added and user provided value checked.

show more ...

Create ask_password() and re-use code

Commit add function ask_password() which leads to code re-usability and shedding
couple lines of otherwise redundant code.

Fix 'user help' output

Commit fixes padding of 'user help' output. Also, list of expected values of
privilege leves have been added.

Don't use tmp variable since it's not necessary in ipmi_user_test()

Split ipmi_user_main() into smaller functions

Commit splits ipmi_user_main() into smaller functions. Hopefully, this will be
better than giant main() function.

Clenaup formatting in ipmi_user_main()

Code cleanup in ipmi_user_main()

This is just a tip of an iceberg, really.