IPMIFruArea: move source into separate fru_area.cpp

Move the implementation of the class into its own source file.

Change-Id: I02d941dd8173f0cede8cdfe8af1fdc5f5418abb4
Signed-off-by: Patrick Ventur

IPMIFruArea: move source into separate fru_area.cpp

Move the implementation of the class into its own source file.

Change-Id: I02d941dd8173f0cede8cdfe8af1fdc5f5418abb4
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

fru_area: cleanup headers

Cleanup headers, dropping sd-bus header and c-headers. Add in cstdint
for uint8_t.

Change-Id: I751478a83ac807b688bb9b7d9efff2efc7578a4a
Signed-off-by: Patrick Venture <ve

fru_area: cleanup headers

Cleanup headers, dropping sd-bus header and c-headers. Add in cstdint
for uint8_t.

Change-Id: I751478a83ac807b688bb9b7d9efff2efc7578a4a
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

cleanup: rename fru_area_vec_t type and use using

Rename fru_area_vec_t to FruAreaVector and declare with using instead of
typedef.

Change-Id: I482c8ce7cedef1c67efb49b2e066ba9867547e93
Signed-off-b

cleanup: rename fru_area_vec_t type and use using

Rename fru_area_vec_t to FruAreaVector and declare with using instead of
typedef.

Change-Id: I482c8ce7cedef1c67efb49b2e066ba9867547e93
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

rename header: fru-area.hpp to fru_area.hpp

Rename fru-area.hpp header file per the openbmc file naming convention.

Change-Id: I751c8d5650bb5e71238923c4728a9cdedccc7c7f
Signed-off-by: Patrick Ventu

rename header: fru-area.hpp to fru_area.hpp

Rename fru-area.hpp header file per the openbmc file naming convention.

Change-Id: I751c8d5650bb5e71238923c4728a9cdedccc7c7f
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata.cpp: drop unused, add used header

Drop the sdbusplus/server.hpp for sdbusplus/bus.hpp header.

Change-Id: I8ea1ae95812ceb911ac6f70f259b5884e0c4ab3b
Signed-off-by: Patrick Venture <ventu

writefrudata.cpp: drop unused, add used header

Drop the sdbusplus/server.hpp for sdbusplus/bus.hpp header.

Change-Id: I8ea1ae95812ceb911ac6f70f259b5884e0c4ab3b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

ipmi_fru: Rename to IPMIFruArea

Rename ipmi_fru to IPMIFruArea

FRU is an acronym for Field Replaceable Unit, but is consistently Fru in
this codebase.

Change-Id: I53f82b51bbf01416c8a666082612cd709

ipmi_fru: Rename to IPMIFruArea

Rename ipmi_fru to IPMIFruArea

FRU is an acronym for Field Replaceable Unit, but is consistently Fru in
this codebase.

Change-Id: I53f82b51bbf01416c8a666082612cd70945cc9a5
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

ipmi_fru: drop unused sd_bus pointer

Drop unused sd_bus pointer from fru_info class.

Change-Id: Id93412c17d15118e8e6f66736c9dc74289392fa4
Signed-off-by: Patrick Venture <venture@google.com>

ipmi_fru: drop unused member functions

Drop unused member functions from fru_info class.

Change-Id: Iedf108979892cf12639652bd649efb5c2d7a74ef
Signed-off-by: Patrick Venture <venture@google.com>

writefrudata: drop unused lib mapper header

Drop unused lib mapper header.

Change-Id: Ia7d2aad793d49d0c0cd5c5636e1e240147c25188
Signed-off-by: Patrick Venture <venture@google.com>

writefrudata: drop unused dynamic linking header

Drop unused header: dlfcn.h

Change-Id: I1ea305913572003fabf0c2b76e75f04640bb55cb
Signed-off-by: Patrick Venture <venture@google.com>

writefrudata.cpp: add header for file

Add header writefrudata.hpp to corresponding file.

Change-Id: I2bec36d3c0744e7c496e7b7c161dfc6cf14bdf72
Signed-off-by: Patrick Venture <venture@google.com>

writefrudata: add missing header: map

Add missing header map to add to standard namespace.

Change-Id: I719fd0d194cb6fd8fa2e67f8acb784b498cf122a
Signed-off-by: Patrick Venture <venture@google.com>

writefrudata.cpp: fixup variable shadowing

[writefrudata.cpp:176] -> [writefrudata.cpp:242]: (style) Local
variable path shadows outer symbol

Change-Id: I9fc35d6d67f51a0b9a2b9174c314e560d8531119
Si

writefrudata.cpp: fixup variable shadowing

[writefrudata.cpp:176] -> [writefrudata.cpp:242]: (style) Local
variable path shadows outer symbol

Change-Id: I9fc35d6d67f51a0b9a2b9174c314e560d8531119
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

style: rename update_inventory, move into anonymous

Move ipmi_update_inventory into an anonymous namespace and rename per
the openbmc style naming conventions.

Change-Id: I931bd9a50ca695d667eb57030

style: rename update_inventory, move into anonymous

Move ipmi_update_inventory into an anonymous namespace and rename per
the openbmc style naming conventions.

Change-Id: I931bd9a50ca695d667eb5703089f1ca020ca6995
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

style: move getService into anonymous namespace

Move getService into an anonymous namespace.

Change-Id: I75df449858bdc8347fafe3c0ab839ff18b5a2496
Signed-off-by: Patrick Venture <venture@google.com>

style: move getFRUValue into anonymous namespace

Move getFRUValue into anonymous namespace. A later step may move this
into a global scope to enable testing, or it may be replaced by an
interface.

style: move getFRUValue into anonymous namespace

Move getFRUValue into anonymous namespace. A later step may move this
into a global scope to enable testing, or it may be replaced by an
interface.

Change-Id: Ie4299ab713a455dd8c18b91c842ded5dfc26e85b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

style: rename cleanup_error, move into anonymous

Move cleanup_error into an anonymous namespace and rename per the
openbmc style naming conventions.

Change-Id: Ib307ce2e89ecaff241c7b2d2403b75dbce79

style: rename cleanup_error, move into anonymous

Move cleanup_error into an anonymous namespace and rename per the
openbmc style naming conventions.

Change-Id: Ib307ce2e89ecaff241c7b2d2403b75dbce794dbb
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

style: apply naming convention to ipmi_validate_fru_area

Apply openbmc style naming convention to ipmi_validate_fru_area as part
of a multi-step cleanup process.

Change-Id: I082189030441e57579d0725

style: apply naming convention to ipmi_validate_fru_area

Apply openbmc style naming convention to ipmi_validate_fru_area as part
of a multi-step cleanup process.

Change-Id: I082189030441e57579d072501279ff698fe1b7e3
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: add function header

Change-Id: Ibfe32351e04ace02cb830399a56cf1860a74df87
Signed-off-by: Patrick Venture <venture@google.com>

writefrudata: cleanup header

Cleanup header from unnecessary guarding. The guards may have been
required in earlier compilations if the source was in a mixed
environment.

Change-Id: Id03a524ad8bd1

writefrudata: cleanup header

Cleanup header from unnecessary guarding. The guards may have been
required in earlier compilations if the source was in a mixed
environment.

Change-Id: Id03a524ad8bd1375f1aefc0bec8661e4d929543a
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

frup: add missing header

Add missing header "utility" provides std::pair<>.

Change-Id: I5d303c5f41f7af16ef3dc75fdd9818ed17978a5a
Signed-off-by: Patrick Venture <venture@google.com>

types: fixup header

Fixup types.hpp to include the message header that provides the types
used.

Change-Id: If75a3288aa9a1ecd8313d50caf8d93f76e1ce06d
Signed-off-by: Patrick Venture <venture@google.c

types: fixup header

Fixup types.hpp to include the message header that provides the types
used.

Change-Id: If75a3288aa9a1ecd8313d50caf8d93f76e1ce06d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

readeeprom: use log error instead of fprintf(stderr)

Use log<level::ERR>() instead of fprintf(stderr,...) on failure to
connect to sdbus.

Change-Id: Ie32d4f02c83a2d204ab71f0ab178d60c136dff97
Signed

readeeprom: use log error instead of fprintf(stderr)

Use log<level::ERR>() instead of fprintf(stderr,...) on failure to
connect to sdbus.

Change-Id: Ie32d4f02c83a2d204ab71f0ab178d60c136dff97
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: drop function parameter set

[writefrudata.cpp:570]: (warning) Assignment of function parameter has
no effect outside the function. Did you forget dereferencing it?

Change-Id: Ie4162c2

writefrudata: drop function parameter set

[writefrudata.cpp:570]: (warning) Assignment of function parameter has
no effect outside the function. Did you forget dereferencing it?

Change-Id: Ie4162c28c10aa5964ebabb5f0db5f3f477ffa831
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: swap in log<> calls, cleanup c calls

Transition debug and error output to use log<> mechanism.
Transition c-library or compiler choice calls to cpp libraries.

Change-Id: I1b5c6327897c

writefrudata: swap in log<> calls, cleanup c calls

Transition debug and error output to use log<> mechanism.
Transition c-library or compiler choice calls to cpp libraries.

Change-Id: I1b5c6327897c30be1be2f34212138b8cacb0bc84
Signed-off-by: Patrick Venture <venture@google.com>

show more ...