use registerHandler instead of ipmi_register_callback

Since ipmi_register_callback declared in api.h has been gradually
deprecated, this patch is to use registerHandler instead of
ipmi_register_call

use registerHandler instead of ipmi_register_callback

Since ipmi_register_callback declared in api.h has been gradually
deprecated, this patch is to use registerHandler instead of
ipmi_register_callback.

Change-Id: I90d1e78593abcad117afa9330602c46d7f237c20
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

remove IPMI_FRU_PARSER_DEBUG

Since IPMI_FRU_PARSER_DEBUG is no longer used, this commit removes
IPMI_FRU_PARSER_DEBUG and convert logging to lg2::debug.

Change-Id: Ib2ce2bd57aac534e9ad0379f547006ce

remove IPMI_FRU_PARSER_DEBUG

Since IPMI_FRU_PARSER_DEBUG is no longer used, this commit removes
IPMI_FRU_PARSER_DEBUG and convert logging to lg2::debug.

Change-Id: Ib2ce2bd57aac534e9ad0379f547006ce7ddd864e
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Update the registered IPMI method name

Update registered IPMI method names to use `Lower Camel Case`.

Change-Id: I05bce3cbc6969872d239e2f304eaa9fa81215502
Signed-off-by: George Liu <liuxiwei@ieisys

Update the registered IPMI method name

Update registered IPMI method names to use `Lower Camel Case`.

Change-Id: I05bce3cbc6969872d239e2f304eaa9fa81215502
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

convert logging to lg2

Change-Id: I9a62a7cd3d5a9e3a98f7c9ee053b8138b2698c80
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

remove IPMI_CC

Since IPMI_CC declared in api.h has been gradually deprecated,
this submission will use ipmi::cc in api.hpp instead.

Change-Id: Ia4858024e78903c52065f4e7e3e97df226883756
Signed-off-b

remove IPMI_CC

Since IPMI_CC declared in api.h has been gradually deprecated,
this submission will use ipmi::cc in api.hpp instead.

Change-Id: Ia4858024e78903c52065f4e7e3e97df226883756
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

clang-tidy: Initial Commit

Added initial .clang-tidy configuration file with recommended C++ checks
aligned with the OpenBMC-approved checklist. This setup enforces modern
C++ best practices and hel

clang-tidy: Initial Commit

Added initial .clang-tidy configuration file with recommended C++ checks
aligned with the OpenBMC-approved checklist. This setup enforces modern
C++ best practices and helps catch common issues early in development.

Tested: Verified build.

Change-Id: I216ab8d142e0d6fa069244c2c3f885dff7c028e3
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Fix unused private field warnings

Resolved -Wunused-private-field warnings flagged by clang-tidy
by eliminating unused private member variables from the class.

Change-Id: I12054e7e32507

clang-tidy: Fix unused private field warnings

Resolved -Wunused-private-field warnings flagged by clang-tidy
by eliminating unused private member variables from the class.

Change-Id: I12054e7e32507bf14a3fff0ba2dac4ec4c8f7327
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Replaced C-Style Casts with C++-Style

Resolved the following style warnings by replacing C-style casts
with appropriate C++-style casts

'''
frup.cpp:193:34: style: C-style pointer c

clang-tidy: Replaced C-Style Casts with C++-Style

Resolved the following style warnings by replacing C-style casts
with appropriate C++-style casts

'''
frup.cpp:193:34: style: C-style pointer casting [cstyleCast]
const uint8_t* areabufptr = (const uint8_t*)areabuf;
^
frup.cpp:255:34: style: C-style pointer casting [cstyleCast]
const uint8_t* areabufptr = (const uint8_t*)areabuf;
^
frup.cpp:333:34: style: C-style pointer casting [cstyleCast]
const uint8_t* areabufptr = (const uint8_t*)areabuf;
^
frup.cpp:463:34: style: C-style pointer casting [cstyleCast]
const uint8_t* areabufptr = (const uint8_t*)areabuf;
^
frup.cpp:611:26: style: C-style pointer casting [cstyleCast]
char* bin_in_ascii = (char*)malloc(bin_in_ascii_len);
^
frup.cpp:616:24: style: C-style pointer casting [cstyleCast]
char* bin_copy = &((char*)bin_in_ascii)[2];
^
frup.cpp:710:17: style: C-style pointer casting [cstyleCast]
(uint8_t*)msgbuf + 2, len, &chassis_type,
^
6/7 files checked 0% done
frup.cpp:737:17: style: C-style pointer casting [cstyleCast]
(uint8_t*)msgbuf + 2, len, nullptr, &mfg_date_time,
^
frup.cpp:769:17: style: C-style pointer casting [cstyleCast]
(uint8_t*)msgbuf + 2, len, nullptr,
'''

Change-Id: Ifa13f8e5033ab09710ac6c7fa329396984947fc8
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

NetFn: Use api.hpp instead of api.h

Since NetFn declared in api.h has been gradually deprecated, this
submission is to use api.hpp instead of api.h.

https://gerrit.openbmc.org/c/openbmc/phosphor-ho

NetFn: Use api.hpp instead of api.h

Since NetFn declared in api.h has been gradually deprecated, this
submission is to use api.hpp instead of api.h.

https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/79391

Change-Id: Ib8aa5783234b7c47c987da2b857532c9ac02b711
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

clang-tidy:scripts change filenames to [ch]pp.mako

Openbmc typically name mako files as "foo.type.mako" instead of
"foo.mako.type" because many tools mistakenly identify the file
type as "type" rath

clang-tidy:scripts change filenames to [ch]pp.mako

Openbmc typically name mako files as "foo.type.mako" instead of
"foo.mako.type" because many tools mistakenly identify the file
type as "type" rather than "mako". Currently, Meson is incorrectly
including these files in the `clang-tidy` invocation, causing errors.
Rename the files both to fit convention and to avoid the issues.

Change-Id: Ib97f494bd79232d761afd5f740932fe1739a6c4e
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

Change-Id: I0e0749db217667d9c3f51f8fac6cb58e8915e8d2
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: suppress unknown warning group

The following errors were reported during clang-tidy enablement due
to unknown warning group. This temporary fix is to extend the
existing pragma for the c

clang-tidy: suppress unknown warning group

The following errors were reported during clang-tidy enablement due
to unknown warning group. This temporary fix is to extend the
existing pragma for the clang, until a permanent solution is
implemented.

'''
frup.cpp:630:32: [0m[0;1;31merror: [0m[1munknown warning group '-Wstringop-truncation', ignored [-Werror,-Wunknown-warning-option]
'''

Tested: Build and unit testing verified.

Change-Id: If95f70354fedca7d041f0529ae1c4fc8e03ef7c5
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I92f6993193f38689416252c33fdba5f8dcb857c0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I62a2e66ce0ab39ba7146f677823cf12a1f50c17c
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I62a2e66ce0ab39ba7146f677823cf12a1f50c17c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: I006516b1bdf67f6e8f01b151644fb2b0ae75413e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I98f262c24e427f4228b184715d7ad88b0d7060f6
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ifdce925775a753cb71bfe44f3229d434b173283b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3a511d2180b4f77d727275df11a4804d13bce05d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I9afbcdacb8d77eed50119c015d71a6cdf0518d2b

show more ...

scripts: remove unused gen_pimrules.py

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib6fccba3d892c49818161077437542559f1220ae

build: remove autotools support

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I464fb65b640a078ba880c3c8c75d85234568e12e

build: install strgfnhandler into ipmi-providers dir

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I454ea1157f5bf75937a2215317ab018fefee2252

build: enable meson builds

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2f56761421ee765bc616397c0ad5b88f4e5bc0e9

scripts: accept absolute paths to YAML

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I94044f096db64e6152bf4e7cd3bff7159e1cc85a

frup: suppress stringop-truncation warning

The code involved here doesn't entirely make sense because it is
performing a sequence of hex to ascii conversions, but then
overwriting the beginning with

frup: suppress stringop-truncation warning

The code involved here doesn't entirely make sense because it is
performing a sequence of hex to ascii conversions, but then
overwriting the beginning with a "0x", which seems to lose the
first 2 bytes.

Until someone has a chance to unravel this code and turn it into
a more modern implementation, suppress the GCC warning about string
truncation (since the string truncation is done by design).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0e5001396a037cacbe7f8c534eddb8381385ebed

show more ...