0b0e1487 | 06-Feb-2025 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy:scripts change filenames to [ch]pp.mako
Openbmc typically name mako files as "foo.type.mako" instead of "foo.mako.type" because many tools mistakenly identify the file type as "type" rath
clang-tidy:scripts change filenames to [ch]pp.mako
Openbmc typically name mako files as "foo.type.mako" instead of "foo.mako.type" because many tools mistakenly identify the file type as "type" rather than "mako". Currently, Meson is incorrectly including these files in the `clang-tidy` invocation, causing errors. Rename the files both to fit convention and to avoid the issues.
Change-Id: Ib97f494bd79232d761afd5f740932fe1739a6c4e Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
883aa420 | 18-Dec-2024 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: Replace NULL with nullptr
Replaced all instances of NULL with nullptr to improve type safety and clarity, as nullptr is the modern C++ standard for null pointers.
Tested: Build verified
clang-tidy: Replace NULL with nullptr
Replaced all instances of NULL with nullptr to improve type safety and clarity, as nullptr is the modern C++ standard for null pointers.
Tested: Build verified
Change-Id: I0e0749db217667d9c3f51f8fac6cb58e8915e8d2 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
4abe0eee | 18-Dec-2024 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: suppress unknown warning group
The following errors were reported during clang-tidy enablement due to unknown warning group. This temporary fix is to extend the existing pragma for the c
clang-tidy: suppress unknown warning group
The following errors were reported during clang-tidy enablement due to unknown warning group. This temporary fix is to extend the existing pragma for the clang, until a permanent solution is implemented.
''' frup.cpp:630:32: [0m[0;1;31merror: [0m[1munknown warning group '-Wstringop-truncation', ignored [-Werror,-Wunknown-warning-option] '''
Tested: Build and unit testing verified.
Change-Id: If95f70354fedca7d041f0529ae1c4fc8e03ef7c5 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
4bb4cfd2 | 01-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
meson: reformat with meson formatter
Apply the `meson format` results.
Change-Id: I92f6993193f38689416252c33fdba5f8dcb857c0 Signed-off-by: Patrick Williams <patrick@stwcx.xyz> |
dedaef57 | 01-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: I62a2e66ce0ab39ba7146f677823cf12a1f50c17c Signed-off-by: Patrick Williams <p
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: I62a2e66ce0ab39ba7146f677823cf12a1f50c17c Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
4db17e95 | 18-Dec-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-19
clang-format-19 isn't compatible with the clang-format-18 output, so we need to reformat the code with the latest version. A few parameters in clang-tidy have b
clang-format: re-format for clang-19
clang-format-19 isn't compatible with the clang-format-18 output, so we need to reformat the code with the latest version. A few parameters in clang-tidy have been deprecated, so adjust the style file accordingly.
See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style. See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.
Change-Id: I006516b1bdf67f6e8f01b151644fb2b0ae75413e Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
a3cc2286 | 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: I98f262c24e427f4228b184715d7ad88b0d7060f6 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
bc5725d0 | 17-Jun-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Fix spelling mistakes using codespell
This commit corrects various spelling mistakes throughout the repository. The corrections were made automatically using `codespell`[1] tool.
[1]: https://githu
Fix spelling mistakes using codespell
This commit corrects various spelling mistakes throughout the repository. The corrections were made automatically using `codespell`[1] tool.
[1]: https://github.com/codespell-project/codespell
Change-Id: Ifdce925775a753cb71bfe44f3229d434b173283b Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
d90dda48 | 20-Oct-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I3a511d2180b4f77d727275df11a4804d13bce05d Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
98b7c410 | 15-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
meson_options.txt: Support for reading options from meson.options
Support has been added for reading options from meson.options instead of meson_options.txt[1]. These are equivalent, but not using t
meson_options.txt: Support for reading options from meson.options
Support has been added for reading options from meson.options instead of meson_options.txt[1]. These are equivalent, but not using the .txt extension for a build file has a few advantages, chief among them many tools and text editors expect a file with the .txt extension to be plain text files, not build scripts.
[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I9afbcdacb8d77eed50119c015d71a6cdf0518d2b
show more ...
|
440d84d4 | 19-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
scripts: remove unused gen_pimrules.py
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ib6fccba3d892c49818161077437542559f1220ae
|
e4b45ce1 | 19-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: remove autotools support
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I464fb65b640a078ba880c3c8c75d85234568e12e
|
71533438 | 19-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: install strgfnhandler into ipmi-providers dir
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I454ea1157f5bf75937a2215317ab018fefee2252 |
75edb2ec | 19-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: enable meson builds
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I2f56761421ee765bc616397c0ad5b88f4e5bc0e9 |
545a5d33 | 19-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
scripts: accept absolute paths to YAML
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I94044f096db64e6152bf4e7cd3bff7159e1cc85a |
6f47bee5 | 19-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
frup: suppress stringop-truncation warning
The code involved here doesn't entirely make sense because it is performing a sequence of hex to ascii conversions, but then overwriting the beginning with
frup: suppress stringop-truncation warning
The code involved here doesn't entirely make sense because it is performing a sequence of hex to ascii conversions, but then overwriting the beginning with a "0x", which seems to lose the first 2 bytes.
Until someone has a chance to unravel this code and turn it into a more modern implementation, suppress the GCC warning about string truncation (since the string truncation is done by design).
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I0e5001396a037cacbe7f8c534eddb8381385ebed
show more ...
|
2c8c7ce1 | 19-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
strgfnhandler: suppress unused parameter warnings
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I53ca6693f9b89429a89a763445f074309a55d98f |
bd2d8690 | 19-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
writefrudata: remove vla
Variable length arrays are not allowed in standard C++. Remove them in favor of std::vector.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Id6e4d6f287bf59
writefrudata: remove vla
Variable length arrays are not allowed in standard C++. Remove them in favor of std::vector.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Id6e4d6f287bf59bdb5888b1a2d34e41d72572548
show more ...
|
9084f520 | 03-Nov-2022 |
Willy Tu <wltu@google.com> |
fru-parser: Remove the use of mktime
mktime get the time in localtime and will mess up the time if the timezone != UTC. The FRU data should be the raw data in UTC and the reader will convert to loca
fru-parser: Remove the use of mktime
mktime get the time in localtime and will mess up the time if the timezone != UTC. The FRU data should be the raw data in UTC and the reader will convert to localtime at their end.
This issue is detected when we change the timezone to PST/PDT with https://gerrit.openbmc.org/c/openbmc/openbmc/+/58293 and the FRU EEPROM time does not match the expected Mfg Date anymore.
Used the timestamp of 1/1/1996 UTC directly.
Data Reader: https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/58466
Tested: Fru EEPROM Mfg Time now is in the same (after timezone conversion) between the raw data and FRU output.
Change-Id: I9d2d045f037d1976e45ed4e0c1857bb8d5ebc06d Signed-off-by: Willy Tu <wltu@google.com>
show more ...
|
cfa96afa | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I59041b73cc8b15c2a3800911540e1a10011f6150 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
085d51a9 | 18-Jul-2023 |
Vernon Mauery <vernon.mauery@linux.intel.com> |
Set new maintainer as Patrick Williams
Remove Vernon Mauery as maintainer.
Change-Id: Ia0f4a860d7191079c3b0119789387ff28ea3712e Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com> |
06514028 | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
markdownlint: fix all warnings
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I102df3eb41e6491999c94f33d9ee118ceb3f48a4 |
35f2c90d | 05-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
python: fix flake8 warnings
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I19379f25f64c64ec45f363de4af11e21ba0e0df2 |
c5c1737c | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
black: re-format
black and isort are enabled in the openbmc-build-scripts on Python files to have a consistent formatting. Re-run the formatter on the whole repository.
Change-Id: I5e068068ef3faa2
black: re-format
black and isort are enabled in the openbmc-build-scripts on Python files to have a consistent formatting. Re-run the formatter on the whole repository.
Change-Id: I5e068068ef3faa2f2c77bc1726b134eb6268dcfb Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
2de07e9d | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML files to have consistent formatting for these file types. Re-run the formatter on the whole repository.
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML files to have consistent formatting for these file types. Re-run the formatter on the whole repository.
Change-Id: I4e8e80d3e90345e107038546c485510b565ac636 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|