frup: gcc8: swap abusive use strncpy w/ memcpy

Fix the following warning under gcc8:

| ../git/frup.cpp: In function 'void _append_to_dict(uint8_t, uint8_t*, IPMIFruInfo&)':
| ../git/frup.cpp:664:24

frup: gcc8: swap abusive use strncpy w/ memcpy

Fix the following warning under gcc8:

| ../git/frup.cpp: In function 'void _append_to_dict(uint8_t, uint8_t*, IPMIFruInfo&)':
| ../git/frup.cpp:664:24: error: 'char* strncpy(char*, const char*, size_t)' output truncated before terminating nul copying 2 bytes from a string of the same length [-Werror=stringop-truncation]
| strncpy(bin_in_ascii, "0x", 2);
| ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~

Change-Id: Ia35d0ae733f0879f6c9d23126bab5fc899e89def
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

writefrudata: add doxygen for methods

Add doxygen comments for methods.

Change-Id: Ifc155279a21b258300dadd409abfb617652159dc
Signed-off-by: Patrick Venture <venture@google.com>

IPMIFruArea: Add doxygen to class

Add doxygen to IPMIFruArea class.

Change-Id: Ie28dd84c25df939671771741d7e4faca931e613e
Signed-off-by: Patrick Venture <venture@google.com>

writefrudata: drop extra parens in call to parse

Drop extra parentheses around parameters in call to parse_fru_area.
This involves changing a casting from c-style to a static_cast<>.

Change-Id: I28

writefrudata: drop extra parens in call to parse

Drop extra parentheses around parameters in call to parse_fru_area.
This involves changing a casting from c-style to a static_cast<>.

Change-Id: I281a950146fd296f8c9b15bd6dfc8562ad9b14bc
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: Drop unused dbus debug

Drop unused dbus debug code. There were no calls to set the values and
the debug printing them would therefore always print empty strings.

Change-Id: I767baf9f3

IPMIFruArea: Drop unused dbus debug

Drop unused dbus debug code. There were no calls to set the values and
the debug printing them would therefore always print empty strings.

Change-Id: I767baf9f3450c9944396930069089a6bbb6e5c6a
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: use default destructor

Use default destructor now that there isn't a raw pointer.

Change-Id: I3b28a99ca27a9e5dd15de9809e882cab02eedf75
Signed-off-by: Patrick Venture <venture@google.co

IPMIFruArea: use default destructor

Use default destructor now that there isn't a raw pointer.

Change-Id: I3b28a99ca27a9e5dd15de9809e882cab02eedf75
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: use vector instead of raw byte pointer

Use vector of bytes instead of raw byte pointer.

Change-Id: I20a2beec3cbbc44c8cc3a48cefd73f3f27bdcc8f
Signed-off-by: Patrick Venture <venture@goo

IPMIFruArea: use vector instead of raw byte pointer

Use vector of bytes instead of raw byte pointer.

Change-Id: I20a2beec3cbbc44c8cc3a48cefd73f3f27bdcc8f
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: add missing curly braces for style

OpenBMC style dictates conditional statements needs curly braces.

Change-Id: Iff7066dec2e7a376f2a97e67591ba95b7aa8549d
Signed-off-by: Patrick Ventur

writefrudata: add missing curly braces for style

OpenBMC style dictates conditional statements needs curly braces.

Change-Id: Iff7066dec2e7a376f2a97e67591ba95b7aa8549d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: rename member variables per openbmc style

OpenBMC style dictates member variables be lower camel and not snake
case.

Change-Id: I3e217b51f910612c3e5ecf1480340a27ef29d774
Signed-off-by:

IPMIFruArea: rename member variables per openbmc style

OpenBMC style dictates member variables be lower camel and not snake
case.

Change-Id: I3e217b51f910612c3e5ecf1480340a27ef29d774
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

build: set language to C++

Set the language in the build to C++.

Change-Id: Iaf56356269617c0546d2b42a225bf8732fe6356c
Signed-off-by: Patrick Venture <venture@google.com>

MAINTAINERS: Update Emily's IRC nick

Change-Id: I56b9100c0d7ee8bee84c00eba4fd0d0899aa50e8
Signed-off-by: Emily Shaffer <emilyshaffer@google.com>

writefrudata: drop unused sd-bus.h

Drop unused sd-bus.h header.

Change-Id: I0a55cd3aa5a551d7fa04706d7e0c5b6b275efcf5
Signed-off-by: Patrick Venture <venture@google.com>

strgfnhandler: rename function per openbmc style guide

Function names should be lower camel and not snake case.

Change-Id: I6f8683850ce017e63641415846e8a0f031fccba7
Signed-off-by: Patrick Venture <

strgfnhandler: rename function per openbmc style guide

Function names should be lower camel and not snake case.

Change-Id: I6f8683850ce017e63641415846e8a0f031fccba7
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

strgfnhandler: rename all variables per openbmc style

OpenBMC style declares variables be lower camel and not snake case.

Change-Id: I4a448b84ae3d930049d4cb761216459799a698fa
Signed-off-by: Patrick

strgfnhandler: rename all variables per openbmc style

OpenBMC style declares variables be lower camel and not snake case.

Change-Id: I4a448b84ae3d930049d4cb761216459799a698fa
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: rename all variables per openbmc style

OpenBMC style declares variables be lower camel and not snake case.

Change-Id: Iec348bf9825caecc976f654a37ac149a5981c94b
Signed-off-by: Patrick

writefrudata: rename all variables per openbmc style

OpenBMC style declares variables be lower camel and not snake case.

Change-Id: Iec348bf9825caecc976f654a37ac149a5981c94b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: fixup function naming per style

Fixup function naming to lowerCamelCase for OpenBMC style guide.

Change-Id: I8c8eda9f4aad29aadd092329248c97a556f22b9a
Signed-off-by: Patrick Venture <v

writefrudata: fixup function naming per style

Fixup function naming to lowerCamelCase for OpenBMC style guide.

Change-Id: I8c8eda9f4aad29aadd092329248c97a556f22b9a
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

update: use sdbusplus instead of sd_bus raw pointers

Update code to use sdbusplus instead of raw sd_bus pointers.

Change-Id: I80cd4492480824827c27fbf19eb54487e28d3b75
Signed-off-by: Patrick Venture

update: use sdbusplus instead of sd_bus raw pointers

Update code to use sdbusplus instead of raw sd_bus pointers.

Change-Id: I80cd4492480824827c27fbf19eb54487e28d3b75
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: add missing constness

Set iterator to const reference where possible.

Change-Id: I2d5d766990d49df3e6a6fef743698053413152fc
Signed-off-by: Patrick Venture <venture@google.com>

IPMIFruArea: delete default constructor

Default constructor marked private, but should be deleted.

Change-Id: I324516c51bd5f59b68284d9adcbf117cd74115af
Signed-off-by: Patrick Venture <venture@googl

IPMIFruArea: delete default constructor

Default constructor marked private, but should be deleted.

Change-Id: I324516c51bd5f59b68284d9adcbf117cd74115af
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

writefrudata: cleanup extra parentheses

Cleanup extra parentheses from calling accessors against object pointer,
which is actually a reference to a unique_ptr.

Change-Id: Icf47bf376947d1afb0753c18b

writefrudata: cleanup extra parentheses

Cleanup extra parentheses from calling accessors against object pointer,
which is actually a reference to a unique_ptr.

Change-Id: Icf47bf376947d1afb0753c18be66417e2bac4507
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: apply naming convention to member functions

Apply naming convention to member functions.

Change-Id: I3b0516592dd4225f7be43c3d9cdcc9c8853d20b7
Signed-off-by: Patrick Venture <venture@go

IPMIFruArea: apply naming convention to member functions

Apply naming convention to member functions.

Change-Id: I3b0516592dd4225f7be43c3d9cdcc9c8853d20b7
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: move private area under public

For standard readability a class is typically written with public
preceding private.

Change-Id: Icdce1ee8426d651293d16f9a1ba16176a3f767c3
Signed-off-by:

IPMIFruArea: move private area under public

For standard readability a class is typically written with public
preceding private.

Change-Id: Icdce1ee8426d651293d16f9a1ba16176a3f767c3
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: drop iv prefix from members

Drop iv_ prefix from class members.
Renamed class members where necessary and updated some method
parameters to avoid name conflicts.

Change-Id: Id888dab9fc

IPMIFruArea: drop iv prefix from members

Drop iv_ prefix from class members.
Renamed class members where necessary and updated some method
parameters to avoid name conflicts.

Change-Id: Id888dab9fcc020c4dff68d689a38f869c0de3525
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

IPMIFruArea: drop unused member methods

Drop unused member methods.

Change-Id: I1bf78f8a896173deacc0f55e3e3b8f1f0c64302a
Signed-off-by: Patrick Venture <venture@google.com>

IPMIFruArea: move assignments to constructor list

Move member assignment to constructor list.

Change-Id: I140aabc92533c07f6c50eb19a323e6c52dbf43a4
Signed-off-by: Patrick Venture <venture@google.com>