build: remove libmapper dependency

Nothing in the codebase actually uses libmapper. Remove the
library dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib4c037da312cd4e33

build: remove libmapper dependency

Nothing in the codebase actually uses libmapper. Remove the
library dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib4c037da312cd4e33eb30806da0422ae70a3f83b

show more ...

Fix offset size

Signed-off-by: Jean-Marie Verdun <jean-marie.verdun@hpe.com>
Change-Id: Ic6128e836c3add71737022b9bfb4c96713f0772c

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idab99ed8fdb9bdf5cc0e130d576f55d256df9cce

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7450b52603a9f3d007c4685f1a3820e861610c31

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1310544bdbc85e0195a096e9d2ee6f38b4f178c5

build: enable C++20

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ida5402ae8d39b264fea044a510f66840cad8a90c

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Id70d5c9f933cadef89f0fb803449e40c4ecde66d

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic5d65c069f9d15ccbb81419180edcf119f8ee08e

show more ...

MAINTAINERS: Replace IRC by DISCORD

Discord is becoming the chat server of choice.

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: Ia0d3eb74c59f68626045bfa72ba8e7749a025014

MAINTAINERS: Remove Tom from maintainers list

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: Id5d69c880f1462c04c734755b8bb61c106b6e4bd

writefrudata: validate multi-record data

It is fail to parse FRU data with multi-record area available as its
header data is different from other areas.
Support validate multi-record data so that ca

writefrudata: validate multi-record data

It is fail to parse FRU data with multi-record area available as its
header data is different from other areas.
Support validate multi-record data so that can parse FRU data with
multi-record enabled.

Tested:
1. Check if the FRU with multi-record can be parsed.
2. Check IPMI fru print command.
FRU Device Description : Builtin FRU Device (ID 0)
Chassis Type : Rack Mount Chassis
Chassis Serial : A1A1-A000-0000000000123
Board Mfg Date : Tue Feb 4 00:00:00 2020 UTC
Board Mfg : AmpereComputing(R)
Board Product : MT.JADE
Board Serial : 9510002CJ0LA
Board Part Number : B81.03010.0001
Product Manufacturer : AmpereComputing(R)
Product Name : MT.JADE
Product Part Number : AC82830AC10C
Product Version : PR010
Product Serial : AMPX3A1-A000-0000000000123

Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Change-Id: I163c5c7bff2f7315e9c6b610f5074c37bc167ccf

show more ...

bootstrap: fix shellcheck warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86ef079c9632e5563a1a56d6a2e23aad59ecbc57

scripts: convert to python3

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5ac0c1ac6f5420ec9763419223e651c3f887afe6

MAINTAINERS: remove Emily Shaffer

See https://lists.ozlabs.org/pipermail/openbmc/2020-January/020345.html

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
Change-Id: I0758fe3665aaa8586f61626b

MAINTAINERS: remove Emily Shaffer

See https://lists.ozlabs.org/pipermail/openbmc/2020-January/020345.html

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
Change-Id: I0758fe3665aaa8586f61626b22754c9c3016cf15

show more ...

writefrudata: variable rc scope reduction

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I0f3e943e27d856937aa7cc6ddf6c579e4e309b2d

debug: add details on notify failure

There can be more than one service providing this method, therefore
output what service failed, and additionally the path.

Signed-off-by: Patrick Venture <ventu

debug: add details on notify failure

There can be more than one service providing this method, therefore
output what service failed, and additionally the path.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I44232418849ac435689a7859aa0baeb3aec5bc90

show more ...

writefrudata: update error message for FRU not found

Update the error message for FRU not found to specify that the FRU isn't
found in the generated source.

Signed-off-by: Patrick Venture <venture@

writefrudata: update error message for FRU not found

Update the error message for FRU not found to specify that the FRU isn't
found in the generated source.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1f624950ec995b40af178f3cc0006b26abf1d9fa

show more ...

Extend the list of supported dbus property types

The Value type represents all types that are possible for a FRU info.
Most fields in a FRU info are boolean or string. There is also a
3-byte timesta

Extend the list of supported dbus property types

The Value type represents all types that are possible for a FRU info.
Most fields in a FRU info are boolean or string. There is also a
3-byte timestamp that, being converted to unix time, fits well into
uint64_t.

However for multirecord area records, there may be other data types,
not all of which are directly listed in IPMI FRU specification.

Hence, this Value type will now list all types possible for dbus nodes
with sdbusplus except for unixfd, object_path, and signature.

The class of Value will also be changed to std::variant per
request of Vernon Mauery, as part of effort to free the sdbusplus
library of extraneous features.

Part of:
https://gerrit.openbmc-project.xyz/q/topic:FRU-MultiRecord

Change-Id: I5d688ba9c14fa77cbe5171bd2ac7610e89c08220
Signed-off-by: Alexander Amelkin <a.amelkin@yadro.com>

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ifbf3b709c08bbd892060291530a906e88430f5be

transition to cli11 instead of custom arg parser

Transition to use cli11 for argument parsing instead of a custom
argument parser.

Tested: Not tested on hardware.
Signed-off-by: Patrick Venture <ve

transition to cli11 instead of custom arg parser

Transition to use cli11 for argument parsing instead of a custom
argument parser.

Tested: Not tested on hardware.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I9c516c8c2d76e35c6c31592f96e8f281e9d47ad6

show more ...

add autom4te.cache/ to .gitignore

Add missing "autom4te.cache/" to .gitignore file.

Tested: Not tested on hardware.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie06d1b22bb2a74e2f

add autom4te.cache/ to .gitignore

Add missing "autom4te.cache/" to .gitignore file.

Tested: Not tested on hardware.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie06d1b22bb2a74e2f6e2901d213fffa0cacac2c4

show more ...

Convert host-ipmid -> libipmid

phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.

Change-Id: Ib222df1605afe

Convert host-ipmid -> libipmid

phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.

Change-Id: Ib222df1605afe277457f34eb69a3d65c663325b7
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Iccc91bcdd4ad57980a4731184b448

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: Iccc91bcdd4ad57980a4731184b448936c1968f85
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

readeeprom: Allow FRU ID 0 to be selected

We incorrectly checked that FRU ID != 0, which is the default FRU ID.
Actually, the IPMI spec specifies FRU ID 0xff as reserved, so the check
was changed to

readeeprom: Allow FRU ID 0 to be selected

We incorrectly checked that FRU ID != 0, which is the default FRU ID.
Actually, the IPMI spec specifies FRU ID 0xff as reserved, so the check
was changed to prevent that ID from being used instead.

Split out fruid parsing code to its own function to cover various edge
and failure cases.

Tested:
Ran 'phosphor-read-eeprom --eeprom fru.bin --fruid=0' and checked that
values are reported to inventory as expected.
Ran with '--fruid=ff' ('invalid' FRU ID): rejected
Ran with '--fruid=xx' (non-HEX FRU ID): rejected
Ran with '--fruid=100' (out-of-range FRU ID): rejected
Ran with '--fruid="0 0"' (invalid number): rejected
Ran with '--fruid=10.0' (non-integer): rejected
Ran with '--fruid=0x12' (valid HEX FRU ID): accepted
Ran with '--fruid=fe' (valid HEX FRU ID): accepted

Change-Id: Ic1fb79cefc6931f21d0b5cb4363ad5fd44f47c92
Signed-off-by: Oskar Senft <osk@google.com>

show more ...

writefrudata: Fix verifyFruData to skip CRC check for internal use area.

The contents of the internal use area are not defined beyond the first
byte, which means that we should not expect its last b

writefrudata: Fix verifyFruData to skip CRC check for internal use area.

The contents of the internal use area are not defined beyond the first
byte, which means that we should not expect its last byte to be a CRC
for the area.

Change-Id: I15aba7f48e13f8a93c5a6b7e3262d9227da5dad7
Signed-off-by: Oskar Senft <osk@google.com>

show more ...