frup: suppress stringop-truncation warning

The code involved here doesn't entirely make sense because it is
performing a sequence of hex to ascii conversions, but then
overwriting the beginning with

frup: suppress stringop-truncation warning

The code involved here doesn't entirely make sense because it is
performing a sequence of hex to ascii conversions, but then
overwriting the beginning with a "0x", which seems to lose the
first 2 bytes.

Until someone has a chance to unravel this code and turn it into
a more modern implementation, suppress the GCC warning about string
truncation (since the string truncation is done by design).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0e5001396a037cacbe7f8c534eddb8381385ebed

show more ...

fru-parser: Remove the use of mktime

mktime get the time in localtime and will mess up the time if the
timezone != UTC. The FRU data should be the raw data in UTC and the
reader will convert to loca

fru-parser: Remove the use of mktime

mktime get the time in localtime and will mess up the time if the
timezone != UTC. The FRU data should be the raw data in UTC and the
reader will convert to localtime at their end.

This issue is detected when we change the timezone to PST/PDT with
https://gerrit.openbmc.org/c/openbmc/openbmc/+/58293
and the FRU EEPROM time does not match the expected Mfg Date anymore.

Used the timestamp of 1/1/1996 UTC directly.

Data Reader:
https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/58466

Tested:
Fru EEPROM Mfg Time now is in the same (after timezone conversion)
between the raw data and FRU output.

Change-Id: I9d2d045f037d1976e45ed4e0c1857bb8d5ebc06d
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I59041b73cc8b15c2a3800911540e1a10011f6150
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

frup: gcc8: swap abusive use strncpy w/ memcpy

Fix the following warning under gcc8:

| ../git/frup.cpp: In function 'void _append_to_dict(uint8_t, uint8_t*, IPMIFruInfo&)':
| ..

frup: gcc8: swap abusive use strncpy w/ memcpy

Fix the following warning under gcc8:

| ../git/frup.cpp: In function 'void _append_to_dict(uint8_t, uint8_t*, IPMIFruInfo&)':
| ../git/frup.cpp:664:24: error: 'char* strncpy(char*, const char*, size_t)' output truncated before terminating nul copying 2 bytes from a string of the same length [-Werror=stringop-truncation]
| strncpy(bin_in_ascii, "0x", 2);
| ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~

Change-Id: Ia35d0ae733f0879f6c9d23126bab5fc899e89def
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

frup.cpp: drop unused variable

[frup.cpp:628] -> [frup.cpp:694]: (style) The expression 'sdr < 0'
is always false.

This is true because the value is set to 0 and never re-assign

frup.cpp: drop unused variable

[frup.cpp:628] -> [frup.cpp:694]: (style) The expression 'sdr < 0'
is always false.

This is true because the value is set to 0 and never re-assigned.

Change-Id: I668f5cc5a13a0c87afa3af978c341fb60f51b70d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

add clang-format

Add clang-format file.

Change-Id: Ib99bbeb0ec59b5befb742dec38286c24a7f842ea
Signed-off-by: Patrick Venture <venture@google.com>

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Ifbc540985ddef6ee0ac6e5510c9bf79f24f89f96
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Support Build date in IPMI Board FRU format

Resolves openbmc/openbmc#1533

Change-Id: I9269cd24ec11a4a43657541c529e28a756f76c48
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

Remove debug printf of VPD keys

The output from these printfs clog up the journal. If
needed then we should move them to phosphor logging and
make debug.

Change-Id: I26600a

Remove debug printf of VPD keys

The output from these printfs clog up the journal. If
needed then we should move them to phosphor logging and
make debug.

Change-Id: I26600a0d13f834da1c35d914285b13a3bc2eea4a
Signed-off-by: Andrew Geissler <andrewg@us.ibm.com>

show more ...

Inventory: Add chassis fru data

Change-Id: Idc83199d584ffe6d1b66debcb36244dd393495d0
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

Fix bug in FRU data processing logic

The logic assumed IPMI FRU data is encoded in ascii always, but the data
could be ascii or binary. Handle both encodings.

Change-Id: Ie89bb0

Fix bug in FRU data processing logic

The logic assumed IPMI FRU data is encoded in ascii always, but the data
could be ascii or binary. Handle both encodings.

Change-Id: Ie89bb077fd32a23bb96bd4cda78b66d2ccdd9774
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

rename frup.h -> frup.hpp

This header contains c++ code.

Change-Id: I4bc6cf0ddfbdc6ac4d93580a5203bb59537bbb04
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

Re-factor to use MRW and Inventory interfaces

The write FRU command now figures out properties to be written for a FRU
via a generated header file, which in turn is generated via scrips

Re-factor to use MRW and Inventory interfaces

The write FRU command now figures out properties to be written for a FRU
via a generated header file, which in turn is generated via scrips
deriving their inputs from MRW and Inventory d-bus interfaces.

Change-Id: I9939aeec24566cf518f4e63dc6ae344b236a541f
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Change c->cpp.

It is required as we would be using c++ containers.

Change-Id: Ifefc468ac7b2e94d1b9948a6aeb7f8d42d8e6555
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>