clang-tidy: Initial commit

Added initial .clang-tidy configuration file with recommended C++ checks
aligned with the OpenBMC-approved checklist. This setup enforces modern
C++ best practices and hel

clang-tidy: Initial commit

Added initial .clang-tidy configuration file with recommended C++ checks
aligned with the OpenBMC-approved checklist. This setup enforces modern
C++ best practices and helps catch common issues early in development.

Change-Id: I529af91945aeadc609b132e832813f21d7dcc263
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: guard optional timer before deref

Fix bugprone-unchecked-optional-access warnings by checking
request->timer before calling cancel(), expires_after(), and
async_wait(). Ensures safe acce

clang-tidy: guard optional timer before deref

Fix bugprone-unchecked-optional-access warnings by checking
request->timer before calling cancel(), expires_after(), and
async_wait(). Ensures safe access to optional values without
changing functional behavior.

Fixed below errors

'''
../ipmbbridged.cpp:361:13: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
361 | request->timer->cancel();
| ^~~~~~~~~~~~~~
../ipmbbridged.cpp:775:9: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
775 | request->timer->expires_after(
| ^~~~~~~~~~~~~~
../ipmbbridged.cpp:777:9: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
777 | request->timer->async_wait(yield[ec]);
'''

Change-Id: I99f34617aecb7d0269ea746eaff2f47dad59f980
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

Add delay between frame send retries

Introduced a delay between retries to allow the bus to stabilize
and ongoing transactions to complete. The delay increases
exponentially, calculated as 30 ms mul

Add delay between frame send retries

Introduced a delay between retries to allow the bus to stabilize
and ongoing transactions to complete. The delay increases
exponentially, calculated as 30 ms multiplied by 2 raised to the
power of the number of retries.

Change-Id: Ibbfd202118a69c270cbb4f047ef44f15ebf72bd6
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

show more ...

markdownlint: minor fixes

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4c06c11f4f3405df6f0951db9ca9106488c83045

Add dependency on boost::context

Boost 1.87 now seems to require this.

Change-Id: I439b9d0bb66a989ce6acb43fbc058cc29324e511
Signed-off-by: Ed Tanous <etanous@nvidia.com>

ipmbbridged: Fix the issue with busy caused by incorrect requests

D-bus method:
sendRequest yyyyay <channel> <netf> <lun> <cmd> <dataLen> <data>

If dataLen is greater than ipmbMaxFrameLength (264

ipmbbridged: Fix the issue with busy caused by incorrect requests

D-bus method:
sendRequest yyyyay <channel> <netf> <lun> <cmd> <dataLen> <data>

If dataLen is greater than ipmbMaxFrameLength (264), the request will
not be set to invalid and will continue to occupy outstandingRequests
until it is full, which will result in all subsequent requests being
busy.

busctl call xyz.openbmc_project.Ipmi.Channel.Ipmb \
/xyz/openbmc_project/Ipmi/Channel/Ipmb org.openbmc.Ipmb \
sendRequest yyyyay 0x00 0x30 0x00 0x06 0x00
(iyyyyay) 3 0 0 0 0 0

Error:
sendRequest (dataLen > 264) ipmbHandleRequest
|
requestAdd
|
(outstandingRequests save request) <-- makeRequestValid(request)
|
(dataLen > 264, return -1) <-- ipmbToi2cConstruct(buffer)
|
returnStatus(ipmbResponseStatus::error)

(Repeat sending until outstandingRequests is full)
------------------------------------------------------------------
sendRequest ipmbHandleRequest
|
requestAdd
|
seqNumGet \
(outstandingRequests is full, return false) <----
|
returnStatus(ipmbResponseStatus::busy)

All subsequent requests will be returned to busy and can only be
restored by restarting the service.

Change-Id: Idfda2af1a136dfcdc478e21d172de673f1efef03
Signed-off-by: Tian Jingzai <tianjingzai@phytium.com.cn>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: Ia4274f5a4406e8d6806ddbf08b04e7c8a241e625
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ie0caa386ecfd04cdfe74d99292cf538fbcc007f1
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ie0caa386ecfd04cdfe74d99292cf538fbcc007f1
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Update Vernon Mauery email

Change-Id: I377af5f95d6b666ea6c927cb0c54096a98a51e9a
Signed-off-by: Vernon Mauery <vernon.mauery@gmail.com>

Rename README to README.md

Since the CI will check mardkwon format files, the README files will
be updated to `.md` suffix.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6175f53024

Rename README to README.md

Since the CI will check mardkwon format files, the README files will
be updated to `.md` suffix.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6175f53024559b41e05c2bd91d76548c889cb3ca

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ia647f7c9c2dfb8dab46de151ef03f95aba460e78
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

change vector constructor for gcc-14

gcc-14, with the latest Yocto sync, fails with the following compile
failure:

```
| ../git/ipmbbridged.cpp:724:34: error: value computed is not used [-Werror=un

change vector constructor for gcc-14

gcc-14, with the latest Yocto sync, fails with the following compile
failure:

```
| ../git/ipmbbridged.cpp:724:34: error: value computed is not used [-Werror=unused-value]
| 724 | std::vector<uint8_t> buffer(0);
```

Attempt using the default constructor, which should be equivalent,
instead.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2d79813a52354bb00d992d6edfd9e2cc3a3ceacf

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I0d3acfeb002b6e3e8356b4f1c2a960c53ecadf2e
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Update language in ipmbbridge to be more inclusive

Use more inclusive terminology inside of ipmbbridge repo.

Tested: No functional change. Verified on Intel system that ipmb.service
runs and Ipmb c

Update language in ipmbbridge to be more inclusive

Use more inclusive terminology inside of ipmbbridge repo.

Tested: No functional change. Verified on Intel system that ipmb.service
runs and Ipmb channel still gets published on DBus.

Change-Id: I70577a3b28e209a38bcd3d2ec99dd17b09a2d723
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

meson: Support building boost as subproject

Add support for the local meson build on the system without boost.

Tested:
"meson setup build && cd build && meson compile" finishes successfully.

Chang

meson: Support building boost as subproject

Add support for the local meson build on the system without boost.

Tested:
"meson setup build && cd build && meson compile" finishes successfully.

Change-Id: I22eb23c216f9333589ab61ae4d1cb707be5c9a0a
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: adjust nlohmann-json dependency

Simplify the nlohmann-json dependency and align the wrap file with other
repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic41132c

meson: adjust nlohmann-json dependency

Simplify the nlohmann-json dependency and align the wrap file with other
repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic41132c20f48da7591ff380b3448ab73fa78052b

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I5e93cd3dd8350b503c35f60adca83c9a71631631
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I9ea3416a29d8c921871c0

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I9ea3416a29d8c921871c06984f8e05f12a7dbb03
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I6c4866ab239a7e53c7b00347645ba825f1abef9f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I095be438ae99d7bf26d3cbc49de1d4947684856a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

The executable was renamed to ipmbbridge

- The executable was renamed ipmbbridge while deleting CMake support, but ipmb.service expected it to be ipmbbridged.

ipmb.service: Failed to locate exe

The executable was renamed to ipmbbridge

- The executable was renamed ipmbbridge while deleting CMake support, but ipmb.service expected it to be ipmbbridged.

ipmb.service: Failed to locate executable /usr/bin/ipmbbridged: No such file or directory
ipmb.service: Failed at step EXEC spawning /usr/bin/ipmbbridged: No such file or directory
ipmb.service: Main process exited, code=exited, status=203/EXEC
ipmb.service: Failed with result 'exit-code'.

Test:
$ systemctl status ipmb
* ipmb.service - IPMB bridge
Loaded: loaded (/lib/systemd/system/ipmb.service; enabled; preset: enabled)
Active: active (running) since Fri 2023-03-03 09:49:51 UTC; 1 month 4 days ago
Main PID: 476 (ipmbbridged)
CPU: 599ms
CGroup: /system.slice/ipmb.service
`-476 /usr/bin/ipmbbridged

Change-Id: Ifc3b3525db9628ad76fa6f56b8817c7b0a332ac9
Signed-off-by: Jorge Cisneros <jcisneros3@lenovo.com>

show more ...

build: delete CMake support

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I080469d3a5cdfea8a9f32750305bbe80485c37f7

build: add meson and subproject wrap files

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I810d8ba10135b984ef864013d579b1461d843ba9

squash pedantic warnings over flexible array members

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I134eb823a6860007f1bcfde0f40f6ca2c8bb36b2

clean up missing-field-initializers warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I56c700b5fd234e623994e61eaf615432b7b155ab