Add mfg filter to allow MTM cmds only in mfg mode

For security purpose, mfg filter check is used to allow
manufacturing mode commands execution only in manufacturing mode.
Invalid command comp code

Add mfg filter to allow MTM cmds only in mfg mode

For security purpose, mfg filter check is used to allow
manufacturing mode commands execution only in manufacturing mode.
Invalid command comp code should be returned otherwise. This
provides option to return 0xC1 even for invalid number of
bytes specified as expected.

Tested:
ipmitool raw 0x30 0x14 0x0c 0x00 0x00 0x00
ipmitool raw 0x30 0x15 0x01 0x00
ipmitool raw 0x30 0xB5 0x01
ipmitool raw 0x30 0xA1
ipmitool raw 0x30 0xA2
All these commands return 0xC1, when not in manufacturing
mode and executes as expected

Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>
Change-Id: I0adae24b17f729d97aca7c5fc93df92520e7bf5a
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>

show more ...

update oemcommands.hpp to use new API

All the command handler numbers and netfn numbers were done
using the old API. This updates all the enums to be ipmi::Cmd
or ipmi::NetFn types. This improves re

update oemcommands.hpp to use new API

All the command handler numbers and netfn numbers were done
using the old API. This updates all the enums to be ipmi::Cmd
or ipmi::NetFn types. This improves readability by eliminating
unneeded static_casts and brings the legacy code to the present.

One minor fix, otherwise the code is the same. The call to
registerFilter was passing a netfn instead of a priority. It compiled
but it was incorrect. This updates it to use the correct parameter.

Tested: builds and produces the same binary output (other than the
aforementioned registerFilter fix)

Change-Id: I7e83123245b3f340088f8ec75a31b7611d0ecda0
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

remove unused file src/smbiosmdrv2.cpp

This file has been rewritten to be src/smbiosmdrv2handler.cpp using the
new IPMI API. It is no longer used.

Change-Id: Iaa57a40be138df4395cbbfd116bf52c440daf8

remove unused file src/smbiosmdrv2.cpp

This file has been rewritten to be src/smbiosmdrv2handler.cpp using the
new IPMI API. It is no longer used.

Change-Id: Iaa57a40be138df4395cbbfd116bf52c440daf855
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add parameter selector to CR config command resp

Add Parameter selector to response of Get Cold Redundancy Configuration
Command. According to Intel BMC EPS, the first response data after
completion

Add parameter selector to CR config command resp

Add Parameter selector to response of Get Cold Redundancy Configuration
Command. According to Intel BMC EPS, the first response data after
completion code should be parameter selector.

Tested:
ipmitool raw 0x30 0x2e 0x00 return 0x00 0x01
ipmitool raw 0x30 0x2e 0x01 return 0x01 0x01
ipmitool raw 0x30 0x2e 0x02 return 0x02 0x01

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I9e05579f974843a9f3389d817205e60c7373c92f

show more ...

Fix build

ctx moved away from being a ptr

tested: it builds

Change-Id: I39f99729a6e44c544178e9e2b28edcfd8a4551fb
Signed-off-by: James Feist <james.feist@linux.intel.com>

Override Set Boot option command

Safe boot mode is not supported in INTEL platforms, so, it's needed
to override the Set Boot Options IPMI command in INTEL OEM command
by removing the safe mode item

Override Set Boot option command

Safe boot mode is not supported in INTEL platforms, so, it's needed
to override the Set Boot Options IPMI command in INTEL OEM command
by removing the safe mode item.

Tested:
ipmitool raw 0x00 0x08 0x05 0x80 0x0c
return 0xcc to indicate Invalid data field in request.

Change-Id: I9539c2e0ead3edb97799f63a5c1d4109c2ef3754
Signed-off-by: Chen Yugang <yugang.chen@linux.intel.com>

show more ...

intel-ipmi-oem: add slot I2C master RW command

This command is used to perform i2c master read/write on PCIE slots.

Tested:
Reading the 0x4e device on slot 2 of riser 1(i2c bus is 17),
the below tw

intel-ipmi-oem: add slot I2C master RW command

This command is used to perform i2c master read/write on PCIE slots.

Tested:
Reading the 0x4e device on slot 2 of riser 1(i2c bus is 17),
the below two commands have the same result:

ipmitool raw 0x3e 0x52 0 0x11 0x4e 8 0
i2cget -f -y 17 0x4e 0 i 8

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I03872296345d180571db2205a9a30c08f28b69b6

show more ...

[oem-cmd]: Support for Get/Set security modes

Command support for Get & Set Security modes are added. These
modes are used to limit the host interfaces IPMI command
execution. Based on the mode comm

[oem-cmd]: Support for Get/Set security modes

Command support for Get & Set Security modes are added. These
modes are used to limit the host interfaces IPMI command
execution. Based on the mode commands are fully blocked or
filtered or always allowed.

Tested:
1. ipmitool raw 0x30 0xB3 --> lists out Restriction & SecurityMode
2. ipmitool raw 0x30 0xB4 <newMode> --> updates RestrictionMode to
new value successfully
3. Verified improper values for set security mode.

Change-Id: I1f5f4ae53581a0f5da1684450853037b5bd39fea
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

intel-ipmi-oem:Support for Set/Get Manf MAC data

Support added for Set / Get Manufacturing data to program
the individual HW eth addr. This will be used in manufacturing
side.

Tested:
1. Verified t

intel-ipmi-oem:Support for Set/Get Manf MAC data

Support added for Set / Get Manufacturing data to program
the individual HW eth addr. This will be used in manufacturing
side.

Tested:
1. Verified that Get / Set Mfg data command works after mfg mode
2. ipmitool raw 0x30 0xA1 0x1 0x1a 0x6b 0x32 0x87 0x91 0x86
updates eth1 MAC after a reboot as expected.

Change-Id: I9a028e8688cd8c89fd51fdc14c570be10a51ed25
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Add set/get Http boot option OEM commands

Set/get Http boot option is used to add a new boot item in reserved bits,
which set to 1101b in data 2nd[5:2] of boot flags parameter.

tested:
it's tested

Add set/get Http boot option OEM commands

Set/get Http boot option is used to add a new boot item in reserved bits,
which set to 1101b in data 2nd[5:2] of boot flags parameter.

tested:
it's tested in system for IPMI OEM command and BIOS
- get/set http boot option,
set: ipmitool raw 0x30 0xEA 0x05 0x80 0x34
get: ipmitool raw 0x30 0xEB 0x05 0x00 0x00

Change-Id: Ie2927c924e233023b1644ce2e62e06003d55e0f2
Signed-off-by: Chen,Yugang <yugang.chen@linux.intel.com>

show more ...

Fix the incorrect completion code

When running set cold redundancy configuration command, it always return
incorrect completion code, the string value of ColdRedundancyStatus always be
sent to dbus

Fix the incorrect completion code

When running set cold redundancy configuration command, it always return
incorrect completion code, the string value of ColdRedundancyStatus always be
sent to dbus as a bool type.

Tested:
ipmitool raw 0x30 0x2d 0x01 0x00 return 00.
ipmitool raw 0x30 0x2d 0x02 0x00 return 00.

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: If5c8d625af78f9331e713b275bf53fccb33fcc46

show more ...

Add additional check for i2c master write read command

For security reasons, in i2c master RW IPMI command,
if the write date count > 1, needs to check if it is in MTF mode.

Tested:
In normal mode,

Add additional check for i2c master write read command

For security reasons, in i2c master RW IPMI command,
if the write date count > 1, needs to check if it is in MTF mode.

Tested:
In normal mode,
ipmitool raw 0x6 0x52 0xf 0xa2 8 0 works, but
ipmitool raw 0x6 0x52 0xf 0xa2 8 0 0 fails with
Insufficient privilege level.
Boot into MFG mode, the above command works.

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I364f41f632ed3790bcd1d9e9193c9c4a3529af53

show more ...

intel-ipmi-oem: cleanup - Removed duplicate OemCmd

Removed duplicate OemCmds in intel-ipmi-oem, and moved to the
correct one IPMINetfnIntelOEMGeneralCmd enum class.

Change-Id: Iac694c8e2c72f9ad99ed

intel-ipmi-oem: cleanup - Removed duplicate OemCmd

Removed duplicate OemCmds in intel-ipmi-oem, and moved to the
correct one IPMINetfnIntelOEMGeneralCmd enum class.

Change-Id: Iac694c8e2c72f9ad99ed4fae933e0d26f53d4f08
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Add type 12h sdr records

This adds support for BMC and ME type 12 records.

Tested:

ipmitool sdr list mcloc

Device ID : �Basbrd Mgmt Ctl
Entity ID : 0.46 (Unspecified)
De

Add type 12h sdr records

This adds support for BMC and ME type 12 records.

Tested:

ipmitool sdr list mcloc

Device ID : �Basbrd Mgmt Ctl
Entity ID : 0.46 (Unspecified)
Device Slave Address : 20h
Channel Number : 0h
ACPI System P/S Notif : Not Required
ACPI Device P/S Notif : Not Required
Controller Presence : Dynamic
Logs Init Agent Errors : No
Event Message Gen : Enable
Device Capabilities
Chassis Device : Yes
Bridge : No
IPMB Event Generator : Yes
IPMB Event Receiver : Yes
FRU Inventory Device : Yes
SEL Device : Yes
SDR Repository : Yes
Sensor Device : Yes

Device ID : �Mgmt Engin
Entity ID : 0.46 (Unspecified)
Device Slave Address : 2Ch
Channel Number : 6h
ACPI System P/S Notif : Not Required
ACPI Device P/S Notif : Not Required
Controller Presence : Static
Logs Init Agent Errors : No
Event Message Gen : Enable
Device Capabilities
Chassis Device : No
Bridge : No
IPMB Event Generator : Yes
IPMB Event Receiver : No
FRU Inventory Device : No
SEL Device : No
SDR Repository : No
Sensor Device : Yes

Change-Id: I3d015ca2f61ab07be18ba46239c3d6a919f0298b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix build issue

/home/jenkins-op/workspace/openbmc-repository-ci/openbmc/intel-ipmi-oem/src/firmware-update.cpp:29:
ISO C++ forbids converting a string constant -Werror=write-string
10:57:23 29 |

Fix build issue

/home/jenkins-op/workspace/openbmc-repository-ci/openbmc/intel-ipmi-oem/src/firmware-update.cpp:29:
ISO C++ forbids converting a string constant -Werror=write-string
10:57:23 29 | static constexpr char *secondaryFitImageStartAddr =

Tested: builds

Change-Id: I66dcb5932388cda513124b88dcaa58e31bc034e6
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

firmware-update: fix for firmware update

updated firmware update module to support for KCS and USB

Tested:
Tested firmware update utility for USB and KCS

Signed-off-by: anil kumar appana <anil.kum

firmware-update: fix for firmware update

updated firmware update module to support for KCS and USB

Tested:
Tested firmware update utility for USB and KCS

Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Change-Id: I129cd8456eda369386ccdb13d5136708a50f87d1

show more ...

[Mfg]: Ethernet interface carrier status support

Added support to return carrier status for NC-SI diagnostic
signal type.

Tested:
ipmitool raw 0x30 0x14 0x10 0 0 --> returns 0x01 as output
when BMC

[Mfg]: Ethernet interface carrier status support

Added support to return carrier status for NC-SI diagnostic
signal type.

Tested:
ipmitool raw 0x30 0x14 0x10 0 0 --> returns 0x01 as output
when BMC is in manufacturing mode.

Change-Id: Ibd2ee38e4cdb39c081e8a2df24305d9509d6fe78
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

[Mfg]: Reset MTM timer for mfg cmds execution

Whenever manufacturing commands are executed successfully
reset the MTM timer expiry.

Tested:
1. Verified after entering manufacturing mode, issuing
an

[Mfg]: Reset MTM timer for mfg cmds execution

Whenever manufacturing commands are executed successfully
reset the MTM timer expiry.

Tested:
1. Verified after entering manufacturing mode, issuing
any successful manufacturing commands extends the timer.
2. Verified timer is not extended, if invalid length of
manufacturing command is specified, or when tried to commands
when BMC is not in manufacturing mode.

Change-Id: If8817c19f9f803d8e81e91c9aa0056d350617a3d
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Fix: Set SM Signal cmd check for optional byte

For Set SM Signal cmd 4th byte is optional
and only required for fan power signal type(05h).
Updated Set SM Signal cmd to include optional byte
request

Fix: Set SM Signal cmd check for optional byte

For Set SM Signal cmd 4th byte is optional
and only required for fan power signal type(05h).
Updated Set SM Signal cmd to include optional byte
request parameter and rewritten using new ipmi handler API.

Tested:
ipmitool raw 0x30 0x15 0x01 0x00 0x00
ipmitool raw 0x30 0x15 0x0D 0x00 0x00
//resulting in completion code of 0x00

Change-Id: I9872b7d4a3559b192ff564250d0db11313f9aa5e
Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>

show more ...

Start turning on some warnings

This repo needs a lot of help with warnings, start
turning some on slowly.

Change-Id: Icb3cee86829228cd4cbabecc98e43c77cef17223
Signed-off-by: James Feist <james.feis

Start turning on some warnings

This repo needs a lot of help with warnings, start
turning some on slowly.

Change-Id: Icb3cee86829228cd4cbabecc98e43c77cef17223
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add command to control BMC system reset on SMI timeout

This adds a get and set command to enable or disable the BMC
system reset to recover a system after an SMI timeout error.

Tested:
Get SMI Rese

Add command to control BMC system reset on SMI timeout

This adds a get and set command to enable or disable the BMC
system reset to recover a system after an SMI timeout error.

Tested:
Get SMI Reset Disable Status:
ipmitool raw 0x30 0x43
01

Injected SMI Timeout error and system did not reset.

Clear SMI Reset Disable:
ipmitool raw 0x30 0x42 0
ipmitool raw 0x30 0x43
00

Injected SMI Timeout error and system was reset.

Change-Id: If0321c5abd17fbdb97579516bf4864f8ffeec3a5
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Fix clearing of CPU error and crashdump counts

The error and crashdump counts are uint8_t values, so a literal
0 must be cast as a uint8_t or it will be rejected on DBus.

Also need to clear all 4 C

Fix clearing of CPU error and crashdump counts

The error and crashdump counts are uint8_t values, so a literal
0 must be cast as a uint8_t or it will be rejected on DBus.

Also need to clear all 4 CPU counts stored in settings.

Tested:
Started with a non-zero CPU Error and Crashdump count and cleared
each one:
5 CPU Errors and 14 Crashdumps:
ipmitool raw 0x30 0x9a
00 3f 45 c0 c0 c0 0e

Clear the CPU Errors:
ipmitool raw 0x30 0x9b 0 0 1

0 CPU Errors and 14 Crashdumps:
ipmitool raw 0x30 0x9a
00 3f 40 c0 c0 c0 0e

Clear the Crashdumps:
ipmitool raw 0x30 0x9b 0 0 2

0 CPU Errors and 0 Crashdumps:
ipmitool raw 0x30 0x9a
00 3f 40 c0 c0 c0 00

Change-Id: I19948b7e1d862749b98901b8e17e840cf78fc0b7
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Set Enabled to trigger NMI_OUT BSOD

When user invokes "Set NMI source" command, BMC will trigger host BSOD
if the 'source' parameter is not 'NONE'. And it will save NMI source in
dbus property.

The

Set Enabled to trigger NMI_OUT BSOD

When user invokes "Set NMI source" command, BMC will trigger host BSOD
if the 'source' parameter is not 'NONE'. And it will save NMI source in
dbus property.

There is case that same NMI source occurs twice in a row. If we use dbus
value 'source' only, it is impossible to tell if source is changed. To
avoid this issue, NMI_OUT handler also introduces an 'enabled' dbus property.
Command will set 'Enabled' property to true every time. Once MNI approach
finishes, it will reset 'Enabled' to false.

tested:
it's tested in system for IPMI OEM command - set NMI source
Set: ipmitool raw 0x30 0xed 1
Windows BSOD is triggered after the command is issued.

Change-Id: I4e4054ea8afb09a1aa67f91b6250b6d71e9bcc7e
Signed-off-by: Chen Yugang <yugang.chen@linux.intel.com>

show more ...

firmware-update: move FwMaxTransferSize to new API

Rewrite "Firmware Maxium Transfer Size" command to use new API.

Tested:
verified using ipmitool raw command.

ipmitools raw 0x8 0x22 //command
02

firmware-update: move FwMaxTransferSize to new API

Rewrite "Firmware Maxium Transfer Size" command to use new API.

Tested:
verified using ipmitool raw command.

ipmitools raw 0x8 0x22 //command
02 01 80 00 00 00 02 00 c8 00 00 //output

Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Change-Id: I4b87c0a397dedcdf70eca8d518536f5510554efa

show more ...

Implement Cold Redundancy Configuration Command

Implement Set and Get Cold Redundancy Configuration ipmi command.
These two commands are used to set or get configure parameters in
Cold Redundancy.

Implement Cold Redundancy Configuration Command

Implement Set and Get Cold Redundancy Configuration ipmi command.
These two commands are used to set or get configure parameters in
Cold Redundancy.

Tested:
set and get ColdRedundancyEnabled
ipmitool raw 0x30 0x2d 0x01 0x00 return 00
ipmitool raw 0x30 0x2e 0x01 return 00
set and get RotationEnabled
ipmitool raw 0x30 0x2d 0x02 0x00 return 00
ipmitool raw 0x30 0x2e 0x02 return 00
set and get RotationAlgorithm
ipmitool raw 0x30 0x2d 0x03 0x01 0x01 0x02 return 00
ipmitool raw 0x30 0x2e 0x03 return 01 01 02
set and get PeriodOfRotation
ipmitool raw 0x30 0x2d 0x04 0x00 0x00 0x09 0x00 return 00
ipmitool raw 0x30 0x2e 0x04 return 00 00 09 00

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I012ebd5edf9267517d04c12ca46c9675982097ec

show more ...