Increase BMC firmware size limit to 45MB

The firmware update was failing for larger BMC images since the limit
of 37MB was being exceeded. Recent BMC firmware builds have grown
beyond this threshold

Increase BMC firmware size limit to 45MB

The firmware update was failing for larger BMC images since the limit
of 37MB was being exceeded. Recent BMC firmware builds have grown
beyond this threshold, causing update failures. Increase the runtime
firmware size limit to 45MB to accommodate current and near-future
firmware sizes. This provides headroom while maintaining protection
against unexpectedly large images.

Tested: BMC firmware update successful with larger images up to 45MB.

Change-Id: Ie309f82bd2b97242f304d278e0bd7a736f04e8cb
Signed-off-by: Swaroop Aradhya N M <swaroopx.aradhya.n.m@intel.com>

show more ...

Remove unused boost header

Change-Id: I150225423545e7baaebf8d49caac3c21ad726469
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

remove incrementing instance in get/set SmSignal

Incrementing the instance parameter proved to be a bad choice in case
someone wants to index for example fans/pwms from 0. Reaching fan0
would requir

remove incrementing instance in get/set SmSignal

Incrementing the instance parameter proved to be a bad choice in case
someone wants to index for example fans/pwms from 0. Reaching fan0
would require using instance equal to 255 and relying on unsigned
integer overflow. This change removes this, allowing for intuitive
indexing from 0.

Note that this will change the behavior for everyone.

Tested:
On platform, commands succeed with expected effect

Change-Id: Ic0dcfdde410484a979dc3de6296796f273bd0290
Signed-off-by: Florian Breska <florian.breska@intel.com>

show more ...

fix multiple coverity issues

- out of bounds access
- unreachable code
- potential int overflow
- unchecked return value
- dead default switch

Change-Id: I442d2279f3f059fc186db578e22056fa838a65be
S

fix multiple coverity issues

- out of bounds access
- unreachable code
- potential int overflow
- unchecked return value
- dead default switch

Change-Id: I442d2279f3f059fc186db578e22056fa838a65be
Signed-off-by: Marciniak, Patryk <patryk.marciniak@intel.com>

show more ...

appcommands: use ObjectMapper::default_service

Replace deprecated ipmi::MAPPER_BUS_NAME with the PDI-generated
ObjectMapper::default_service constant from the auto-generated
xyz/openbmc_project/Obje

appcommands: use ObjectMapper::default_service

Replace deprecated ipmi::MAPPER_BUS_NAME with the PDI-generated
ObjectMapper::default_service constant from the auto-generated
xyz/openbmc_project/ObjectMapper/common.hpp header.
Fix needed due to this change:
https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/85048

Change-Id: Ic8e1d53ff378c72e4e20a25f2c78f50bef71f038
Signed-off-by: Marciniak, Patryk <patryk.marciniak@intel.com>

show more ...

json: format output with 4-space indentation

Use `dump(4)` instead of `dump()` to generate JSON with
4-space indentation, improving readability of written files.

Change-Id: I3f1ffbdff6784765d54825e

json: format output with 4-space indentation

Use `dump(4)` instead of `dump()` to generate JSON with
4-space indentation, improving readability of written files.

Change-Id: I3f1ffbdff6784765d54825e0aec0dbdfaefc488b
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Fix core dump issue during fru edit

Core-dumps are getting generated while editing the multi-record
area offset in the common header area of FRU.

Current code does not check whether it has crossed

Fix core dump issue during fru edit

Core-dumps are getting generated while editing the multi-record
area offset in the common header area of FRU.

Current code does not check whether it has crossed the cached fru
memory area size while trying to get End-of-list and data-length.
Added a check for fru-size before accessing these fields.

Tested:
ipmitool raw 0x0A 0x12 0 0 0 0x1 0x0 0xXX 0xXX 0xXX 0xXX 0x0 0xXX

Change-Id: Ie6aca8712b994cf8b10095626d9bfebbff44fbc7
Signed-off-by: Jitendra Tripathy <jitendra.kumarx.tripathy@intel.com>

show more ...

chassiscommands: Update chassis intrusion retrieval method

This commit updates to use GetSubTree for checking chassis intrusion
service presence on D-Bus. As the object path prefix and name of chass

chassiscommands: Update chassis intrusion retrieval method

This commit updates to use GetSubTree for checking chassis intrusion
service presence on D-Bus. As the object path prefix and name of chassis
intrusion is going to be changed [1], the old hardcoded string can't be
used to look for it anymore.

[1] https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/76254

Change-Id: I275293786c98512742caeb85189c3613e7fe98e8
Signed-off-by: Chaul Ly <chaul@amperecomputing.com>

show more ...

Fix for display of BMC version as 0.00 in BIOS

BMC version is displayed as 0.00 in BIOS EDKII menu
instead of the actual BMC version.

SoftwareFunctional path has been changed due to the new
code im

Fix for display of BMC version as 0.00 in BIOS

BMC version is displayed as 0.00 in BIOS EDKII menu
instead of the actual BMC version.

SoftwareFunctional path has been changed due to the new
code implementation. Modified the code to support the
new implementation.

Tested:
Read the BMC version on BMC console. Boot to BIOS EDKII
menu and verify the BMC version.

Change-Id: Ia3c15c27c447d314fdc15ec3c855ce5bef1ca853
Signed-off-by: Jitendra Tripathy <jitendra.kumarx.tripathy@intel.com>

show more ...

Fix outdated boost header include

This commit fixes the header include paths from boost library which are
no longer valid.

Change-Id: I2adf06d46f3f597c16e013e54eaedcd2cb0ad42f
Signed-off-by: Chau L

Fix outdated boost header include

This commit fixes the header include paths from boost library which are
no longer valid.

Change-Id: I2adf06d46f3f597c16e013e54eaedcd2cb0ad42f
Signed-off-by: Chau Ly <chaul@amperecomputing.com>

show more ...

remove IPMI_CC

Since IPMI_CC declared in api.h has been gradually deprecated,
this submission will use ipmi::cc in api.hpp instead.

Change-Id: If605247d9e2453b9b13d307f53da3b6143af0259
Signed-off-b

remove IPMI_CC

Since IPMI_CC declared in api.h has been gradually deprecated,
this submission will use ipmi::cc in api.hpp instead.

Change-Id: If605247d9e2453b9b13d307f53da3b6143af0259
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Fix build issues with boost 1.87

With boost 1.87, some calls to spawn() generate this error:

error: ignoring returned value of type 'boost::asio::
deferred_async_operation<void(std::__exception_ptr

Fix build issues with boost 1.87

With boost 1.87, some calls to spawn() generate this error:

error: ignoring returned value of type 'boost::asio::
deferred_async_operation<void(std::__exception_ptr::exception_ptr),
boost::asio::detail::initiate_spawn<boost::asio::io_context::
basic_executor_type<std::allocator<void>, 0> >...', declared with
attribute 'nodiscard' [-Werror=unused-result]

Change-Id: I2e98bc9f45c729ab2b0efe7b51d3eeb87aa37e6b
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Update to the latest .clang-format

Change-Id: Idaaffec251b35a024482a67ef424c3424a92149c
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

Fix build errors with GCC 14

Fix various build errors exposed after updating to GCC 14.

Change-Id: Iec680182785b32650741115ed7d758b2b6bf7d38
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

Reliably report the BMC Ready state

A very rare corner case was found when reporting BMC Ready. The D-Bus
matching function needed to be initialized prior to reading the
associated D-Bus property an

Reliably report the BMC Ready state

A very rare corner case was found when reporting BMC Ready. The D-Bus
matching function needed to be initialized prior to reading the
associated D-Bus property and saving it to a global variable.

There was a small slice of time where the D-Bus entry could be
updated, and the associated update event dropped.

A test script was created to increase the likelihood of landing in the
critical point where the BMC Ready event is dropped.

Tested:
Ran the test script and it failed in under 30 runs.
Ran the same script on this change, which ran for 370+ passes.

Change-Id: Ic4fca745452eee392e8ff5a3f1b5f39200dfc21d
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Overriding ipmiAppGetSystemGuid method

Due to the below upstream change systemGUID read changed from
/xyz/openbmc_project/control/host0/systemGUID interface to
/xyz/openbmc_project/inventory/system/

Overriding ipmiAppGetSystemGuid method

Due to the below upstream change systemGUID read changed from
/xyz/openbmc_project/control/host0/systemGUID interface to
/xyz/openbmc_project/inventory/system/chassis/motherboard/bios

https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/74471

Since hosting SystemGUID at a different place than inventory,
overriding ipmiAppGetSystemGuid API. So that it can match OEM
mechanism of setting it.

Change-Id: I7b0ba6bc06db869ce95bae3e7eb81e4b8ad804a7
Signed-off-by: poram srinivasa rao <poramx.srinivasa.rao@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>

show more ...

Fix for Change in LED Controller service

Due to below upstream change, user unable to Set SM Signal for different
LED's. All the dbus calls also affected due to this change.
https://gerrit.openbmc.o

Fix for Change in LED Controller service

Due to below upstream change, user unable to Set SM Signal for different
LED's. All the dbus calls also affected due to this change.
https://gerrit.openbmc.org/c/openbmc/phosphor-led-sysfs/+/57455

Currently all LED Controllers are grouped into single service.
So this fix provides to support for all the LED controllers based on
new service i.e. xyz.openbmc_project.LED.Controller

Tested:
Ipmitool commands are verified working as expected.
Command: ipmitool raw 0x30 0xb4 0x03 0x02 //Set Security mode
Response: //Success
Command: ipmitool raw 0x30 0x15 0x0D 00 00 00 //Set SM Signal
Response: //Success

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I4ee6f0d3f6148aae69e04fde028ab8ec46187ad8

show more ...

fw-update: Increase BMC firmware size limit

As BMC Firmware size is increased, firmware update via KCS is not
allow if BMC firmware size is crossing 35MB.
So increase BMC FW size to 37MB.

Tested:
A

fw-update: Increase BMC firmware size limit

As BMC Firmware size is increased, firmware update via KCS is not
allow if BMC firmware size is crossing 35MB.
So increase BMC FW size to 37MB.

Tested:
Able to process the file using KCS interface and BMC firmware update
successful.

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I570cf84a970f066bff25abda2866bad5a6c2d3b7

show more ...

obmc-ikvm: rename service file to align with repo name

Updated systemd service file as following for better readability
start-ipkvm.service -> obmc-ikvm.service

Testing:

Verified systemd service u

obmc-ikvm: rename service file to align with repo name

Updated systemd service file as following for better readability
start-ipkvm.service -> obmc-ikvm.service

Testing:

Verified systemd service using QEMU + AST2600EVB firmware.

Before changes:

root@evb-ast2600:~# systemctl status start-ipkvm
* start-ipkvm.service - OpenBMC ipKVM daemon

After changes:

root@evb-ast2600:~# systemctl status obmc-ikvm
* obmc-ikvm.service - OpenBMC ipKVM daemon

Change-Id: I8260a09b074b04c47821758c31ecad5d53eca40c
Signed-off-by: Mohammed Javith Akthar M <mohammedjavitham@ami.com>

show more ...

Migrate sensor handling to phosphor-ipmi-host D-Bus

Updates have been applied to phosphor-ipmi-host D-Bus sensors code to
allow removal of virtually all functions in the sensorcommands.cpp
file.

Si

Migrate sensor handling to phosphor-ipmi-host D-Bus

Updates have been applied to phosphor-ipmi-host D-Bus sensors code to
allow removal of virtually all functions in the sensorcommands.cpp
file.

Side by side comparison of the functions that handle SDRs and other
sensor features shows that the code is almost an exact duplicate.

Implementing a sensorcommands_oem linkable module to
phosphor-ipmi-host allows the remaining OEM functionality to be
inserted into the phosphor-ipmi-host shared object.

Tested:
Side by side comparison of the SDR dump
Spot checks of sensor lists
Confirmed SEL data is still sent to /var/log/redfish

Change-Id: I1a15208e38fa77df71a06740d66e6ab359508b80
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

firmware-update: Increase BMC firmware size

As BMC Firmware size is increased, firmware update via KCS is not
allow if BMC firmware size is crossing 33MB.
So increase BMC FW size to 35MB.

Tested:
A

firmware-update: Increase BMC firmware size

As BMC Firmware size is increased, firmware update via KCS is not
allow if BMC firmware size is crossing 33MB.
So increase BMC FW size to 35MB.

Tested:
Able to process the file using KCS interface and BMC firmware update
successful.

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I292a36c55072177ceda075558c9df62ae790e934

show more ...

Change name to ResetOnMCERR

The BMC will now be in control of the reset on MCERR, so change the name
to align with the IERR and ERR2 options.

Change-Id: I0d2449ce4c29c3b6915d64cf68cbf02e06df921d
Si

Change name to ResetOnMCERR

The BMC will now be in control of the reset on MCERR, so change the name
to align with the IERR and ERR2 options.

Change-Id: I0d2449ce4c29c3b6915d64cf68cbf02e06df921d
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id2036ab746164981596b3ee36259f3ca5d3f1334
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Revert "StorageCmd: Get fru data from different services"

This commit is being reverted as part of an on-going process to
migrate portions of intel-ipmi-oem code to general purpose
phosphor-ipmi-hos

Revert "StorageCmd: Get fru data from different services"

This commit is being reverted as part of an on-going process to
migrate portions of intel-ipmi-oem code to general purpose
phosphor-ipmi-host functions.

Gerrit review: https://gerrit.openbmc.org/c/openbmc/intel-ipmi-oem/+/46931
SHA: f23fd543404a948ae436a5cf4092354dcb60a366

The phosphor-ipmi-host version of storagecommands in the dbus-sdr
subdirectory does not implement this commit. Despite not having this
code in place the FRU functionality works correctly.

The commit message does not provide a good explanation of why it
exists. In light of the fact that the FRU's are enumerated, and FRU
IPMI commands function correctly without this change, the code is
being removed. In the event that this code did provide value, it can
be addressed in the phosphor-ipmi-host base.

Change-Id: Ie25c2719dd4d5482d789c0249ec3e11916203813
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Change OS state busname and objpath

Change the busname and object path of OS state interface.

This commit relies on the patch below:
[1] https://gerrit.openbmc.org/c/openbmc/x86-power-control/+/695

Change OS state busname and objpath

Change the busname and object path of OS state interface.

This commit relies on the patch below:
[1] https://gerrit.openbmc.org/c/openbmc/x86-power-control/+/69589

Change-Id: Ia7a1aedb0d034f292d16a31e4da5f7317cde4d50
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...