Reliably report the BMC Ready state

A very rare corner case was found when reporting BMC Ready. The D-Bus
matching function needed to be initialized prior to reading the
associated D-Bus property an

Reliably report the BMC Ready state

A very rare corner case was found when reporting BMC Ready. The D-Bus
matching function needed to be initialized prior to reading the
associated D-Bus property and saving it to a global variable.

There was a small slice of time where the D-Bus entry could be
updated, and the associated update event dropped.

A test script was created to increase the likelihood of landing in the
critical point where the BMC Ready event is dropped.

Tested:
Ran the test script and it failed in under 30 runs.
Ran the same script on this change, which ran for 370+ passes.

Change-Id: Ic4fca745452eee392e8ff5a3f1b5f39200dfc21d
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Overriding ipmiAppGetSystemGuid method

Due to the below upstream change systemGUID read changed from
/xyz/openbmc_project/control/host0/systemGUID interface to
/xyz/openbmc_project/inventory/system/

Overriding ipmiAppGetSystemGuid method

Due to the below upstream change systemGUID read changed from
/xyz/openbmc_project/control/host0/systemGUID interface to
/xyz/openbmc_project/inventory/system/chassis/motherboard/bios

https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/74471

Since hosting SystemGUID at a different place than inventory,
overriding ipmiAppGetSystemGuid API. So that it can match OEM
mechanism of setting it.

Change-Id: I7b0ba6bc06db869ce95bae3e7eb81e4b8ad804a7
Signed-off-by: poram srinivasa rao <poramx.srinivasa.rao@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>

show more ...

Fix for Change in LED Controller service

Due to below upstream change, user unable to Set SM Signal for different
LED's. All the dbus calls also affected due to this change.
https://gerrit.openbmc.o

Fix for Change in LED Controller service

Due to below upstream change, user unable to Set SM Signal for different
LED's. All the dbus calls also affected due to this change.
https://gerrit.openbmc.org/c/openbmc/phosphor-led-sysfs/+/57455

Currently all LED Controllers are grouped into single service.
So this fix provides to support for all the LED controllers based on
new service i.e. xyz.openbmc_project.LED.Controller

Tested:
Ipmitool commands are verified working as expected.
Command: ipmitool raw 0x30 0xb4 0x03 0x02 //Set Security mode
Response: //Success
Command: ipmitool raw 0x30 0x15 0x0D 00 00 00 //Set SM Signal
Response: //Success

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I4ee6f0d3f6148aae69e04fde028ab8ec46187ad8

show more ...

fw-update: Increase BMC firmware size limit

As BMC Firmware size is increased, firmware update via KCS is not
allow if BMC firmware size is crossing 35MB.
So increase BMC FW size to 37MB.

Tested:
A

fw-update: Increase BMC firmware size limit

As BMC Firmware size is increased, firmware update via KCS is not
allow if BMC firmware size is crossing 35MB.
So increase BMC FW size to 37MB.

Tested:
Able to process the file using KCS interface and BMC firmware update
successful.

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I570cf84a970f066bff25abda2866bad5a6c2d3b7

show more ...

obmc-ikvm: rename service file to align with repo name

Updated systemd service file as following for better readability
start-ipkvm.service -> obmc-ikvm.service

Testing:

Verified systemd service u

obmc-ikvm: rename service file to align with repo name

Updated systemd service file as following for better readability
start-ipkvm.service -> obmc-ikvm.service

Testing:

Verified systemd service using QEMU + AST2600EVB firmware.

Before changes:

root@evb-ast2600:~# systemctl status start-ipkvm
* start-ipkvm.service - OpenBMC ipKVM daemon

After changes:

root@evb-ast2600:~# systemctl status obmc-ikvm
* obmc-ikvm.service - OpenBMC ipKVM daemon

Change-Id: I8260a09b074b04c47821758c31ecad5d53eca40c
Signed-off-by: Mohammed Javith Akthar M <mohammedjavitham@ami.com>

show more ...

Migrate sensor handling to phosphor-ipmi-host D-Bus

Updates have been applied to phosphor-ipmi-host D-Bus sensors code to
allow removal of virtually all functions in the sensorcommands.cpp
file.

Si

Migrate sensor handling to phosphor-ipmi-host D-Bus

Updates have been applied to phosphor-ipmi-host D-Bus sensors code to
allow removal of virtually all functions in the sensorcommands.cpp
file.

Side by side comparison of the functions that handle SDRs and other
sensor features shows that the code is almost an exact duplicate.

Implementing a sensorcommands_oem linkable module to
phosphor-ipmi-host allows the remaining OEM functionality to be
inserted into the phosphor-ipmi-host shared object.

Tested:
Side by side comparison of the SDR dump
Spot checks of sensor lists
Confirmed SEL data is still sent to /var/log/redfish

Change-Id: I1a15208e38fa77df71a06740d66e6ab359508b80
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

firmware-update: Increase BMC firmware size

As BMC Firmware size is increased, firmware update via KCS is not
allow if BMC firmware size is crossing 33MB.
So increase BMC FW size to 35MB.

Tested:
A

firmware-update: Increase BMC firmware size

As BMC Firmware size is increased, firmware update via KCS is not
allow if BMC firmware size is crossing 33MB.
So increase BMC FW size to 35MB.

Tested:
Able to process the file using KCS interface and BMC firmware update
successful.

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I292a36c55072177ceda075558c9df62ae790e934

show more ...

Change name to ResetOnMCERR

The BMC will now be in control of the reset on MCERR, so change the name
to align with the IERR and ERR2 options.

Change-Id: I0d2449ce4c29c3b6915d64cf68cbf02e06df921d
Si

Change name to ResetOnMCERR

The BMC will now be in control of the reset on MCERR, so change the name
to align with the IERR and ERR2 options.

Change-Id: I0d2449ce4c29c3b6915d64cf68cbf02e06df921d
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id2036ab746164981596b3ee36259f3ca5d3f1334
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Revert "StorageCmd: Get fru data from different services"

This commit is being reverted as part of an on-going process to
migrate portions of intel-ipmi-oem code to general purpose
phosphor-ipmi-hos

Revert "StorageCmd: Get fru data from different services"

This commit is being reverted as part of an on-going process to
migrate portions of intel-ipmi-oem code to general purpose
phosphor-ipmi-host functions.

Gerrit review: https://gerrit.openbmc.org/c/openbmc/intel-ipmi-oem/+/46931
SHA: f23fd543404a948ae436a5cf4092354dcb60a366

The phosphor-ipmi-host version of storagecommands in the dbus-sdr
subdirectory does not implement this commit. Despite not having this
code in place the FRU functionality works correctly.

The commit message does not provide a good explanation of why it
exists. In light of the fact that the FRU's are enumerated, and FRU
IPMI commands function correctly without this change, the code is
being removed. In the event that this code did provide value, it can
be addressed in the phosphor-ipmi-host base.

Change-Id: Ie25c2719dd4d5482d789c0249ec3e11916203813
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Change OS state busname and objpath

Change the busname and object path of OS state interface.

This commit relies on the patch below:
[1] https://gerrit.openbmc.org/c/openbmc/x86-power-control/+/695

Change OS state busname and objpath

Change the busname and object path of OS state interface.

This commit relies on the patch below:
[1] https://gerrit.openbmc.org/c/openbmc/x86-power-control/+/69589

Change-Id: Ia7a1aedb0d034f292d16a31e4da5f7317cde4d50
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

Update RestrictionMode enum

Update the RestrictionMode enum to incoming phosphor-dbus-interfaces
changes

Change-Id: Ie0ed543d539cf6f94410fa6ae7fc76868be63081
Signed-off-by: Matt Simmering <matthew.

Update RestrictionMode enum

Update the RestrictionMode enum to incoming phosphor-dbus-interfaces
changes

Change-Id: Ie0ed543d539cf6f94410fa6ae7fc76868be63081
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

Increase MaxFWImageSize to avoid transfer failure

While doing Firmware update via KCS, image is not
transferring properly due to exceeding the max Firmware
image size

Tested:
After increasing t

Increase MaxFWImageSize to avoid transfer failure

While doing Firmware update via KCS, image is not
transferring properly due to exceeding the max Firmware
image size

Tested:
After increasing the Max Firmware Image Size, image transferred
successfully and updated

Change-Id: I3c4a2eea50e9c4cb21fdcc66a7c08f3c27ae757e
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

storagecommands: Split validation logic

The Fru validation logic is useful in isolation, split it into a
separate library that can be included.

Tested:
[0/1] Running all tests.
1/12 phosphor-objmg

storagecommands: Split validation logic

The Fru validation logic is useful in isolation, split it into a
separate library that can be included.

Tested:
[0/1] Running all tests.
1/12 phosphor-objmgr / well_known OK 0.24s
2/12 phosphor-objmgr / need_to_introspect OK 0.22s
3/12 phosphor-objmgr / name_change OK 0.16s
4/12 phosphor-objmgr / interfaces_added OK 0.13s
5/12 phosphor-objmgr / handler OK 0.09s
6/12 phosphor-objmgr / mapper OK 0.07s
7/12 phosphor-host-ipmid / entitymap_json OK 0.06s
8/12 phosphor-host-ipmid / message OK 0.05s
9/12 phosphor-host-ipmid / session/closesession OK 0.03s
10/12 phosphor-objmgr / associations OK 0.20s
11/12 phosphor-host-ipmid / dbus-sdr/sensorcommands OK 0.02s
12/12 intel-ipmi-oem / message OK 0.02s

Ok: 12
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0

Change-Id: I9130eb81703b0cda7c3229f16cd689dd2c96c55c
Signed-off-by: Peter Foley <pefoley@google.com>

show more ...

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-Id: I694f0624eae2cdbb071ab97fe019cd5684615541
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix the bugs found in static analysis

This commit fixes the static analyzer reported issues:

Operands don't affect result
some conditions are not required to check as its always true

Change-Id: Ic

Fix the bugs found in static analysis

This commit fixes the static analyzer reported issues:

Operands don't affect result
some conditions are not required to check as its always true

Change-Id: Icea12472652440b8c66e79491ffe43f2b18cf381
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I1367c2eabf95f27b5acb08b9e6fd6eedcb77377f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Get Device ID: support new version format

We plan to change our version string to the format
"<platform>-YEAR.WEEK.BUILD-g<hash>-<hash>".

This supports the new format by allowing for a dot instead

Get Device ID: support new version format

We plan to change our version string to the format
"<platform>-YEAR.WEEK.BUILD-g<hash>-<hash>".

This supports the new format by allowing for a dot instead of a dash
before the BUILD number and by using only the last two characters of the
major version string.

Tested:
Confirmed that "ipmitool mc info" and "ipmitool raw 6 1" both return the
correct version information from the old and new version strings.

Change-Id: I7e9cdffd37c0033062377a0b575d8d4635fb5625
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

changes to make it build without cheating

intel-ipmi-oem was using header files from phosphor-host-ipmid that were
not actually in the distributed list of headers. Since intel-ipmi-oem is
on its way

changes to make it build without cheating

intel-ipmi-oem was using header files from phosphor-host-ipmid that were
not actually in the distributed list of headers. Since intel-ipmi-oem is
on its way to removing the files that use those headers anyway, this is
a stop-gap measure to be able to compile in the meantime.

Tested: sensors work as before

Change-Id: Ie443d2b53d12936f0ec7747cc9a01ed75ac63ab5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Maue

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Remove unused namespace

After some recent changes, the error.hpp file must be included to find
sdbusplus::xyz::openbmc_project::Common::Error, but it's unused, so just
remove it.

Change-Id: I185c45

Remove unused namespace

After some recent changes, the error.hpp file must be included to find
sdbusplus::xyz::openbmc_project::Common::Error, but it's unused, so just
remove it.

Change-Id: I185c453def4515a35749f687a57b4f0b6da6deb8
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Add a configuration option to allow reset on MCERR

MCERR is another type of error that can be recovered by a reset. This
adds a configuration option to control if the BMC will allow that
recovery.

Add a configuration option to allow reset on MCERR

MCERR is another type of error that can be recovered by a reset. This
adds a configuration option to control if the BMC will allow that
recovery.

Tested:
Injected an MCERR and confirmed that when this option is true, recovery
is enabled. When this option is false, recovery is blocked.

Change-Id: I435af50acc41061e3a5036c84d12a99ffeee8969
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Rename CATERR to IERR

CATERR is ambiguous because it represents two types of errors: IERR and
MCERR. This changes the name to IERR to be more specific.

Change-Id: I9f2c3967885b0d8eea0ceef310febd412

Rename CATERR to IERR

CATERR is ambiguous because it represents two types of errors: IERR and
MCERR. This changes the name to IERR to be more specific.

Change-Id: I9f2c3967885b0d8eea0ceef310febd4124ddb558
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Add OEM get BMC Version String command

Change-Id: If8704427844eee4f54173425a2b74787f939a9cf
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

Return error when SDR offset is out of range

When reading SDRs, if the requested offset is beyond the end of the SDR,
we should return an error indicating that the offset is out of range.

Tested:
C

Return error when SDR offset is out of range

When reading SDRs, if the requested offset is beyond the end of the SDR,
we should return an error indicating that the offset is out of range.

Tested:
Confirmed that reading offset 0x40 or 0x41 of a 64-byte SDR return an
error:
ipmitool raw 0xa 0x23 0x01 0x00 0x87 0x00 0x40 0x1
Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0 cmd=0x23 rsp=0xc9): Parameter out of range
ipmitool raw 0xa 0x23 0x01 0x00 0x87 0x00 0x41 0x1
Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0 cmd=0x23 rsp=0xc9): Parameter out of range

Change-Id: I3423dddadeb3d2a5e2075ae079d263503ac0679e
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...