Return error when SDR offset is out of range

When reading SDRs, if the requested offset is beyond the end of the SDR,
we should return an error indicating that the offset is out of range.

Tested:
C

Return error when SDR offset is out of range

When reading SDRs, if the requested offset is beyond the end of the SDR,
we should return an error indicating that the offset is out of range.

Tested:
Confirmed that reading offset 0x40 or 0x41 of a 64-byte SDR return an
error:
ipmitool raw 0xa 0x23 0x01 0x00 0x87 0x00 0x40 0x1
Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0 cmd=0x23 rsp=0xc9): Parameter out of range
ipmitool raw 0xa 0x23 0x01 0x00 0x87 0x00 0x41 0x1
Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0 cmd=0x23 rsp=0xc9): Parameter out of range

Change-Id: I3423dddadeb3d2a5e2075ae079d263503ac0679e
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Fix to prevent the FRU corruption while updating

While updating the FRU , if we try to read the FRU data
by running command "ipmitool fru list" before 2 seconds after
editing the FRU, getting corrup

Fix to prevent the FRU corruption while updating

While updating the FRU , if we try to read the FRU data
by running command "ipmitool fru list" before 2 seconds after
editing the FRU, getting corrupted data

Tested:

FRU data not corrupted and updated successfully

Change-Id: I8d2949706378b776888c6768755a57f3727ffb51
Signed-off-by: PavanKumarIntel <pavanx.kumar.martha@intel.com>

show more ...

Fix object path of chassis intrusion

The chassis intrusion object path got updated upstream.
This fix aligns with latest sensor path.

Change-Id: I34841746f9f1b6795a7175659fb4ff71d562b816
Signed-off

Fix object path of chassis intrusion

The chassis intrusion object path got updated upstream.
This fix aligns with latest sensor path.

Change-Id: I34841746f9f1b6795a7175659fb4ff71d562b816
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

Fix IPMI firmware update programming failure

The IPMI Firmware Update sequence fails on some systems. The update
process receives the new firmware image data in the /tmp file
system. During the fina

Fix IPMI firmware update programming failure

The IPMI Firmware Update sequence fails on some systems. The update
process receives the new firmware image data in the /tmp file
system. During the final update phase the image is copied into the
/tmp/images subdirectory. If /tmp and /tmp/images are not part of the
same filesystem the std::filesystem::rename() function fails.

This commit changes the update process. The rename() is still
attempted. In the event the rename() fails, a copy() operation is
performed in the belief the destination is on a separate filesystem.

Tested:
Confirmed this change works on systems with a common /tmp filesystem.
Confirmed this change works on systems with the source file and the
destination file on different filesystems.

Change-Id: I5e3da6c0f453941ea54cb829d2bcaeadda0db438
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Added support for ipmi tool based mux slot disable

Currently ipmitool doesn't support mctp mux-slot
disabling capablity.

this patch will support to disable/enable mctp
mux slot funtionality using i

Added support for ipmi tool based mux slot disable

Currently ipmitool doesn't support mctp mux-slot
disabling capablity.

this patch will support to disable/enable mctp
mux slot funtionality using ipmi tool.

Change-Id: I0bdbd86d2fb4f806d61f665a8014c0c097ee4258
Signed-off-by: Vasu V <vasu.v@intel.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I59c0a8c4b89131ecd3e9a841ed37ef3b8dcf8e9d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Remove MDRv1 SMBIOS commands

MDRv1 SMBIOS commands are no longer supported. This removes the IPMI
handlers.

Tested: builds and runs as expected; MDRv1 commands are not present

Change-Id: Ie5370172

Remove MDRv1 SMBIOS commands

MDRv1 SMBIOS commands are no longer supported. This removes the IPMI
handlers.

Tested: builds and runs as expected; MDRv1 commands are not present

Change-Id: Ie537017254cfeba58d60f79b5005c4d729665d3c
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Change terminology to inclusive terms

Tested: No functionality changes, code still compiles.

Change-Id: I61dd3c6f3ecfb96088a68b1254a22c5fa5376b3d
Signed-off-by: Matt Simmering <matthew.simmering@in

Change terminology to inclusive terms

Tested: No functionality changes, code still compiles.

Change-Id: I61dd3c6f3ecfb96088a68b1254a22c5fa5376b3d
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

Fix Get and Set SM PWM Signal

On systems with multiple fan controllers, Index value is only unique
within the same controller. This means that Index alone can not be used
to correctly identify a fan

Fix Get and Set SM PWM Signal

On systems with multiple fan controllers, Index value is only unique
within the same controller. This means that Index alone can not be used
to correctly identify a fan sensor. This commit fixes this defect by
specifically searching for the "Fan_#" Entity Manager object where # is
the fan being accessed.

The commit which introduced this issue can be found here:
https://gerrit.openbmc.org/c/openbmc/intel-ipmi-oem/+/56909

This commit also replaces phosphor-logging log with lg2.

Testing:
1. System with multiple fan controllers that have duplicated index
property:
busctl introspect xyz.openbmc_project.EntityManager
/xyz/openbmc_project/inventory/system/board/XXXXXXXX/Fan_7
xyz.openbmc_project.Configuration.I2CFan interface
.Address property t
47
.BindConnector property s
"System Fan connector 7"
.Bus property t
6
.Index property t
0
busctl introspect xyz.openbmc_project.EntityManager
/xyz/openbmc_project/inventory/system/board/XXXXXXXX/Fan_1
xyz.openbmc_project.Configuration.I2CFan interface
.Address property t
44
.BindConnector property s
System Fan connector 1"
.Bus property t
6
.Index property t
0

Without fix:
ipmitool raw 0x30 0x14 0x0d 0 0x00
3c
ipmitool raw 0x30 0x14 0x0d 6 0x00
Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0x14
rsp=0xcc): Invalid data field in request.

With fix:
ipmitool raw 0x30 0x14 0x0d 0 0x00
3c
ipmitool raw 0x30 0x14 0x0d 6 0x00
3c
ipmitool raw 0x30 0x15 0x05 0 0x1 0x40
ipmitool raw 0x30 0x15 0x05 6 0x1 0x46
ipmitool raw 0x30 0x14 0x0d 0 0x00
40
ipmitool raw 0x30 0x14 0x0d 6 0x00
46

2. System with one pwm port controlling two fans:
busctl introspect xyz.openbmc_project.EntityManager
/xyz/openbmc_project/inventory/system/board/XXXXXXXX/Fan_1
xyz.openbmc_project.Configuration.I2CFan.Connector interface
.Name property s
"System Fan connector 1" emits-change
.Pwm property t
0 emits-change
.PwmName property s
"Pwm_1_2" emits-change
busctl introspect xyz.openbmc_project.EntityManager
/xyz/openbmc_project/inventory/system/board/XXXXXXXX/Fan_2
xyz.openbmc_project.Configuration.I2CFan.Connector interface
.Name property s
"System Fan connector 2" emits-change
.Pwm property t
0 emits-change
.PwmName property s
"Pwm_1_2" emits-change

ipmitool raw 0x30 0x14 0x0d 0 0x00
3c
ipmitool raw 0x31 0x14 0x0d 1 0x00
3c
ipmitool raw 0x30 0x15 0x05 0 0x1 0x40
ipmitool raw 0x30 0x14 0x0d 0 0x00
40
ipmitool raw 0x31 0x14 0x0d 1 0x00
40

Signed-off-by: Alex Schendel <alex.schendel@intel.com>
Change-Id: I8e2323c4572ed21c4e2f58d282574e65270bf60c

show more ...

Match FRU I2C bus address size to phosphor-host-ipmid definition

The entity-manager and phosphor-host-ipmid changed the D-Bus signature
of the I2C bus number variable from 8-bit to 16-bit. This chan

Match FRU I2C bus address size to phosphor-host-ipmid definition

The entity-manager and phosphor-host-ipmid changed the D-Bus signature
of the I2C bus number variable from 8-bit to 16-bit. This change
caused a mismatch in intel-ipmi-oem, which kept the 8-bit signature.

Tested:
Issued busctl FruDeviceManager calls changing the signature from
yy to qy
Issued 'ipmitool fru' commands and confirmed the FRU contents in the
system were displayed.

Change-Id: I83d4a339f4be4c686db35256bf3b574cd34bdb29
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Fix for GetFanControlConfiguration IPMI command

GetFanControlConfiguration IPMI command not working as expepcted.
So updated busctl interface to fetch correct service from object Mapper.

Tested:
Be

Fix for GetFanControlConfiguration IPMI command

GetFanControlConfiguration IPMI command not working as expepcted.
So updated busctl interface to fetch correct service from object Mapper.

Tested:
Before Fix:
Command: ipmitool raw 0x30 0x8a 0x00
Response:
Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0x8a
rsp=0xcc): Invalid data field in request
Command: busctl call "xyz.openbmc_project.ObjectMapper"
"/xyz/openbmc_project/object_mapper" "xyz.openbmc_project.ObjectMapper"
GetObject sas /xyz/openbmc_project/inventory/system/chassis/motherboard/CPU_1
1 "xyz.openbmc_project.Inventory.Item"
Response: Call failed: The resource is not found.

After Fix:
Command: ipmitool raw 0x30 0x8a 0x00
Response: 80 00 04 00 00 00 00
Command: busctl call "xyz.openbmc_project.ObjectMapper"
"/xyz/openbmc_project/object_mapper" "xyz.openbmc_project.ObjectMapper"
GetObject sas /xyz/openbmc_project/inventory/system/chassis/motherboard/cpu0
1 "xyz.openbmc_project.Inventory.Item"
Response: a{sas} 1 "xyz.openbmc_project.Smbios.MDR_V2" 10
"org.freedesktop.DBus.Introspectable" "org.freedesktop.DBus.Peer"
"org.freedesktop.DBus.Properties" "xyz.openbmc_project.Association.Definitions"
"xyz.openbmc_project.Inventory.Connector.Slot"
"xyz.openbmc_project.Inventory.Decorator.Asset"
"xyz.openbmc_project.Inventory.Decorator.LocationCode"
"xyz.openbmc_project.Inventory.Decorator.Revision"
"xyz.openbmc_project.Inventory.Item" "xyz.openbmc_project.Inventory.Item.Cpu"

Change-Id: Ic212637113c3cb52867ba7addcb599547c1ce7a2
Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com>

show more ...

Set Chassis Intrusion status dynamically

Set the Chassis Intrusion status in the Get Chassis Status command
dynamically by checking for the Chassis Intrusion service.

Tested:
Chassis Intrusion stat

Set Chassis Intrusion status dynamically

Set the Chassis Intrusion status in the Get Chassis Status command
dynamically by checking for the Chassis Intrusion service.

Tested:
Chassis Intrusion status is set as active on a platform with the service
running. Chassis Intrusion status is set as inactive on a platform
without the service running.

Signed-off-by: Matt Simmering <matthew.simmering@intel.com>
Change-Id: I5eb503d3d0b456aad5c6b16a585aa10e18e8a0e1

show more ...

The slot i2c master read write command is updated

The update is to perform read-write operation on the devices behind MUX
in various components like
RISER, HSBP and PCIe slots present in baseboard.

The slot i2c master read write command is updated

The update is to perform read-write operation on the devices behind MUX
in various components like
RISER, HSBP and PCIe slots present in baseboard.

Tested:
The slot i2c command was tested for reading data from HSBP CPLD
present behind baseboard MUX and found to be successful

Signed-off-by: V-Sanjana <sanjana.v@intel.com>
Change-Id: I25ce882fda50f5946ca2acec0290d1c769ab019a

show more ...

Update filter to allowlist instead of whitelist

Remove racist terminology in favor of descriptive terminology.

Tested: builds and runs with no change in behavior.

Change-Id: Ic7ab6f4b316043da67f07

Update filter to allowlist instead of whitelist

Remove racist terminology in favor of descriptive terminology.

Tested: builds and runs with no change in behavior.

Change-Id: Ic7ab6f4b316043da67f079cd92cd6f070ddcf108
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Move the location of sensor object manager

Per phosphor-dbus-interfaces, all sensor implementations should be
implementing an ObjectManager at /xyz/openbmc_project/sensors

This commit updates intel

Move the location of sensor object manager

Per phosphor-dbus-interfaces, all sensor implementations should be
implementing an ObjectManager at /xyz/openbmc_project/sensors

This commit updates intel-ipmi-oem to look from the corrrect location.

Tested:
No good way to test, as I don't have an intel-ipmi-oem platform, but a
similar patch made to phosphor-ipmi-host showed the correct results.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I6d059cb1da79a7444da813e329b7ed7ebd8d0350

show more ...

Remove ManagedObjectType Dependency

libipmi now has a getManagedObjects() function which obviates the need
to specify a custom type and use a direct dbus yield method call. This
does not change any

Remove ManagedObjectType Dependency

libipmi now has a getManagedObjects() function which obviates the need
to specify a custom type and use a direct dbus yield method call. This
does not change any behavior of the Get or Capture Manufacturing Data
commands. This commit serves to improve readability and remove
unnecessary dependencies.

Tested:
Get Manufacturing Data continues to report MAC Address:
ipmitool raw 0x30 0xA2 0x00
01 a4 bf 01 8c c4 94

Change-Id: I128ef0679932bf247c1e9e1e8bd2e870a24e3d16
Signed-off-by: Alex Schendel <alex.schendel@intel.com>

show more ...

Fix Get and Set SM Signal Fan PWM Command

The Get SM Signal and Set SM Signal IPMI commands function under the
assumption that there is a 1:1 relationship between the fan Pulse Width
Modulator (PWM)

Fix Get and Set SM Signal Fan PWM Command

The Get SM Signal and Set SM Signal IPMI commands function under the
assumption that there is a 1:1 relationship between the fan Pulse Width
Modulator (PWM), and the fan tachometer. Not all hardware follows this
model. The code changes in this commit updates these IPMI commands to handle
the introduction of HW that uses one PWM output to control two fans.

For systems that have a 1:1 PWM/Tachometer relationship, this code improves
upon the original "signal instance" lookup. The "signal instance" now
specifies a "fan number". Systems may not have a linear relationship between
"fan header numbers" and the PWM that controls the fan on that header. Prior
to this commit the "signal instance" had to be the PWM number. Now the Get/Set
commands associate a linear fan number to the respective PWM.

Systems that use one PWM to control multiple fans, and by extension multiple
tachometers use a secondary lookup to determine the fan to modify/read. The
JSON file describing the fan PWM/tachometer is updated to add a "PWMName"
record. The instance number is combined with the PWMName entry to identify
the correct HW to read/modify. The PWMName entry in the JSON file nomenclature
defines two fans (i.e. "PWMName:" "Pwm_3_4"), which are associated to a PWM,
(i.e. "Pwm": 1).

Tested:
On system with default PWM name:
IPMI command:
ipmitool raw 0x30 0x14 0x0d 6 0x00 # read fan 7 pwm
32
ipmitool raw 0x30 0x15 0x05 6 0x1 0x48 # set fan 7 pwm (72%)
ipmitool raw 0x30 0x14 0x0d 6 0x00 # read fan 7 pwm
48
root@intel-obmc:~# busctl get-property
xyz.openbmc_project.EntityManager
/xyz/openbmc_project/inventory/system/chassis/Fan_7
xyz.openbmc_project.Configuration.AspeedFan.Connector Pwm
t 12
(In this system, Fan 7 is connected to PWM 12)

Dbus tree showing default name:
busctl tree xyz.openbmc_project.FanSensor
`-/xyz/openbmc_project/sensors
|-/xyz/openbmc_project/sensors/fan_pwm
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_1
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_13
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_14
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_15
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_16
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_2
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_3
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_4
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_5
| `-/xyz/openbmc_project/sensors/fan_pwm/Pwm_6

On system with non-default PWM name:
IPMI command:
ipmitool raw 0x30 0x14 0x0d 1 0x00 # read fan 2 pwm
64
ipmitool raw 0x30 0x15 0x05 0 0x1 0x48 # set fan 2 pwm
ipmitool raw 0x30 0x14 0x0d 0 0x00 # read fan 1 pwm
48 # shared with fan 2

Dbus tree showing non-default PWM name:
busctl tree xyz.openbmc_project.FanSensor
`-/xyz/openbmc_project/sensors
|-/xyz/openbmc_project/sensors/fan_pwm
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_11_12
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_1_2
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_3_4
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_5_6
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_7_8
| `-/xyz/openbmc_project/sensors/fan_pwm/Pwm_9_10

Change-Id: I9a40256ed892170f8ba88a3a617b5a2e11693c9f
Signed-off-by: Alex Schendel <alex.schendel@intel.com>

show more ...

treewide: change EM's ObjectManager path

EntityManager moves its ObjectManager in commit [1], this patch is to
change accordingly. Please see [1] for why we made that change.

[1] https://gerrit.ope

treewide: change EM's ObjectManager path

EntityManager moves its ObjectManager in commit [1], this patch is to
change accordingly. Please see [1] for why we made that change.

[1] https://gerrit.openbmc.org/c/openbmc/entity-manager/+/57279

Tested: code compiles. I don't have a system with this repo enabled.
But code inspection can show that only ObjectManager path changed.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I166cc919bf355d5ee3224553129854a28fdf03b7

show more ...

Change static flat_map to constexpr array of pairs

This changes a hardcoded static flat_map to a compile-time defined
constexpr array of pairs to reduce binary space.

Tested:
Confirmed that 'ipmito

Change static flat_map to constexpr array of pairs

This changes a hardcoded static flat_map to a compile-time defined
constexpr array of pairs to reduce binary space.

Tested:
Confirmed that 'ipmitool sdr elist' shows the correct units

Change-Id: Id66d8c3f7324c39360ccb083fb3b5f3d154ac215
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Condense std::variants

Where possible, reduce to a single std::variant type to reduce binary
size.

Change-Id: I73b59765109ce1ccd7339f0e214d1ec3929e1ffc
Signed-off-by: Jason M. Bills <jason.m.bills@

Condense std::variants

Where possible, reduce to a single std::variant type to reduce binary
size.

Change-Id: I73b59765109ce1ccd7339f0e214d1ec3929e1ffc
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Specify "8-bit ASCII + Latin 1" SDR encoding

Applications using OpenSolaris libipmi can't handle "Unicode" (type 0)
encoding for the sensor names [0].

This results in issues with VMWare ESXi which

Specify "8-bit ASCII + Latin 1" SDR encoding

Applications using OpenSolaris libipmi can't handle "Unicode" (type 0)
encoding for the sensor names [0].

This results in issues with VMWare ESXi which uses IPMI to fetch sensor
data from the BMC, all the names are shown as "Unspecified 1" (if
default EntityId is used), so status page, SEL entries and the logs
become very confusing.

Fix this by telling it to process all bytes as is by using "8-bit ASCII
+ Latin 1" type.

Tested with VMWare ESXi 7.0 Update 2 and regular ipmitool (using GNU
FreeIPMI), both shows names correctly.

[0] https://github.com/kofemann/opensolaris/blob/master/usr/src/lib/libipmi/common/ipmi_util.c#L258

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: I53d74944717b1642eab6bee3c2c8566a1b8808b1

show more ...

Check reserved fields in appSlotI2CMasterWriteRead

Reserved field checking was not present, so this adds a check to make
sure that ther reserved fields do not have bits set. Also fixes a typo
for th

Check reserved fields in appSlotI2CMasterWriteRead

Reserved field checking was not present, so this adds a check to make
sure that ther reserved fields do not have bits set. Also fixes a typo
for the reserved field name.

Tested: Run a slot i2c write read command that has a bit set in the
reserved field and see that it gets rejected.

Change-Id: I7f63cc71b97f4864c8dc59738a240630e388120e
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie7375047bd567aa052d3bd35a6dd7008779a05b4

show more ...

Check SetEFIBootOptions when Byte 1&2 are 0

Update of: ipmiOemSetEfiBootOptions()
A check is done when both arguments are 0.
This is a invalid or unuseful condition.

Tested
==========
Issue command

Check SetEFIBootOptions when Byte 1&2 are 0

Update of: ipmiOemSetEfiBootOptions()
A check is done when both arguments are 0.
This is a invalid or unuseful condition.

Tested
==========
Issue command "ipmitool raw 0x30 0xEA 0x00 0x00 " expect rtn mess:
Unable to send RAW command
(channel=0x0 netfn=0x30 lun=0x0 cmd=0xea rsp=0xcc):
Invalid data field in request

Signed-off-by: Mike Jones <michaelx.jones@intel.com>
Change-Id: Ia28cb34983baf0c28084227fd1df71e5045406cd

show more ...

bmccontrolservices: Use service name for matching

The object paths of services are changed after service-config-manager
switched using sdbusplus to encode them, but now the service names can
be deco

bmccontrolservices: Use service name for matching

The object paths of services are changed after service-config-manager
switched using sdbusplus to encode them, but now the service names can
be decoded from the object paths. This patch changes to use service
name for matching accordingly.

Also changes unorderded_map bmcServices to array as random access is
not needed here.

Requires service-config-manager change #52557 ("Encode object path with
sdbusplus") being merged first.

Tested:
Verified both Get/Set BMC Services IPMI commands work as before.

Change-Id: I6da7f275c252059b121c323280214012f330340f
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...