storagecommands: magic number for record_type

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Iee54333d804333de82ad47c8077b414baee53f4c

Use the new RestartCause interface

Tested:
Combined with the RestartCause changes ran 'ipmitool raw 0 7'
and 'ipmitool chassis restart_cause' commands and confirmed that
they correctly return the cu

Use the new RestartCause interface

Tested:
Combined with the RestartCause changes ran 'ipmitool raw 0 7'
and 'ipmitool chassis restart_cause' commands and confirmed that
they correctly return the current RestartCause.

Change-Id: I8361040b12db6567ea48157b9f2e048054e8df1d
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

storagecommands: drop extra check range condition

The recordType variable is a uint8_t and the <= check will never be
false.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I06a692ad

storagecommands: drop extra check range condition

The recordType variable is a uint8_t and the <= check will never be
false.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I06a692ad06e9e07fd5e0f170ecf8c7ed27d9d83e

show more ...

Implement a Command To Get PSU Version

Implement an IPMI command to get PSU version.

Tested:
Run ipmitool raw 0x30 0xef
returns: 03 32 01 03 32 01

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.i

Implement a Command To Get PSU Version

Implement an IPMI command to get PSU version.

Tested:
Run ipmitool raw 0x30 0xef
returns: 03 32 01 03 32 01

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I087b7786b7dd669f5b1eecb8a9bc9647362fd207

show more ...

sensorcommands: add stdexcept header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I47eddd3e730a51a94efe0aadfaf446697f532d8c

sensorcommands: add array header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ib171d91416aa5c03cb43f9860ae21cabcdb50eb3

sensorcommands: add memory header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I8e8d7bb276828001811b1a3af473594ae2197923

sensorcommands: add algorithm header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ifccc9f2bc95115fd7212d31eab1b39a0de186ade

sensorcommands: add variant header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I2d3feee798215f28b444e69f818849b34b42df48

sensorcommands: add cstring header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie86be5e3b68f98a3690cb7b2ec9669a605d8d235

sensorcommands: add utility header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If3c7971c9eed7a1296280d47fb27fe92de25efb7

sensorcommands: add optional header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: If1883c74aadcedff7a17ba84f03cc058589f3612

smbiosmdrv2handler: drop unused vars

[src/smbiosmdrv2handler.cpp:626]: (style) Unused variable: status
[src/smbiosmdrv2handler.cpp:624]: (style) Unused variable: res
[src/smbiosmdrv2handler.cpp:625]

smbiosmdrv2handler: drop unused vars

[src/smbiosmdrv2handler.cpp:626]: (style) Unused variable: status
[src/smbiosmdrv2handler.cpp:624]: (style) Unused variable: res
[src/smbiosmdrv2handler.cpp:625]: (style) Unused variable: resDat

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I3ae767f91ad9948f6ddae86126a729b2eed33efe

show more ...

bugfix: smbiosmdrv2handler: sizeof(pointer)

[src/smbiosmdrv2handler.cpp:570]:
[src/smbiosmdrv2handler.cpp:1002]:
[src/smbiosmdrv2handler.cpp:1112]:
(warning) Using 'sizeof' on array given as functio

bugfix: smbiosmdrv2handler: sizeof(pointer)

[src/smbiosmdrv2handler.cpp:570]:
[src/smbiosmdrv2handler.cpp:1002]:
[src/smbiosmdrv2handler.cpp:1112]:
(warning) Using 'sizeof' on array given as function argument returns
size of a pointer.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ib311a970e324f24769064dc2ad47a8c3be1ca420

show more ...

manufacturingcommands: pass string by const ref

[src/manufacturingcommands.cpp:89]:
(performance) Function parameter 'setState' should be passed by const
reference.

Signed-off-by: Patrick Venture <

manufacturingcommands: pass string by const ref

[src/manufacturingcommands.cpp:89]:
(performance) Function parameter 'setState' should be passed by const
reference.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie22127f4d071d684d646d047178e639826537437

show more ...

sensorcommands: zeroize some ints

[src/sensorcommands.cpp:867]:
(error) Uninitialized variable: assertionEnabledLsb
(error) Uninitialized variable: assertionEnabledMsb
(error) Uninitialized variable

sensorcommands: zeroize some ints

[src/sensorcommands.cpp:867]:
(error) Uninitialized variable: assertionEnabledLsb
(error) Uninitialized variable: assertionEnabledMsb
(error) Uninitialized variable: deassertionEnabledLsb
(error) Uninitialized variable: deassertionEnabledMsb

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Id9703bef367b48353881c7ae37bd294c7bf5c5f9

show more ...

storagecommands: add functional header

The functional header provides std::hash

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I48451b1278a3d53e0d0622e72590a8ac7d9bd53d

storagecommands: pass by reference

[src/storagecommands.cpp:598]:
[src/storagecommands.cpp:628]:
(performance) Function parameter 'selLogFiles' should be passed by const reference.
[src/storagecomma

storagecommands: pass by reference

[src/storagecommands.cpp:598]:
[src/storagecommands.cpp:628]:
(performance) Function parameter 'selLogFiles' should be passed by const reference.
[src/storagecommands.cpp:642]:
(performance) Function parameter 'hexStr' should be passed by const reference.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I0528a122f34e9b53627f041c1bdd7be4f34858ed

show more ...

sensorcommands: add map header

Add header for map that is used in this file.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Id47365bfc5c1ffc450a37cebb5a29ae8eedcf202

storagecommands: move Read and Write FRU data

Rewrite "Read and write FRU data" to new IPMI provider API.

Tested:
verified using ipmitool storage commands.
a. read fru data
b. write fru data before

storagecommands: move Read and Write FRU data

Rewrite "Read and write FRU data" to new IPMI provider API.

Tested:
verified using ipmitool storage commands.
a. read fru data
b. write fru data before and after the changes.

Write Fru data:
Input Command: ipmitool raw 0x0a 0x12 0x00 0x02 0x01 0x15 0x26 0x24
0x20 0x1a 0x10 0x01 0x02 0x03 0x5 0x43 0x55 0x66 0xaa 0xbb 0xaa
Output: 00

Read fru data:
Input Command: ipmitool raw 0x0a 0x11 0x00 0x02 0x01 0x10
Output: 10 15 26 24 20 1a 10 01 02 03 05 43 55 66 aa bb aa

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Id9e52623d262bab8fa1fe861896fc36a43c9f488

show more ...

Bug fixing for boot option

1.ipmi boot option format is
"ipmitool raw 0x00 0x08 0x05 0x80 0x18 0x00 0x00 0x00 "
the last three parameters of "0x00 0x00 0x00" are needed
in boot options command forma

Bug fixing for boot option

1.ipmi boot option format is
"ipmitool raw 0x00 0x08 0x05 0x80 0x18 0x00 0x00 0x00 "
the last three parameters of "0x00 0x00 0x00" are needed
in boot options command format, add it to the commands.
2. boot option set in progess is a status, but it should
can be update if it's in set-in-progress, otherwise, it
would never be changed back to update new boot option.

Tested:
it's tested by the following commands:
1.ipmitool raw 0x00 0x08 0x05 0x80 0x18 0x00 0x00 0x00
2.ipmitool raw 0x00 0x08 00 01
ipmitool raw 0x00 0x08 00 00

Change-Id: I3196d8472ae5135f37bcacd607d6e5a4228a6fe7
Signed-off-by: Chen Yugang <yugang.chen@linux.intel.com>

show more ...

intel-ipmi-oem: Fix special mode path

Special mode object patch needs to be corrected to read
the property value properly using Get Security mode command

Tested:
1. Verified proper value is returne

intel-ipmi-oem: Fix special mode path

Special mode object patch needs to be corrected to read
the property value properly using Get Security mode command

Tested:
1. Verified proper value is returned using
ipmitool raw 0x30 0xB3

Change-Id: I13169a69032184db6491598314b421f195ae529c
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

intel-ipmi-oem: Replace yield with ctx for mfg cmd

Replace yield with ctx pointer where ever possible
in manufacturing commands. This gives option to avoid
getSdBus() calls as sdbus pointer & yield

intel-ipmi-oem: Replace yield with ctx for mfg cmd

Replace yield with ctx pointer where ever possible
in manufacturing commands. This gives option to avoid
getSdBus() calls as sdbus pointer & yield will be used.

Tested:
Verified existing manufacturing commands are working fine.

Change-Id: Ifdd7f0c3872768cf167648396ca194e77fcb13b2
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

intel-ipmi-oem: add clear CMOS command

There is an i2c device on bus4, the slave address is 0x70. Based on the
spec, writing 0x1 to address 0x60 on this device, will trigger the clear
CMOS action.

intel-ipmi-oem: add clear CMOS command

There is an i2c device on bus4, the slave address is 0x70. Based on the
spec, writing 0x1 to address 0x60 on this device, will trigger the clear
CMOS action.

Tested:
Run the below command in MFG mode:
ipmitool raw 0x32 0x91

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I2e549de7ab18c448e81cc8b431cf90bab8fd9dd0

show more ...

Implement Get Message Flags Command

Enable command that Get Message Flag can set right bit about
watchdog.

Tested:
Set watchdog timer
(Pre-timeout interrupt is Messaging, Initial Countdown is 2 sec

Implement Get Message Flags Command

Enable command that Get Message Flag can set right bit about
watchdog.

Tested:
Set watchdog timer
(Pre-timeout interrupt is Messaging, Initial Countdown is 2 second).
ipmitool raw 0x06 0x24 0x5 0x30 0x1 0x3e 0x14 0x00
Start watchdog timer.
ipmitool mc watchdog reset
After watchdog timer expired,
restart host and excute Get Message Flag Command.
ipmitool raw 0x06 0x31
Expect return "0x0b".

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Ib545034edfd0087e45d6a97125495e365989d7d3

show more ...