Updated set security command for val unsecure

Support added for set security mode command to set the validation
unsecure value when image is build with debug-tweaks. This will be
used to enable the

Updated set security command for val unsecure

Support added for set security mode command to set the validation
unsecure value when image is build with debug-tweaks. This will be
used to enable the validation unsecure mode permanently, till
reset to defaults is performed. By default this feature will be disabled
and will be enabled when validation unsecure mode is specified.

Tested:
Tested along with special mode manager changes
1. Verified feature working state with validation-unsecure and not working
without validation-unsecure
2. Verified that set security mode enables the validation unsecure
3. Manufacturing commands are executed when in validation unsecure
mode

Change-Id: Ib160fbafc0e92cf33cc129039ae932364ad4dee4
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Changing std::pow argument 10 to 10.0 for double

Sanity check to ensure correct std::pow function overload called

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Iac67371a25adbcfc03c85c09

Changing std::pow argument 10 to 10.0 for double

Sanity check to ensure correct std::pow function overload called

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Iac67371a25adbcfc03c85c09c4609063d00f6c37

show more ...

Correcting defaults for min and max sensor bounds

Hardcoded (-127,128) seems wrong to me
Using (-128,127) which I think was the intention
This matches what a signed byte would be

Signed-off-by: Jos

Correcting defaults for min and max sensor bounds

Hardcoded (-127,128) seems wrong to me
Using (-128,127) which I think was the intention
This matches what a signed byte would be

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Ia0f1e7b25b673be50593e2cc056c69f3bb0b76cd

show more ...

Update mfg mode query to D-Bus interface

Updated manufacturing mode query to be based on D-Bus interface
instead of uint8_t as earlier. This is done to be in sync
with common D-Bus interface

Tested

Update mfg mode query to D-Bus interface

Updated manufacturing mode query to be based on D-Bus interface
instead of uint8_t as earlier. This is done to be in sync
with common D-Bus interface

Tested:
With updated special-mode-mgr daemon, which follows the
D-Bus interface
1. Verified that manufacturing mode commands are executed as
before, when in manufacturing mode.

Change-Id: I1828739751272b8d9151e2ab4a32c4861bbe90d7
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Fix:set smsignal cmd results 0xcc for speaker param

For set sm signal cmd request byte 1, signal type 09h (speaker)
gives 0xcc which is unexpected as speaker parameter is supported.
This code provid

Fix:set smsignal cmd results 0xcc for speaker param

For set sm signal cmd request byte 1, signal type 09h (speaker)
gives 0xcc which is unexpected as speaker parameter is supported.
This code provides fix for the same by adding case for signal type
09h (speaker) in the set smsignal cmd implemetation.

Tested:
Verified by executing set sm signal cmd which gives success cc

ipmitool raw 0x30 0x15 0x09 0x00 0x00 0x00

Change-Id: I5f4a3a49aab009c760cf069b5e3250e09704de27
Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>

show more ...

Refactoring: Firmware image write data command.

Updated firmware write data command as per new design.

Tested:

Tested firmware update utility via KCS interface

Signed-off-by: Rajashekar Gade Redd

Refactoring: Firmware image write data command.

Updated firmware write data command as per new design.

Tested:

Tested firmware update utility via KCS interface

Signed-off-by: Rajashekar Gade Reddy <raja.sekhar.reddy.gade@linux.intel.com>
Change-Id: I59bd15f639634cf34a9d188ce62cc6529fe038fb

show more ...

Updated privilege for set front panel command

Updated the execution privilege settings to
'Admin' for Set Front Panel Button enables
command as per IPMI spec.

Tested:
Tested Front Panel Enable comm

Updated privilege for set front panel command

Updated the execution privilege settings to
'Admin' for Set Front Panel Button enables
command as per IPMI spec.

Tested:
Tested Front Panel Enable command with different
privileged users and works only with Admin privilege.

Change-Id: I0a23a04321afb45107ac582bede40582c9ccc13c
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Remove the override set boot option command for set-in-progress state

The get/set boot option commands are sharing a variable
for the set-in-progress state.Both of them need to be in the same file.

Remove the override set boot option command for set-in-progress state

The get/set boot option commands are sharing a variable
for the set-in-progress state.Both of them need to be in the same file.

The override is used to disable safe boot mode support on Intel platforms.
Currently host-ipmi supports a new added compile option to disable it,
the override can be removed to re-use the implementation in host-ipmi.

Tested:
// set safe mode boot option fail
// after enabled the disable-boot-flag-safe-mode-support in ipmi-host
ipmitool raw 0x00 0x08 0x05 0x80 0x0c
Unable to send RAW command (channel=0x0 netfn=0x0 lun=0x0 cmd=0x8 rsp=0xcc):
Invalid data field in request

// bootdev command works
ipmitool chassis bootdev bios
Set Boot Device to bios

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Id5d2f1a039d679dda445005d56381d7239ee6593

show more ...

Fix the incorrect completion code for region read command

When the input data is invalid, the return code should be 0xcc,
0xc7 means the request data length is not matching with
the actual length of

Fix the incorrect completion code for region read command

When the input data is invalid, the return code should be 0xcc,
0xc7 means the request data length is not matching with
the actual length of the request data.

Tested:
using an incorrect offset 0xff00, the command will fail with 0xcc:
ipmitool raw 0x3e 0x23 0x01 0x1 0x00 0xff
Unable to send RAW command (channel=0x0 netfn=0x3e lun=0x0 cmd=0x23 rsp=0xcc):
Invalid data field in request

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Ie82fb978ca924dc64e378c8c567315f686f48059

show more ...

Updated Get Firmware Root Certficate data command

Updated IPMI Get Firmware Root Certficate data command(0x25) for PFR

This command works only for PFR enabled platforms.

Tested:
- Enabled INTEL_P

Updated Get Firmware Root Certficate data command

Updated IPMI Get Firmware Root Certficate data command(0x25) for PFR

This command works only for PFR enabled platforms.

Tested:
- Enabled INTEL_PFR_ENABLED flag and verified the below command
ipmitool -I dbus raw 0x08 0x25
Returns proper data.
- Disabled INTEL_PFR_ENABLED flag and verified
Returns error.

Signed-off-by: Rajashekar Gade Reddy <raja.sekhar.reddy.gade@linux.intel.com>
Change-Id: I8a6d0c939d26a8e8058dc35b26c6f78228ea8e5c

show more ...

Added support for Get Firmware Version Information

Added support for Get Firmware Version Information.
This command works only for PFR enabled platform.

Tested:
- On PFR enabled platforms:
Req:

Added support for Get Firmware Version Information

Added support for Get Firmware Version Information.
This command works only for PFR enabled platform.

Tested:
- On PFR enabled platforms:
Req: ipmitool raw 0x08 0x20
Res: 02 01 00 14 02 00 00 00 00 00 00 00 00 00 00 00
02 00 14 02 00 00 00 00 00 00 00 00 00 00 00
- Non-PFR platforms
Req: ipmitool raw 0x08 0x20
Res: Invalid command(0xC1)

Change-Id: I67a0674fbde053dc9088e76bbec871ddbab32e04
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Update NMI source OEM definition after its Property moved to
phospher-dbus-interfaces

It's needed to update the IPMI OEM NMI source definition since NMI
source property is moved from intel-dbus-inte

Update NMI source OEM definition after its Property moved to
phospher-dbus-interfaces

It's needed to update the IPMI OEM NMI source definition since NMI
source property is moved from intel-dbus-interface to
phospher-dbus-interfaces by changing from "com.intel" to
"xyz.openbmc_project" with some definition name changed.

Tested
it's tested in system for IPMI OEM command - get/set NMI source
Set: ipmitool raw 0x30 0xed 1
Windows BSOD is triggered after the command is issued.

Change-Id: I671ed8b005e0bb5a3ca8a2d37291a21a39ae1166
Signed-off-by: Chen Yugang <yugang.chen@linux.intel.com>

show more ...

bugfix: storagecommands: read fru: return bytes included

The requested number of bytes could exceed the bytes remaining,
therefore only return the length of the bytes returned.

Signed-off-by: Patri

bugfix: storagecommands: read fru: return bytes included

The requested number of bytes could exceed the bytes remaining,
therefore only return the length of the bytes returned.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Id1e107b07fc787bf49d0b0455be2e4e10750b798

show more ...

firmware-update: move fw update mode to new API

Rewrite exit firmware update mode" command to use new api

Tested:
verified using ipmitool raw command
1.command output before code modifications
ipmi

firmware-update: move fw update mode to new API

Rewrite exit firmware update mode" command to use new api

Tested:
verified using ipmitool raw command
1.command output before code modifications
ipmitool raw 0x08 0x28
Unable to send RAW command (channel=0x0 netfn=0x8 lun=0x0 cmd=0x28
rsp=0xcc):
Invalid data field in request
2.command output after code modifications
ipmitool raw 0x08 0x28
Unable to send RAW command (channel=0x0 netfn=0x8 lun=0x0 cmd=0x28
rsp=0xcc):
Invalid data field in request

Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Change-Id: I3f33b2d87e9088007f4283985970e7e8ca1afe4e

show more ...

Fix for set/get cold redundancy configuration commands

In set, the length of input parameters should be the same as the connected PSUs;
In get, the length of the return value should be the same as t

Fix for set/get cold redundancy configuration commands

In set, the length of input parameters should be the same as the connected PSUs;
In get, the length of the return value should be the same as the connected PSUs;

Tested:
On system with two PSUs:

ipmitool raw 0x30 0x2e 5
05 02

ipmitool raw 0x30 0x2d 0x03 0x01 0x01 0x02
00
ipmitool raw 0x30 0x2e 3
03 01 01 02

ipmitool raw 0x30 0x2d 0x03 0x01 0x01 0x02 0x3
Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0x2d rsp=0xc7): Request data length invalid

ipmitool raw 0x30 0x2d 0x03 0x01 0x01
Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0x2d rsp=0xc7): Request data length invalid

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I3352d7aa197af63925569ef1758132914d18eaa8

show more ...

sensor SDRs: lookup Board to set IPMI info

Looks up the board object, if there is an association, and if that board
object specifies an EntityId or EntityInstance, it will use those values
in the SD

sensor SDRs: lookup Board to set IPMI info

Looks up the board object, if there is an association, and if that board
object specifies an EntityId or EntityInstance, it will use those values
in the SDR. If the configuration of the sensor also implements one or
both of those properties, then those are used instead.

Tested: Validated if the json Board file has EntityId and
EntityInstance, those values are used in the SDR. Validated if the
configuration for the sensor has those values, then those are used
instead. Verified it works in cases where these values are not set,
etc.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I998eff9b0145ede7b386041b35f488fa6dd6714f

show more ...

storagecommands: return true on device match

Currently the code will find the right device, but if that device didn't
implement the Ipmi decorator interface it'll keep searching. Once we've
found t

storagecommands: return true on device match

Currently the code will find the right device, but if that device didn't
implement the Ipmi decorator interface it'll keep searching. Once we've
found the device matching bus+address, we can stop searching.

Tested: This was not tested.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7b37490dd447860a32eaffcbe95464dcb5d9ab97

show more ...

Refactor Set Firmware Update Mode command

Refactor Set firmware Update Mode command
along with fixing issues around completion code.

Tested:
Tested scenario's for proper completion code
- Invalid

Refactor Set Firmware Update Mode command

Refactor Set firmware Update Mode command
along with fixing issues around completion code.

Tested:
Tested scenario's for proper completion code
- Invalid random number length: rsp=0xc7
- Wrong random number : rsp=0xcc
- Random number expired : rsp=0xcc
- Already update in progress: rsp=0xc0(busy)
- All good : 0x00

Change-Id: I9c4dbfeed43ee6f218633cc8f4fd26d82eb07f49
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

storagecommands: use quotes for project headers

Use quotes to search locally for project headers.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic54ccd76956ddea55b3dbd10b47ffc7a939

storagecommands: use quotes for project headers

Use quotes to search locally for project headers.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic54ccd76956ddea55b3dbd10b47ffc7a939d948c

show more ...

sensorcommands: use quotes for project headers

Use quotes to search locally for project headers.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7bf95b2fab696bc6f2891e5a06000ec2a6c3

sensorcommands: use quotes for project headers

Use quotes to search locally for project headers.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7bf95b2fab696bc6f2891e5a06000ec2a6c3b7c7

show more ...

storagecommands: add queries to set IPMI info

storagecommands gets the list of FRUs by getting the list of devices
owned by the FruDevice service. The information we need is owned by the
EntityManag

storagecommands: add queries to set IPMI info

storagecommands gets the list of FRUs by getting the list of devices
owned by the FruDevice service. The information we need is owned by the
EntityManager service. If a Board owned by the EntityManager has two
interfaces:
- xyz.openbmc_project.Inventory.Decorator.FruDevice
- xyz.openbmc_project.Inventory.Decorator.Ipmi

Then it can be matched to a FruDevice and the entityId and
entityInstance can be properly set in the SDR.

This is only working for FRUs.

Tested: Verified that if a Board has the two interfaces, it properly
sets the EntityId and EntityInstance values from dbus.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I637182f552cf4b1f8299dc9ce2ac4c27885e201e

show more ...

Cleaned not implemented commands from registration

Removed not implemented firmware (netfn: 0x08) commands
from registration. Let the execution queue to return
appropriate response, if a handler is

Cleaned not implemented commands from registration

Removed not implemented firmware (netfn: 0x08) commands
from registration. Let the execution queue to return
appropriate response, if a handler is not registered.

We can register them, when they get implemented.

Tested:
Tested with unregistered command and verified CC.
Request: ipmitool raw 8 0xFF
Response: 0xC1 - Invalid command

Change-Id: I6f6846c8d3e84ccc681b9fd00cef1af8b5ce1722
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Enabled PFR image validation support for PFR ptfms.

Added support for validating the PFR image in ipmi firmware write
data command.

Tested:

Tested firmware update utility via KCS interface

Signed

Enabled PFR image validation support for PFR ptfms.

Added support for validating the PFR image in ipmi firmware write
data command.

Tested:

Tested firmware update utility via KCS interface

Signed-off-by: Rajashekar Gade Reddy <raja.sekhar.reddy.gade@linux.intel.com>
Change-Id: I16d66af593dd2ab03759281d4cef8ba238c1d85a

show more ...

Bug fixing for set boot options

Set boot options to persistent not working, fix it by using bool
pointer type.And also update oneTimeEnabled value since it's
property changed.

Tested:
It works by s

Bug fixing for set boot options

Set boot options to persistent not working, fix it by using bool
pointer type.And also update oneTimeEnabled value since it's
property changed.

Tested:
It works by set boot option IPMI command with persistent parameter.
ipmitool raw 0x00 0x08 0x05 0xc0 0x3c 0x00 0x00 0x00

Change-Id: I81c68b89fe80b6ecbad1da99f4f169442a9ee675
Signed-off-by: Chen Yugang <yugang.chen@linux.intel.com>

show more ...

Support Device information for GetOEMDeviceInformation

Currently, it's support only for BIOS info for GetOEMDeviceInformation
IPMI OEM command; now, add getting Device information for it, it's to
ge

Support Device information for GetOEMDeviceInformation

Currently, it's support only for BIOS info for GetOEMDeviceInformation
IPMI OEM command; now, add getting Device information for it, it's to
get BMC version and Me version numbers from their DBUS properties.

Tested:
It's tested by IPMI OEM command.
ipmitool raw 0x30 0x27 1 10 0
ipmitool raw 0x30 0x27 2 2 0

Change-Id: I6bb4919c961b11f0b8dc33020f8fd5f4b250354b
Signed-off-by: Chen Yugang <yugang.chen@linux.intel.com>

show more ...