oemcommands: Fix for set security mode to mfg mode

Issue: Set security mode fails to enter manufacturing mode even though
command got executed successfully.
Fix: As manufacturing mode is rese

oemcommands: Fix for set security mode to mfg mode

Issue: Set security mode fails to enter manufacturing mode even though
command got executed successfully.
Fix: As manufacturing mode is reserved, can't enable using set security
mode command. So returning 0xCC as completion code.

Tested:
Verified using ipmitool raw commands.
Before fix:
Command: ipmitool raw 0x30 0xb4 0x03 0x01 //set security mode to mfg
Response: //Success

After fix:
Command: ipmitool raw 0x30 0xb4 0x03 0x01 //set security mode to mfg
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xb4 rsp=0xcc): Invalid data field in request

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ib166bb7d4a5248a7f6f5b04615a9d80e8a78b3fe

show more ...

firmware-update:Add Support to get fwSecurityVer

Add support to read BKC and SVN version for BMC Active and Recovery
image.

Tested:
Command : ipmitool raw 0x08 0x21 //get firmware security version

firmware-update:Add Support to get fwSecurityVer

Add support to read BKC and SVN version for BMC Active and Recovery
image.

Tested:
Command : ipmitool raw 0x08 0x21 //get firmware security version
Response: 02 01 01 01 02 01 01

Signed-off-by: Punith Nadur Basavarajaiah <punitx.basavarajaiah@intel.com>
Change-Id: I25a801fe00fef3c4c65b57aacb59089be1705d58

show more ...

GetFwVersionInfo: Fix for Firmware aux version

Issue: Get Version Information return incorrect Firmware AUX version

FIX: Firmware aux version was parsing incorrectly. Do the parsing by
correct

GetFwVersionInfo: Fix for Firmware aux version

Issue: Get Version Information return incorrect Firmware AUX version

FIX: Firmware aux version was parsing incorrectly. Do the parsing by
correct regex pattern of BMC version.

Tested:
Verified using ipmitool raw commands
Before fix:
Command: ipmitool raw 0x08 0x20 // Get version Information
Response: 01 02 00 70 01 00 00 00 00 00 00 00 00 00 00 00

After fix:
Command: ipmitool raw 0x08 0x20 // Get version Information
Response: 02 01 00 74 0a 8a 37 78 00 00 00 00 00 00 00 00
02 00 70 01 00 00 00 00 00 00 00 00 00 00 00

Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: I7c2baf8a0da15e3ca4db5d6f9d6de7bf739aa755

show more ...

Fix cold redundancy is not runing as user configuration.

Cold redundancy service is not runing as user configuration.
1. Properties are not sync between settings server and daemon.
2. Wrong property

Fix cold redundancy is not runing as user configuration.

Cold redundancy service is not runing as user configuration.
1. Properties are not sync between settings server and daemon.
2. Wrong property is used to config cold redundancy enabling.

Tested:
Cold redundancy is working as user config.

Change-Id: Ia0b7aa6aff65be4d86daa82616eefaea575baf5e
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>

show more ...

storagecommands: Fix for GetFruAreaInfo command

Issue: GetFruAreaInfo command is giving incorrect response for Invalid
FRU Device ID's.

Fix: Add check for invalid FRU Device ID's to return completi

storagecommands: Fix for GetFruAreaInfo command

Issue: GetFruAreaInfo command is giving incorrect response for Invalid
FRU Device ID's.

Fix: Add check for invalid FRU Device ID's to return completion code as
0xCB.

Tested:
Verified using ipmitool raw commands.
Case 1: Valid FRU Device ID:
Command: ipmitool raw 0x0a 0x10 0xce //Get fru Area info
Response: a9 00 00
Case 2: Invalid FRU Device ID:
Command: ipmitool raw 0x0a 0x10 0x01 //Get fru Area info
Response: Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0
cmd=0x10 rsp=0xcb): Requested sensor, data, or record not
found

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I8e3416beff40c133804af9e913d83c2372784439

show more ...

Allow more than 256 IPMI sensors in a system

Systems with more than 255 IPMI sensors report strange values for
sensors assigned beyond the 255 limit for a single LUN. This is due to
the sensor numbe

Allow more than 256 IPMI sensors in a system

Systems with more than 255 IPMI sensors report strange values for
sensors assigned beyond the 255 limit for a single LUN. This is due to
the sensor number assignment rolling over to 0, and then applying the
most recent SDR values to the sensor calculation.

This change assigns up to 255 sensors to a single LUN (0xFF is
reserved). When the 256th sensor is assigned the sensor gets placed in
the LUN. LUNs 0, 1, and 3 are used, as LUN 2 is special.

Another guard has been created that throws an exception when more than
765 sensors have been assigned. This makes it obvious to the system
designer the limit for IPMI sensors has been reached.

Tested:
Forced the maxmimum number of sensors in the system to be 63 per LUN.

"ipmitool sdr elist" returned correct values for every sensor even
when the sensor number displayed in the printout matched the value of
a sensor printed earlier.

"ipmitool sensor get P3V3" returns a valid reading. In my test "P3V3"
was in LUN1.

"ipmitool raw 4 0x20 0" reported 63 sensors for LUN0, and that LUN0
and LUN1 had sensors.

"ipmitool raw -l 1 4 0x20 0" reported the remaining sensor count.

"ipmitool raw 0xa 0x2d 0" returns the correct value for LUN0 Sensor 0

"ipmitool raw -l 1 0xa 0x2d 0" returns the correct value for LUN1
Sensor 0

Change-Id: Ic1708b66339e57b1b765f5a9a684e829a0ec8fba
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

bridgingcommands:Fix for System interface commands

Issue: Set BMC Global Enables, Clear Message Flags, Get Message Flags,
Get Message, Read Event Message Buffer commands are allowed to execute
in al

bridgingcommands:Fix for System interface commands

Issue: Set BMC Global Enables, Clear Message Flags, Get Message Flags,
Get Message, Read Event Message Buffer commands are allowed to execute
in all the channels instead to allow only with System interface.

Fix: Added condition check in each API to allow only with system
interface.

Tested:
Verified using cmdtool utility and clear linux OS.
Before Fix:
Set BMC Global Enables, Clear Message Flags, Get Message Flags,
Get Message and Read Event Message Buffer commands are working in other
than system interface channels.
Command: ipmitool raw 0x06 0x2e 0x09 //Set BMC Global Enables
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x2e rsp=0xd5): Command not supported in present state
Command: ipmitool raw 0x06 0x30 0x00 //Clear Message Flags
Response: //Success
Command: ipmitool raw 0x06 0x31 //Get Message Flags
Response: 00
Command: ipmitool raw 0x6 0x34 0x06 0x2c 0xd3 0x01 0xfc 0xfc 0x04 0x00
0x2c 0xfc 0x08 0xc1 0x13 //Send message
Response:
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
.......
00 00 00 00 00 00 00 00
Command: ipmitool raw 0x06 0x33 //Get Message
Response: fc fc d4 30 2c fc 04 c1 13
Command: ipmitool raw 0x06 0x35 //ReadEventMessageBuffer
Response: 55 55 c0 41 a7 00 00 00 00 00 3a ff 00 ff ff ff

Verified from Clear Linux (System interface):
Command: ipmitool raw 0x06 0x2e 0x09 //Set BMC Global Enables
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x2e rsp=0xd5): Command not supported in present state

After Fix:
1. Verified executing from BMC.
2. Enable ProvisionedHostWhitelist mode (KCS trust policy) and verified.

Command: ipmitool raw 0x06 0x2e 0x09 //Set BMC Global Enables
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x2e rsp=0xd5): Command not supported in present state
Command: ipmitool raw 0x06 0x30 0x00 //Clear Message Flags
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x2e rsp=0xd5): Command not supported in present state
Command: ipmitool raw 0x06 0x31 //Get Message Flags
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x2e rsp=0xd5): Command not supported in present state
Command: ipmitool raw 0x06 0x33 //Get Message
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x2e rsp=0xd5): Command not supported in present state
Command: ipmitool raw 0x06 0x35 //ReadEventMessageBuffer
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x2e rsp=0xd5): Command not supported in present state

Verified from system interface using cmdtool utility and Clear linux.
Command: cmdtool.efi 20 18 2e 9 //Set BMC Global Enables
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x2e rsp=0xd4): Insufficient privilege level
Command: cmdtool.efi 20 18 30 00 //Clear Message Flags
Response: 00 //Success
Command: cmdtool.efi 20 18 31 //Get Message Flags
Response: 00 02
Command: cmdtool.efi 20 18 33 //Get Message
Response: 00 FC FC D4 30 2C FC 04 C1 13
Command: cmdtool.efi 20 18 35 //ReadEventMessageBuffer
Response: 00 55 55 C0 41 A7 00 00 00 00 00 3A FF 00 FF FF FF

Verified using Clear Linux (System Interface)
Command: ipmitool raw 6 0x2e //Set BMC Global Enables
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x2e rsp=0xd4): Insufficient privilege level
Command: ipmitool raw 6 0x30 0x00 //Clear Message Flags
Response: //Success
Command: ipmitool raw 6 0x31 //Get Message Flags
Response: 02

Note: OpenIPMI driver provided by the Linux kernel will reject the
Get Message, Send Message and Read Event Message Buffer commands
because it handles the message sequencing internally.
https://manpages.debian.org/testing/ipmitool/ipmitool.1.en.html

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Id2246a9f7427f9c4af12201fc9d19cccb41fc6ae

show more ...

smbiosmdrv2handler:Fix for MDRV2 get data info

Issue: Mdrv2 get data set info response giving as 0xce which is
incorrect.

Fix: Update MDRiiGetDataInfoResponse structure definition as per IPMI
OEM c

smbiosmdrv2handler:Fix for MDRV2 get data info

Issue: Mdrv2 get data set info response giving as 0xce which is
incorrect.

Fix: Update MDRiiGetDataInfoResponse structure definition as per IPMI
OEM commands documentation and provided fix to get correct response
as provided in test results.

Tested:
Verified using ipmitool raw commands.
Before:
Command: ipmitool raw 0x3e 0x39 0x01 0x01 //SMMDR Data Set Info Offer
Response: 28 29 2a 2b 2c 2d 2e 2f 30 31 32 33 34 35 36 42
//SMMDR Get Data Set Info command
Command: ipmitool raw 0x3e 0x32 0x01 0x01 0x28 0x29 0x2a 0x2b 0x2c 0x2d
0x2e 0x2f 0x30 0x31 0x32 0x33 0x34 0x35 0x36 0x42
Response: Unable to send RAW command (channel=0x0 netfn=0x3e lun=0x0
cmd=0x32 rsp=0xce): Command response could not be provided

After:
Command: ipmitool raw 0x3e 0x39 0x01 0x01 //SMMDR Data Set Info Offer
Response: 28 29 2a 2b 2c 2d 2e 2f 30 31 32 33 34 35 36 42
//SMMDR Get Data Set Info command
Command: ipmitool raw 0x3e 0x32 0x01 0x01 0x28 0x29 0x2a 0x2b 0x2c 0x2d
0x2e 0x2f 0x30 0x31 0x32 0x33 0x34 0x35 0x36 0x42
Response: 02 28 29 2a 2b 2c 2d 2e 2f 30 31 32 33 34 35 36
42 01 00 00 11 45 0f 00 00 7a 1b

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ia23f1cf19608281dc98e971f9c5e84c7dde4ba61

show more ...

minor fix: clear CMOS command CC correction

The clearCMOS command is supported only in manufacturing
mode. Outside of MTM mode, It should return Invalid
command(0xC1) but its returning 0xD4. Correct

minor fix: clear CMOS command CC correction

The clearCMOS command is supported only in manufacturing
mode. Outside of MTM mode, It should return Invalid
command(0xC1) but its returning 0xD4. Corrected the
CC to 0xC1.

Tested:
- Outside MTM mode cleaCMOS returns 0xC1.

Change-Id: Icd747f8e904dbafc4a35fef0fb55a65ee4721a9b
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

whitelist-filter: Fix for non-whitelist commands

Issue: Non-whitelist commands are resulting improper Completion Code
as CommandNotAvailable.

Fix: Change the completion code to Insufficient

whitelist-filter: Fix for non-whitelist commands

Issue: Non-whitelist commands are resulting improper Completion Code
as CommandNotAvailable.

Fix: Change the completion code to Insufficient privilege level as
expected.

Tested:
Verified using ipmitool raw command from Linux OS
1. Set restriction mode as ProvisionedHostWhitelist
Command: busctl set-property xyz.openbmc_project.RestrictionMode.Manager
/xyz/openbmc_project/control/security/restriction_mode
xyz.openbmc_project.Control.Security.RestrictionMode
RestrictionMode s "xyz.openbmc_project.Control.Security.
RestrictionMode.Modes.ProvisionedHostWhitelist"
Response: //Success
2. Check the restriction mode
Command: ipmitool raw 0x30 0xb3
Response: 04 00
3. Execute cold reset command from Linux OS terminal
Command : ipmitool raw 0x06 0x02
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x2 rsp=0xd4): Insufficient privilege level

Signed-off-by: Snehalatha V <snehalathaX.v@intel.com>
Change-Id: I75180ed4a72e180ef968868a8011f70513558abd

show more ...

oemcommands: Implement OEM Get Reading command

Newly implement OEM Get Reading command API. It implements for
"Inlet Air Temperature" Reading type.

Tested:
Verified on single node system using Oem

oemcommands: Implement OEM Get Reading command

Newly implement OEM Get Reading command API. It implements for
"Inlet Air Temperature" Reading type.

Tested:
Verified on single node system using Oem get reading commands.
Command: ipmitool raw 0x30 0xe2 0x00 0x00 0x00 //OEM Get reading
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xe2 rsp=0xc9): Parameter out of range
Command: ipmitool raw 0x30 0xe2 0x10 0x0 0x0 //OEM Get reading
Response: 10 1a 00
Command: ipmitool raw 0x30 0xe2 0x20 0x0 0x0 //OEM Get reading
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xe2 rsp=0xc9): Parameter out of range
Command: ipmitool raw 0x30 0xe2 0x30 0x0 0x0
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xe2 rsp=0xcc): Invalid data field in request

Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: I6450fe95b4ef52eed4784561180d1da667d30360

show more ...

FRU: Invalidate cache when frus change

This creates a match for FruDevice changes and
update the cache when one changes.

Tested:
ipmitool fru list immediately after rescan
had correct values. fru l

FRU: Invalidate cache when frus change

This creates a match for FruDevice changes and
update the cache when one changes.

Tested:
ipmitool fru list immediately after rescan
had correct values. fru list was faster

Change-Id: I2f332814bd1a0ef38a87dc31b8cd3c16fa6b8d76
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

types: move common types into types header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I8e6f6fbae784a8ceebcc83ac53c1beb5c7b46779

Add support to mark sensors unavailable

This marks sensors unavailable when they respond
with nan, or when the available interface says
they are not available.

Tested:

ipmitool sensor list showed

Add support to mark sensors unavailable

This marks sensors unavailable when they respond
with nan, or when the available interface says
they are not available.

Tested:

ipmitool sensor list showed sensors as unavailable
SSB Temp | na | degrees C | na | na | 0.000
| 5.000 | 98.000 | 103.000 | na

Change-Id: I6a4f8ee14864e9d9330a58d83f71dde90cc23dbe
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Rename ME event MessageIds to ensure consistency

In review https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/31981
it was found that naming convention of MessageId doesn't comply with
previously

Rename ME event MessageIds to ensure consistency

In review https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/31981
it was found that naming convention of MessageId doesn't comply with
previously defined messages.
This change aligns the implementation with updated MessageRegistry
contents.

Signed-off-by: Agnieszka Szlendak <Agnieszka.Szlendak@intel.com>
Change-Id: I9302b0f456a6793b65d39305b173b7d27aacd9c6

show more ...

Update to latest clang-format

Update to clang-format-10

Change-Id: I1c33ef7115c7a1459164d71f63921019d2dc9a98
Signed-off-by: James Feist <james.feist@linux.intel.com>

Fix for gcc 10 type conversion

Converted to byte first to remove error:

error: conversion from 'int' to non-scalar type
'std::variant<unsigned char>' requested | 299 |
std::variant<uint8_t> value

Fix for gcc 10 type conversion

Converted to byte first to remove error:

error: conversion from 'int' to non-scalar type
'std::variant<unsigned char>' requested | 299 |
std::variant<uint8_t> value = 0;

Tested: built with dunfell

Change-Id: Idfbf459bbf32dfb62857a84fd7ed0a21918b2d1c
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Write support for baseboard EEPROM FRU.

Write FRU implementation for baseboards having their FRU in an EEPROM.

Tested:
BC, CC, WC BaseBoards:

1.) Update the image via redfish and it bo

Write support for baseboard EEPROM FRU.

Write FRU implementation for baseboards having their FRU in an EEPROM.

Tested:
BC, CC, WC BaseBoards:

1.) Update the image via redfish and it boots fine.
2.) Ipmitool fru
Response :Listed all the fru details.
3.) Ipmitool read fru <FRU ID>
Response :Read the fru details successfully.
4.) Ipmitool sdr
Response :List the sensors details successfully.
5.) Ipmitool sensors
Response :List the sensors details successfully.

BC BaseBoard:
1.)Ipmitool write fru <FRU ID> <FRU FILE>
Response :Write the fru file successfully.
2.)First enter to manufacturing mode.
ipmitool raw 0x0A 0x12 0x00 0x10 0x00 0x43 0x41
Response:Success.(return code 00)

Signed-off-by: Saravanan Palanisamy
saravanan.palanisamy@linux.intel.com
Signed-off-by: Anoop S <anoopx.s@intel.com>
Change-Id: I2811551213d1a5335f17354af153d32dde4b81ea

show more ...

Allow only Administrator to bridge on ME commands

Allow only Administrator to bridge on ME commands

Tested:
Verified by using below commands
1. Enter in Manufacturing mode by executing below comman

Allow only Administrator to bridge on ME commands

Allow only Administrator to bridge on ME commands

Tested:
Verified by using below commands
1. Enter in Manufacturing mode by executing below command
Command: ipmitool raw 0x30 0xB4 3 2
Response: //Success

2. Verify using ME commands
Command: ipmitool -I lanplus -H <BMC_IP> -U root -P 0penBmc -L
ADMINISTRATOR -t 0x2c -b 6 raw 0x2e 0xca 0x57 0x01 0x00
Response: 57 01 00 06 04 00 04 03
Command: ipmitool -I lanplus -H <BMC_IP> -U root -P 0penBmc -L USER -t
0x2c -b 6 raw 0x2e 0xca 0x57 0x01 0x00
Response: Unable to send RAW command (channel=0x6 netfn=0x2e lun=0x0
cmd=0xca rsp=0xd4): Insufficient privilege level
Command: ipmitool -I lanplus -H <BMC_IP> -U root -P 0penBmc -L OPERATOR
-t 0x2c -b 6 raw 0x2e 0xca 0x57 0x01 0x00
Response: Unable to send RAW command (channel=0x6 netfn=0x2e lun=0x0
cmd=0xca rsp=0xd4): Insufficient privilege level

Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: I34eb3ae50965c3562306578a34f1a6bf5cba9387

show more ...

Rewrite handleIpmbChannel api

Rewriting new_method_call to yield_method_calll for handleIpmbChannel

Tested:
Verified using below send message commands
1. Send message command
Command:
FS0:\cmdtool

Rewrite handleIpmbChannel api

Rewriting new_method_call to yield_method_calll for handleIpmbChannel

Tested:
Verified using below send message commands
1. Send message command
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C 00 00 FC FC 04 00 2C FC 04
C1 13
Response: 00 //Success

2. Get message command
Commad: FS0:\cmdtool\> cmdtool.efi 20 18 33
Response: 00 FC FC 04 00 2C FC 04 C1 13

Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: I9b461ddbc3a93b67e26ec92ff7c41fdc97e49931

show more ...

bridgingcommands:move get&send commands to new api

Rewrite get and send message commands to use new IPMI provider API.

Tested:
verified ipmitool get and send message command, is same both before an

bridgingcommands:move get&send commands to new api

Rewrite get and send message commands to use new IPMI provider API.

Tested:
verified ipmitool get and send message command, is same both before and
after the changes
1. Enter in Manufacturing mode by executing below command
Command: ipmitool raw 0x30 0xB4 3 2
Response: //Success

2. Send message command
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C D3 01 FC FC 04 00 2C FC 08
C1 13
Response: 00 00 00 00 00 00 //Success

3. Get message command
Commad:
FS0:\cmdtool\> cmdtool.efi 20 18 33
Response: 00 FC FC D4 30 2C FC 04 C1 13

Negative Test cases:
Send Message Command:
1. // Encryption Enabled
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 26 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

2. // Authentication Enabled
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 16 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

3. // Channel other than IPMB and Lan
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 07 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

4. // IPMB data length Invalid:
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C
Response: C7

5. // IPMB address invalid:
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2B D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

6. // Tracking = 2 and 3 (Tracking mode not supported)
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 86 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 C6 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

7. // IPMB frame invalid:
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C D3 01 FC FC 04 00 2C FC 08 C1 12
Response: C9

8. // Response queue max size: (After doing multiple send)
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C0

9. IPMB layer non zero status:
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C D4 00 FB FC 04 00 2C FC 09 C1 13
Response: CE

Get Message Command:
10. // After booting, do Get Message command (Before send command)
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 33
Response: 80

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Signed-off-by: Deepak Kumar Sahu <deepakx.sahu@intel.com>
Change-Id: I2a4028dbe889a0737821f95889c39e44254a12ca

show more ...

ipmiUserSetUserName argument change

ipmiUserSetUserName accepts a const char* that it converts to a
std::string using a maximum of ipmiMaxUserName to be able to safely
handle non-null terminated nam

ipmiUserSetUserName argument change

ipmiUserSetUserName accepts a const char* that it converts to a
std::string using a maximum of ipmiMaxUserName to be able to safely
handle non-null terminated names.

Tested:
builds and runs as expected

Change-Id: Id8b02216fe9a3572e87f133ae6bfc1f3565c660d
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

oemcommands: Rewriting ipmiUserSetUserName

ipmiUserSetUserName API signature is changed to use string variable.

Tested:
Command: cmdtool.efi 20 c0 5a 64 65 62 75 67 75 73 65 72 0 0 0 0 0 0 0
30 70

oemcommands: Rewriting ipmiUserSetUserName

ipmiUserSetUserName API signature is changed to use string variable.

Tested:
Command: cmdtool.efi 20 c0 5a 64 65 62 75 67 75 73 65 72 0 0 0 0 0 0 0
30 70 65 6e 42 6d 63 31 0 0 0 0 0 0 0 0 0 0 0 0
Response: User is created successfully
Command: ipmitool user list 1 //User list for channel 1
Response:
ID Name Callin Link Auth IPMI Msg Channel Priv Limit
1 root false true true ADMINISTRATOR
2 debuguser true false false NO ACCESS
3 user3 true false false NO ACCESS
4 user4 true false false NO ACCESS

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I673b1c35df14672b7efd31f83f006ff59e562d21

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3ca37b91268fdbd8579d92d293997a3d49258a87

Prevent flush from appending a random numeric value to the MAC addr

After using the OEM command to assign a new MAC address to the system
I found the mac-check script was always reassigning the MAC

Prevent flush from appending a random numeric value to the MAC addr

After using the OEM command to assign a new MAC address to the system
I found the mac-check script was always reassigning the MAC value on
every boot. This caused the NIC to go down unnecessarily. Replacing
the fflush, whatever that was, with the ostream.flush() function
prevents appending an unexpected garbage character.

Tested:
Removed ethaddr, eth1addr from u-boot
Removed /var/sofs/factory-settings/network/mac
Booted system, and confirmed the macdir exists, and is empty
Used "ipmitool raw 0x30 0xa1 0 <eth addr bytes>
Used "echo /var/sofs/factory-settings/network/mac/eth0"
Confirmed file did not have a bogus character added by fflush.
Created a file for eth1.

Change-Id: I8d174de42af9fb2733a50ce5627dbcc547e2da15
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...