changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Maue

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add a configuration option to allow reset on MCERR

MCERR is another type of error that can be recovered by a reset. This
adds a configuration option to control if the BMC will allow that
recovery.

Add a configuration option to allow reset on MCERR

MCERR is another type of error that can be recovered by a reset. This
adds a configuration option to control if the BMC will allow that
recovery.

Tested:
Injected an MCERR and confirmed that when this option is true, recovery
is enabled. When this option is false, recovery is blocked.

Change-Id: I435af50acc41061e3a5036c84d12a99ffeee8969
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Rename CATERR to IERR

CATERR is ambiguous because it represents two types of errors: IERR and
MCERR. This changes the name to IERR to be more specific.

Change-Id: I9f2c3967885b0d8eea0ceef310febd412

Rename CATERR to IERR

CATERR is ambiguous because it represents two types of errors: IERR and
MCERR. This changes the name to IERR to be more specific.

Change-Id: I9f2c3967885b0d8eea0ceef310febd4124ddb558
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Add OEM get BMC Version String command

Change-Id: If8704427844eee4f54173425a2b74787f939a9cf
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I59c0a8c4b89131ecd3e9a841ed37ef3b8dcf8e9d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Change terminology to inclusive terms

Tested: No functionality changes, code still compiles.

Change-Id: I61dd3c6f3ecfb96088a68b1254a22c5fa5376b3d
Signed-off-by: Matt Simmering <matthew.simmering@in

Change terminology to inclusive terms

Tested: No functionality changes, code still compiles.

Change-Id: I61dd3c6f3ecfb96088a68b1254a22c5fa5376b3d
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

Fix for GetFanControlConfiguration IPMI command

GetFanControlConfiguration IPMI command not working as expepcted.
So updated busctl interface to fetch correct service from object Mapper.

Tested:
Be

Fix for GetFanControlConfiguration IPMI command

GetFanControlConfiguration IPMI command not working as expepcted.
So updated busctl interface to fetch correct service from object Mapper.

Tested:
Before Fix:
Command: ipmitool raw 0x30 0x8a 0x00
Response:
Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0x8a
rsp=0xcc): Invalid data field in request
Command: busctl call "xyz.openbmc_project.ObjectMapper"
"/xyz/openbmc_project/object_mapper" "xyz.openbmc_project.ObjectMapper"
GetObject sas /xyz/openbmc_project/inventory/system/chassis/motherboard/CPU_1
1 "xyz.openbmc_project.Inventory.Item"
Response: Call failed: The resource is not found.

After Fix:
Command: ipmitool raw 0x30 0x8a 0x00
Response: 80 00 04 00 00 00 00
Command: busctl call "xyz.openbmc_project.ObjectMapper"
"/xyz/openbmc_project/object_mapper" "xyz.openbmc_project.ObjectMapper"
GetObject sas /xyz/openbmc_project/inventory/system/chassis/motherboard/cpu0
1 "xyz.openbmc_project.Inventory.Item"
Response: a{sas} 1 "xyz.openbmc_project.Smbios.MDR_V2" 10
"org.freedesktop.DBus.Introspectable" "org.freedesktop.DBus.Peer"
"org.freedesktop.DBus.Properties" "xyz.openbmc_project.Association.Definitions"
"xyz.openbmc_project.Inventory.Connector.Slot"
"xyz.openbmc_project.Inventory.Decorator.Asset"
"xyz.openbmc_project.Inventory.Decorator.LocationCode"
"xyz.openbmc_project.Inventory.Decorator.Revision"
"xyz.openbmc_project.Inventory.Item" "xyz.openbmc_project.Inventory.Item.Cpu"

Change-Id: Ic212637113c3cb52867ba7addcb599547c1ce7a2
Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com>

show more ...

Condense std::variants

Where possible, reduce to a single std::variant type to reduce binary
size.

Change-Id: I73b59765109ce1ccd7339f0e214d1ec3929e1ffc
Signed-off-by: Jason M. Bills <jason.m.bills@

Condense std::variants

Where possible, reduce to a single std::variant type to reduce binary
size.

Change-Id: I73b59765109ce1ccd7339f0e214d1ec3929e1ffc
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie7375047bd567aa052d3bd35a6dd7008779a05b4

show more ...

Check SetEFIBootOptions when Byte 1&2 are 0

Update of: ipmiOemSetEfiBootOptions()
A check is done when both arguments are 0.
This is a invalid or unuseful condition.

Tested
==========
Issue command

Check SetEFIBootOptions when Byte 1&2 are 0

Update of: ipmiOemSetEfiBootOptions()
A check is done when both arguments are 0.
This is a invalid or unuseful condition.

Tested
==========
Issue command "ipmitool raw 0x30 0xEA 0x00 0x00 " expect rtn mess:
Unable to send RAW command
(channel=0x0 netfn=0x30 lun=0x0 cmd=0xea rsp=0xcc):
Invalid data field in request

Signed-off-by: Mike Jones <michaelx.jones@intel.com>
Change-Id: Ia28cb34983baf0c28084227fd1df71e5045406cd

show more ...

Include fstream

Missing the fstream include is causing build errors, so adding it to fix
the build.

Tested:
Confirmed that it builds.

Change-Id: I3417340256f9965778f7cde0a1d26a33edd2d320
Signed-of

Include fstream

Missing the fstream include is causing build errors, so adding it to fix
the build.

Tested:
Confirmed that it builds.

Change-Id: I3417340256f9965778f7cde0a1d26a33edd2d320
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

move PowerRestoreDelay to RestorePolicy interface

The `xyz.openbmc_project.Control.Power.RestoreDelay` is undocumented
which prevents to use phosphor-settings to handle this parameter.

This propert

move PowerRestoreDelay to RestorePolicy interface

The `xyz.openbmc_project.Control.Power.RestoreDelay` is undocumented
which prevents to use phosphor-settings to handle this parameter.

This property looks good fit to
`xyz.openbmc_project.Control.Power.RestorePolicy` interface, so it was
included there.

Type of the value was changed from uint16 to uint64 and units changes
from seconds to microseconds.
See https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/50231
for details.

Tested: Jason M. Bills confirmed that the commands to get and set the
power restore delay correctly convert to and from unit64_t.

Signed-off-by: Andrei Kartashev <a.kartashev@yadro.com>
Change-Id: I58dd601e561b53660ddb50e2b2c2b77ee2083030

show more ...

Add OEM Command to Read Mailbox PFR Registers

This OEM command allows user to read PFR mailbox
registers by specifying register address, no of
bytes to read and register identifier
(single byte or F

Add OEM Command to Read Mailbox PFR Registers

This OEM command allows user to read PFR mailbox
registers by specifying register address, no of
bytes to read and register identifier
(single byte or FIFO register)
Below command supports reading of single byte and
FIFO registers

ipmitool raw 0x3e 0x84 [Register Address] [No of Bytes to Read] [Register Identifier]
Note: Register Identifier:0 for single byte read register
Register Identifier:1 for FIFO read register

Tested:
1.Single Byte Register Testing:
a.ipmitool raw 0x3e 0x84 0x08 13 0:
Successfully returned 13 bytes starting from the single byte read register address 0x08.
2.FIFO Read Register Testing:
a.ipmitool raw 0x3e 0x84 0x08 13 1:
Successfully returned 13 bytes from the FIFO address 0x08.
3.When Register Identifier is not 0 or 1 command will fail.
4.When either of register address or no of bytes is zero the command will fail.

Signed-off-by: Ankita Vilas Gawade <ankita.gawade@intel.com>
Change-Id: Ie64af93b1c9d79d407b331ef9d0d64a408614780

show more ...

Add HSC version support for get OEMdevice info cmd

Added HSC version support for get OEM device info IPMI command.
With this patch able to populate HSC 1, 2, 3 inventory item versions to

Add HSC version support for get OEMdevice info cmd

Added HSC version support for get OEM device info IPMI command.
With this patch able to populate HSC 1, 2, 3 inventory item versions to
get OEM device info command.

Tested:
Verified using IPMI command
Command : ipmitool raw 0x30 0x27 1 //Get OEM device info command
Response: 0a 00 87 02 01 02 01 06 02 00 00

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I8efffa774c73da00ec4b5df9f3480bca3c35dfd3

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia9932efb6a9335e80b3f2376d2d62e1b65866f44

Add limit check to fan speed offset

ipmiOEMSetFanSpeedOffset was accepting offset value greater
than its limit. Fix added for limit check for fan speed offset.

Tested :
Veri

Add limit check to fan speed offset

ipmiOEMSetFanSpeedOffset was accepting offset value greater
than its limit. Fix added for limit check for fan speed offset.

Tested :
Verified using IPMI command.

Command: ipmitool raw 0x30 0x8C 0x65 //set fan speed offset to 101.
Response: Unable to send RAW command (channel=0x0 netfn=0x30
lun=0x0 cmd=0x8c rsp=0xcc): Invalid data field in request

Signed-off-by: Manish Baing <manish.baing@intel.com>
Change-Id: I99b6a18dc69b7956c4488f39306fb69afd1f522b

show more ...

Update to use SecureString and SecureBuffer

ipmiOEMSetUser2Activation gets a SecureBuffer and the extra
OPENSSL_cleanse functions can be removed for SecureString

Change-Id: Ib62

Update to use SecureString and SecureBuffer

ipmiOEMSetUser2Activation gets a SecureBuffer and the extra
OPENSSL_cleanse functions can be removed for SecureString

Change-Id: Ib629ea4c3bd12c446dfad671bb47ed0b61001fd6
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9915c0207bbca91296548e7a1e707e499c3d7838

show more ...

oemcommands: use SecureString for password

The ipmiSetSpecialUserPassword API changed to now require a SecureString
instead of a std::string.

See phosphor-host-ipmid commit 1e22

oemcommands: use SecureString for password

The ipmiSetSpecialUserPassword API changed to now require a SecureString
instead of a std::string.

See phosphor-host-ipmid commit 1e22a0f1a0348846eb56f534f101776dc445b764.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idc7a7f80b299b0753c958ae6d012812f2081810e

show more ...

Fix for ME version in get OEM Device info command

Issue: With current implementation, get OEM device info command is
giving incorrect ME minor version in response.

Fix: Populate

Fix for ME version in get OEM Device info command

Issue: With current implementation, get OEM device info command is
giving incorrect ME minor version in response.

Fix: Populate ME minor version same as ME get device ID command minor
version.

Tested:
Verified using IPMI commands
Command: ipmitool raw 0x30 0x27 1 //get OEM device info
Response: 0a 00 72 ff ff ff ff 06 01 ff ff
//ME get device ID
Command: ipmitool -I lanplus -H <bmc-ip> -U <username> -P <password>
-C 17 -t 0x2c -b 6 raw 6 1
Response: 50 01 06 01 02 21 57 01 00 18 0b 06 02 70 01

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ie0c6533eda5cb59f41a92be0381a21768a2d1082

show more ...

Code clean up to handle memory exception

Modified the code to Pass string data pointer instead
of the string object reference

Signed-off-by: gokulsanker <gokul.sanker.v.g@intel.

Code clean up to handle memory exception

Modified the code to Pass string data pointer instead
of the string object reference

Signed-off-by: gokulsanker <gokul.sanker.v.g@intel.com>
Change-Id: I28759c5d9d7a2632222c5395b08366a81a0ec4fd

show more ...

Fix for set/get EFI boot options unsupported param

In Set/get EFI boot Options IPMI command, for unsupported parameter
giving incorrect response. So return as ccParameterNotSupported fo

Fix for set/get EFI boot options unsupported param

In Set/get EFI boot Options IPMI command, for unsupported parameter
giving incorrect response. So return as ccParameterNotSupported for
unsupported parameters.

Tested:
Verified using IPMI command
Command : ipmitool raw 0x30 0xea 0x27 0x27 //Set EFI boot options
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xea rsp=0x80): Unknown (0x80)
Command : ipmitool raw 0x30 0xea 0x7 0x27 0x34
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xea rsp=0x80): Unknown (0x80)
Command : ipmitool raw 0x30 0xeb 0x27 0x27 0x34 //Get EFI boot options
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xea rsp=0x80): Unknown (0x80)
Command : ipmitool raw 0x30 0xeb 0x7 0x27 0x34
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xea rsp=0x80): Unknown (0x80)

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I6b3dd9d8d8bef501698b7b82c5934ef9f1f381ec

show more ...

Reset ChannelInfo before calling getChannelInfo()

chInfo is initialized with '0' in statement 'ChannelInfo chInfo{};'
This is to make sure even if getChannelInfo function fails to upda

Reset ChannelInfo before calling getChannelInfo()

chInfo is initialized with '0' in statement 'ChannelInfo chInfo{};'
This is to make sure even if getChannelInfo function fails to update
chInfo,un-initialized/previous chInfo data will not be used for
further execution in function ipmiOEMSetUser2Activation.

Tested:
By printing structure chInfo for each IPMI channel
before calling getChannelInfo function, we observed that
'chInfo' structure intialized with zeroes for each IPMI channel.

Signed-off-by: Manish Baing <manish.baing@intel.com>
Change-Id: I0fcfabd30d05f4d360758cff31bb98fff01c5f7e

show more ...

oemcommands: Validate reserved field content

In "Set Processor Error Configuration" command, byte-1’s [7-2],
byte-2, byte-3's [7-1], bits are reserved and in "Disable BMC System
Re

oemcommands: Validate reserved field content

In "Set Processor Error Configuration" command, byte-1’s [7-2],
byte-2, byte-3's [7-1], bits are reserved and in "Disable BMC System
Reset Action" command, byte-1’s [7-1] bits are reserved. So return
"InvalidFieldRequest" when reserved content is non-zero.

Tested:
IPMI Command: Set Processor Error Configuration
Case 1: Byte 1 - reserved1 bits zero
Command: ipmitool raw 0x30 0x9b 0x03 0x0 0x01
Response: //Success
Case 2: Byte 1 - reserved1 bits non-zero
Command: ipmitool raw 0x30 0x9b 0xf3 0x0 0x01
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x9b rsp=0xcc): Invalid data field in request
Case 3: Byte 2 - reserved2 bits zero
Command: ipmitool raw 0x30 0x9b 0x03 0x0 0x01
Response: //Success
Case 4: Byte 2 - reserved2 bits non-zero
Command: ipmitool raw 0x30 0x9b 0x03 0x1 0x01
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x9b rsp=0xcc): Invalid data field in request
Case 5: If byte - 3 is not present
Command: ipmitool raw 0x30 0x9b 0x03 0x0
Response: //Success
Case 6: byte-3 with reserved portion(reserved3) zero
Command: ipmitool raw 0x30 0x9b 0x03 0x0 0x01
Response: //Success
Case 7: byte-3 with reserved portion (reserved3) non-zero.
Command: ipmitool raw 0x30 0x9b 0x03 0x0 0xf1
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x9b rsp=0xcc): Invalid data field in request

IPMI Command: Disable BMC System Reset Action
Case 1: Byte-1 reserved portion (reserved1) non-zero.
Command : ipmitool raw 0x30 0x42 0x03
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x42 rsp=0xcc): Invalid data field in request
Case 2: Byte-1 reserved portion (reserved1) is zero.
Command : ipmitool raw 0x30 0x42 0x01
Response: //Success

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I84a6e3be21d6101824867ff9f92b83be2e6aa406

show more ...

Fix build issues

* Fix casting issues that are causing the build to fail.
* Fix gtest warnings by updating the source revision

Change-Id: Id6eb6b1fef335f88e7e12074f712b82ecd1a23

Fix build issues

* Fix casting issues that are causing the build to fail.
* Fix gtest warnings by updating the source revision

Change-Id: Id6eb6b1fef335f88e7e12074f712b82ecd1a233a
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...