Condense std::variants

Where possible, reduce to a single std::variant type to reduce binary
size.

Change-Id: I73b59765109ce1ccd7339f0e214d1ec3929e1ffc
Signed-off-by: Jason M. Bills <jason.m.bills@

Condense std::variants

Where possible, reduce to a single std::variant type to reduce binary
size.

Change-Id: I73b59765109ce1ccd7339f0e214d1ec3929e1ffc
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie7375047bd567aa052d3bd35a6dd7008779a05b4

show more ...

bmccontrolservices: Use service name for matching

The object paths of services are changed after service-config-manager
switched using sdbusplus to encode them, but now the service names can
be deco

bmccontrolservices: Use service name for matching

The object paths of services are changed after service-config-manager
switched using sdbusplus to encode them, but now the service names can
be decoded from the object paths. This patch changes to use service
name for matching accordingly.

Also changes unorderded_map bmcServices to array as random access is
not needed here.

Requires service-config-manager change #52557 ("Encode object path with
sdbusplus") being merged first.

Tested:
Verified both Get/Set BMC Services IPMI commands work as before.

Change-Id: I6da7f275c252059b121c323280214012f330340f
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Fix SOL over SSH service control

According to Intel BMC EPS, byte 2 bit 6 of control BMC Service command
(0x30 0xB1) controls SOL over SSH service. But now it controls the SOL
service, meaning that

Fix SOL over SSH service control

According to Intel BMC EPS, byte 2 bit 6 of control BMC Service command
(0x30 0xB1) controls SOL over SSH service. But now it controls the SOL
service, meaning that disabling it will also disable other SOL services
like SOL over RMCP+ and SOL on web, while SOL SSH port is still open
and accepts incoming connections. This patch fixes this issue by only
disabling the SOL SSH service.

Tested:
* Disabling SOL over SSH will stop the SOL SSH service and all existing
SOL SSH connections are closed. The port is also closed.
* After disabling SOL SSH service, SOL can still be connected from web.

Change-Id: I4f4001805a636ea33168327be806afba1328fcc4
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia9932efb6a9335e80b3f2376d2d62e1b65866f44

fix: Correct bit mask for GetBMCServiceStatus cmd

Bit 14 and 15 of GetBMCServiceStatus command response represents
status of Video and USB redirection. These 2 bits should match since

fix: Correct bit mask for GetBMCServiceStatus cmd

Bit 14 and 15 of GetBMCServiceStatus command response represents
status of Video and USB redirection. These 2 bits should match since
a single service maintains both. The logic for the same is already
implemented. But incorrect mask resulted in error values when previously
un-used bits(bit 13) got defined for new services.

This change corrects the bit mask to extract only bit 15

Tested:
Verified commands is giving expected response
Command: ipmitool raw 0x30 0xb2
Response: 68 e0
Command: ipmitool raw 0x30 0xB1 0x00 0x68 0xe0
Response: Success
Command: ipmitool raw 0x30 0xb2
Response: 00 00

Signed-off-by: Arun P. Mohanan <arun.p.m@linux.intel.com>
Change-Id: Iba8e44fe6ee21e599c6f1575c7ba90a48cdee746

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9915c0207bbca91296548e7a1e707e499c3d7838

show more ...

Update to latest clang-format

Update to clang-format-10

Change-Id: I1c33ef7115c7a1459164d71f63921019d2dc9a98
Signed-off-by: James Feist <james.feist@linux.intel.com>

update oemcommands.hpp to use new API

All the command handler numbers and netfn numbers were done
using the old API. This updates all the enums to be ipmi::Cmd
or ipmi::NetFn types.

update oemcommands.hpp to use new API

All the command handler numbers and netfn numbers were done
using the old API. This updates all the enums to be ipmi::Cmd
or ipmi::NetFn types. This improves readability by eliminating
unneeded static_casts and brings the legacy code to the present.

One minor fix, otherwise the code is the same. The call to
registerFilter was passing a netfn instead of a priority. It compiled
but it was incorrect. This updates it to use the correct parameter.

Tested: builds and produces the same binary output (other than the
aforementioned registerFilter fix)

Change-Id: I7e83123245b3f340088f8ec75a31b7611d0ecda0
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

intel-ipmi-oem: cleanup - Removed duplicate OemCmd

Removed duplicate OemCmds in intel-ipmi-oem, and moved to the
correct one IPMINetfnIntelOEMGeneralCmd enum class.

Change-Id: I

intel-ipmi-oem: cleanup - Removed duplicate OemCmd

Removed duplicate OemCmds in intel-ipmi-oem, and moved to the
correct one IPMINetfnIntelOEMGeneralCmd enum class.

Change-Id: Iac694c8e2c72f9ad99ed4fae933e0d26f53d4f08
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Start turning on some warnings

This repo needs a lot of help with warnings, start
turning some on slowly.

Change-Id: Icb3cee86829228cd4cbabecc98e43c77cef17223
Signed-off-by:

Start turning on some warnings

This repo needs a lot of help with warnings, start
turning some on slowly.

Change-Id: Icb3cee86829228cd4cbabecc98e43c77cef17223
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

intel-ipmi-oem: Add support - control bmc services

Support added for get & set control bmc services, which will
use srvcfg-manager daemon's Masked property to mask or
unmask a proper

intel-ipmi-oem: Add support - control bmc services

Support added for get & set control bmc services, which will
use srvcfg-manager daemon's Masked property to mask or
unmask a property.

Tested:
1. Verified ipmitool 0x30 0xB2 for the control bmc service values
2. Verified masking RMCP+ service using ipmitool 0x30 0xB1 0x0 0x8 0x0

Change-Id: I25762e09ff50935919684bb490b729c2ca861a1b
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Move commands from ipmi-providers

Many commands were in ipmi-providers and need to be moved into the
active development library (intel-ipmi-oem). This copies wholesale
those commands

Move commands from ipmi-providers

Many commands were in ipmi-providers and need to be moved into the
active development library (intel-ipmi-oem). This copies wholesale
those commands, even though many need to be rewritten to use the new
ipmi providers API.

Tested-by: build and see that the commands are still present even when
the ipmi-providers library is removed

Change-Id: If326f5d7844adeed7da2d3b7a2f1d3eeeea43b29
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...