catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia9932efb6a9335e80b3f2376d2d62e1b65866f44

biosxml: run dos2unix

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie3977e37d069f676a2f84b498c49cda5bb9e00da

Guarantee SDR Type12 byte alignment matches the IPMI spec

The Type12 structure used a uint24_t to assign storage for 3 reserved
bytes in the Type12 SDR definition. This turned out to be an issue as

Guarantee SDR Type12 byte alignment matches the IPMI spec

The Type12 structure used a uint24_t to assign storage for 3 reserved
bytes in the Type12 SDR definition. This turned out to be an issue as
the compiler promoted the uint24_t to a uint32_t, which added one
additional byte to the structure. This in turn pushed the trailing
bytes out of alignment.

The defintion has been changed to use an explicit uint8_t array that
is three bytes in size. This defines the structure in a way that
guarantees the size of the record is correct.

The structure has also had a constructor added to it to eliminate code
duplication, and to reduce the likelihood of errors caused by manual
calculation of values.

Tested:
Issued 'ipmitool sdr dump /tmp/sdrs.bin'
Performed a hex dump on the binary data and reviewed the Type12
records.
Confirmed all fields were correctly assigned, including the inclusion
of only 3 reserved bytes.

Change-Id: I3fef5a1fe67877e5a6cf6e7928c5f15599bfb6f6
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Add 'greater than' support in depex computation.

Added support in code to compute depex expressions
with _GE_ and _GTE_.

Tested:
With bios.xml file which had the following knob:

<knob
type="scalar

Add 'greater than' support in depex computation.

Added support in code to compute depex expressions
with _GE_ and _GTE_.

Tested:
With bios.xml file which had the following knob:

<knob
type="scalar"
setupType="numeric"
name="CoreDisableMask_0"
varstoreIndex="05"
prompt="CoreDisableMask_0"
description="Core Disable Bitmap (Hex) 0:
Enable all cores. 0xffff: Disable all cores "
size="8"
offset="0x014A"
depex="Sif( SstPpLevelTotalCount _GT_ 1
AND ( ( IssTdpLevel _EQU_ 0xFF
AND SstPpLevelEnableSystem_0 _NEQ_ 1 )
OR ( IssTdpLevel _NEQ_ 0xFF AND IssTdpLevel _GT_ 0 )
OR DynamicIss _EQU_ 1 ) )"
default="0x0000000000000000"
CurrentVal="0x0000000000000000"
min="0x0"
max="0xFFFFFFFFFFFFFFFF"
step="0x1"/>

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Change-Id: I45cd879ca1bb35e6cde9ea581b3a5c63577525d0

show more ...

Fix support for Get Payload.

Get Payload is split into two as follows:
1) Get Payload Info (ipmitool raw 0x30 0xd6 0 1):
Return info of Payload1 (pending list) data

2) Get Payload data (ipmitool ra

Fix support for Get Payload.

Get Payload is split into two as follows:
1) Get Payload Info (ipmitool raw 0x30 0xd6 0 1):
Return info of Payload1 (pending list) data

2) Get Payload data (ipmitool raw 0x30 0xd6 1 1):
Return Payload1 (pending list) data.

Note: Pending list is the BIOS knobs edited by patch to
https://<IP>/redfish/v1/Systems/system/Bios/Settings,
which is stored in BMC.

Tested:
Step 1)
Patch to https://<IP>/redfish/v1/Systems/system/Bios/Settings
with the following data:
{
"data":{
"Ce2LmLoggingEn": "0x0",
"CoreCrashLogDisable": "0x1",
"CpuCrashLogClear": "0x0",
"DfxEadrDebugLogs": "0x1",
"DfxFadrDebugLogs": "0x1",
"WheaLogMemoryEn": "0x1"
}
}

Step 2)
Give command ipmitool raw 0x30 0xd6 0 1

Response:
00 00 01 7e 00 00 00 08 4c d3 e9 00 01 a8 9e 00
00

Step 3)
Give command ipmitool raw 0x30 0xd6 1 1 0x09 0 0 0 0x7e 0 0 0

Response:
01 75 00 00 00 89 51 07 a0 69 6e 67 45 6e 3d 30
78 30 0a 43 6f 72 65 43 72 61 73 68 4c 6f 67 44
69 73 61 62 6c 65 3d 30 78 31 0a 43 70 75 43 72
61 73 68 4c 6f 67 43 6c 65 61 72 3d 30 78 30 0a
44 66 78 45 61 64 72 44 65 62 75 67 4c 6f 67 73
3d 30 78 31 0a 44 66 78 46 61 64 72 44 65 62 75
67 4c 6f 67 73 3d 30 78 31 0a 57 68 65 61 4c 6f
67 4d 65 6d 6f 72 79 45 6e 3d 30 78 31 0a

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Change-Id: I6a3bec66f78c2c9b6296e3dbba7743971b372f75

show more ...

Add PCIe scan option to BMC Feature Control command

This adds an option to enable and disable the PCIe scan feature using
the MTM BMC Feature Control command.

Changes to request bytes for PCIe scan

Add PCIe scan option to BMC Feature Control command

This adds an option to enable and disable the PCIe scan feature using
the MTM BMC Feature Control command.

Changes to request bytes for PCIe scan feature:
Byte 1 – Supported features
01h - PCIe scan
Byte 2 – Enable/Disable feature
00h – Stops the given feature
01h – Starts the given feature
02h – Disables the given feature
03h – Enables the given feature
Byte 3:5 – reserved

Tested:
Verified PCIe scan feature can be enabled/disabled as expected in MTM mode

Disable PCIe scan:
ipmitool raw 0x30 0xa4 1 2 0 0 0

Enable PCIe scan:
ipmitool raw 0x30 0xa4 1 3 0 0 0

Change-Id: I90be0b10469542bba80d3b29ff0c727b8a817dfe
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add MTM BMC Feature Control IPMI command

Certain features having security concerns needs to be enabled/disabled
only in manufacturing mode. Add a command to support the same for MCTP
feature.

In ad

Add MTM BMC Feature Control IPMI command

Certain features having security concerns needs to be enabled/disabled
only in manufacturing mode. Add a command to support the same for MCTP
feature.

In addition to starting or stopping a service, add an option to enable
or disable a service which will persist across AC cycles.

Request bytes:
Byte 1 – Supported features
00h - MCTP
01h to FFh - reserved (will be adding support for more features
as needed)
Byte 2 – Enable/Disable feature
00h – Stops the given feature
01h – Starts the given feature
02h - Disables the given feature
03h - Enables the given feature
04h to FFh – reserved
Byte 3 - Custom feature arguments
When byte 2 value is 00h:
00h - MCTP over PCIe
01h - MCTP over SMBus HSBP
02h - MCTP over SMBus PCIe slot
03h to FFh - reserved
Byte 4:5 – reserved

Tested:
Verified MCTP feature can be enabled/disabled as expected in MTM mode
the change will persist across AC cycles.

Signed-off-by: Arun P. Mohanan <arun.p.m@linux.intel.com>
Signed-off-by: Sumanth Bhat <sumanth.bhat@linux.intel.com>
Change-Id: I8f8be36ee3e0fd85cfb1e44599cd0db0a6a8d34a

show more ...

Improve SDR sensor number mapping for sensor nums above 510

The recent submission to support SDR records defining Type 01 records
for sensors did not work when the system had more than 510 sensors.

Improve SDR sensor number mapping for sensor nums above 510

The recent submission to support SDR records defining Type 01 records
for sensors did not work when the system had more than 510 sensors. A
recent change supplied a system that enumerated more sensors then IPMI
can support. The change highlighted an error in how the Type 01
records were built.

This commit handles systems with a larger set of sensors. The code for
handling SDR # 511 correctly creates sensor number 768. It then fills
sensors to the limit of LUN 3.

Tested:
A SUT that supplied 1946 sensors was used to implement and test the
code.
Test cases:
"ipmitool sdr elist" returns 765 sensors
"ipmitool sensor list" returns 765 sensors
"ipmitool -l <lun> raw 4 0x2d <sn>" performed the correct behavior for
luns 0-3, sensor numbers 0, 254, 255.

Change-Id: I8e5160c93e79a366b897554efdd60e2edcd3594a
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Add MFG Set FITc Layout command

FITc layout is used as the ROM ID for incremental PCH
image updates to enforce image layout compatibility.
The update image also contains this value and is compared
u

Add MFG Set FITc Layout command

FITc layout is used as the ROM ID for incremental PCH
image updates to enforce image layout compatibility.
The update image also contains this value and is compared
upon receipt of the update image.

Tested: set the layout:
- enter MFG mode
- ipmitool raw 0x30 0xa3 W X Y Z
- inspect fitc layout file on BMC

Change-Id: I72930407a230b55340f6d12cef48e0e8d273ed6e
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add depex support in bios.xml parsing.

Added logic to execute depex expression for every knob in bios.xml.
knob is added to BiosAttributeRegistry only if depex evaluation result
is TRUE.

Tested:
By

Add depex support in bios.xml parsing.

Added logic to execute depex expression for every knob in bios.xml.
knob is added to BiosAttributeRegistry only if depex evaluation result
is TRUE.

Tested:
By giving GET Request to
'redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'.
Output sample showing few knobs added becuase depex evaluation result
was TRUE:

{
"AttributeName": "AEPErrorInjEn",
"CurrentValue": "0x00",
"DefaultValue": "0x00",
"DisplayName": "AEPErrorInjEn",
"HelpText": "Enable/Disable PMem Error Injection",
"MenuPath": "./",
"ReadOnly": false,
"Type": "String",
"Value": [
{
"OneOf": "0x0"
},
{
"OneOf": "0x1"
}
]
}
{
"AttributeName": "wrVrefCenter",
"CurrentValue": "0x01",
"DefaultValue": "0x01",
"DisplayName": "wrVrefCenter",
"HelpText": "Write Vref Centering Disable/Enable",
"MenuPath": "./",
"ReadOnly": false,
"Type": "String",
"Value": [
{
"OneOf": "0x0"
},
{
"OneOf": "0x1"
}
]
}

Following are few knobs rejected becuase depex evaluation
result was FALSE:

<knob type="scalar" setupType="oneof" name="PfrProvision"
varstoreIndex="04" prompt="PFR Provision"
description="Selectable if PFR is not locked." size="1"
offset="0x0126"
depex="Sif( PfrSupported _EQU_ 0 ) _AND_ Gif( PfrLockStatus _EQU_ 1 OR
PfrProvisionStatus _EQU_ 1 )"
default="0x00" CurrentVal="0x00">
<options>
<option text="Disable" value="0x0"/>
<option text="Enable" value="0x1"/>
</options>
</knob>

<knob type="scalar" setupType="oneof" name="SataHotPlugController0_0"
varstoreIndex="01" prompt="
Hot Plug" description="Designates this port as Hot Pluggable." size="1"
offset="0x0119"
depex="Sif( PchSata_0 _EQU_ 0 ) _AND_
Sif( SataExternalController0_0 _EQU_ 1 )" default="0x00"
CurrentVal="0x00">
<options>
<option text="Disabled" value="0x0"/>
<option text="Enabled" value="0x1"/>
</options>
</knob>

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Change-Id: Iff1ea01fb06200e21cc7f2a2e0fdfdff70376581

show more ...

OOB NV File Handling flow is corrected.

1.OOB NV files are restored properly after BMC reset
2.Added File Error handling

Tested:
Get OOB BIOS capability
ipmitool raw 0x30 0xd4

Set OOB BIOS Capabil

OOB NV File Handling flow is corrected.

1.OOB NV files are restored properly after BMC reset
2.Added File Error handling

Tested:
Get OOB BIOS capability
ipmitool raw 0x30 0xd4

Set OOB BIOS Capability
ipmitool raw 0x30 0xd3 0x16 0 0 0

SetPayload Start Info :
ipmitool raw 0x30 0xd5 0 3 0 0 0x44 0 0 0 0xc 0xab 0xc2 0x53 0x0
Success with Reservation ID
SetPayload InProgress :
ipmitool raw 0x30 0xd5 1 3 <Reservation ID> 0 0 0 0 0x44 0 0 0
0xc 0xab 0xc2 0x53 0x50 0x58 0x4F 0x24 0x44 00 0x20 00 0x02
0x4E 0x81 00 0x03 00 0x03 0xF8 0x02 00 00 0x79 0x18 00
0x04 00 0x07 00 00 00 00 00 00 00 0x02 0x24 00 00 0xE8
0x7E 0xF8 0x83 0x06 00 00 00 00 00 00 00 00 00 00 00 00
0x7F 00 0x07 00 00 0x81 00 00 00 00 00 00 00 00 00
EndOfTransfer:
ipmitool raw 0x30 0xd5 2 3 <Reservation ID>
Success with data
Reboot the BMC
reboot

Get Payload Info:
ipmitool raw 0x30 0xd6 0 3
Success with data
Get Payload:
ipmitool raw 0x30 0xd6 1 3 0 0 0 0 0x44 0 0 0
Success with data

Delete the Payload3 File:
Get Payload Info
ipmitool raw 0x30 0xd6 0 3
0xFF // Unspecified Error

Get Payload :
ipmitool raw 0x30 0xd6 1 3 0 0 0 0 0x44 0 0 0
0xFF // Unspecified Error

Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>
Change-Id: I6c09e4154d4a33557fe02449f20e820204a8e0f5

show more ...

fix: correct SetBiosPwdHash and GetBiosPwdHash cmd

As per recent EDK core, there is a change in BIOS password handling.
User password option in BIOS setup is removed for security reasons.
Also, move

fix: correct SetBiosPwdHash and GetBiosPwdHash cmd

As per recent EDK core, there is a change in BIOS password handling.
User password option in BIOS setup is removed for security reasons.
Also, moved to SHA256 algo and seed size is increased from 16 bytes
to 32 bytes.

This change is to correct the two password handling commands to comply
with the the new bios changes.

Tested:
Executed both the commands D7 and D8 through KCS interface.
Verified cmd response is success and as expected.

Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>
Change-Id: I8fbd1623c5feaf33a9a8f91905bb1773163fbbae

show more ...

Fix build issues

* Fix casting issues that are causing the build to fail.
* Fix gtest warnings by updating the source revision

Change-Id: Id6eb6b1fef335f88e7e12074f712b82ecd1a233a
Signed-off-by: Ja

Fix build issues

* Fix casting issues that are causing the build to fail.
* Fix gtest warnings by updating the source revision

Change-Id: Id6eb6b1fef335f88e7e12074f712b82ecd1a233a
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Remove unused POST code D-Bus defines

The object path is no longer valid so better to remove it.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: Ifd980d1170a26e6b3049030c6fdbe7e

Remove unused POST code D-Bus defines

The object path is no longer valid so better to remove it.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: Ifd980d1170a26e6b3049030c6fdbe7e559536042

show more ...

sensorcommands: Add IPMI reading logging instrumentation

Noteworthy sensor readings, such as the first reading,
a new minimum or maximum value, or ending a good or
bad streak of readings, will now h

sensorcommands: Add IPMI reading logging instrumentation

Noteworthy sensor readings, such as the first reading,
a new minimum or maximum value, or ending a good or
bad streak of readings, will now have some useful logging output.

Tested: Example logs
```
root@bmc:~# journalctl --no-pager | grep 'IPMI sensor'
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor0: First reading, value=6 byte=51
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor0: Range min=0 max=30, Coefficients mValue=118 rExp=-3 bValue=0 bExp=0 bSigned=0
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor1: First reading, value=7 byte=59
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor1: Range min=0 max=30, Coefficients mValue=118 rExp=-3 bValue=0 bExp=0 bSigned=0
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor2: First reading, value=1.437 byte=12
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor2: Range min=0 max=30, Coefficients mValue=118 rExp=-3 bValue=0 bExp=0 bSigned=0
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor3: First reading, value=1.437 byte=12
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor3: Range min=0 max=30, Coefficients mValue=118 rExp=-3 bValue=0 bExp=0 bSigned=0
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor4: First reading, value=1.96 byte=17
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor4: Range min=0 max=30, Coefficients mValue=118 rExp=-3 bValue=0 bExp=0 bSigned=0
...
```
Machine and sensors names are replaced.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Idf7c8d4285b286fdc0afb3f0e7260c2d4915b326
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Fix sensor missing issue.

There is issue for "BMC randomly unable to get sensor readings".
When invoking "ipmitool sdr" from Linux OS (host), it only
returns three sensors like following partial rec

Fix sensor missing issue.

There is issue for "BMC randomly unable to get sensor readings".
When invoking "ipmitool sdr" from Linux OS (host), it only
returns three sensors like following partial records:
[root@localhost ~]# ipmitool sdr
CPU Power | 0 Watts | ok
Memory Power | 0 Watts | ok
Total Power | 0 Watts | ok
[root@localhost ~]#

There 2 caches sensorTree and sensorDataRecords.
When sensorDataRecords cache and sensorTree cache is not sync,
which causes this issue, like sensorTree cache has 10 sensors
but there are just 5 sensors in sensorDataRecords cache.
Most important sensorDataRecords cache is not necessary,
ipmiStorageGetSDR could get data from dbus directly and
no any performance impact.

Using sensorMapUpdatePeriod(10s) but not sensorMapSdrUpdatePeriod(60s),
60 seconds are too long to answer user with some SDR content
at the first time of BMC bootup.

Tested:
All sensors could be listed even at booting phase.
Could print correct sensor set along with the boot progress.

root@intel-obmc:~# ipmitool sdr
CPU Power | 202 Watts | ok
Memory Power | 0 Watts | ok
Total Power | 312 Watts | ok
root@intel-obmc:~# ipmitool sdr
System Airflow | 14 unspecified | ok
PSU1 In Current | 1.18 Amps | ok
PSU1 Out Current | 20.80 Amps | ok
PSU2 In Current | 0 Amps | ok
PSU2 Out Current | no reading | ns
Pwm 1 | 29.79 unspecifi | ok
Pwm 2 | 29.79 unspecifi | ok
Pwm 3 | 29.79 unspecifi | ok
Pwm 4 | 29.79 unspecifi | ok
Pwm 5 | 29.79 unspecifi | ok
Pwm 6 | 29.79 unspecifi | ok
Pwm 13 | 29.79 unspecifi | ok
Pwm 14 | 29.79 unspecifi | ok
Pwm 15 | 29.79 unspecifi | ok
Pwm 16 | 29.79 unspecifi | ok
Pwm PSU1 Fan 1 | 39.98 unspecifi | ok
Pwm PSU1 Fan 2 | 39.98 unspecifi | ok
.............
PVCCD HV CPU1 | 1.18 Volts | ok
PVCCFA EHV FIVRA | 1.16 Volts | ok
PVCCINFAON CPU1 | 1.11 Volts | ok
PVCCIN CPU1 | 1.68 Volts | ok
PVNN PCH AUX | 1.03 Volts | ok
root@intel-obmc:~#

Change-Id: I729d9bcbf91f0e96c62fb5f5ebe0240a0eaa47df
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
Signed-off-by: Helen Huang <he.huang@linux.intel.com>
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>

show more ...

IPMI OEM Commands for OOB bios config

Four IPMI OEM commands are defined and implemented for the
communication beteween BIOS and BMC.
cmdSetBIOSCap = 0xD3;
cmdGetBIOSCap = 0xD4;
cmdSetPayload = 0xD5

IPMI OEM Commands for OOB bios config

Four IPMI OEM commands are defined and implemented for the
communication beteween BIOS and BMC.
cmdSetBIOSCap = 0xD3;
cmdGetBIOSCap = 0xD4;
cmdSetPayload = 0xD5;
cmdGetPayload = 0xD6;
cmdSetPasswordHashInfo = 0xD7;
cmdGetStoredPasswordHash = 0xD8;

Added the OTA Payload Type

Tested:
1. ipmitool is working well for these 6 commands
2. passed unit test w/ bios and bios.xml is generated successfully

Change-Id: Ic318c18ca6d59c3ad6e10df9ffb2b22a38a55ddf
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>

show more ...

Add sufficient delay to create smbios2 file

Issue: Sometimes with existing defaultTimeout & sysClock delay, BIOS is
not responding with required information to create smbios2 file which
contains DIM

Add sufficient delay to create smbios2 file

Issue: Sometimes with existing defaultTimeout & sysClock delay, BIOS is
not responding with required information to create smbios2 file which
contains DIMM info.

Fixed: Increase defaultTimeout & sysClock time to provide required delay
to get response from SMBIOS in order to populate DIMM information.

Tested:
1. Verified for 100 DC cycles.
2. smbios2 file is generated for each cycle with proper DIMM information

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ie33a95ecb91639f8d2af2836f97b32890e6f6fab

show more ...

Allow more than 256 IPMI sensors in a system

Systems with more than 255 IPMI sensors report strange values for
sensors assigned beyond the 255 limit for a single LUN. This is due to
the sensor numbe

Allow more than 256 IPMI sensors in a system

Systems with more than 255 IPMI sensors report strange values for
sensors assigned beyond the 255 limit for a single LUN. This is due to
the sensor number assignment rolling over to 0, and then applying the
most recent SDR values to the sensor calculation.

This change assigns up to 255 sensors to a single LUN (0xFF is
reserved). When the 256th sensor is assigned the sensor gets placed in
the LUN. LUNs 0, 1, and 3 are used, as LUN 2 is special.

Another guard has been created that throws an exception when more than
765 sensors have been assigned. This makes it obvious to the system
designer the limit for IPMI sensors has been reached.

Tested:
Forced the maxmimum number of sensors in the system to be 63 per LUN.

"ipmitool sdr elist" returned correct values for every sensor even
when the sensor number displayed in the printout matched the value of
a sensor printed earlier.

"ipmitool sensor get P3V3" returns a valid reading. In my test "P3V3"
was in LUN1.

"ipmitool raw 4 0x20 0" reported 63 sensors for LUN0, and that LUN0
and LUN1 had sensors.

"ipmitool raw -l 1 4 0x20 0" reported the remaining sensor count.

"ipmitool raw 0xa 0x2d 0" returns the correct value for LUN0 Sensor 0

"ipmitool raw -l 1 0xa 0x2d 0" returns the correct value for LUN1
Sensor 0

Change-Id: Ic1708b66339e57b1b765f5a9a684e829a0ec8fba
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

smbiosmdrv2handler:Fix for MDRV2 get data info

Issue: Mdrv2 get data set info response giving as 0xce which is
incorrect.

Fix: Update MDRiiGetDataInfoResponse structure definition as per IPMI
OEM c

smbiosmdrv2handler:Fix for MDRV2 get data info

Issue: Mdrv2 get data set info response giving as 0xce which is
incorrect.

Fix: Update MDRiiGetDataInfoResponse structure definition as per IPMI
OEM commands documentation and provided fix to get correct response
as provided in test results.

Tested:
Verified using ipmitool raw commands.
Before:
Command: ipmitool raw 0x3e 0x39 0x01 0x01 //SMMDR Data Set Info Offer
Response: 28 29 2a 2b 2c 2d 2e 2f 30 31 32 33 34 35 36 42
//SMMDR Get Data Set Info command
Command: ipmitool raw 0x3e 0x32 0x01 0x01 0x28 0x29 0x2a 0x2b 0x2c 0x2d
0x2e 0x2f 0x30 0x31 0x32 0x33 0x34 0x35 0x36 0x42
Response: Unable to send RAW command (channel=0x0 netfn=0x3e lun=0x0
cmd=0x32 rsp=0xce): Command response could not be provided

After:
Command: ipmitool raw 0x3e 0x39 0x01 0x01 //SMMDR Data Set Info Offer
Response: 28 29 2a 2b 2c 2d 2e 2f 30 31 32 33 34 35 36 42
//SMMDR Get Data Set Info command
Command: ipmitool raw 0x3e 0x32 0x01 0x01 0x28 0x29 0x2a 0x2b 0x2c 0x2d
0x2e 0x2f 0x30 0x31 0x32 0x33 0x34 0x35 0x36 0x42
Response: 02 28 29 2a 2b 2c 2d 2e 2f 30 31 32 33 34 35 36
42 01 00 00 11 45 0f 00 00 7a 1b

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ia23f1cf19608281dc98e971f9c5e84c7dde4ba61

show more ...

oemcommands: Implement OEM Get Reading command

Newly implement OEM Get Reading command API. It implements for
"Inlet Air Temperature" Reading type.

Tested:
Verified on single node system using Oem

oemcommands: Implement OEM Get Reading command

Newly implement OEM Get Reading command API. It implements for
"Inlet Air Temperature" Reading type.

Tested:
Verified on single node system using Oem get reading commands.
Command: ipmitool raw 0x30 0xe2 0x00 0x00 0x00 //OEM Get reading
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xe2 rsp=0xc9): Parameter out of range
Command: ipmitool raw 0x30 0xe2 0x10 0x0 0x0 //OEM Get reading
Response: 10 1a 00
Command: ipmitool raw 0x30 0xe2 0x20 0x0 0x0 //OEM Get reading
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xe2 rsp=0xc9): Parameter out of range
Command: ipmitool raw 0x30 0xe2 0x30 0x0 0x0
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0xe2 rsp=0xcc): Invalid data field in request

Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: I6450fe95b4ef52eed4784561180d1da667d30360

show more ...

types: move common types into types header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I8e6f6fbae784a8ceebcc83ac53c1beb5c7b46779

sensorutils: drop unused variables

Drop unused min10/max10 variables.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I9a696672e25936b1e26371044298d76bb14133f7

Update to latest clang-format

Update to clang-format-10

Change-Id: I1c33ef7115c7a1459164d71f63921019d2dc9a98
Signed-off-by: James Feist <james.feist@linux.intel.com>

Rewrite handleIpmbChannel api

Rewriting new_method_call to yield_method_calll for handleIpmbChannel

Tested:
Verified using below send message commands
1. Send message command
Command:
FS0:\cmdtool

Rewrite handleIpmbChannel api

Rewriting new_method_call to yield_method_calll for handleIpmbChannel

Tested:
Verified using below send message commands
1. Send message command
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C 00 00 FC FC 04 00 2C FC 04
C1 13
Response: 00 //Success

2. Get message command
Commad: FS0:\cmdtool\> cmdtool.efi 20 18 33
Response: 00 FC FC 04 00 2C FC 04 C1 13

Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: I9b461ddbc3a93b67e26ec92ff7c41fdc97e49931

show more ...