Update getThreshold to new API

This command is broken out into a "getIPMIThresholds" function
and the actual handler so that the SDR can call the same code
to get thresholds into IPMI format. Doing

Update getThreshold to new API

This command is broken out into a "getIPMIThresholds" function
and the actual handler so that the SDR can call the same code
to get thresholds into IPMI format. Doing this caused quite a
bit of rewrite so I updated it to the new API as well.

Tested: IPMI sensor list thresholds still worked.

Change-Id: If6f33574d61549ec0e70955f3d1867af8d698246
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Remove bitfields from the SEL record structures

Bitfields are not endian-safe, so this change removes the
bitfields from the SEL record structures and defines the
event direction as an offset.

Test

Remove bitfields from the SEL record structures

Bitfields are not endian-safe, so this change removes the
bitfields from the SEL record structures and defines the
event direction as an offset.

Tested:
Confirmed that SEL events are still added and listed with the
correct assertion state.

Change-Id: I4b7428d28b2738f729612e6d793a61694853f89a
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add remaining BIOS thermal settings

This adds set/get for Fan UCC and fan speed offset.
Also this updates them to the new API.

Tested: was able to get and set parameters using bios
and changes were

Add remaining BIOS thermal settings

This adds set/get for Fan UCC and fan speed offset.
Also this updates them to the new API.

Tested: was able to get and set parameters using bios
and changes were reflected next bios reading, as well
as in entity-manager

Change-Id: Ifd979e5d7966d05587c3af36791bd79ef358d391
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Sensor Reading Get: Add threshold byte

Third byte should show threshold status based on
spec. Add the threshold data and update to the new
api.

Tested: Sensor list still worked, used sensor overide

Sensor Reading Get: Add threshold byte

Third byte should show threshold status based on
spec. Add the threshold data and update to the new
api.

Tested: Sensor list still worked, used sensor overide
to modify threshold and saw byte in sensor get. sdr elist
also started showing status.

Change-Id: Ic08555563b62048f334b5cb4aaedcd3fcef1f5f7
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Remove registration.hpp and api.h

They are deprecated.

Change-Id: Ia796a82814efb7bc4d796623c716833e000118bf
Signed-off-by: James Feist <james.feist@linux.intel.com>

Adding Def user creation using Intel OEM command

New Def user is created based on given username and pwd

Tested: New user is created successfully using this cmd.
ipmitool -I LAN raw OEMNefn Cmd <1

Adding Def user creation using Intel OEM command

New Def user is created based on given username and pwd

Tested: New user is created successfully using this cmd.
ipmitool -I LAN raw OEMNefn Cmd <16 bytes username><20 bytes Pwd>
new username and password is set in user id 2 on top of def user

Added more restriction like works only in LAN,system interface
should not available,LAN should be configured in static and
user 2 should not enabled or configured previously.

Command work only with user created with callback priv by default

Change-Id: I77809e18fbef8e82ae2ba27527698e7fa5c5fd85
Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>

show more ...

OEM command SendFwUpdateStatus

It is used by BIOS/ME to report firmware update status.
Orignal implement uses OEM SEL. In openbmc, OEM SEL is no longer
supported. We use redfish visiable logging ins

OEM command SendFwUpdateStatus

It is used by BIOS/ME to report firmware update status.
Orignal implement uses OEM SEL. In openbmc, OEM SEL is no longer
supported. We use redfish visiable logging instead.

Tested:
1.ipmitool xxx raw 0x30 0x44 0x0 0x10 0x1 0x2 0x30 0x31 0x32 0x33
2. check 'journal -ef -overbose'
expect message with tag 'REDFISH_MESSAGE_ID' is observed
3. check redfish interface
/redfish/v1/Systems/system/LogServices/EventLog/Entries/
expect entries match what we create

Change-Id: I8746e9250bcfb4d8c4a905a1ccaedcc7efab2f51
Signed-off-by: Jia, chunhui <chunhui.jia@linux.intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Improve sensor tree handling in sdrutils.hpp

This change adds a bimap of sensor number to path to improve
lookup of both types.

Also, with the current implementation each time a sensor number is
re

Improve sensor tree handling in sdrutils.hpp

This change adds a bimap of sensor number to path to improve
lookup of both types.

Also, with the current implementation each time a sensor number is
requested, the sensor tree must be retrieved from dbus and
parsed. This is fairly expensive and mostly unnecessary
because the sensor tree doesn't change often.

To help improve performance, this change also caches the sensor
tree and number mapping so requests can be returned quickly.
The sensor tree cache is cleared whenever a sensor interface
is added or removed. Regenerating the sensor tree cache
causes the sensor number map cache to also be regenerated so
both contain the latest sensor information.

Tested: Manually added SEL events to verify that they are
mapped to the correct sensors.

'ipmitool sel list' command with 105 SEL entries improved from
8.25 seconds to 1.50 seconds.

Change-Id: I0366e41985c980cbfa28f66a2a979f30ab98141a
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add Exit Air Temp Limit Support

Exit air temp in BIOS is set using the TControl command.
Implement enough of this command to get Exit air temp
limit to work correctly in BIOS. BIOS hard codes the
le

Add Exit Air Temp Limit Support

Exit air temp in BIOS is set using the TControl command.
Implement enough of this command to get Exit air temp
limit to work correctly in BIOS. BIOS hard codes the
legacy sensor number to 0x2e, so we will probably want
to have them fix this at some point in the future.

Tested: Changed clamp values through bios and they were
the same on next read.

Change-Id: I17e1f9771d3b7806a9ea1e3db30c2d5a7b2cab6a
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add CFM Limit Set / Get commands

These commands can be used to set the Min / Max
CFM limits.

Tested: Used bios to change cfm limits and they
were persisted.

Change-Id: Id806acb9c13b32228d1fe86baf4

Add CFM Limit Set / Get commands

These commands can be used to set the Min / Max
CFM limits.

Tested: Used bios to change cfm limits and they
were persisted.

Change-Id: Id806acb9c13b32228d1fe86baf436e756f32d212
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add sensor deassert tracking

Get sensor event status command needs this information.

Tested: Used sensor override and made fan cross a threshold,
then go back. Get sensor event status command had c

Add sensor deassert tracking

Get sensor event status command needs this information.

Tested: Used sensor override and made fan cross a threshold,
then go back. Get sensor event status command had correct
bits set.

Change-Id: I8d8c7203ea6cb1d0e467f6267445e2d7395426a6
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix set sensor threshold command number

0x28 -> 0x26

Tested-by: Now works at 0x26

Change-Id: I0b1bac6e0bc17d9886f838de125bab5a1e985681
Signed-off-by: James Feist <james.feist@linux.intel.com>

Add fan profile host support

Implement the fan profile portions of get / set fan
profile ipmi commands. These commands have been overused
with too much debug information, currently we only plan
to s

Add fan profile host support

Implement the fan profile portions of get / set fan
profile ipmi commands. These commands have been overused
with too much debug information, currently we only plan
to support the part that the host needs.

Tested-by: Modified the settings on the host and they
were persisted correctly on the next boot

Change-Id: I5736703123154193b8e193ccb14fc2ffb9f5320b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Implement get/set platform serial port parameters command

This command is used for BIOS to set/get host serial host configuration.

Tested:
set config:
ipmitool raw 0x32 0x90 1 0
get config:
ipmitoo

Implement get/set platform serial port parameters command

This command is used for BIOS to set/get host serial host configuration.

Tested:
set config:
ipmitool raw 0x32 0x90 1 0
get config:
ipmitool raw 0x32 0x90 0

Change-Id: I97feebbfd88033a186e19e6f53ab92a240902603
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

show more ...

IPMI COMMAND: Get LED status

LED status includes system identify/amber/green status.
They are handled by led.controller and defined by Physical.interface.yaml

uint8_t status; //LED Status

IPMI COMMAND: Get LED status

LED status includes system identify/amber/green status.
They are handled by led.controller and defined by Physical.interface.yaml

uint8_t status; //LED Status
//[1:0] = Reserved
//[3:2] = Status(Amber)
//[5:4] = Status(Green)
//[7:6] = System Identify
//Status definitions:
//00b = Off
//01b = Blink
//10b = On
//11b = invalid
TestBy: ipmitool raw 0x30 0xb0

Change-Id: Ifce7c037f332cbe3fafd19e4e0acd9da6e06d12b
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>

show more ...

Add SEL commands for Jounal-based SEL entries

This change adds support for SEL IPMI commands using
journal-based SEL entries.

It adds Get SEL Info, Get SEL Entry, Add SEL Entry, and
Clear SEL, to g

Add SEL commands for Jounal-based SEL entries

This change adds support for SEL IPMI commands using
journal-based SEL entries.

It adds Get SEL Info, Get SEL Entry, Add SEL Entry, and
Clear SEL, to get and add entries using the journal.

This is going into intel-ipmi-oem for now because of conflicts
with existing SEL and sensor numbering implemenations. Once
the implemenations can be aligned, these commands can move to
the common IPMI implementation.

Tested: Verified that each of the above commands works as
expected.

Change-Id: Ib7c3832dfaf2bd60e828e368e029a2754c774b07
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

intel-ipmi-oem: Update with new ipmid/api.h path

The non-Yocto build is failing after the changes to the
ipmid-api.h path, so this change updates to the new
ipmid/api.h path.

Tested: Built with and

intel-ipmi-oem: Update with new ipmid/api.h path

The non-Yocto build is failing after the changes to the
ipmid-api.h path, so this change updates to the new
ipmid/api.h path.

Tested: Built with and without Yocto and confirmed both
complete successfully.

Change-Id: If00684c5ca65d99879f6d606709c82d80044af95
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Set pwm as sensor type fan

It was being defaulted to reserved.

Change-Id: Idb2f328b0efba3246bf58ffaa6f50c20b6899e23
Signed-off-by: James Feist <james.feist@linux.intel.com>

Apply comments from review 14430 to ipmi scaling

Some general cleanup style comments were suggested in
the above review. Apply them.

Tested-by: Verified unit tests worked.

Change-Id: Ia68b2d41308a

Apply comments from review 14430 to ipmi scaling

Some general cleanup style comments were suggested in
the above review. Apply them.

Tested-by: Verified unit tests worked.

Change-Id: Ia68b2d41308a2fc2997a247e87e65308fc8f4db0
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Update sdrutils.hpp for use outside of intel-ipmi-oem

This change makes some minor improvements to match what was
up for review in phosphor-host-ipmid and removes sdrutils.hpp
dependencies on local

Update sdrutils.hpp for use outside of intel-ipmi-oem

This change makes some minor improvements to match what was
up for review in phosphor-host-ipmid and removes sdrutils.hpp
dependencies on local files so it can be used outside of
intel-ipmi-oem.

Change-Id: Id126069cbe348fac4923c82f99ba96ebd7c35902
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Change sensorutils to be header-only

In the future sensorutils may need to move to a common repo, so
making it header-only so it can be shared and moved more easily.

Change-Id: I901be5e7721a5fa0f5e

Change sensorutils to be header-only

In the future sensorutils may need to move to a common repo, so
making it header-only so it can be shared and moved more easily.

Change-Id: I901be5e7721a5fa0f5e308145d55ca3998b11811
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Move SensorSubTree declaration to ipmi scope

Move SensorSubTree declaration to ipmi scope
Issue: Unable to resolve this symbol during loading of this
library, which is due to definition & declaratio

Move SensorSubTree declaration to ipmi scope

Move SensorSubTree declaration to ipmi scope
Issue: Unable to resolve this symbol during loading of this
library, which is due to definition & declaration being in different
scope.

Unit-Test:
Verified that library is loaded properly and ipmitool sensor list
works.

Change-Id: I243e0033d0b76a14c0976f16bd6b893c0e96cb55
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Fix checking of string::npos in sensor type parsing

The current string parsing to get sensor type from the path
does not correctly check for string::npos after the calls
to rfind(). This change add

Fix checking of string::npos in sensor type parsing

The current string parsing to get sensor type from the path
does not correctly check for string::npos after the calls
to rfind(). This change adds proper string::npos checking
after each rfind() before the position is used.

Tested: Ran 'ipmitool sensor list' and confirmed that the
sensor units are displayed properly.

Change-Id: If9a7113d105fdf7f4450a22d4b881cf2b5a9c090
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Move getSensorConnection to header file

Move getSensorConnection to header file, so that the same
can be used by ipmi-providers Set Sensor override command

Change-Id: Ic6c313eb2bc07710c175b7908647a

Move getSensorConnection to header file

Move getSensorConnection to header file, so that the same
can be used by ipmi-providers Set Sensor override command

Change-Id: Ic6c313eb2bc07710c175b7908647a800f5fe45a0
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Implement Intel get/set shutdown policy IPMI OEM commands

Tested By:
ipmitool raw 0x30 0x60 1
ipmitool raw 0x30 0x62

Change-Id: I8ca7429b569a465420c9b878fe29f8617c8ef76c
Signed-off-by: Yong Li <yon

Implement Intel get/set shutdown policy IPMI OEM commands

Tested By:
ipmitool raw 0x30 0x60 1
ipmitool raw 0x30 0x62

Change-Id: I8ca7429b569a465420c9b878fe29f8617c8ef76c
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>

show more ...