clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id2036ab746164981596b3ee36259f3ca5d3f1334
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Maue

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Change terminology to inclusive terms

Tested: No functionality changes, code still compiles.

Change-Id: I61dd3c6f3ecfb96088a68b1254a22c5fa5376b3d
Signed-off-by: Matt Simmering <matthew.simmering@in

Change terminology to inclusive terms

Tested: No functionality changes, code still compiles.

Change-Id: I61dd3c6f3ecfb96088a68b1254a22c5fa5376b3d
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie7375047bd567aa052d3bd35a6dd7008779a05b4

show more ...

Update to latest clang-format

Update to clang-format-10

Change-Id: I1c33ef7115c7a1459164d71f63921019d2dc9a98
Signed-off-by: James Feist <james.feist@linux.intel.com>

Rewrite handleIpmbChannel api

Rewriting new_method_call to yield_method_calll for handleIpmbChannel

Tested:
Verified using below send message commands
1. Send message comman

Rewrite handleIpmbChannel api

Rewriting new_method_call to yield_method_calll for handleIpmbChannel

Tested:
Verified using below send message commands
1. Send message command
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C 00 00 FC FC 04 00 2C FC 04
C1 13
Response: 00 //Success

2. Get message command
Commad: FS0:\cmdtool\> cmdtool.efi 20 18 33
Response: 00 FC FC 04 00 2C FC 04 C1 13

Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: I9b461ddbc3a93b67e26ec92ff7c41fdc97e49931

show more ...

bridgingcommands:move get&send commands to new api

Rewrite get and send message commands to use new IPMI provider API.

Tested:
verified ipmitool get and send message command, is

bridgingcommands:move get&send commands to new api

Rewrite get and send message commands to use new IPMI provider API.

Tested:
verified ipmitool get and send message command, is same both before and
after the changes
1. Enter in Manufacturing mode by executing below command
Command: ipmitool raw 0x30 0xB4 3 2
Response: //Success

2. Send message command
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C D3 01 FC FC 04 00 2C FC 08
C1 13
Response: 00 00 00 00 00 00 //Success

3. Get message command
Commad:
FS0:\cmdtool\> cmdtool.efi 20 18 33
Response: 00 FC FC D4 30 2C FC 04 C1 13

Negative Test cases:
Send Message Command:
1. // Encryption Enabled
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 26 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

2. // Authentication Enabled
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 16 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

3. // Channel other than IPMB and Lan
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 07 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

4. // IPMB data length Invalid:
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C
Response: C7

5. // IPMB address invalid:
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2B D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

6. // Tracking = 2 and 3 (Tracking mode not supported)
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 86 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 C6 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C9

7. // IPMB frame invalid:
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C D3 01 FC FC 04 00 2C FC 08 C1 12
Response: C9

8. // Response queue max size: (After doing multiple send)
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C D3 01 FC FC 04 00 2C FC 08 C1 13
Response: C0

9. IPMB layer non zero status:
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 34 06 2C D4 00 FB FC 04 00 2C FC 09 C1 13
Response: CE

Get Message Command:
10. // After booting, do Get Message command (Before send command)
Command:
FS0:\cmdtool\> cmdtool.efi 20 18 33
Response: 80

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Signed-off-by: Deepak Kumar Sahu <deepakx.sahu@intel.com>
Change-Id: I2a4028dbe889a0737821f95889c39e44254a12ca

show more ...

bridgingcommands:Move ClearMessageFlags to new API

Rewrite ipmiAppClearMessageFlags command to use the newly
introduced IPMI provider API.

Tested:
Verified using ipmitool Cl

bridgingcommands:Move ClearMessageFlags to new API

Rewrite ipmiAppClearMessageFlags command to use the newly
introduced IPMI provider API.

Tested:
Verified using ipmitool ClearMessageFlags behavior is same
before and after the changes.

Command : ipmitool raw 0x06 0x31 //Get Message Flags
Response: 02

Command : ipmitool raw 0x06 0x30 0x00 //Clear Message Flags
Response:

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I8c03050332408e909ab61994f337cfa2c1c036a4

show more ...

Implement Get Message Flags Command

Enable command that Get Message Flag can set right bit about
watchdog.

Tested:
Set watchdog timer
(Pre-timeout interrupt is Messaging

Implement Get Message Flags Command

Enable command that Get Message Flag can set right bit about
watchdog.

Tested:
Set watchdog timer
(Pre-timeout interrupt is Messaging, Initial Countdown is 2 second).
ipmitool raw 0x06 0x24 0x5 0x30 0x1 0x3e 0x14 0x00
Start watchdog timer.
ipmitool mc watchdog reset
After watchdog timer expired,
restart host and excute Get Message Flag Command.
ipmitool raw 0x06 0x31
Expect return "0x0b".

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Ib545034edfd0087e45d6a97125495e365989d7d3

show more ...

remove legacy ipmid_get_sd_bus_connection calls

The new way is to use the shared_ptr to the sdbusplus::asio::
connection. A shared pointer is cheaper to instantiate than
a dbus objec

remove legacy ipmid_get_sd_bus_connection calls

The new way is to use the shared_ptr to the sdbusplus::asio::
connection. A shared pointer is cheaper to instantiate than
a dbus object. This also paves the way to eventually replace
many of the blocking dbus calls with yielding or async dbus
calls.

Change-Id: Iea326782266d769457851aabf98e2e582d1bf81e
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Move commands from ipmi-providers

Many commands were in ipmi-providers and need to be moved into the
active development library (intel-ipmi-oem). This copies wholesale
those commands

Move commands from ipmi-providers

Many commands were in ipmi-providers and need to be moved into the
active development library (intel-ipmi-oem). This copies wholesale
those commands, even though many need to be rewritten to use the new
ipmi providers API.

Tested-by: build and see that the commands are still present even when
the ipmi-providers library is removed

Change-Id: If326f5d7844adeed7da2d3b7a2f1d3eeeea43b29
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...