flash: Rename header guard

Make it align with the file name

Change-Id: I304baec9edbc62470475e383d6f93640b25a0763
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd: Rename flash files

Change-Id: Icfe9d61775a198c5a0f8227bf5d6c4b7f11aeec3
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Make set_window_bytemap return standard errno

Do the error number conversion at the edges.

Change-Id: I5774065f13c8afb865926436b36ea9831f27620d
Signed-off-by: Andrew Jeffery <andrew@aj.id.

windows: Make set_window_bytemap return standard errno

Do the error number conversion at the edges.

Change-Id: I5774065f13c8afb865926436b36ea9831f27620d
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd: Clean up dbus objects

Change-Id: I24328c8fca02b004b0297ecc2f2a0320bfb23d9b
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxctl: Switch to new DBus interface

Change-Id: I05500784d94f14cf51510c9a6cb81110356ef0e1
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

dbus: Use new bus name, object and interface

The new interface is a more typical use of DBus, exposing multiple
methods for the functions that are available on the object. The legacy
interface by co

dbus: Use new bus name, object and interface

The new interface is a more typical use of DBus, exposing multiple
methods for the functions that are available on the object. The legacy
interface by comparison exposed only one method whose arguments selected
sub-commands to be executed. The legacy approach is not terribly
discoverable and leads to a lack of clarity in the client code. The
legacy approach also obscured the implementation with its use of `struct
mbox_dbus_msg`. The new interface wraps around the existing helpers and
so also deals with `struct mbox_dbus_msg`, but this can at least be
removed in the future.

Change-Id: I7113ed8fd2324bf3fb049d8d20acb3fd7fba6de3
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

dbus: Mark current command set as legacy

Change-Id: I1b5d1c9262ea6ae0a9ff77c902b6941943085cd1
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

dbus: Use consistent prefix for dbus function symbols

Improves readability by making it easier to tell at a glance what the
symbols are affecting.

Change-Id: I00e206b6383670118232e9b5a48cfbc4be5775

dbus: Use consistent prefix for dbus function symbols

Improves readability by making it easier to tell at a glance what the
symbols are affecting.

Change-Id: I00e206b6383670118232e9b5a48cfbc4be5775b8
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

test: bmc_event_ack_v2 must negotiate v2

The test checks for a v2-specific masking behaviour of the BMC status
byte. Ensure we have v2 before assuming v2 semantics.

Change-Id: I9791b000b8f11db4ccc3

test: bmc_event_ack_v2 must negotiate v2

The test checks for a v2-specific masking behaviour of the BMC status
byte. Ensure we have v2 before assuming v2 semantics.

Change-Id: I9791b000b8f11db4ccc34af6da554aea2139a732
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxctl: Remove redundant includes

Presumably these were copy/pasted from mboxd.c.

Change-Id: I39957921df86bcc436d4b3e51a76cc75408fd30c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

common: Include what we use in the header

Specifically, include syslog.h to grab the LOG_* macros.

Change-Id: I596549a43e3a714a115f55df405178fe5ef53f09
Signed-off-by: Andrew Jeffery <andrew@aj.id.a

common: Include what we use in the header

Specifically, include syslog.h to grab the LOG_* macros.

Change-Id: I596549a43e3a714a115f55df405178fe5ef53f09
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd_lpc_reset: Use SPDX licence header

Change-Id: Iacb5a6553c5a4530688d4b6bcbf7a92d7111cf6b
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

make: Improve cscope database quality

At least automake-1.15 doesn't unique-ify over all files listed in all
_SOURCES variables, which means we wind up with a database full of
duplicate symbols.

Im

make: Improve cscope database quality

At least automake-1.15 doesn't unique-ify over all files listed in all
_SOURCES variables, which means we wind up with a database full of
duplicate symbols.

Improve this by hacking up the cscope.files target to sort/unique the
file list before generating the database.

Change-Id: I1cc84e35ca6b5160c7c46d8d579547ec3d9b4497
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

format-code: Look for clang-format-6.0 as well

Otherwise we break the CI infrastructure. Also, fix up some errors that
v6.0 catches that v5.0 doesn't.

Change-Id: Idcbb102ebfda500f874a3e9f13d8ba2b72

format-code: Look for clang-format-6.0 as well

Otherwise we break the CI infrastructure. Also, fix up some errors that
v6.0 catches that v5.0 doesn't.

Change-Id: Idcbb102ebfda500f874a3e9f13d8ba2b72b6230d
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd: Drop unused sdbusplus configuration

Change-Id: I8a0977130f8a2f20ea0e9ad23d271b0d7076097c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

README: Add build documentation

Particularly, demonstrate how to avoid linking with a C++ compiler if
not configured with `--enable-virtual-pnor`.

Change-Id: I7fd0da535cd436085c2adcd3cdd058f1fc0762

README: Add build documentation

Particularly, demonstrate how to avoid linking with a C++ compiler if
not configured with `--enable-virtual-pnor`.

Change-Id: I7fd0da535cd436085c2adcd3cdd058f1fc076276
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

configure: Don't enable the virtual PNOR by default

To date, most systems are not configured with the virtual PNOR feature.
Turn it off by default, so only systems that want it enable it.

See vpnor

configure: Don't enable the virtual PNOR by default

To date, most systems are not configured with the virtual PNOR feature.
Turn it off by default, so only systems that want it enable it.

See vpnor/README.md to understand whether this is a feature you want for
your system design.

Change-Id: I33f57946444db92a72851c9ce24df6121860b742
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mbox: Forward-declare struct mbox_context

Avoid compilation errors such as:

$ make
make all-am
make[1]: Entering directory '/home/andrew/src/openbmc/phosphor-mboxd'
CC mbox

mbox: Forward-declare struct mbox_context

Avoid compilation errors such as:

$ make
make all-am
make[1]: Entering directory '/home/andrew/src/openbmc/phosphor-mboxd'
CC mboxd-common.o
CC mboxd-mboxd_dbus.o
CC mboxd-mboxd_lpc.o
CC mboxd-mboxd_msg.o
CC mboxd-mboxd_windows.o
CC mboxd-mtd.o
CC mboxd-mboxd_flash.o
CC mboxctl-mboxctl.o
CC mboxd-mboxd_lpc_reset.o
In file included from mboxd_dbus.c:28:0:
mbox.h:133:42: error: ‘struct mbox_context’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
typedef int (*mboxd_mbox_handler)(struct mbox_context *, union mbox_regs *,
^~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:2201: recipe for target 'mboxd-mboxd_dbus.o' failed
make[1]: *** [mboxd-mboxd_dbus.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Change-Id: Ie59a7b6a0831dc509b133fe35a2107f802afb49c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

tests: Ensure we don't disable asserts

Change-Id: Ieede7bc3c7b9d7dadc48a41b54dbe6c2b474c555
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Add MAINTAINERS file

Change-Id: Id92a36dbb0e6f1a34d7992aafcecf6bd90de29b8
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Add MAINTAINERS file

Change-Id: I695ebb12ecf451eaee3e5e1f6eafa1402526e79e
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

vpnor: Catch ReasonedError in vpnor_copy_bootloader_partition

It was observed that mboxd cored on systems that didn't have a virtual
PNOR deployed:

```
May 09 10:53:48 witherspoon systemd[1]: Start

vpnor: Catch ReasonedError in vpnor_copy_bootloader_partition

It was observed that mboxd cored on systems that didn't have a virtual
PNOR deployed:

```
May 09 10:53:48 witherspoon systemd[1]: Starting Updates symlinks for active PNOR version...
May 09 10:53:49 witherspoon obmc-flash-bios[1238]: ls: /media/pnor-ro-*: No such file or directory
May 09 10:53:49 witherspoon systemd[1]: Started Updates symlinks for active PNOR version.
May 09 10:53:49 witherspoon systemd[1]: Started Phosphor MBOX Daemon.
May 09 10:53:51 witherspoon mboxd[1242]: terminate called after throwing an instance of 'openpower::virtual_pnor::UnknownPartition'
May 09 10:53:51 witherspoon mboxd[1242]: what(): Partition HBB is not listed in the table of contents
May 09 10:53:51 witherspoon systemd[1]: Created slice system-systemd\x2dcoredump.slice.
May 09 10:53:51 witherspoon systemd[1]: Started Process Core Dump (PID 1243/UID 0).
May 09 10:53:51 witherspoon phosphor-host-state-manager[1237]: Initial Host State will be Off
May 09 10:53:51 witherspoon phosphor-host-state-manager[1237]: External request to reset reboot count
May 09 10:53:51 witherspoon systemd[1]: Started Phosphor Host State Manager.
May 09 10:53:51 witherspoon systemd[1]: Started Witherspoon UART render controller.
May 09 10:53:53 witherspoon systemd[1]: Started Wait for /xyz/openbmc_project/state/host0.
May 09 10:53:53 witherspoon systemd[1]: Starting Reset host sensors...
May 09 10:53:53 witherspoon systemd[1]: Starting Reboot If Enabled...
May 09 10:53:53 witherspoon systemd[1]: Starting Phosphor Time Manager daemon...
May 09 10:53:55 witherspoon systemd[1]: mboxd.service: Main process exited, code=dumped, status=6/ABRT
May 09 10:53:56 witherspoon systemd[1]: mboxd.service: Unit entered failed state.
May 09 10:53:56 witherspoon systemd[1]: mboxd.service: Failed with result 'core-dump'.
```

The ToC parsing and partition lookup functions can throw a variety of
exceptions, though the ones we care about are all derived from
ReasonedError. Catch ReasonedError to avoid core-dumping mboxd when it is
launched without a virtual PNOR available or symlinks in place th point it to
the virtual PNOR root directory.

Further, explicitly ignore the failure in the start-up path. This keeps
mboxd alive, which will recover on receiving a RESET if the appropriate
images and symlinks have been put in place.

Change-Id: I1f753d1944d29499e360cbdf5a27a3531f37eed6
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

vpnor: Honour return codes in reset_lpc()

Without inspecting the return codes we have no way to communicate up the
call stack whether the operation was successful.

Change-Id: If8af2995522901ec8fcfc

vpnor: Honour return codes in reset_lpc()

Without inspecting the return codes we have no way to communicate up the
call stack whether the operation was successful.

Change-Id: If8af2995522901ec8fcfc571cf1393b0441f8c9a
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

vpnor: Fix formatting in pnor_partition.cpp

Found in the process of resolving openbmc/openbmc#3125.

Change-Id: I5869eab6b1253548ac29cea8c86d71ba34f3f819
Signed-off-by: Andrew Jeffery <andrew@aj.id.

vpnor: Fix formatting in pnor_partition.cpp

Found in the process of resolving openbmc/openbmc#3125.

Change-Id: I5869eab6b1253548ac29cea8c86d71ba34f3f819
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd_msg: Fix overflow in get_suggested_timeout()

The suggested timeout is a two-byte unsigned value, but when introducing the
debug message it was stored in a one-byte unsigned value. This can lea

mboxd_msg: Fix overflow in get_suggested_timeout()

The suggested timeout is a two-byte unsigned value, but when introducing the
debug message it was stored in a one-byte unsigned value. This can lead
to overflow under some circumstances.

Change-Id: If4f86a8dc812ae27d703a10fb3d21ba3c2541e65
Fixes: 285195987721 ("mboxd: Introduce a new DEBUG log level")
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...