77692f50 | 21-Dec-2023 |
Andrew Jeffery <andrew@aj.id.au> |
OWNERS: Update Andrew's preferred email
We're having some grief with non-preferred emails in Gerrit[1]. I now prefer project-related content goes to my work email address, so use my non-preferred em
OWNERS: Update Andrew's preferred email
We're having some grief with non-preferred emails in Gerrit[1]. I now prefer project-related content goes to my work email address, so use my non-preferred email to implement the switch.
[1]: https://issues.gerritcodereview.com/issues/317345953
Change-Id: Ie6d17763b57360e939d1a42cbf2c9bfd238e90cb Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
82077511 | 28-Nov-2023 |
Adriana Kobylak <anoo@us.ibm.com> |
vpnor: Look for files in rw directory first
IBM systems running PLDM create lid files for the host content instead of PNOR partition files: ``` https://github.com/openbmc/pldm/blob/master/oem/ibm/co
vpnor: Look for files in rw directory first
IBM systems running PLDM create lid files for the host content instead of PNOR partition files: ``` https://github.com/openbmc/pldm/blob/master/oem/ibm/configurations/fileTable.json ```
In order to continue to support mboxd (hiomapd), symlinks with the PNOR partition file names are created to point to the lid files: https://gerrit.openbmc.org/c/openbmc/openpower-pnor-code-mgmt/+/45249
Since these symlinks are created at runtime, they can only be created in the read-write directory. Update the mboxd (hiomapd) code to look at the rw directory first, since in general the code searches in patch directories first to allow overrides. Then if the partition files are not found default to the read-only directory.
The symlinks are created prior to mboxd starting via a Before dependency in the openpower service file: ``` https://github.com/openbmc/openpower-pnor-code-mgmt/blob/master/mmc/openpower-update-bios-attr-table.service#L6 ```
Tested: Verified mboxd started successfully in a p10bmc and witherspoon system.
Change-Id: I281cd41591ab55cd1b3de474ad25c5992ea2d498 Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
show more ...
|
68a24c9e | 25-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
resolve stricter warnings
In order to convert this repository to Meson, we need to make it compile under `warning_level=3`. Fix a number of warning classes across the repository or disable them.
S
resolve stricter warnings
In order to convert this repository to Meson, we need to make it compile under `warning_level=3`. Fix a number of warning classes across the repository or disable them.
Some fixes are:
* Add missing header files. * Fully initialize structs as necessary. * Add `__attribute__((unused))` on parameters as necessary. * Fix comparisons between signed and unsigned. * Fix printf specifiers as necessary. * Avoid case-fallthrough. * Remove if conditions which are always true.
Some warnings would require extensive code changes, due to their pervasive use, and so are disabled at a per-file level: * `-Wpointer-arith` * `-Wunused-result`
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: If8992b9108f12b39f796ed090ba29868c9f3c627
show more ...
|
6a51e5f4 | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML files to have consistent formatting for these file types. Re-run the formatter on the whole repository.
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML files to have consistent formatting for these file types. Re-run the formatter on the whole repository.
Change-Id: If25c6524616e9c814ceab023c877d6049cb9f959 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
ad5dd0f5 | 04-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
bootstrap: fix shellcheck warnings
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I13c342ba20e2ab708b3117d890cad257a3e3482a |
a75dcde3 | 04-Aug-2022 |
Patrick Williams <patrick@stwcx.xyz> |
MAINTAINERS: remove file
The MAINTAINERS file is deprecated in favor of OWNERS.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ie120d01e91d309aaa31134440420f4e47a59086d
|
e75b64ce | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
OWNERS: switch 'matches' to 'matchers'
The original OWNERS template had a mistake which used 'matches' instead of the field supported by the Gerrit plugin 'matchers'. Update the OWNERS file to have
OWNERS: switch 'matches' to 'matchers'
The original OWNERS template had a mistake which used 'matches' instead of the field supported by the Gerrit plugin 'matchers'. Update the OWNERS file to have the correct field.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I16c1a7735830ef3e2616abc3339aa23c72b94703
show more ...
|
bf48004f | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
format-code: update clang-format to 14
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I597b95bb7a34feb762c20388fdd8b7e5ddf82359 |
fb7ebc2e | 16-Jun-2022 |
Patrick Williams <patrick@stwcx.xyz> |
MAINTAINERS: update Deepak's email
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I42fe5605e90eb6bad45e8012bace4003b94542ba |
7539be8d | 16-Jun-2022 |
Patrick Williams <patrick@stwcx.xyz> |
build: enable C++20
Elsewhere, all of our C++ repositories have updated to C++20. Enable it here as well.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I39ef53e7b41acd2f6b16070e35
build: enable C++20
Elsewhere, all of our C++ repositories have updated to C++20. Enable it here as well.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I39ef53e7b41acd2f6b16070e3533006d6b4dadeb
show more ...
|
150be912 | 16-Jun-2022 |
Patrick Williams <patrick@stwcx.xyz> |
switch experimental::fs to std::fs
std::filesystem was added to C++17 and is well supported now. Remove the older std::experimental::filesystem usage.
Signed-off-by: Patrick Williams <patrick@stwc
switch experimental::fs to std::fs
std::filesystem was added to C++17 and is well supported now. Remove the older std::experimental::filesystem usage.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I6d1ef0f3ac02954ddbffc332393fa11930dffad7
show more ...
|
220674cd | 23-Oct-2021 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Add OWNERS file
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com> Change-Id: I1d7125db233d854103e81f0509a8125882659a71 |
fab4020d | 03-Sep-2021 |
Ed Tanous <edtanous@google.com> |
clang-format code with new clang
New clang, new formatting.
Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: Ib20e9ed59f6d6c22e65d54212a096f15071b77b3 |
5c9264da | 14-May-2021 |
Andrew Geissler <geissonator@yahoo.com> |
vpnor: Fix const decltype() error reported by gcc-11
The latest yocto rebase has brought in a new compiler. It's flagging the following error with this code:
| ../git/vpnor/table.cpp: In member fun
vpnor: Fix const decltype() error reported by gcc-11
The latest yocto rebase has brought in a new compiler. It's flagging the following error with this code:
| ../git/vpnor/table.cpp: In member function 'const pnor_partition& openpower::virtual_pnor::partition::Table::partition(size_t) const': | ../git/vpnor/table.cpp:159:49: error: 'decltype(auto)' cannot be cv-qualified | 159 | const decltype(auto) table = getNativeTable(); | |
The function is already returning a const so the declaration of the variable as a const is redundant (and no longer allowed by the compiler)
Change-Id: I105f7e0a90c87b2618439a49e387ee74b4f5dc79 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
show more ...
|
0ad17216 | 14-May-2021 |
Andrew Geissler <geissonator@yahoo.com> |
vpnor: Fix style issues reported by clang tooling
The files in this commit need to be changed to fix a warning found in the latest gcc version. The issue has to do with using the following syntax: `
vpnor: Fix style issues reported by clang tooling
The files in this commit need to be changed to fix a warning found in the latest gcc version. The issue has to do with using the following syntax: `const decltype(auto)`
First update the files in question to match with the latest clang11 formatting.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: If728d370665b42f2ccafea84dbfd50a2ae80c77a
show more ...
|
b5e78091 | 16-May-2021 |
Andrew Jeffery <andrew@aj.id.au> |
format-code: Fix formatting failures
There's a lengthy comment in the custom script as to why it needs to exist, and given it does, make it work.
At some point the build scripts started passing the
format-code: Fix formatting failures
There's a lengthy comment in the custom script as to why it needs to exist, and given it does, make it work.
At some point the build scripts started passing the directory whose code should be formatted as the first argument to format-code.sh[1].
When format-code.sh is invoked, the working directory remains the workspace directory, so make our custom script change into the repo in order for the git commands to work.
[1] https://github.com/openbmc/openbmc-build-scripts/blob/cd9578b262fcce6f1e4e3f76fa05fa5f56100123/scripts/unit-test.py#L1221
Change-Id: I34cb9dacb0270afadab0b8f138df80446bce63a2 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
1230660d | 16-May-2021 |
Andrew Jeffery <andrew@aj.id.au> |
format-code: Update default clang-format to v11
v6 is a bit out of date and not what the infrastructure uses, so move with the times.
Change-Id: If0692bbe6809e1dcbd951b6cfa737341cf4246f0 Signed-off
format-code: Update default clang-format to v11
v6 is a bit out of date and not what the infrastructure uses, so move with the times.
Change-Id: If0692bbe6809e1dcbd951b6cfa737341cf4246f0 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
5ff50e3c | 30-Nov-2020 |
Adriana Kobylak <anoo@us.ibm.com> |
vpnor: Use the partition in rw if it exists
Look for the partition file in the rw directory first as the default. This allows mboxd to support a single writable directory for the case where the part
vpnor: Use the partition in rw if it exists
Look for the partition file in the rw directory first as the default. This allows mboxd to support a single writable directory for the case where the partition files (including the read-only ones) need to be modified at runtime by the BMC, for example to support two different configurations of a system using the same firmware image.
Tested: Enabled debug traces to check where the read and write requests were being fulfilled from and copied some partition files to the patch directory: On witherspoon, verified the reads/writes were done on the patch directory for the files that existed there, and reads were fulfilled from the ro dir, and writes from the rw dir. On rainier where all partitions exist in the rw dir, verified the reads/writes were done on the patch dir for the files that existed there, and reads/writes were done to the rw dir. For the HB_VOLATILE partition that gets erased, the ro dir was then used to read after it was deleted from the rw dir.
Change-Id: I3fe1875bd6a47aa82e9a1f23bc136a5a4f499c7f Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
show more ...
|
dfbeae25 | 12-Mar-2020 |
Joel Stanley <joel@jms.id.au> |
Disable aspeed mbox backend
This disables the mbox backend in the daemon. The associated code remains, as it is tangled in to the tests which provide coverage for parts of the code base beyond the m
Disable aspeed mbox backend
This disables the mbox backend in the daemon. The associated code remains, as it is tangled in to the tests which provide coverage for parts of the code base beyond the mbox backend.
A future cleanup would refactor the tests to not rely on the mbox transport, andfinally remove the mbox transport itself.
Change-Id: Id4fe74617a2dd920c1f8bc8ac4cd69cfbc0239b6 Signed-off-by: Joel Stanley <joel@jms.id.au>
show more ...
|
2ecad07c | 10-Apr-2020 |
Andrew Jeffery <andrew@aj.id.au> |
control: Retain current backend on initialisation failure
A failure to initialise a new backend should not lead to the current backend becoming invalid. Fix the current behaviour by only destroying
control: Retain current backend on initialisation failure
A failure to initialise a new backend should not lead to the current backend becoming invalid. Fix the current behaviour by only destroying the current backend once we know the requested backend has successfully initialised.
Change-Id: I5da11b346b8b5ab2c95085f512de4599d1272f57 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
affbf2ed | 10-Apr-2020 |
Andrew Jeffery <andrew@aj.id.au> |
backend: Ensure ops pointer is valid in backend_init()
If support for e.g. the vpnor backend isn't compiled in then the ops pointer will be set to NULL. Prevent the NULL dereference by validating ea
backend: Ensure ops pointer is valid in backend_init()
If support for e.g. the vpnor backend isn't compiled in then the ops pointer will be set to NULL. Prevent the NULL dereference by validating each pointer in turn.
Change-Id: I5a293d173736f192e087762308017bf16eda7f4d Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
ca5eda80 | 05-Feb-2020 |
Andrew Jeffery <andrew@aj.id.au> |
mbox_log_console(): Add explicit fflush() for stdout
stdout is line-buffered by default while stderr is not. Additionally the logging infra was switching between stderr and stdout based on the sever
mbox_log_console(): Add explicit fflush() for stdout
stdout is line-buffered by default while stderr is not. Additionally the logging infra was switching between stderr and stdout based on the severity of the message. Make sure we flush stdout if necessary.
Change-Id: I9649e1aa20dca6220cdd5ca91f2bab2a99b24aac Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
02821c6a | 31-Jan-2020 |
Andrew Jeffery <andrew@aj.id.au> |
vpnor: partition: Fix file descriptor leaks
In the face of errors we were leaking the partition file descriptor when throwing exceptions.
Change-Id: I257a491460062384928d8dda6bbf178da662f3b3 Signed
vpnor: partition: Fix file descriptor leaks
In the face of errors we were leaking the partition file descriptor when throwing exceptions.
Change-Id: I257a491460062384928d8dda6bbf178da662f3b3 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
5b970448 | 31-Jan-2020 |
Andrew Jeffery <andrew@aj.id.au> |
vpnor: partition: Only attempt read() for in-bounds accesses
Attempting to read after an lseek() past the end of the file leads to an error and we bail out. The error propagates up the callstack and
vpnor: partition: Only attempt read() for in-bounds accesses
Attempting to read after an lseek() past the end of the file leads to an error and we bail out. The error propagates up the callstack and causes errors on the host side, where really we should just be returning an erased window.
Change-Id: I06cdda4f7f6aa4d66e133de95cd642e04418bbe0 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
e2744c0e | 27-Jan-2020 |
Andrew Jeffery <andrew@aj.id.au> |
vpnor: Avoid mmap() due to lack of support on some filesystems
JFFS2 does not support writable mappings. Switch to read()/write() and add all the failure handling to ensure we get the required seman
vpnor: Avoid mmap() due to lack of support on some filesystems
JFFS2 does not support writable mappings. Switch to read()/write() and add all the failure handling to ensure we get the required semantics.
Change-Id: I5ec547bf7a01a389cf8f1403f748026fe6bb21fa Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|